From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F406C77B7C for ; Tue, 24 Jun 2025 09:21:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C3E656B00A9; Tue, 24 Jun 2025 05:21:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C157B6B00AA; Tue, 24 Jun 2025 05:21:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B52426B00AC; Tue, 24 Jun 2025 05:21:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A6AB26B00A9 for ; Tue, 24 Jun 2025 05:21:04 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 24D31160201 for ; Tue, 24 Jun 2025 09:21:04 +0000 (UTC) X-FDA: 83589750048.06.CA89AC9 Received: from out30-133.freemail.mail.aliyun.com (out30-133.freemail.mail.aliyun.com [115.124.30.133]) by imf22.hostedemail.com (Postfix) with ESMTP id 08EFAC0004 for ; Tue, 24 Jun 2025 09:21:00 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=Hg1DZeuq; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf22.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.133 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750756861; a=rsa-sha256; cv=none; b=OzQsC3xjjno3OHh/6nRWqiqUsBRjl1QAq/9wTT0SkKyPKAReR6c7/t/OHwxAFeyg0upoSP 7oEW3b0595V1fcHC1Iz0ac6hRntIB/2MnLF4g0avUe7r0vx5Bpcvw+/KVPCEoEFBMpC0jq tiFJWBd5vz6RywY8OtVdwRb8+r+HMSw= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=Hg1DZeuq; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf22.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.133 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750756861; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dLsT6vIUOkiWqe9khgfw1CalTOzKAVaMh9ZCazfucIY=; b=OJfQKZR41Brmq9IeG4NT6zAWxv4fG8ehhA7IjbvFlMX+xMRsAv9Pvy1xFynHaaZ5wCPAaw Xz0lW5obD+S9Vy+bSIGdszM7YpEcvTtp7fvToylkDWEuh92Tl2ywQVhy6CQ9TrDjekJKKc IDXB5fGHLx9sMAK8nKg5wXw03CkQp/s= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1750756857; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=dLsT6vIUOkiWqe9khgfw1CalTOzKAVaMh9ZCazfucIY=; b=Hg1DZeuqYUekbjQ1e4M6PTJnbIsh4kzQIP/+oPF4FsmdnvnOw8e0adwcFQpVn6bYPp8PV9hZcAwrhh1kNOTwQf4dtRmt1QTU2u/MTSIoNpnvHKxwOSL71Enu0FrbrnteXCSW7lA/GLfzS62NgyIxGE6hqo4bv0dbK7FXvlmfwlQ= Received: from 30.74.144.102(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0Wegbozo_1750756855 cluster:ay36) by smtp.aliyun-inc.com; Tue, 24 Jun 2025 17:20:56 +0800 Message-ID: <40e13005-0ed1-4d76-8961-fc6fced06681@linux.alibaba.com> Date: Tue, 24 Jun 2025 17:20:55 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] mm: huge_memory: disallow hugepages if the system-wide THP sysfs settings are disabled To: David Hildenbrand , akpm@linux-foundation.org, hughd@google.com Cc: ziy@nvidia.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <44c805d7-000a-440e-995b-106f324eff15@redhat.com> From: Baolin Wang In-Reply-To: <44c805d7-000a-440e-995b-106f324eff15@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: 08EFAC0004 X-Rspamd-Server: rspam10 X-Stat-Signature: 9d4yx4icu9iaq4dsrjrij3tu11gq8p86 X-HE-Tag: 1750756860-151654 X-HE-Meta: U2FsdGVkX1+E+4QfxA7iYiRSK9ndOfPCPRpYsup0/X6XzuSYyT3jwrOCiVSrv5l2np0eYKgKYFIC8UnV5VgB5gCS+r6IH5BLUU1LUcj9YxDzhHzxrGAG3NqSmTBlcLec8E4LSmsTYGsaTRQIWdrMSSWsWYUbBHqmg5b86YiY4XtN4fjiJMf4L20QU3bArbhth9mKbsyhpJBhqpNuPUTVz6hDGNqiFSyCLAr+1WH8Wpu1mY5HdX4pxjf5JFk+pAT6YCdgYXAmAOkpCnm0HIA0E5Oumc0+EndzmlBeDxDbCczpfGdBZEcqosrQRhpWgzWETeeKL1TYl7MeSUDQXnDqST1rZP1b8X4iRthRXuZa1aoTcU64Kyl14WXKUwvihoX3jUuhBYVs2+JBpFMHDU0bY2U6idV8KyQeeYCM0DA2qmIIAsqjDv8YtPSmTLVoeB83ygKi2sBvnCx4KrWal7UiOONwuj49/Z611PusGOx1WXRJshd3r1gZhi4auvBVE5NuPWJW7FmjnowNDQUxSTlTkhhkkjRMPjd1hXDm/EY+K4VhDxT6lEHbeXKDRHCNahXW+UpNq3HUHibyVG6YGKZ/D9cr3FS5K0YDEs0BjhlBUCCNzLDmcraHYN/+PAND1HpHwQfmVPWChu2zh+KslAvuNA/MMktasy/UlgEOqxifaU60lzasJHacUMXPBUEO46f9fLVA7D6xQBh4/hNLMdP8URmUFeS/3HZfqqIYdmJD1n2xBOPA6gbfeAPHF4rGOxV3ZyVteXmXWWmQ4JpiLRXWHjk5nfSFir0XIg80a9ue3QqmXnZAnoTz0oaWGGqyvmRVTkp5hMkPMam+gqK0ZkmuS/HQ5gCJ4DN+ODgmX/3gjLqs4Rzh/Ws0HBf7o/8fnWKpKIojjam9f/iYyWTuhYp0O8a/bOGUWq8MYdQMcTYKgyhhPUOZClmp5bfZmBIXpHm3udY3lKmicSb3IjmxXz8 xwUiNVH4 AA8g5T4hVxgRs5RKO8x2lYdmss8DFff2r8zmqzGCzGyZoYF9QgCH/Yc9vNS6s5yg5XIkxiT1DemONL9vyLgeThiiztJkbl75PuDhsr8JwPLzbPeL6rayXSPD+qblMYeAANFiNz6vJP2dy01jX+qos/vC0zKCacVxWgzGP49FKcnq94hVALksWFadIrQRrrUlEqQQfr6a33s99FAHT4YQK7LUHt6TsISfcdarGMziY+qcl7M702yDuc3Xc9eOap2UIhsvjtaHeIXZJllUS8YfpN4dL70H9kVZf6hS1VOYLxC4YD+vcS0hzpAFp1XNRtOhBCqkWmoEqm4/82JqlCq9Id+uwdQRL44HQd7CcZQGewlKPpW1uUowaB8Wa6sQdAgNJ5kNAyCpEVAf2gvI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/6/24 16:29, David Hildenbrand wrote: > On 24.06.25 03:48, Baolin Wang wrote: >> >> >> On 2025/6/23 21:54, David Hildenbrand wrote: >>> >>>> diff --git a/tools/testing/selftests/mm/khugepaged.c b/tools/testing/ >>>> selftests/mm/khugepaged.c >>>> index 4341ce6b3b38..85bfff53dba6 100644 >>>> --- a/tools/testing/selftests/mm/khugepaged.c >>>> +++ b/tools/testing/selftests/mm/khugepaged.c >>>> @@ -501,11 +501,7 @@ static void __madvise_collapse(const char *msg, >>>> char *p, int nr_hpages, >>>>        printf("%s...", msg); >>>> -    /* >>>> -     * Prevent khugepaged interference and tests that MADV_COLLAPSE >>>> -     * ignores /sys/kernel/mm/transparent_hugepage/enabled >>>> -     */ >>>> -    settings.thp_enabled = THP_NEVER; >>>> +    settings.thp_enabled = THP_ALWAYS; >>> >>> >>> Would MADVISE mode also work here? If we don't set MADV_HUGEPAGE, then >>> khugepaged should be excluded, correct? >> >> I tried this, but some test cases failed. As I replied to Barry, it's >> because some tests previously set MADV_NOHUGEPAGE, and now there is no >> way to clear the MADV_NOHUGEPAGE flag except by setting MADV_HUGEPAGE. > > Okay, can you add that detail to the patch description. Sure. Will do. > I suspect we > really want a way to undo what MADV_NOHUGEPAGE/MADV_NOHUGEPAGE did (if > only naming wouldn't be complicated: MADV_DEFAULT_HUGEPAGE, hmmmm).