From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0517ECAAD8 for ; Tue, 30 Aug 2022 07:28:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 488A7940007; Tue, 30 Aug 2022 03:28:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4380F6B0074; Tue, 30 Aug 2022 03:28:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D7F4940007; Tue, 30 Aug 2022 03:28:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 1F9536B0073 for ; Tue, 30 Aug 2022 03:28:43 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id EA93F403BC for ; Tue, 30 Aug 2022 07:28:42 +0000 (UTC) X-FDA: 79855431684.21.080D66E Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf29.hostedemail.com (Postfix) with ESMTP id 7B36212000A for ; Tue, 30 Aug 2022 07:28:41 +0000 (UTC) Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 27U7ITvb027552; Tue, 30 Aug 2022 07:28:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pp1; bh=WeNv+LY/qC4unbGWA+rZL0j3Exo6NFHf8oMxYQdckNg=; b=ET/DVqaaTnd0UvozYE7GjUh2qY9bj6SmU1KFIo33gHR5mn2dLMOFX3izOvInV2K1D9C/ qdBdbITq4t9uG0LVWFx314e0vy4gwwqID7ZD/E4F4+/E/SfVVh5J4izgBaKY6gZ94ReJ myiW1tL2Ukddy7UMsQDEyucGKH37xrTKBqQhSFOpb/40/fUz8QIUewRdGLvd6xfBirRU hz4rcf7iPzK8AF0VNVt4sE1uC5oklwp4CzSoKzNLsaxJDlgAqtxNOswMkjTz3Ii0RVVV 5REQBzq8SiHZ9JkS/Q0Z9riFk7VDDCK6oBYAW7tXC7RDxmQrqwMAeeKsRV3AmlwIq3Pj kw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3j9e1pr8pr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 30 Aug 2022 07:28:21 +0000 Received: from m0098409.ppops.net (m0098409.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 27U7KPcZ000949; Tue, 30 Aug 2022 07:28:20 GMT Received: from ppma02fra.de.ibm.com (47.49.7a9f.ip4.static.sl-reverse.com [159.122.73.71]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3j9e1pr8nc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 30 Aug 2022 07:28:20 +0000 Received: from pps.filterd (ppma02fra.de.ibm.com [127.0.0.1]) by ppma02fra.de.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 27U7NOUt018714; Tue, 30 Aug 2022 07:28:17 GMT Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by ppma02fra.de.ibm.com with ESMTP id 3j7aw8teem-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 30 Aug 2022 07:28:17 +0000 Received: from b06wcsmtp001.portsmouth.uk.ibm.com (b06wcsmtp001.portsmouth.uk.ibm.com [9.149.105.160]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 27U7SFFY41288028 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 30 Aug 2022 07:28:15 GMT Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1A658A405C; Tue, 30 Aug 2022 07:28:15 +0000 (GMT) Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id AAFA6A4054; Tue, 30 Aug 2022 07:28:10 +0000 (GMT) Received: from [9.43.77.247] (unknown [9.43.77.247]) by b06wcsmtp001.portsmouth.uk.ibm.com (Postfix) with ESMTP; Tue, 30 Aug 2022 07:28:10 +0000 (GMT) Message-ID: <40b5c045-1825-e0f3-ffe3-b90e96f940a2@linux.ibm.com> Date: Tue, 30 Aug 2022 12:58:09 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH v2] mm/demotion: Expose memory tier details via sysfs Content-Language: en-US To: Wei Xu Cc: Linux MM , Andrew Morton , Huang Ying , Yang Shi , Davidlohr Bueso , Tim C Chen , Michal Hocko , Linux Kernel Mailing List , Hesham Almatary , Dave Hansen , Jonathan Cameron , Alistair Popple , Dan Williams , Johannes Weiner , jvgediya.oss@gmail.com, Bharata B Rao References: <20220829060745.287468-1-aneesh.kumar@linux.ibm.com> <22cb7a8a-84fe-04c7-41ea-50eff8184dc1@linux.ibm.com> From: Aneesh Kumar K V In-Reply-To: Content-Type: text/plain; charset=UTF-8 X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: unvKeZ3qAjfaGW4aNQ8nEUsJN2WAJfkW X-Proofpoint-GUID: RHtnbh4a5aKcsbmtmpxI4ejGYgtMR1ZN Content-Transfer-Encoding: 8bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-08-30_02,2022-08-25_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 lowpriorityscore=0 suspectscore=0 mlxlogscore=999 priorityscore=1501 phishscore=0 adultscore=0 impostorscore=0 spamscore=0 clxscore=1015 mlxscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000 definitions=main-2208300033 ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661844521; a=rsa-sha256; cv=none; b=FUYJkhYJ3VDVEIXv2OZ7mFFZQsfGD2b70eGKf76F6/vDJrvj+13SLjlWybEoSvXAt8bv7U B+qrqhfDO0NiS0Fw2+LmdD0EMbwXY3Zg4XZZxDUIoLM74CizavjdthIcwfQFK49kwRB7WF 0UtB9HqZO/Ay7OMFGFutwPhGo/FpRXg= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b="ET/DVqaa"; spf=pass (imf29.hostedemail.com: domain of aneesh.kumar@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=aneesh.kumar@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661844521; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WeNv+LY/qC4unbGWA+rZL0j3Exo6NFHf8oMxYQdckNg=; b=JUyHjWEWEK+EW2UtBMnlMmlmrLZq+y/vkRcBC78DGLhSKb0VkNrAfTQ/D1y527sv4xBGoO lmiMzHyD+ed3kHfcvdNTDIdMJ/XTea2eghGMYr51vknEwY43Nwsj03y8iB0dOIVqwsfHyu 57yYxpNSHIxyiBGH4j6HHRCb7YQ1vts= Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b="ET/DVqaa"; spf=pass (imf29.hostedemail.com: domain of aneesh.kumar@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=aneesh.kumar@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: p7sqpdpm39jbxbans1yhwz9sa9rkak86 X-Rspamd-Queue-Id: 7B36212000A X-HE-Tag: 1661844521-93110 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 8/30/22 12:47 PM, Wei Xu wrote: > On Mon, Aug 29, 2022 at 11:46 PM Aneesh Kumar K V > wrote: >> >> On 8/30/22 12:01 PM, Wei Xu wrote: >>> On Sun, Aug 28, 2022 at 11:08 PM Aneesh Kumar K.V >>> wrote: >>>> >>>> This patch adds /sys/devices/virtual/memory_tiering/ where all memory tier >>>> related details can be found. All allocated memory tiers will be listed >>>> there as /sys/devices/virtual/memory_tiering/memory_tierN/ >>>> >>>> The nodes which are part of a specific memory tier can be listed via >>>> /sys/devices/virtual/memory_tiering/memory_tierN/nodes >>>> >>>> The abstract distance range value of a specific memory tier can be listed via >>>> /sys/devices/virtual/memory_tiering/memory_tierN/abstract_distance >>>> >>>> A directory hierarchy looks like >>>> :/sys/devices/virtual/memory_tiering$ tree memory_tier4/ >>>> memory_tier4/ >>>> ├── abstract_distance >>>> ├── nodes >>>> ├── subsystem -> ../../../../bus/memory_tiering >>>> └── uevent >>>> >>>> All toptier nodes are listed via >>>> /sys/devices/virtual/memory_tiering/toptier_nodes >>>> >>>> :/sys/devices/virtual/memory_tiering$ cat toptier_nodes >>>> 0,2 >>>> :/sys/devices/virtual/memory_tiering$ cat memory_tier4/nodes >>>> 0,2 >>>> :/sys/devices/virtual/memory_tiering$ cat memory_tier4/abstract_distance >>>> 512 - 639 >>>> >>>> Signed-off-by: Aneesh Kumar K.V >>>> --- >>>> .../ABI/testing/sysfs-kernel-mm-memory-tiers | 41 +++++ >>>> mm/memory-tiers.c | 155 +++++++++++++++--- >>>> 2 files changed, 174 insertions(+), 22 deletions(-) >>>> create mode 100644 Documentation/ABI/testing/sysfs-kernel-mm-memory-tiers >>>> >>>> diff --git a/Documentation/ABI/testing/sysfs-kernel-mm-memory-tiers b/Documentation/ABI/testing/sysfs-kernel-mm-memory-tiers >>>> new file mode 100644 >>>> index 000000000000..6955f69a4423 >>>> --- /dev/null >>>> +++ b/Documentation/ABI/testing/sysfs-kernel-mm-memory-tiers >>>> @@ -0,0 +1,41 @@ >>>> +What: /sys/devices/virtual/memory_tiering/ >>>> +Date: August 2022 >>>> +Contact: Linux memory management mailing list >>>> +Description: A collection of all the memory tiers allocated. >>>> + >>>> + Individual memory tier details are contained in subdirectories >>>> + named by the abstract distance of the memory tier. >>>> + >>>> + /sys/devices/virtual/memory_tiering/memory_tierN/ >>>> + >>>> + >>>> +What: /sys/devices/virtual/memory_tiering/memory_tierN/ >>>> + /sys/devices/virtual/memory_tiering/memory_tierN/abstract_distance >>>> + /sys/devices/virtual/memory_tiering/memory_tierN/nodes >>>> +Date: August 2022 >>>> +Contact: Linux memory management mailing list >>>> +Description: Directory with details of a specific memory tier >>>> + >>>> + This is the directory containing information about a particular >>>> + memory tier, memtierN, where N is derived based on abstract distance. >>>> + >>>> + A smaller value of N implies a higher (faster) memory tier in the >>>> + hierarchy. >>> >>> Given that abstract_distance is provided, it would be more flexible if >>> we don't commit to the interface where N in memtierN also indicates >>> the memory tier ordering. >> >> >> IIUC this is one of the request that Johannes had ie, to be able to understand the >> memory tier hierarchy based on memtier name. >> >>>> + >>>> + abstract_distance: The abstract distance range this specific memory >>>> + tier maps to. >>> >>> I still think the name of "abstract distance" is kind of confusing >>> because it is not clear what is the other object that this distance >>> value is relative to. Do we have to expose this value at this point >>> if N in memtierN can already indicate the memory tier ordering? >>> >> >> I do agree that abstract distance is confusing. But IIUC we agreed that it is much better >> than other names suggested and is closer to already understood "numa distance" term. >> >> https://lore.kernel.org/linux-mm/YuLF%2FGG8x5lQvg%2Ff@cmpxchg.org/ >> > > "NUMA distance" measures the distance between two NUMA nodes. > > I bring it up again because this name will become a user visible > kernel interface, which we will need to live with for a long time. > Even if we decide to keep the name, it would be better if we can > define between which two (abstract) points the abstract distance > reports. > > Another option is to remove this interface for now until it becomes > necessary to report abstract distances to userspace. > Ok I will send a v3 with abstract_distance dropped. -aneesh