From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03EDACD3431 for ; Wed, 4 Sep 2024 08:20:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 86B486B02D6; Wed, 4 Sep 2024 04:20:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 81B146B02D7; Wed, 4 Sep 2024 04:20:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6BBD08D0228; Wed, 4 Sep 2024 04:20:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4F0BB6B02D6 for ; Wed, 4 Sep 2024 04:20:36 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id CAE231A0E65 for ; Wed, 4 Sep 2024 08:20:35 +0000 (UTC) X-FDA: 82526359230.25.EE9655A Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf04.hostedemail.com (Postfix) with ESMTP id 80E1D4002A for ; Wed, 4 Sep 2024 08:20:33 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=OAtwqqaw; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=9GmKonCH; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=eKRgG+NZ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=8jykDmv6; dmarc=none; spf=pass (imf04.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725438009; a=rsa-sha256; cv=none; b=31XGj7JQGRT2vMn+GTCRu9tpXKTLf36WQs5afg7hUGPw8xX0GmON5RXtNR/oiJpSAVL0W8 BO1qhReTOXrvtxKzcVW5ZdVqImVrGfzcljVJQx+mOl41JhRcHVV78WlWsbzS2Oor3hTlEc OS0q+q+S5ruityIfFuuvQMPEUpdIjpU= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=OAtwqqaw; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=9GmKonCH; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=eKRgG+NZ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=8jykDmv6; dmarc=none; spf=pass (imf04.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725438009; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SqYnct0LSqRngHGJk0Qq4Uk/Skvt4li6oCkptSllDus=; b=KmXMQzC0AlUP4ZJaVtPpzQjBxCQJxWfyHab1zE/7tYWfPrudC9Cd4pnJHqzQJdgKkGCP6w 8KgnFxEjHg9jEESbCET+AVNvAR4dW1olwxpmeDuwIinnuOfGVsfLtQFNISpEnVSSefk5ys tj8eAKrLSJdgdMoUkA2h6NrVwHIOTrE= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DD8E31F7A6; Wed, 4 Sep 2024 08:20:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1725438032; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=SqYnct0LSqRngHGJk0Qq4Uk/Skvt4li6oCkptSllDus=; b=OAtwqqawSRDvsDE/XGHigw0Uy4la7DOMhtYRBjOVgm77YiQKwAcKV/J5JhBJMWNJjlaT7D +iKpwwMLKuLomIzDqGMUzRucE5pEgoJespye3paNfw8ThxRwumB0+4kM2axr7RXDpUwBgJ Fa5wdMwhtYa3KdxmfI4QQIh99d2A7kM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1725438032; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=SqYnct0LSqRngHGJk0Qq4Uk/Skvt4li6oCkptSllDus=; b=9GmKonCHYw1xzLry9lqs5UFAWZOpAE+p3mJtcg6+eFoqDBO6HjcYKheJbcGbsAg91u3O0e wxGNE2mdxWAamfBQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1725438031; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=SqYnct0LSqRngHGJk0Qq4Uk/Skvt4li6oCkptSllDus=; b=eKRgG+NZg5ataYi40LjOxL/SQKPry1JOlMCVC5QAr3gh4vcZ/OmnZgT4fgxAWpsJIKSwhZ Z9GAGGu+Bp3WwfR7qkiCYNBLPOezRXMEqXUd5gaodEfy84uYCyVo5xfNrebneSnAvysfvh oE8VK5Ye+ENCnRt1pUZjHnasly1J9ag= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1725438031; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=SqYnct0LSqRngHGJk0Qq4Uk/Skvt4li6oCkptSllDus=; b=8jykDmv6VbJvtGvKj2GmKsA/5Xmk0M8aXPbAz7JUBzONdBg+Pv6By5QtxrhrHBlXuEGHoS vlrL1zMDegYOlgDg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id CA678139D2; Wed, 4 Sep 2024 08:20:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id xxUVMU8Y2GZJfwAAD6G6ig (envelope-from ); Wed, 04 Sep 2024 08:20:31 +0000 Message-ID: <40b37458-5f75-40c1-b07a-529072e4c4a1@suse.cz> Date: Wed, 4 Sep 2024 10:20:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 15/15] io_uring: port to struct kmem_cache_args Content-Language: en-US To: Christian Brauner , Jens Axboe , Jann Horn , Linus Torvalds , Mike Rapoport Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org References: <20240903-work-kmem_cache_args-v2-0-76f97e9a4560@kernel.org> <20240903-work-kmem_cache_args-v2-15-76f97e9a4560@kernel.org> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20240903-work-kmem_cache_args-v2-15-76f97e9a4560@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 80E1D4002A X-Rspamd-Server: rspam01 X-Stat-Signature: me615p5c7frp9rubrfji8zp7y8gmd87a X-HE-Tag: 1725438033-719038 X-HE-Meta: U2FsdGVkX1+lpBM4z/mKnNRhtQ3blKEmeeF4iBo3GtWn3TdtIEkcybqy6/hfzxa+kynCDZHCA0qnafA6teThthrYX8+66eiN9aW04481y+mdkedsuInopGXGztKDzg1a/lW8R1gId9wQ3SpdsBA6yP5Z9Lywzhti7rU85R7Cql7ppacL7aJjrDd5C2Mi+ydZu2Oa4c6cVcKW1CzlwzQDizvPvKZJSN2nR600gk+9I4tfUr8/eMHV3SYTMmfYQ7F3nt/ufvUEiU9M56jeSJLxNPymNvz5p6N19O22pgVkSvgL3D2DDlpHuaDRQrSxeic1hpB6j0J3HsSYyNzbcXMCqC/Yh3s+f3py1+SHvfHA5aaDXc7s9HikMjed4NWvTf/nEJwbZMlH4fuc3x911QmHepTQ2xi7rop2dMRTawtGiKZO7niQfzutb+7a2IAxi0qZ7L/JLzV7NVL8mjNJ2aY9oJhZztuvo+wK18dFzmZ8zLhswO9Fm71sk2vAItHLczMGocosYNXyl8aWP6E5yeRFbDPNqFNVRjAvge99weHrnW6M9+VU1VyfHdPiTB9VTwsIJRJ0M706EnUR6tUZ48Gkl9p3VOvdpQfCVjQNfLQZlf335m9FQ6KmbLGjSeOp2DCGrMhzIsJaBX+e5WbDPb0wuz9nfKOUSrr3fpOeB05x7AI9bhkWdr4PefD1eh/2d5udg4iV3dBLFJ4N4mATYO9F+I7eZUdGnfLpTlzEQPofO7t2FPEUeNCghgrtN61jeMXiq1lSUpE0aYlRov00xzPsyoa3/U7AzlYCncRFKIkrcSbYUpp6K2GW/2dhU0stsqnq48XMqx6gnLHoXPZfrEmcO9MijSZIgJj447KORzjlJgSS8ylLIFOimi/rrMUsH/94csgvxtEu48go7HVSYKb4cEIzgs6JWf8azJmsSUXI/XvkrEPeltGe0SRcsU37wFfbUDcqsxIjxF1o1xvGsBR UEw+B7Ja gO4yA1bwJZA/fcsPv4LRY6tVeTjdBurDVzSwtTQWPKFvEfcGcsYVXow+DmxYE1bE6nHQ13CYe8n1tmIcXrS2CFthHhF9IxFmHh0/LCOt8QvPq7ts2pMD+rsHYhR1cCDW9q2XYds+yfwJ9Z8F75tNqoMj9MqDTEu6dA7ObkF+zsmZxFCZfAH25WkCYUVg6PYgbw10pkcCFJcSw6BMRmzfPQux933iLKLrBCH/QeFhDOnUt/TOXXYkWzpC4zeHRPHrNQ+ZwBunwjUv22W9DUmy2pE0yju+vI/Fqu6srpo2AA4zsghxXurq9XVEUCFJkrlG8mLOJCgxGWC8sLiSY2VArzC7mORkmcvV94wEM X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/3/24 16:20, Christian Brauner wrote: > Port req_cachep to struct kmem_cache_args. Fine but doesn't bring anything on its own, wouldn't Jens want to supply the freeptr_offset at the same time to benefit from it? > Signed-off-by: Christian Brauner > --- > io_uring/io_uring.c | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) > > diff --git a/io_uring/io_uring.c b/io_uring/io_uring.c > index 3942db160f18..d9d721d1424e 100644 > --- a/io_uring/io_uring.c > +++ b/io_uring/io_uring.c > @@ -3638,6 +3638,11 @@ SYSCALL_DEFINE2(io_uring_setup, u32, entries, > > static int __init io_uring_init(void) > { > + struct kmem_cache_args kmem_args = { > + .useroffset = offsetof(struct io_kiocb, cmd.data), > + .usersize = sizeof_field(struct io_kiocb, cmd.data), > + }; > + > #define __BUILD_BUG_VERIFY_OFFSET_SIZE(stype, eoffset, esize, ename) do { \ > BUILD_BUG_ON(offsetof(stype, ename) != eoffset); \ > BUILD_BUG_ON(sizeof_field(stype, ename) != esize); \ > @@ -3722,12 +3727,9 @@ static int __init io_uring_init(void) > * range, and HARDENED_USERCOPY will complain if we haven't > * correctly annotated this range. > */ > - req_cachep = kmem_cache_create_usercopy("io_kiocb", > - sizeof(struct io_kiocb), 0, > - SLAB_HWCACHE_ALIGN | SLAB_PANIC | > - SLAB_ACCOUNT | SLAB_TYPESAFE_BY_RCU, > - offsetof(struct io_kiocb, cmd.data), > - sizeof_field(struct io_kiocb, cmd.data), NULL); > + req_cachep = kmem_cache_create("io_kiocb", sizeof(struct io_kiocb), &kmem_args, > + SLAB_HWCACHE_ALIGN | SLAB_PANIC | SLAB_ACCOUNT | > + SLAB_TYPESAFE_BY_RCU); > io_buf_cachep = KMEM_CACHE(io_buffer, > SLAB_HWCACHE_ALIGN | SLAB_PANIC | SLAB_ACCOUNT); > >