From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0EA4C001DE for ; Sun, 30 Jul 2023 13:57:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D78448D0009; Sun, 30 Jul 2023 09:57:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D28698D0001; Sun, 30 Jul 2023 09:57:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BF0468D0009; Sun, 30 Jul 2023 09:57:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B13AA8D0001 for ; Sun, 30 Jul 2023 09:57:19 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 81F2F40A2A for ; Sun, 30 Jul 2023 13:57:19 +0000 (UTC) X-FDA: 81068430198.30.D7DFCFE Received: from out-125.mta1.migadu.com (out-125.mta1.migadu.com [95.215.58.125]) by imf25.hostedemail.com (Postfix) with ESMTP id 8FE8BA0003 for ; Sun, 30 Jul 2023 13:57:17 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=iwoYw6Ha; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf25.hostedemail.com: domain of yanjun.zhu@linux.dev designates 95.215.58.125 as permitted sender) smtp.mailfrom=yanjun.zhu@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690725437; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PGVwrSKPSqOKImBWbZoAx1qzxZDIg0U6/MyAhWrgbuQ=; b=CQzQ4Z/+w9YaVs3ozNV236Is5r2B1ITwYoUHRLbfdeMAP2CyzjDHaoYL42hdqkDGBBQ+UE 0RZZ92JdW6RUPGMaPA04IObG/Y+FLAmB4amsfB4smnns8IgFxZWuX3HQaWqQsUxrnhOvVl 9mZ/qUdbZatCd6mvj2wcmFI6NHGDlus= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=iwoYw6Ha; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf25.hostedemail.com: domain of yanjun.zhu@linux.dev designates 95.215.58.125 as permitted sender) smtp.mailfrom=yanjun.zhu@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690725437; a=rsa-sha256; cv=none; b=ZagXBJkn3GsTox5QJ8zHMEorZmy3TIYCFikRQ4IoI3sf7bf2LR8qRG11oVbtOAW2U0nY1b ORr3OOePpZGoNzWP/k1rRsFDuLf07G2e7hngPcGGLtJiH7pEwX1Z7pR0TO39A80RmnVARx P150i5XDTkrbIHjncca4nPGyd1JXL+0= Message-ID: <40a3ab47-da3e-0d08-b3fa-b4663f3e727d@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1690725435; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PGVwrSKPSqOKImBWbZoAx1qzxZDIg0U6/MyAhWrgbuQ=; b=iwoYw6Haq+kOYGPuPZKv5wW+uOf7UmUbzIK+dEi5BcvQ8JE87XsTTo3/OaLFjVQBD/o/ir fRSrCMrpEvqE0XtHAMIKkjF5ulAwlVSYlFZPhPk/oZ9ZcnH4KqxFkMf4MzqaUwsOND4ZDJ 4e/ew8GqIOajhMOJNNAbOKquCrq4by4= Date: Sun, 30 Jul 2023 21:57:06 +0800 MIME-Version: 1.0 Subject: Re: [PATCH 03/13] scatterlist: Add sg_set_folio() To: Matthew Wilcox Cc: linux-mm@kvack.org, Andrew Morton , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-afs@lists.infradead.org, linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org References: <20230621164557.3510324-1-willy@infradead.org> <20230621164557.3510324-4-willy@infradead.org> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Zhu Yanjun In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 8FE8BA0003 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: k1fge3w39szjsp1aqps6p7xw6nq7ebi6 X-HE-Tag: 1690725437-578758 X-HE-Meta: U2FsdGVkX1+aW1J1CvC1IUuZWNyWzuPJBa0aJreoz0eI6WL52LJq3tO3T0IVzpbsQomSvQCk4LQmyUWTh2S/OnIZg/GSZHFWVqqnBiGi11lT3Cvf5aPGwRbGCX5HUgl6KuEL3czXUVMlsOVWpCz6dh/U1GX09CbvmKXbKJPzAOadb5X1SaKI5uom2kHr/eodTDYoPU0fzNgJzx8mhcZ7CVbiuvxCIQg9NPG76YEwKQRKEoMP4Qn5qOTxQi7TVMcKMhq/CBnZmb8ZlIhKMVs4k6rjo9bFdzYINXD12b/oZO+pGHQpXJc4VSQm7o++QODAOKmFbMzR62qciyd9NemDSyO0aO0yG/imvBPtdglvGp4XBSA+Z+1xx4Ni0zEj9kQp+NITnOVaZfvrZqxP5S0v9n4PtF4keWxGfQpZy+wk5gR4uNP6h1H1gCMcCzd9/GEcuRiqlYP8aNkOoh/1Yk6RqHv2gks5EQVoA4PFPLa+tZw9MPccNXjzyE2UeTAFchGOX+CEjNJlMPUYCgLnoJGA9iaNodyPGPY51o1Iwntz2wUemjuMARCwKU2MHO91ACFQXED0hZjPNsETm6v9alzwkpR4AeFam2hLr7D9dLufVbo3uTXGfBMJr0n9tCgJJBSkc+uForJIYvDlXbqaY3BbUEZl79/I3CbPajvuP1uwWU3YeGEHRJ5ivH/DVcZ6BnQW3s9QohXP2tbz0SyJ5+TzKkSzkdisV8Z6Kyin2d0BFCP+EsTnslSg0AcDFDV11M5eXR3jhurVvrHOF7Ny+84OxBOwXm323aC7Loh9ocBJS668vQEQv7WXvG1xnhRXzU+965i3DUUdC+c1UT25xbtmY/pfEsyHXZBQ0wYJCBN2Z54UObZbTGS+HRimtqNmfcd6U7aAa0AG4g7+PUckuV6vHg10tmFP7yZJr1EZgImmwlhcu15qcJc5X/yWvgyExncsKibdu9cdwuX/QG//Dk7 Ps24fFGQ FHyi8/9+AzwYjz5bpsYTYLi4q1VUqHxAp/zgJuMvEGkb6FJSnRhUXh2SiC9GGbGKN359gkqYd5TEI1NFXmRTbgrink0afjozta9904Yp5QRD3K7yuKjgEEN1siya7eH/boyhl2/qSAvbfzNE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 在 2023/7/30 19:18, Matthew Wilcox 写道: > On Sun, Jul 30, 2023 at 07:01:26PM +0800, Zhu Yanjun wrote: >> Does the following function have folio version? >> >> " >> int sg_alloc_append_table_from_pages(struct sg_append_table *sgt_append, >> struct page **pages, unsigned int n_pages, unsigned int offset, >> unsigned long size, unsigned int max_segment, >> unsigned int left_pages, gfp_t gfp_mask) >> " > No -- I haven't needed to convert anything that uses > sg_alloc_append_table_from_pages() yet. It doesn't look like it should > be _too_ hard to add a folio version. In many places, this function is used. So this function needs the folio version. Another problem, after folio is used, I want to know the performance after folio is implemented. How to make tests to get the performance? Thanks a lot. Zhu Yanjun