From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 727A7E7718F for ; Mon, 30 Dec 2024 18:26:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0935A6B0098; Mon, 30 Dec 2024 13:26:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0437F6B0099; Mon, 30 Dec 2024 13:25:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E269C6B00A3; Mon, 30 Dec 2024 13:25:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8D09F6B0098 for ; Mon, 30 Dec 2024 13:25:59 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B46A016087A for ; Mon, 30 Dec 2024 18:25:58 +0000 (UTC) X-FDA: 82952453010.26.2198DEC Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) by imf01.hostedemail.com (Postfix) with ESMTP id DD56740016 for ; Mon, 30 Dec 2024 18:25:20 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Fdu7vUCP; spf=pass (imf01.hostedemail.com: domain of nadav.amit@gmail.com designates 209.85.218.48 as permitted sender) smtp.mailfrom=nadav.amit@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735583125; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=c4Cv2FWyi1dOOOU9BTe3r48rsCqijhG21beZ7nCyVIc=; b=0IP/b1QJO8okiN6OrN/+8SaMeVMNEKCsSM3gLeoTKFegxGOOaGNSRJDqn/pNv6tucS0iOf S5NcN+O7x9+z2yOhl0EBfCU/xN7PnKSE88+wGT4WCA/BNU0i4RiIRp2mIUpf/okMO9kIPm Z1SV6pcl03iak2Mv20V5fKM+tbl0X+Q= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735583125; a=rsa-sha256; cv=none; b=iEziqEzdv3XknMJT6+W0J6oM4nFpJmc0+2s1VI7s5j3+4mju6RrSiMfztKwFHYt6JCZt3o qMdzD0FFG/PlXFy90PECuCrcl5TVKhKYkhkGXv/bMTv7ft2P+Q+4rrVFgBaDo0jW9kdhof Ctjccv5xOhZTYCgYJG+iG1W3VvZRXo8= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Fdu7vUCP; spf=pass (imf01.hostedemail.com: domain of nadav.amit@gmail.com designates 209.85.218.48 as permitted sender) smtp.mailfrom=nadav.amit@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-aab6fa3e20eso1555801666b.2 for ; Mon, 30 Dec 2024 10:25:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735583155; x=1736187955; darn=kvack.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=c4Cv2FWyi1dOOOU9BTe3r48rsCqijhG21beZ7nCyVIc=; b=Fdu7vUCPEFO6H5pc0IMbgPTJ3LnN61aZ4DhLaVd9GtKS66Wkg0FBFNRIUqSQ1laVsu x2tNtbu9NGE907qhrb5eTcQ2fn7FfzccCSHSuNUftz0Dr2WjSwUepwiBR7hUEiir2Fxl 2f65Mk6zrgGaP3h/oGDYWIqThpAGa6QWK23bJNlYRa12ruBsANOVEQ0Xp/qoOZWWPRg+ UD6pYwSqoGIvgdQ7WLnlWGj9OYfkN/inaDmvx9obq2MlGWpARJ4n/EWFf6/dUVQZ5O5C i8GKzvRlwQS8mVuaSOOYq1VNvzFwC34hTc+Y8vDXSr8eVj1zLQFkV5r3u1lOqYEexi/T MOQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735583155; x=1736187955; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=c4Cv2FWyi1dOOOU9BTe3r48rsCqijhG21beZ7nCyVIc=; b=GW00Ayucc/Ctanqv1alF5U6cDve0m5NwpxFQZQpB+diA3V/+vvSj/wVetK0JyFIkbX 1OQzgl+BnqPB3UMbykflwG0ptVqxkBrK0k0N/eZtUeqNX6rm91uTqlS0sxJTR4krDXgG Qx3eEsu+cNUhJ4Uc8gdPuIbfVXUFvOBdyqBxqr5djXSdE+42X5cRWPSj48VcMcvIsmEj DV03y9Q2oJbQomedjTMsqGqheJPMmXak8EXjEjAoMg1UGPqABZW2eCElxwYFVVZRwIiA JJd5TmoY7Zg9Gu8hj2bgUc9gP68rm/O/2s8MhlsMG31LAxuCrqj+4xeMqROM0lJ7jsMf OZ1w== X-Forwarded-Encrypted: i=1; AJvYcCUdfiMZxJJuqUsraSCCMcvRu7i08msfFh3M+hq7QnTlhDLXH0mCStiJ6B7nqVlk9vu41KTk99L49A==@kvack.org X-Gm-Message-State: AOJu0YxcZm1IuIoUrUDizrOT1MHW8+LIC5+5p9YI+6sgBd2sW21Erczi 8cBW9pi3fBoRzAte108jMv1/HB0SANjQVUa5mcp7Kem3+nLFMqIq X-Gm-Gg: ASbGncv6L3Uwv0ZdSy6MZisiM7mOhyZeKHR3SNVWbMnAvYtXbuWNTQKuKfyduAsJQL2 yEQdHvuqBPeSbAEfOZugH08VJF9DPfqlUTuArSri6sZTSM6Qy127BgE9Y/tMHbORB2MD5QKHbS3 xLiCVEPkBfKcvJBQJV0RSjuuaNNZbbyQVpBNB7sElBoTyTcjK63+lk4Y+HtM3syrc1zDOPk9FG/ KLWNhRMB6GzhTGYDdhIXjzQpi0pNzm991coolDn+wgZM44M9v8oQmpYCZtnKcMwa+do6mf+Og== X-Google-Smtp-Source: AGHT+IHw2JU5Wyqfk8AFSsi+FCQ5WkOGTKKAN23Vi5IhLMHTvYSQN9n+ShG0NvWFbqzc7jGJDSPvYA== X-Received: by 2002:a17:907:7f16:b0:aaf:f1a:d2ad with SMTP id a640c23a62f3a-aaf0f1ade0amr1683092766b.50.1735583154561; Mon, 30 Dec 2024 10:25:54 -0800 (PST) Received: from smtpclient.apple ([132.69.243.32]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aaf6afc3e11sm81994566b.73.2024.12.30.10.25.52 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Dec 2024 10:25:53 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.300.87.4.3\)) Subject: Re: [PATCH 11/12] x86/mm: enable AMD translation cache extensions From: Nadav Amit In-Reply-To: <20241230175550.4046587-12-riel@surriel.com> Date: Mon, 30 Dec 2024 20:25:40 +0200 Cc: the arch/x86 maintainers , Linux Kernel Mailing List , kernel-team@meta.com, Dave Hansen , luto@kernel.org, peterz@infradead.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Andrew Morton , zhengqi.arch@bytedance.com, "open list:MEMORY MANAGEMENT" Content-Transfer-Encoding: quoted-printable Message-Id: <40C8627F-0B0B-4F19-8FF8-5D852A5F9F0F@gmail.com> References: <20241230175550.4046587-1-riel@surriel.com> <20241230175550.4046587-12-riel@surriel.com> To: Rik van Riel X-Mailer: Apple Mail (2.3826.300.87.4.3) X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: DD56740016 X-Stat-Signature: q7kynmqcq7bkcpyhgnh56zh8d8wt549t X-Rspam-User: X-HE-Tag: 1735583120-881559 X-HE-Meta: U2FsdGVkX1+EGw3UdXb4Niyz1OdT+Lcpq9WbAIH7sFmQk3zDaOkSQFn7CryD7pbOTyuZyKbIlPOXIyN0lwGQMO83TpE2vPBxG8jo/m4eA3CSa1c+0zuhhah/mQF4XBi9yHmHn/vm6hS1rUgm1c1lTIZoown8pL3n1D7QxvcEftAt8zE/IN7XHFr1Pt4rsj88ZOx8xPehjJPwdwH2p98nEMS0a6kwaWCMic6UMNQ5V/wLE8W6owDwQQ/AKH3CqMAlz2ikfE0YXl7ib7sx4tCJ4CMi8N89xckw7nGSRJ3ZIIw+l5EoNeZGR8W2e9rve9bTm/R9UPe8JaGnmKg9jFJHAOkOqZ3SFQLU90VM78TbjJwvUw2mIEhu5ly8E4q7fdXmPGloGgG+8kj1oUXtHtcmrU10fBWMa4RlrrxVWbBys6pyAbMHj/oi5uXZCrG00f8me/YhHEUmBrR359NLXLZDv94WouxdphHz0lSG4Ex7npm3VjVuhjXbbzlm2Z+AcI97N38FWBGv0sATAA7e8APsz/+XlY6xTuxr3lBHCxe2BikD//nve9d4LqrYyB8AxYuO2M0VRPXImXGr9FBIuNrV2xZIHTKoMdtPNoQToRi0m5nLrXzNNF/nrq1/OIy2kle6+VMtPZ7/RDI1K/svw8ePhCDcNghqsfQOPAySr5tfQZpcgpOKiCbIbqBmW+0k93DShvvWuJO38yS7xRMJXksRH3dKuj875Ps4lCj8msL8bnaG4G40UfbYGAohx8wmlWqBPMdSrfmQql8H/tknkKvszqvgtRhxV/+umDs5jz96WzzjN7yhSgieZKLMCN/mkKcZZgbgAgsGz2YHqzIeJAAVba78fpkDmZunOjsrJru/wRPmjf21c1yuTgt4Ld42pMv/ZLP6eItbsEl7zN15AkCtdCXnHc6hcjCtYg43HdsmeT2ZfhezUGxBLRMtfUVQZl46zYCaPo5B4oD/aeAXl+A RqkERA1p i82/xVuF4NTe2VaY/fHDY9b/JhLKBsl54ZWAKwknV+pu4jqVxVu54MHx+TfZGiOtwsLvRhYd5OoyQQaJpIVnpMv5ecAVc7es4vGJeLhAGr+AYJD80BcGjDfbvvsy9GHaYHsxFLEXQY8e5t5mFmByjduHhCnzClOOvdHHHU4jOJarxR/r2cLCyr//SwDFh/esPj15jn75pxmscjCn9Yy1qV2qdhU2Lp9cAIiyFIywwX1yUoObafTU2jvYt9vjwQB08qMibvIabSwZahecJlguGuEWX03omiel+oz1P5O0YtLrqDIyJvPkL1v1ms20alwNuZQKq7GhnGSJmnDPfv8WenAS7LrkUBWd11D81w06xEqyg8hjs3/3Cu6IBBk+C1KhniBpLyhwu8fwW0fGQ6FX124MYCbGKSXc46ta2qRa+VFF0g24oYSGJvbm1mZNae3naIYpYANgnm9QY4yPbKB7QamE0GTUU4zxVbNQiFgjOGlC2ONNWkYbmaszFbpswG3/X+HyU X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > On 30 Dec 2024, at 19:53, Rik van Riel wrote: >=20 > --- a/arch/x86/kernel/cpu/amd.c > +++ b/arch/x86/kernel/cpu/amd.c > @@ -1143,6 +1143,14 @@ static void cpu_detect_tlb_amd(struct = cpuinfo_x86 *c) >=20 > /* Max number of pages INVLPGB can invalidate in one shot */ > invlpgb_count_max =3D (edx & 0xffff) + 1; > + > + /* If supported, enable translation cache extensions (TCE) */ > + cpuid(0x80000001, &eax, &ebx, &ecx, &edx); > + if (ecx & BIT(17)) { > + u64 msr =3D native_read_msr(MSR_EFER);; > + msr |=3D BIT(15); > + wrmsrl(MSR_EFER, msr); > + } > } Sorry for the gradual/delayed feedback. Is it possible to avoid the BIT(x) and just add the bits to=20 arch/x86/include/asm/msr-index.h like EFER_FFXSR ?