From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87169C369A2 for ; Tue, 8 Apr 2025 15:22:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 84BB86B0024; Tue, 8 Apr 2025 11:22:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7FAC36B0025; Tue, 8 Apr 2025 11:22:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 69BB36B0027; Tue, 8 Apr 2025 11:22:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4BE276B0024 for ; Tue, 8 Apr 2025 11:22:56 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 91510C10E4 for ; Tue, 8 Apr 2025 15:22:56 +0000 (UTC) X-FDA: 83311244352.05.1918427 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by imf07.hostedemail.com (Postfix) with ESMTP id 60F694000E for ; Tue, 8 Apr 2025 15:22:52 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=YeDTlwon; spf=pass (imf07.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.10 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744125773; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=l8cdqG5KHqsfV2J/kbmNJYoWMA/0nOsqrEAaBMjMGD8=; b=r5cmUSfLPFOxxOaB07Upxyu3jX8Agh9er9mWL/Ulrckv9Ay8+VHUc2QJl09MlFAIcwTHCE wDQsOUb8axgevYOvwm6g4fs1S8/577jLb0nyV55hCjAQQYIwf/NObdn4fdRO3CvPxOJAIN Nt+joR6C63tfzBtbTJmE6gpqrw4F5Oo= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=YeDTlwon; spf=pass (imf07.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.10 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744125773; a=rsa-sha256; cv=none; b=P2YCa3L9eNVsf/gen3HOH56YrKSqx8WbejSU+/smvo5Nb07IaEnKRvc+6ZQVlw12KZG18w CZCqPAKh6RcbYUp/EeYIsYs8xyvdpnRAeuu7456Ux+Hpbwm+X7lofKKl3vLC7GFyollpwX aiuwCLVynrJwsx7wM5lB9k9AzBHx9A8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1744125773; x=1775661773; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=D9XuG7Ugb2+SGuMTNvueeFKYwGqptTWhQqYGjQrqjVo=; b=YeDTlwonn5/c9VP7imsQGIRaS+evpPJlMQmB4pqUHN1OirrhAfXk5qeN p4JmfTIy4Hmg6slNdtaMYDb3LxqFWxnKnI9LKDsJG54dp8poWfttPeteG 9gPb79Jp7znX6zvhhKkrLk2LSXyQY+fHkM+mAVX72CR4ZiiC9cFBbkgS2 cl55Cgn1AjmiZ0KzCkRQDGQapOWX7/YpPa4odmaxOZNbP3Ls8S0FTeAor L9ahASFS8V2E+w+wh+JP1mhDi681BpvsR68bSq6aHfy8heAAt6XkuHLv1 cFj61j6Aj9L1FtOnaozk0CraQmC0zGHG0BzGqOEaZK+v+39qRv6wDzHHI Q==; X-CSE-ConnectionGUID: ssrP6NkJSYmB1+iFboa2Qw== X-CSE-MsgGUID: Rwf4a1loSuG6dLz0fBgVwg== X-IronPort-AV: E=McAfee;i="6700,10204,11397"; a="56936749" X-IronPort-AV: E=Sophos;i="6.15,198,1739865600"; d="scan'208";a="56936749" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2025 08:22:51 -0700 X-CSE-ConnectionGUID: Ib9xckXnQRq6rJZ0mR1kdw== X-CSE-MsgGUID: IfuAIkdqSzeGpojNSuwg2g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,198,1739865600"; d="scan'208";a="133023105" Received: from ssimmeri-mobl2.amr.corp.intel.com (HELO [10.124.220.83]) ([10.124.220.83]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2025 08:22:49 -0700 Message-ID: <409d2019-a409-4e97-a16f-6b345b0f5a38@intel.com> Date: Tue, 8 Apr 2025 08:22:47 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 02/12] x86: pgtable: Always use pte_free_kernel() To: Kevin Brodsky , linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Albert Ou , Andreas Larsson , Andrew Morton , Catalin Marinas , Dave Hansen , "David S. Miller" , Geert Uytterhoeven , Linus Walleij , Madhavan Srinivasan , Mark Rutland , Matthew Wilcox , Michael Ellerman , "Mike Rapoport (IBM)" , Palmer Dabbelt , Paul Walmsley , Peter Zijlstra , Qi Zheng , Ryan Roberts , Will Deacon , Yang Shi , linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-openrisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, x86@kernel.org References: <20250408095222.860601-1-kevin.brodsky@arm.com> <20250408095222.860601-3-kevin.brodsky@arm.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20250408095222.860601-3-kevin.brodsky@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 60F694000E X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: ebsyu4qikr8xoaumggiidbq9f4cxz1si X-HE-Tag: 1744125772-541689 X-HE-Meta: U2FsdGVkX1/Y8gCd5AeIeER0hoXV3TrojJHOKMzJjrCFhXIaY/O7cW0QuP3Fugf/YAndyBrvJ2RoLBKuj9I0/kNj2dR5H48h2KqM2IN350Cz7AUWodZDIylg3rKnyTq8OBG/w2MLcz01jELqZywb1Fw3AAREIW69K9cfkcWrbZlr5rT97Co4MZgb24UPNiDQVXQK5nMxSnNRU8zM5Ec2c4AEmuDDTWNikVr7YTklA+t2I/fdkHRzDbhpDkIh2be/5GRxdlG4VqE1MKyBvDigT813ZZX5BHoJAqnrG+5rWwP1Lid1i4ESt53qSQQhTws73Tkyw7/D9bAj4J9EPo6joTnZdx2pltHvB3YA3hD432MLApPssUIsNMOWsn9NjnfFAmp2Zp97ghAlgLIQp6aIio3uRYaubO/4eovEMlT3uvZ6qx73VK2luwd/rbKSvHp8mqUTLbjveVY3VEXjwKTlEw3zw2sI3jspP92VnvtE+lb5/hi63y7qQQ1IzMvb6EPPZqvUjcaQmwhxwLUbUrCUqg8vvQZkhpEtfVmT96P5TgGS85yA2Pk8Tsfo4c95mozWhKwxAzasg46pPqyCTQiPGSGmn6XWeWaViIx/mBZBcmipkoYlpTFqyEGGWgOGIQV2mqzYkARHmqKBIbCTJpldbXkBpUvsfhXcroruKopbwpigWtRjzRwtF8A58GFYFHSWOu24sA8Aprcfz499w5HgQTgvc2zNqx/K0cwVbZkfEuiGZL1tJDkMC/hrKFYfUmFM8TnUcf9eKnt7MwkMd2NKR+nvCEbiIQJzi9R2LZ9FWhdGnd0YQflBqDfgEBDtrRPb32tEbQj1uNHtqQZhDEof7DzXbQQhXoJqchPPtCsxkLb14fL62FYe+ifb0HNbxE6eNqfxIYtWillaZ/w3YzfokeiHbMVModFCD8gSMQkYczv6YrOAz3BHZyHg7CxbLz9h4hC7gPMM/t+1HsF4O5u xIOOxrrc wrGVRLLVuNTSPCt2BUH8QBAip+uZzRnU79QyvwbA9SD4jybz7Kvl4Kxcd5+ML3NINRfBtODG9nHgQ0Fu5G8JbEErywhzCK2rq+Kzu+EAsDVSeBMaRpnmOuaMJH2C7SYvm2Hi/CC+Yi66V31TAAjMs5FfgOdGxlMl/ZPLmU6knFC+5iy9UJuR2Tl0NS7KzViSyGOW8n8yghCqsRcVxwjSC/JC2O9kfqjIWewX20Y+Lm1pBUXQ19RGgWe3ZTQxou0JSg+9oIfQbqxX/d1sISj6tGr8K3ImbgsPBLwIjkA4w7cBwZXc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/8/25 02:52, Kevin Brodsky wrote: > Page table pages are normally freed using the appropriate helper for > the given page table level. On x86, pud_free_pmd_page() and > pmd_free_pte_page() are an exception to the rule: they call > free_page() directly. > > Constructor/destructor calls are about to be introduced for kernel > PTEs. To avoid missing dtor calls in those helpers, free the PTE > pages using pte_free_kernel() instead of free_page(). > > While at it also use pmd_free() instead of calling pagetable_dtor() > explicitly at the PMD level. Looks sane and adding consistency is nice. Are there any tests for folio_test_pgtable() at free_page() time? If we had that, it would make it less likely that another free_page() user could sneak in without calling the destructor. Acked-by: Dave Hansen