From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7F21ECAAD3 for ; Thu, 15 Sep 2022 02:44:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5AAF18D0001; Wed, 14 Sep 2022 22:44:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 55A276B0073; Wed, 14 Sep 2022 22:44:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 422728D0001; Wed, 14 Sep 2022 22:44:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2F97E6B0071 for ; Wed, 14 Sep 2022 22:44:43 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 07E6F1407B3 for ; Thu, 15 Sep 2022 02:44:43 +0000 (UTC) X-FDA: 79912776846.27.FD52954 Received: from out30-43.freemail.mail.aliyun.com (out30-43.freemail.mail.aliyun.com [115.124.30.43]) by imf14.hostedemail.com (Postfix) with ESMTP id D1A181000A3 for ; Thu, 15 Sep 2022 02:44:41 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R101e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045176;MF=xhao@linux.alibaba.com;NM=1;PH=DS;RN=7;SR=0;TI=SMTPD_---0VPqlKcb_1663209877; Received: from 30.240.97.215(mailfrom:xhao@linux.alibaba.com fp:SMTPD_---0VPqlKcb_1663209877) by smtp.aliyun-inc.com; Thu, 15 Sep 2022 10:44:38 +0800 Message-ID: <408fbc89-8711-0ea2-16e7-99b746e1f09e@linux.alibaba.com> Date: Thu, 15 Sep 2022 10:44:37 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH] mm/hugetlbfs: use macro SZ_1K to replace 1024 To: Al Viro Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, mike.kravetz@oracle.com, songmuchun@bytedance.com, SeongJae Park References: <20220914115723.38271-1-xhao@linux.alibaba.com> From: haoxin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663209882; a=rsa-sha256; cv=none; b=Nku75399S+ZGpnpAgB4HmwuyzgNqvohlCUcKamAvk61+btzdkMR9PSjGsHVEd3vYkLOcMC 9VEExp6W2ypOV+BOWKU2nMd/qAJ98aJ1r00+gYst0MaJExCydd5Nl8TYJ8U7SjkDCSCqnr JyRWen6M54AObPSay/uhIHARhlfKdDo= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; spf=pass (imf14.hostedemail.com: domain of xhao@linux.alibaba.com designates 115.124.30.43 as permitted sender) smtp.mailfrom=xhao@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663209882; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ESRYdkU5ESV2p1cNWSzcaEC0Mn/lkXf9i/HR4EQsYMY=; b=HJAPNiT0lgfzmf6CzrY3T2tJXBTpY2e/icsIDBZgfTN9V1oLCoZ4G72PAobtQSzrV3MrPc p8w5vLUiSzViURF4gqrvAQ4qoNft3PPrQhVEn2t/i8x8NWynC3TWereX5qRS/ipsfgqw2T 3yJUG2sr4AcvIWaLEinPQQiDmDqb9I8= Authentication-Results: imf14.hostedemail.com; dkim=none; spf=pass (imf14.hostedemail.com: domain of xhao@linux.alibaba.com designates 115.124.30.43 as permitted sender) smtp.mailfrom=xhao@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: qyechg7jkett5s5ngqxojrkw6jj9mbdd X-Rspamd-Queue-Id: D1A181000A3 X-HE-Tag: 1663209881-978627 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 在 2022/9/15 上午12:43, Al Viro 写道: > On Wed, Sep 14, 2022 at 07:57:23PM +0800, Xin Hao wrote: >> Using macro SZ_1K in hugetlbfs_show_options() has no any functional >> changes, just makes code more readable. > Why is it any more readable that way? The main purpose of this code is to convert size to 'K', and 'M'. I think using SZ_1k does look more appropriate than 1024, that's all. >> Signed-off-by: Xin Hao >> --- >> fs/hugetlbfs/inode.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c >> index f7a5b5124d8a..9b9784ffe8de 100644 >> --- a/fs/hugetlbfs/inode.c >> +++ b/fs/hugetlbfs/inode.c >> @@ -1023,10 +1023,10 @@ static int hugetlbfs_show_options(struct seq_file *m, struct dentry *root) >> if (sbinfo->max_inodes != -1) >> seq_printf(m, ",nr_inodes=%lu", sbinfo->max_inodes); >> >> - hpage_size /= 1024; >> + hpage_size /= SZ_1K; >> mod = 'K'; >> - if (hpage_size >= 1024) { >> - hpage_size /= 1024; >> + if (hpage_size >= SZ_1K) { >> + hpage_size /= SZ_1K; >> mod = 'M'; >> } >> seq_printf(m, ",pagesize=%lu%c", hpage_size, mod); >> -- >> 2.31.0