From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D662C02198 for ; Mon, 10 Feb 2025 09:59:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 99CE56B007B; Mon, 10 Feb 2025 04:59:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 94BD76B0083; Mon, 10 Feb 2025 04:59:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C5386B0085; Mon, 10 Feb 2025 04:59:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5F9056B007B for ; Mon, 10 Feb 2025 04:59:18 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id AEF3B1C6007 for ; Mon, 10 Feb 2025 09:59:17 +0000 (UTC) X-FDA: 83103587154.10.C141D4F Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf28.hostedemail.com (Postfix) with ESMTP id 4D1BCC0002 for ; Mon, 10 Feb 2025 09:59:15 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=uB0TAc8i; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=u1XNse4N; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=uB0TAc8i; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=u1XNse4N; spf=pass (imf28.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739181555; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NioSo9jy6/hmspATT6/1NoFuL/TYInEjWoLVtXb15Ns=; b=Z+ImyU5Xk29lKWcRLZ5ndUe+kbOY9WSu+mKaoiio0ejn+zAgVCx7nXcXvT+i0HG6ZCKTks 0vd1iMMozRxmsNeXxYEaJ2icOWaJXZ7iTe8KS+E7GNE7H/48dy7RSpoZlW9nIytVyZcXHp Zk6eaaPsxPapv6Ay8s7FGmUrsgYiCY8= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=uB0TAc8i; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=u1XNse4N; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=uB0TAc8i; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=u1XNse4N; spf=pass (imf28.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739181555; a=rsa-sha256; cv=none; b=d5IUDx67pkQoMBmBHTZ7d4eZQpa+9d7DkLV7yTCWcvOreU3BEo+mtHlOCK0hz1XlZPfGxV 94FaJnNKQ1t8ahicOEtFCOIm/iKnnhiKCg8Ilrr2607LsxLsPLsNYUvkzGpSmlYQiGTWNv WR5DsrXfJ5USUovFD3Z62Llq3d+PbMU= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8ECDB210EC; Mon, 10 Feb 2025 09:59:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1739181553; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=NioSo9jy6/hmspATT6/1NoFuL/TYInEjWoLVtXb15Ns=; b=uB0TAc8iFjub6vi9CJVn40qFO0grlASak5qJjcG2qc7+T44M47p4SUYR4Oflfmba15U0gA s3wN2MDvT9QGtxS1XPeHmosTBcqYTRkWM6PRD21zWZgOiADSGgX5OM+7qgpuZQGv1T8bik iXw6DFKqxilvpQwzzqIC3fWKNhd7oj0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1739181553; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=NioSo9jy6/hmspATT6/1NoFuL/TYInEjWoLVtXb15Ns=; b=u1XNse4NumlXm+dFPoXoVchnUGhTOzVByc/I4t0k3ZYBhz9B9WCmLrI2ISAczvZNtzALy5 2PD9M2obM7monhDA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1739181553; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=NioSo9jy6/hmspATT6/1NoFuL/TYInEjWoLVtXb15Ns=; b=uB0TAc8iFjub6vi9CJVn40qFO0grlASak5qJjcG2qc7+T44M47p4SUYR4Oflfmba15U0gA s3wN2MDvT9QGtxS1XPeHmosTBcqYTRkWM6PRD21zWZgOiADSGgX5OM+7qgpuZQGv1T8bik iXw6DFKqxilvpQwzzqIC3fWKNhd7oj0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1739181553; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=NioSo9jy6/hmspATT6/1NoFuL/TYInEjWoLVtXb15Ns=; b=u1XNse4NumlXm+dFPoXoVchnUGhTOzVByc/I4t0k3ZYBhz9B9WCmLrI2ISAczvZNtzALy5 2PD9M2obM7monhDA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 70A3013A62; Mon, 10 Feb 2025 09:59:13 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id J8EvG/HNqWcfQgAAD6G6ig (envelope-from ); Mon, 10 Feb 2025 09:59:13 +0000 Message-ID: <40853b61-3ad5-448a-980a-9584561887e6@suse.cz> Date: Mon, 10 Feb 2025 10:59:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] slab: Adjust placement of __kvmalloc_node_noprof Content-Language: en-US To: GONG Ruiqi , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Kees Cook Cc: Tamas Koczka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Xiu Jianfeng , linux-mm@kvack.org, linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250208014723.1514049-1-gongruiqi1@huawei.com> <20250208014723.1514049-2-gongruiqi1@huawei.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20250208014723.1514049-2-gongruiqi1@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 4D1BCC0002 X-Stat-Signature: muhrabbjuomanz9fmrcf8fqyaus7trf3 X-Rspam-User: X-HE-Tag: 1739181555-31065 X-HE-Meta: U2FsdGVkX184WG6X8NlnGOYgGNIdHZZ4oY3qbmFOhdWTInL2h4/E2+MG1v+JbAg21pVD8gN9IzvuXwNajVSOh6caUsQd5jM9JbWJVbLLHKtyCqxkngD1jkeDNSoRUlVLOgU+g12LORRdfTukaWlo7TNret88gybMj5b4+81l2dsKoJTvV6cN2uTkadg8vKpNZRE5wY5VzpqpF9eonxP7BvgCoXc+BH0NvJVWlVM4oxW7zdz7lkYzZG87I60CuFMBRt5SRAo/AaJHUNYFmDOYfPaQRvSmC9PddFyeIaE0Qk4YApUTvgACTC2RvBAn+UNQZA+goMoircVSbftIBXgvgpTix976OY3Ljqtbf4v7ZVrQsfwq2BMnGncKF342DyERvGXmuNEMCbLp/wKyXMlTN0gvHXtDoSVUcZ02qLxxw1ckDdapKCm4CKyw0oVLTvgcXIgHC+f62DRrSXCyFHULLncJnjJdKlsx3oDDTAVTzQa2lOYIQuIVjmfUXXhDvGtnZrHjYMK9trAE36dI3BqGu+dWZigOUbcKDYz6scHYzEDFA69ZMYCJbhvzV0qNCVJ6yw4NQP6inAjtwhUduQdoQEK4k8n6KAzITiK8BnGip1Fw0yVf5W8CgDSZVpjIxKAwDjo8yUvBd5T7VtVtMBmD6GCWpa5Uo7QxyJykON2n4ZdZNQzcarOVXisvWcH2lgjzhxK6M+Kc7NTpICj0gid2/xVQllL/rYpkMukKdcDdgisN4pxqMdZXAlagROvuPPQpOFsCbflh2zpzASc5F3X7ZVYwJ5YxNWYGNzdVU5uaVHgCQKRvmzy8NpONi9c+PGsf3hopnq/q4BvVxAIg0kWmFl2Pbjl0sNJzxKOrT6cZ+aKQ6Psdzna5sQLo/kUjC3qHjpKZXHhhJ/mk7d0ZQ6vCJSwP3IdR93j5q+0MUn/Hp15UkZN/ERshgM7aqiuwJAim2DeogTNB0iRHLOE8rDe Nn5FFo2/ agRzTxBug2ji6xB98ibR90nseRVWkWG1+sG+Dca3g/8ya+o+XM/LY18f5K7q7sd/aERO+eFn1kr+PagxI3qmWjeYWkK+7JYxxuTySMdW/2GquH538Zq/glb/yxfbzmnsgZlg990Obyq8VulDsArjX1JkYNbBBD+VQJizevbJxGqMO5W9oqZWyqSttWkgCJI70OIeSzDKMAWQb6lrO888B7kzD0e/5V4oh9QPi02v4IJKxnDvSXVb5W3cvL7Prnbcv/njaJc+xXRs72A4dAoJAXCjj5q0VKjPLOZNPdCu5GK5DIZP+AeU6gtEdQo2IKy8cjvMAoUaWXlFpT3sRKPXDmyjMKrR077eCsAgwksmVYI0/vYyMnphGtgb/QWgvjs/8i/SXj1MGkTLmssDtsUb+y8lVVKjszeUpnrEb5hHHg+3lB9M= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/8/25 02:47, GONG Ruiqi wrote: > Move __kvmalloc_node_noprof (and also kvfree* for consistency) into > mm/slub.c so that it can directly invoke __do_kmalloc_node, which is > needed for the next patch. Move kmalloc_gfp_adjust to slab.h since now > its two callers are in different .c files. > > No functional changes intended. > > Signed-off-by: GONG Ruiqi > --- > include/linux/slab.h | 22 +++++++++ > mm/slub.c | 90 ++++++++++++++++++++++++++++++++++ > mm/util.c | 112 ------------------------------------------- > 3 files changed, 112 insertions(+), 112 deletions(-) > > diff --git a/include/linux/slab.h b/include/linux/slab.h > index 09eedaecf120..0bf4cbf306fe 100644 > --- a/include/linux/slab.h > +++ b/include/linux/slab.h This could be mm/slab.h instead. But I'd just go all the way and move kvrealloc_noprof() too, it would be more consistent anyway.