From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2E7CC3ABCB for ; Mon, 16 Sep 2024 05:11:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E8116B009F; Mon, 16 Sep 2024 01:11:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 397DB6B00A0; Mon, 16 Sep 2024 01:11:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 25F606B00A1; Mon, 16 Sep 2024 01:11:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 03DE76B009F for ; Mon, 16 Sep 2024 01:11:41 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 75E87A00F9 for ; Mon, 16 Sep 2024 05:11:41 +0000 (UTC) X-FDA: 82569428802.13.0F766B7 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) by imf20.hostedemail.com (Postfix) with ESMTP id 5C62D1C0003 for ; Mon, 16 Sep 2024 05:11:39 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=collabora.com header.s=zohomail header.b=F+27Yvno; arc=pass ("zohomail.com:s=zohoarc:i=1"); spf=pass (imf20.hostedemail.com: domain of Usama.Anjum@collabora.com designates 136.143.188.112 as permitted sender) smtp.mailfrom=Usama.Anjum@collabora.com; dmarc=pass (policy=none) header.from=collabora.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726463391; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fiQmj+mg8bdz3LaM2MFQ1wsitBjBxISWyvNuEMIjyb8=; b=dm4g8LVSGeWVBB5vgaFS7z+8G/aOp2A6g8IDejpPpuMROVqW4WORq1SsIp4iiFryxv/5cN /Jonwncd65fMdNZIHFfQlBm8u8H2fNlf/VNqsXKEUPuO2Pd2yxNF+RxIo5YosKR4dkk00k gcsFyZPKdAyUeff6Q23R/HOOGrk824M= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1726463391; a=rsa-sha256; cv=pass; b=C53pu+7Ah1m7KjOz1LYDL3XhhtKPxNLLeazht6d3Hj54DYsCqD9EaPpRX240k0peKQFKFF AcPn40nsjCF74k6BI0h2MD2oUiimb6X8ApdUsckRJ859Di6hstfZO3fMGiItfhk/ka06hb oJMfx2oAlHmJyUJScGjjAXKTgybbXVk= ARC-Authentication-Results: i=2; imf20.hostedemail.com; dkim=pass header.d=collabora.com header.s=zohomail header.b=F+27Yvno; arc=pass ("zohomail.com:s=zohoarc:i=1"); spf=pass (imf20.hostedemail.com: domain of Usama.Anjum@collabora.com designates 136.143.188.112 as permitted sender) smtp.mailfrom=Usama.Anjum@collabora.com; dmarc=pass (policy=none) header.from=collabora.com ARC-Seal: i=1; a=rsa-sha256; t=1726463488; cv=none; d=zohomail.com; s=zohoarc; b=kwggkEmqLX6Mfr7HygJA+b/VB1IVl/+GGxQ6NewS4pNwJQfJJPZHSJC1Brpegyu6EotB1FwseDlPIm+6ZJsL279Qtrvqvd6qFxPKmlpjN2LOwCXnKwKhn15hBOmXN1jEtm1vxmcVE3QHUZLR3NpXEsoHB54XeImjGvaS0PDey1Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1726463488; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=fiQmj+mg8bdz3LaM2MFQ1wsitBjBxISWyvNuEMIjyb8=; b=DEVN37ppZUptSjjd62+W82sZ1aykTgPENQNnsMnM7OT6S2HczvX7va+vYlprR+Vtn1dcLI7N9PkPrUWmAtoOrT224DIaM2xdabXrp5SJZrC5NnZIc3XRikECzy5hCu49oRk7TGzH3+ZmRzn/5oGFbOKoQYV8XCzRpiBdPBuUsc4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=Usama.Anjum@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1726463488; s=zohomail; d=collabora.com; i=Usama.Anjum@collabora.com; h=Message-ID:Date:Date:MIME-Version:Cc:Cc:Subject:Subject:To:To:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=fiQmj+mg8bdz3LaM2MFQ1wsitBjBxISWyvNuEMIjyb8=; b=F+27YvnoFfhS8+LKAGj8b2uDd3XSSkH3ITGIZxWb20cWNcUlRRSUQmxE/HeJaaSv G11BOFu2zhhjSsuKo726Hv9Ch1doS4cZMUdXNcWXJetVAhRdP+5VoOn1k8thcBR1pCR eRDRMVeCRp1jqiBvczy4z4xX0QTtyMG3Hnbjz0K0= Received: by mx.zohomail.com with SMTPS id 1726463487032102.77484826415719; Sun, 15 Sep 2024 22:11:27 -0700 (PDT) Message-ID: <406c2919-a546-40e4-89af-baa910c22740@collabora.com> Date: Mon, 16 Sep 2024 10:11:18 +0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Usama.Anjum@collabora.com, Andrew Morton , Shuah Khan , Kees Cook , "Liam R. Howlett" , kernel@collabora.com, stable@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] selftests: mm: Fix build errors on armhf To: Jeff Xu References: <20240809082511.497266-1-usama.anjum@collabora.com> <1b36ba43-60a4-441c-981f-9b62f366aa95@collabora.com> Content-Language: en-US From: Muhammad Usama Anjum In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External X-Rspamd-Queue-Id: 5C62D1C0003 X-Stat-Signature: 6zjo1yw4kijnspm8y99fzesc3ye3p8dk X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1726463499-677001 X-HE-Meta: U2FsdGVkX1/kfemsNWc6QfFihwpD6QPNxtOcQ8FXKkLwsI6BY/cuGq4yT5ZTukZKtns+47cxAr/izId3uvR2/uEsnh1P3PwfrEkRg6s3OtAIoyH3uIOqlGtXLki18CC6dqhEuLxSsiXH0imBU6kglZc9bjLmCgKYDhB/6JzW4awnEzUJgM0jwZ9iSG4hUqF6Jt6ypZhSngx7GnaJ2Gac++VIst2FQ9mcyLG/aPYIz6yrtXD7p6wu84b+ADwdnTwH3+C5ics2mKay6WkAUZWAai7/hNY9equuJDq6IF1+QU99MidbvCNmYIzfFcQWCjiifZbyEhC0WEsayuEghGBds/vibPyXowhelB9sZ0xBloypw6UlsrhsMZB4kBE6DdrKCBhxRF9ycALOKvsCKk2wUwK48+KOzC76WfNpFcihgUnrNwa6YAbXEJkR9x8C4KXv1c2yYEyRQYb/YbTQFZlljdJW5jpr3ehUSy4bvGsiUNo28pVhE3u9nUlwFSQIweJmJyAQ2P9+rfsrkXGjXT1xy9Z7RwBXVzLnOWkxFXDnIFm8r7SHxwZmKsCnxe62QvMPfGgPCRPqABbNCj8slM6H6XdI+HF5T1ELbARn6XlNTw5kL3Pdk60u42/teybVbKznvgk1ALJoI6tRTMY3QpKLF7aaZmTwHvA5g5LCI/GNaKhlrHC3ijxQrCk7YQyqddqNEJBlkA7Rq2jWmGzT8K7T06J8jabf4XidbFq0qRD9FLbQXI5J5DBn3bmXam+wzGIcogNrKpBedJWf/eN59ksF7Em35FVap8kURIx7E70Iwoj/rEPqOwNTB6PSPHSGdhtOchbOdPYdumuN21lPD18w7cOrG8BNPMirLTn8ivDoaWBios/8hZ37ML0+2wlMWbJw7SS7EoXY/YpZ3BD45a0E7DqI6P1E2KyftzNQGJUlPjjefxDqbvbn0aa3RbcV1pXeYq2WPdQ9OXBWHGIxGDX zqfqq7p7 9N8MnG6wiQjrS8TvdpxiRECY4UFNbsdAV619E/2zqYYju9i/3lkCFUyioUfKSFdl8mpRuWFBDD2JJ93TjJNfGuCS+JLIditJMVT65urYIeF7XsSWD6uAiPJ4FHlX0gZj698Tn7p9+hPd+v24m5AXPfZvIT3bWivG0E7IBbq60K8gk64JrqtgcB+ovzdt4tbYD1StnJmjqCjpU/8Q9VC1FXF/poS/0oUz7BvyVdDOkudB9PocQcQGzceu1Kle6rKg+3gs8dN5aWvL2XDlzEdskUwijHYCX2CVF0KQoct1RPm9hktRHdeV1g+pxp2401Q7GFfbho8t1nQw76Kzsjx5xHRDEMoSB1fuNhPDYU3SDbCrVy9yLi/NVN5yG5KW+cMgazxg4WEEMC7FSxAg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/14/24 3:33 AM, Jeff Xu wrote: > On Mon, Aug 19, 2024 at 3:05 AM Muhammad Usama Anjum > wrote: >> >> On 8/14/24 3:29 AM, Jeff Xu wrote: >>> Hi Muhammad >>> >>> On Fri, Aug 9, 2024 at 1:25 AM Muhammad Usama Anjum >>> wrote: >>>> >>>> The __NR_mmap isn't found on armhf. The mmap() is commonly available > > What is armhf ? > is that arm64 ? I was able to build arm64 correctly. It is arm architecture. Use following toolchain with it: make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- Please test your patches on it. > > -Jeff > >>>> system call and its wrapper is presnet on all architectures. So it >>>> should be used directly. It solves problem for armhf and doesn't create >>>> problem for architectures as well. Remove sys_mmap() functions as they >>>> aren't doing anything else other than calling mmap(). There is no need >>>> to set errno = 0 manually as glibc always resets it. >>>> >>> The mseal_test should't have dependency on libc, and mmap() is >>> implemented by glibc, right ? >>> >>> I just fixed a bug to switch mremap() to sys_mremap to address an >>> issue that different glibc version's behavior is slightly different >>> for mremap(). >>> >>> What is the reason that __NR_mmap not available in armhf ? (maybe it >>> is another name ?) there must be a way to call syscall directly on >>> armhf, can we use that instead ? >> >> It seems __NR_mmap syscall is deprecated for arm. Found this comment in >> arch/arm/include/asm/unistd.h: >> /* >> * The following syscalls are obsolete and no longer available for EABI: >> * __NR_time >> * __NR_umount >> * __NR_stime >> * __NR_alarm >> * __NR_utime >> * __NR_getrlimit >> * __NR_select >> * __NR_readdir >> * __NR_mmap >> * __NR_socketcall >> * __NR_syscall >> * __NR_ipc >> */ >> >> The glibc mmap() calls mmap2() these days by adjusting the parameters >> internally. From man mmap: >> C library/kernel differences: >> This page describes the interface provided by the glibc mmap() wrapper >> function. Originally, this function invoked a system call of the same >> name. Since Linux 2.4, that system call has been superseded by >> mmap2(2), and nowadays the glibc mmap() wrapper function invokes >> mmap2(2) with a suitably adjusted value for offset. >> >> I'm not sure if behaviour of glibc mmap() and syscall mmap2() would be >> same, but we should use glibc at most places which accounts for >> different architectures correctly. Maybe the differences were only >> present in case of mremap(). >> >> -- >> BR, >> Muhammad Usama Anjum >> -- BR, Muhammad Usama Anjum