From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A788DC27C4F for ; Mon, 24 Jun 2024 02:57:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7144A6B0125; Sun, 23 Jun 2024 22:57:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 64D3F6B0448; Sun, 23 Jun 2024 22:57:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4A0096B044A; Sun, 23 Jun 2024 22:57:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 283276B0447 for ; Sun, 23 Jun 2024 22:57:25 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7263640A53 for ; Mon, 24 Jun 2024 02:57:24 +0000 (UTC) X-FDA: 82264271208.09.41CDCB3 Received: from szxga06-in.huawei.com (szxga06-in.huawei.com [45.249.212.32]) by imf18.hostedemail.com (Postfix) with ESMTP id 4BFF61C0005 for ; Mon, 24 Jun 2024 02:57:20 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=none; spf=pass (imf18.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.32 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719197829; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YT4BCf45PeHs5a5o4UlJOy0Mftg8ZngzzIAulhHOe5s=; b=Q17UkmL8mP4g3fyt1pFrDA+91EzDOTwdVJ6ibLSF8ZdnU6tZFUCiLQmeJTRk5LFX5W5hWt qz6XFaRcu7TmngPF3NImDJ1jKwHw6km8ai4TtDh72DLmyJ6oi8ZgFvCiGRP6CLhhIs8dhg BWWrLcjY25otP+uAbz4pC2hO9QwM3Ng= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719197829; a=rsa-sha256; cv=none; b=rrQm8N/A2g4vBKD5OjeoU3CsF3LzXnrZ+Ef70qCc1JL/40dudPY7PYPgwsOC1v8v7c8olL M4rV3Mj/XXSdDZk5j6tytQ56wburWLTGzdxxa7EkIAVr73e06J97zIpR1AmgQlG03yhHoj gtKFJHtmcYOF2zIO+iOVRT20iQQXIXM= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=none; spf=pass (imf18.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.32 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from mail.maildlp.com (unknown [172.19.163.17]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4W6sz80SCgz1xssc; Mon, 24 Jun 2024 10:55:48 +0800 (CST) Received: from canpemm500002.china.huawei.com (unknown [7.192.104.244]) by mail.maildlp.com (Postfix) with ESMTPS id 8A5EC1A0188; Mon, 24 Jun 2024 10:57:16 +0800 (CST) Received: from [10.173.127.72] (10.173.127.72) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 24 Jun 2024 10:57:16 +0800 Subject: Re: [PATCH v1] mm/memory-failure: refactor log format in unpoison_memory To: Jiaqi Yan CC: , , , , , Naoya Horiguchi References: <20240619063355.171313-1-jiaqiyan@google.com> From: Miaohe Lin Message-ID: <405d629c-65dc-b450-8dbb-95811caef064@huawei.com> Date: Mon, 24 Jun 2024 10:57:15 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20240619063355.171313-1-jiaqiyan@google.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.173.127.72] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To canpemm500002.china.huawei.com (7.192.104.244) X-Stat-Signature: fxb9rad8ugbb98re58w4ugxi578zuwjp X-Rspamd-Queue-Id: 4BFF61C0005 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1719197840-976049 X-HE-Meta: U2FsdGVkX183XGF2DsYYzXY9h+d/wqiCZtKi8WFJd9U/GfkTCZ1AvY4fIWRO+p4xLd7UGcmN0GRgIy1wB12lMKY3MZHXg9jJMWz/jaZ2aGWmrdgCLIrYFcM82wZkR/ExsFJ02zi5OrtiVNhnDWD/npIfDdbe6PvRDVNKocaQLmKgmexM11acmZoO6EDHtUNldEYJDJCwd5OuTvvobAv5fxSRNaq2eG3dzt+CbbPBmalFY7Cd6IPmGwogBQBc8yy1ZazmqK8ZIUa+GaR0aQRIbllHNyUIaSkH0ws3ud6VmUFRfUXg5fGU6OE3+0QCRAmBIzeLWHvSwyEaEQy0I2NoycBNxAdagFUjHkiHXcO3w6OBRjVUJkC5gw7uVJWVPusa14oZeWuCTTZOM7GgK5MKY6oiLG0mAipUOaWMJQWt0Tix/A/Rg87SHkwPiERDOOWwzi3Y3/ylv08mWu17RyyL46LM2EUxEHOnhWg1Hz3kxMuUkBGlcTE0EiZAEE2E/30Crc4abKSXuPCsryt3diB+AgzU21Cv2aKiMwBrbF2/4L8ycbJjsRCcALLb1GE7zkEOXyRsXhcra9w4mIrWT+E4Tj8xAxFa5gxVfe0366W0BNuP3nQ5SqLwu0y+B6Ll0TJmXt5fy4EM6/P6ToTax2+rfZx1kERi7StezfKYmR5i62bXWysVcgDsiYpASaLDEzgrqrrkPY+/Cy3c9QluL4LLtyzFKKDlO6oaKDrP1D+EKOqF5i7rDb+uIh9qPi4uFoLif947ibe8JdCpzLV9acokY7C/K5JR2kV07ExKrU4Iu9FY53CriSc9BtW8RTSCx6c4BLIq8kLTEsn7KpLNxtwDgPtWwIRVbqg6y+kz51rRbZwaTlND8gkO5Skam5CrE+hNCdfY5+6G45aPnKZaJKRLsqgIoyj2vnMjFV8SWSwdkgDM3VJyFo4knuN5UNG/wRAvGh0RBGl5PjN/nUABGvS p5CrsWgn aZsD+AE/0yY3z5Rv8BP3PcErJoQKkck38JwrgUF7fqpTfd1yOBCzSmDZDjRnfhT0gR7/2RJOlLEXKxD8FfWTB1niUykrgFINgeZ5+DGwpmFiR0x+SHeEAFU4mBuAIHCqlkN5+FDZ5pTPimI2ia/zuOjPgRedsxnz5eRaUYfoH0EHeLEhu5W6NMS8IGC+8Iru/cR5CKM8gfbG70nTAeUQmnUuoe9KJQNxV7yJrbeOso+y1BWXT7YHrbBUpoSu0A/GAdjk5twrXC9oCjOLdK49cMuOzRxcPOp9nBRoF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/6/19 14:33, Jiaqi Yan wrote: > Logs from memory_failure and other memory-failure.c code follow the > format: > > "Memory failure: 0x{pfn}: ${lower_case_message}" > > Convert the logs in unpoison_memory to follow similar format: > > "Unpoison: 0x${pfn}: ${lower_case_message}" > > For example (from local test): > [ 1331.938397] Unpoison: 0x144bc8: page was already unpoisoned > > No functional change in this commit. > > Signed-off-by: Jiaqi Yan LGTM. Thanks for your patch. Acked-by: Miaohe Lin Thanks. .