From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89B8EC04FFE for ; Wed, 8 May 2024 13:41:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1942A6B009D; Wed, 8 May 2024 09:41:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 144BF6B00A4; Wed, 8 May 2024 09:41:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 032876B00A5; Wed, 8 May 2024 09:41:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D86506B009D for ; Wed, 8 May 2024 09:41:24 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 94EB0A19DA for ; Wed, 8 May 2024 13:41:24 +0000 (UTC) X-FDA: 82095340488.17.05EB4CD Received: from out30-99.freemail.mail.aliyun.com (out30-99.freemail.mail.aliyun.com [115.124.30.99]) by imf23.hostedemail.com (Postfix) with ESMTP id 9A1FE14001C for ; Wed, 8 May 2024 13:41:20 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=l9Y1vPKH; spf=pass (imf23.hostedemail.com: domain of hsiangkao@linux.alibaba.com designates 115.124.30.99 as permitted sender) smtp.mailfrom=hsiangkao@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715175681; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IWHfvBV+F3yFlGdOQ1Q3mOZgyc0OCykO4A66rQKOeTY=; b=y6cTF4FzxEIDkXAX83RpajjiAHGoF7jprYcNs1s0xL0R6tsIqjAxsAHGJKtej7W76Yuca7 24v36fvWI+FCOWnB5h+AWLVW2ptbtwpDJkiY2BAvANgt9tbEYxeYCmTncMAegQImFZWTyi bIrDTHeQQjhe64kK5/4M1W8XET1J6R4= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=l9Y1vPKH; spf=pass (imf23.hostedemail.com: domain of hsiangkao@linux.alibaba.com designates 115.124.30.99 as permitted sender) smtp.mailfrom=hsiangkao@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715175681; a=rsa-sha256; cv=none; b=4zh6GrALM8O2DhoEFrbFveFuEqtTBo7cJrtaGm9qwgbPX51jrSJrlu3Dwg+mEQ9tW6iFLT V8y6lC8zILM/01w6DmrxNkQ4hsvPHuVIUadCREQhaRP3BLw2Ci7eK123ViM1oDMAuuEvoZ L9iUJveNJ7O2O5FMaTnTo9SLDeorCFU= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1715175675; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=IWHfvBV+F3yFlGdOQ1Q3mOZgyc0OCykO4A66rQKOeTY=; b=l9Y1vPKHtIMvlbh1hdTNpaMaAs054pHBsjU0k/9aKwHeICDKNv7zlg6rQTfpqXtFizkfUM+xaIegEP8GXgxXuI1EkJBcfGd9eMI/f66VdDX34b2A8OnEs9k1ROlQFN8uhPOz1E1CRzMQr5d3V3ubA907YEuFKR3KVtAcdT4i8us= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R261e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam033037067113;MF=hsiangkao@linux.alibaba.com;NM=1;PH=DS;RN=12;SR=0;TI=SMTPD_---0W63uK1o_1715175671; Received: from 30.27.69.8(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0W63uK1o_1715175671) by smtp.aliyun-inc.com; Wed, 08 May 2024 21:41:13 +0800 Message-ID: <404add29-2d3f-45db-9103-0c5b66fb254e@linux.alibaba.com> Date: Wed, 8 May 2024 21:41:10 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH] mm/vmalloc: fix vmalloc which may return null if called with __GFP_NOFAIL To: hailong.liu@oppo.com, akpm@linux-foundation.org, Michal Hocko Cc: urezki@gmail.com, hch@infradead.org, lstoakes@gmail.com, 21cnbao@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, xiang@kernel.org, chao@kernel.org, Oven References: <20240508125808.28882-1-hailong.liu@oppo.com> From: Gao Xiang In-Reply-To: <20240508125808.28882-1-hailong.liu@oppo.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 97tgmdatkqo1q5r8emi3mk8zrnejyi87 X-Rspamd-Queue-Id: 9A1FE14001C X-Rspamd-Server: rspam10 X-Rspam-User: X-HE-Tag: 1715175680-806610 X-HE-Meta: U2FsdGVkX19drcqUvvocPJRsp805tl6R4TKJh7019e1Xjyld9D0ZsWYTfv4sKQGn4PfYAdL6vTTVEjNofdORx3nZ6udJXEUWuJ0djW1ciUEFoCL24ZRT/Ord7eeEydfQ+/QuyM+EYBbvQwHMRjvXQCLRLXGEtFPXlPLn4RRZHRrFk7At3ZSZXSmQiWkz9nit6vWP460s8eCo+5QEkHTBwFnAXaqBLPqMvO88BjZjBk16nl6DAcec1ftuggwoBFUu2HND+ATr2yOz2A/W7IozI2AF0JL7JZQpMGwPnMa+11d88Za4PI+i+Hnzs+NRj4QI/obNN/+ErKU/ms5+BDigTCz/tC2SMyyqFWUd8D9PpcnKOPG0tPx5elTFRNFmA4ZnFZQQiVNbPPvbH39CDDddkjh9ofuljnoh10usXaw13NFFMvb2QFiCua5QJ6in8e6IHD4QrOA7R9k3SVRW2YkG9CFh0M3lp7LMAQds7SCetF+Ri7owgqOISkO6mkb03txQlgCPDv1y0lddxV8XfaTU68om38oIEn7cFBW/5V/ULlUQAIfqs353r95VVlQSHz4iOo95D8EJCIxOU3CS1CcWoJ6eE9/DAZx4GziiFyY4xIQDDnzwCT8JASr+znqpInDgPwT4P+UqTeKYLj1Te4R/JxA8SF7hUNAKHVPzvzjY5IK2cr44Ac9FOKTapMoNaFgE+FJ4Mn/dv8DIszQX1FuGsDvegFOAIUcqCbU7pPvn1z4XSFSJR9CvwrLK69x1vofDyiP/0dDBfvCVtEyiPT+O1UQ1SvNGwf3D/11i5ZFt/JqUkSkfb4zb6G/dPeJ17lGYWiLPqwwuSUpVQtvkXN0XKbnN1MXDvABPQoMz9dLiqpcfRTreTEHmMX/pkrUhNFpvHkqkiMN1e6JOPdUlbYd5Gz7YgsIxqikBoekGXn7Vxdj7ZoNOE/Vs6F5J4a62tDeffJH5vp3PAD348uaMlQ0 xv2uRp6D MiEQdRBv/+oA5k8CpHQqGe7kP2Uz7KmrrWrk9huLWuq/vT7exw1C49c7xOjA/lui54aYw1+UDNWMI5nX1eMz1Q4Q2LNr1saqr9gcZElaco/4QJViUAlzpNZfseX57eM8S2G5ctYc9gaDrhC99/+vY0qa2dFdF61ZWNoMh95LK00v9BZnaXOdE9oK5mPu0EvPPJLSG/QUZwepekvKNAofFaloO31AoJZOy7oiWAGIuwl4Wdn3tD6leYwDHEKOkrEa3c/Y9YyXTH810vIoc041aNVtgqepC3ANqe8dvPPR/BXPGaDKbnr0jHaf8pRdrUOKCnISVd3qAy7bsHoMAyPpDDY1wB4n5kVFTHtivffR35t3BcxIuWWcmaEFoKq2BulnrdyZCYd4dJDwTbQSkYmegLniIwa/jA3QeA1yGOSf3nstxhgl7atsW/7DpPtfw09qxo36o X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: +Cc Michal, On 2024/5/8 20:58, hailong.liu@oppo.com wrote: > From: "Hailong.Liu" > > Commit a421ef303008 ("mm: allow !GFP_KERNEL allocations for kvmalloc") > includes support for __GFP_NOFAIL, but it presents a conflict with > commit dd544141b9eb ("vmalloc: back off when the current task is > OOM-killed"). A possible scenario is as belows: > > process-a > kvcalloc(n, m, GFP_KERNEL | __GFP_NOFAIL) > __vmalloc_node_range() > __vmalloc_area_node() > vm_area_alloc_pages() > --> oom-killer send SIGKILL to process-a > if (fatal_signal_pending(current)) break; > --> return NULL; > > to fix this, do not check fatal_signal_pending() in vm_area_alloc_pages() > if __GFP_NOFAIL set. > > Reported-by: Oven > Signed-off-by: Hailong.Liu Why taging this as RFC here? It seems a corner-case fix of commit a421ef303008 Thanks, Gao Xiang > --- > mm/vmalloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 6641be0ca80b..2f359d08bf8d 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -3560,7 +3560,7 @@ vm_area_alloc_pages(gfp_t gfp, int nid, > > /* High-order pages or fallback path if "bulk" fails. */ > while (nr_allocated < nr_pages) { > - if (fatal_signal_pending(current)) > + if (!(gfp & __GFP_NOFAIL) && fatal_signal_pending(current)) > break; > > if (nid == NUMA_NO_NODE) > --- > This issue occurred during OPLUS KASAN test. Below is part of the log > > -> send signal > [65731.222840] [ T1308] oom-kill:constraint=CONSTRAINT_NONE,nodemask=(null),cpuset=/,mems_allowed=0,global_oom,task_memcg=/apps/uid_10198,task=gs.intelligence,pid=32454,uid=10198 > > [65731.259685] [T32454] Call trace: > [65731.259698] [T32454] dump_backtrace+0xf4/0x118 > [65731.259734] [T32454] show_stack+0x18/0x24 > [65731.259756] [T32454] dump_stack_lvl+0x60/0x7c > [65731.259781] [T32454] dump_stack+0x18/0x38 > [65731.259800] [T32454] mrdump_common_die+0x250/0x39c [mrdump] > [65731.259936] [T32454] ipanic_die+0x20/0x34 [mrdump] > [65731.260019] [T32454] atomic_notifier_call_chain+0xb4/0xfc > [65731.260047] [T32454] notify_die+0x114/0x198 > [65731.260073] [T32454] die+0xf4/0x5b4 > [65731.260098] [T32454] die_kernel_fault+0x80/0x98 > [65731.260124] [T32454] __do_kernel_fault+0x160/0x2a8 > [65731.260146] [T32454] do_bad_area+0x68/0x148 > [65731.260174] [T32454] do_mem_abort+0x151c/0x1b34 > [65731.260204] [T32454] el1_abort+0x3c/0x5c > [65731.260227] [T32454] el1h_64_sync_handler+0x54/0x90 > [65731.260248] [T32454] el1h_64_sync+0x68/0x6c > [65731.260269] [T32454] z_erofs_decompress_queue+0x7f0/0x2258 > --> be->decompressed_pages = kvcalloc(be->nr_pages, sizeof(struct page *), GFP_KERNEL | __GFP_NOFAIL); > kernel panic by NULL pointer dereference. > erofs assume kvmalloc with __GFP_NOFAIL never return NULL. > > [65731.260293] [T32454] z_erofs_runqueue+0xf30/0x104c > [65731.260314] [T32454] z_erofs_readahead+0x4f0/0x968 > [65731.260339] [T32454] read_pages+0x170/0xadc > [65731.260364] [T32454] page_cache_ra_unbounded+0x874/0xf30 > [65731.260388] [T32454] page_cache_ra_order+0x24c/0x714 > [65731.260411] [T32454] filemap_fault+0xbf0/0x1a74 > [65731.260437] [T32454] __do_fault+0xd0/0x33c > [65731.260462] [T32454] handle_mm_fault+0xf74/0x3fe0 > [65731.260486] [T32454] do_mem_abort+0x54c/0x1b34 > [65731.260509] [T32454] el0_da+0x44/0x94 > [65731.260531] [T32454] el0t_64_sync_handler+0x98/0xb4 > [65731.260553] [T32454] el0t_64_sync+0x198/0x19c > > -- > 2.34.1