From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2D76C433F5 for ; Tue, 23 Nov 2021 08:47:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 39F736B0073; Tue, 23 Nov 2021 03:47:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 328766B0074; Tue, 23 Nov 2021 03:47:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1C8C26B0075; Tue, 23 Nov 2021 03:47:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0029.hostedemail.com [216.40.44.29]) by kanga.kvack.org (Postfix) with ESMTP id 08F406B0073 for ; Tue, 23 Nov 2021 03:47:06 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id BFBDA182B0301 for ; Tue, 23 Nov 2021 08:46:55 +0000 (UTC) X-FDA: 78839564790.30.503CAFA Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) by imf31.hostedemail.com (Postfix) with ESMTP id C2CF71046316 for ; Tue, 23 Nov 2021 08:46:49 +0000 (UTC) Received: by mail-ed1-f51.google.com with SMTP id o20so44347734eds.10 for ; Tue, 23 Nov 2021 00:46:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=7HA05XhYlCzTp4qvhhSBcSuSKybJ0PulYKdWBwG+DL8=; b=eRxUC+sJSCTIGOoVdTOOhCcUZfnZdG7DdFIkTVEmTD9NGwphMQiid3xEfITu5XW/Fm OPcyu0o0RT6S6BanewL3NWZY6xVwmP0C439+0yWwFxG7UfkAXRzQPZpRKz3tzk18JnVw HtjSX+daGQP8TGpv1J7Hr4rpLkhRhWOvo2U6K+oZWNz38u91Wa2/oojHfKIIW/fP8O/2 ahzoMGXbn8rp25gMWGp0CrvgXNrpYwO9AUUeMsfLXR/CR8EAjxMYcttXW0FO+AjATfG+ AGb2k3JRmpq499iNZ+yWcjQK0WwJ6RmYDNO89V0hqqHW4QFAC87ThcSmDD7gnTTsYtlu 0MVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=7HA05XhYlCzTp4qvhhSBcSuSKybJ0PulYKdWBwG+DL8=; b=s5XSbke5fAIyXfqCNRb7iV8PEM58K2fKJI81LNjEgQD2ekPARnEdflNGt5ab9ICanw vAZjP29BJuxC6cIxXNdEyR3AavqizBxkWIYC3yTzMc7uyayOekKEZeWCWOXDPe/TtkRy dfmCZVWOdzLLZevcGu7mce97Q3XjUhk7M7nrC9uCBVpjzAIkfHHP9frjyYDRF492KnUa tv/SmA6A6p2tB49fFWin5k82g4eU9nAgXUpVMzl0x5F69LuUNRO1sgW61AYMc8UNVdaW hjmhInIjcRI8g1v5Hanbx1WMwTPe2r6FN6vBFvNRka0EM+A/eVjGb0vFe1+UB3QdNQXr 5zsg== X-Gm-Message-State: AOAM531Q/M4FXFvV3Hu6b5BVIud3Qwq3Gea1t2iaaLyA9HATiyVGn5jl 6F1MTs9Bvo1NysYWcaceEkg= X-Google-Smtp-Source: ABdhPJygultcXZ5O6UR+Ra3FMuRkjBlnywYkj/YSuUzgBBN4t/ktdv6OEJaf5N8LyoDiF4gs7MeeKQ== X-Received: by 2002:a17:906:974c:: with SMTP id o12mr2362914ejy.229.1637657214203; Tue, 23 Nov 2021 00:46:54 -0800 (PST) Received: from ?IPV6:2001:b07:add:ec09:c399:bc87:7b6c:fb2a? ([2001:b07:add:ec09:c399:bc87:7b6c:fb2a]) by smtp.googlemail.com with ESMTPSA id cs12sm5074681ejc.15.2021.11.23.00.46.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Nov 2021 00:46:53 -0800 (PST) Message-ID: <4041d98a-23df-e9ed-b245-5edd7151fec5@redhat.com> Date: Tue, 23 Nov 2021 09:46:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [RFC v2 PATCH 09/13] KVM: Introduce kvm_memfd_invalidate_range Content-Language: en-US To: Chao Peng , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, qemu-devel@nongnu.org Cc: Jonathan Corbet , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H . Peter Anvin" , Hugh Dickins , Jeff Layton , "J . Bruce Fields" , Andrew Morton , Yu Zhang , "Kirill A . Shutemov" , luto@kernel.org, john.ji@intel.com, susie.li@intel.com, jun.nakajima@intel.com, dave.hansen@intel.com, ak@linux.intel.com, david@redhat.com References: <20211119134739.20218-1-chao.p.peng@linux.intel.com> <20211119134739.20218-10-chao.p.peng@linux.intel.com> From: Paolo Bonzini In-Reply-To: <20211119134739.20218-10-chao.p.peng@linux.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 3ct1xa9p9m6iicix8b75kbycogof4h67 Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=eRxUC+sJ; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (imf31.hostedemail.com: domain of paolo.bonzini@gmail.com designates 209.85.208.51 as permitted sender) smtp.mailfrom=paolo.bonzini@gmail.com X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: C2CF71046316 X-HE-Tag: 1637657209-256065 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/19/21 14:47, Chao Peng wrote: > + > + /* Prevent memslot modification */ > + spin_lock(&kvm->mn_invalidate_lock); > + kvm->mn_active_invalidate_count++; > + spin_unlock(&kvm->mn_invalidate_lock); > + > + ret = __kvm_handle_useraddr_range(kvm, &useraddr_range); > + > + spin_lock(&kvm->mn_invalidate_lock); > + kvm->mn_active_invalidate_count--; > + spin_unlock(&kvm->mn_invalidate_lock); > + You need to follow this with a rcuwait_wake_up as in kvm_mmu_notifier_invalidate_range_end. It's probably best if you move the manipulations of mn_active_invalidate_count from kvm_mmu_notifier_invalidate_range_* to two separate functions. Paolo