From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66675C54E68 for ; Thu, 14 Mar 2024 12:33:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EBC8C8009F; Thu, 14 Mar 2024 08:32:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E6AB580073; Thu, 14 Mar 2024 08:32:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D33568009F; Thu, 14 Mar 2024 08:32:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C2CF080073 for ; Thu, 14 Mar 2024 08:32:59 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 98AC6120A57 for ; Thu, 14 Mar 2024 12:32:59 +0000 (UTC) X-FDA: 81895584078.29.BF3A535 Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) by imf10.hostedemail.com (Postfix) with ESMTP id AE8F9C0020 for ; Thu, 14 Mar 2024 12:32:56 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b="I1HG/6WP"; dmarc=pass (policy=quarantine) header.from=collabora.com; spf=pass (imf10.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710419576; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5b4/dIsD7MoDdVghUMVh28b8lyZkUQ5Oi+R3bew56xs=; b=xak4BJLhHbzv6vJBskzxu8hfx3zVOxAlpALS9WuazDDYyzj6qkthbUAHORA0vhXeYw0/ax gLzbUu5lR90dxkPxdS5+g5SwuRIcv7Z78UhjwnYnsMTH+EZorcgkkjfPjyo75CFJIrzZ1r kV1QWbkD3S6LMYrfNeHn30o+Tc4Akzg= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b="I1HG/6WP"; dmarc=pass (policy=quarantine) header.from=collabora.com; spf=pass (imf10.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710419576; a=rsa-sha256; cv=none; b=u22gMHZn0ozVzHOd1StL9wftH1IWmjXkEB17KJqBtUruA7RSiIs5mHiUxAVD1x5GxGiLxp BDKneZsk56gmbLAwBcCmU7kRniG+PKL3BX9mKmy0beo2zRmAmRxZFFCJ3Fu7L149ETm8f7 v4u0IOCCR/veK0dmWWgy9nduQ+WQ49c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1710419575; bh=574oiJk4n6nucm8nS4oAXdmfVeBrOVyCvvWnaYG3mok=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=I1HG/6WPvE/LZ73Mn7MPjH4TZNgGb/hv56lxJ1Z/1lgA2vPA1sh9TIFvjnN9QvJT2 6TZzMAP0EIyd7IwbzMVyH9ZtHJK8PQgiOWdC85SH/v6ZKI0sP82KgpxaV9iSDXMgl6 RwgZiI9cRVwaI15O43ChYvR50wrZJQJTOE9gh+OJU/3e/3oFPaw8d9IwDu4lGe/e1n EwES6B/K0TuqhJCpf9WSqUk+c44skbXSLMq5urYtSpOcjFNzXz/OqG+FEKbb33nZ/L SIoZLa9PflCruCMvY++ogCW22QA7kdRjWjzfoIpNw77JfB+oOm5FkiNREXIH8FG0q7 rJqcLHOMHfS3g== Received: from [10.193.1.1] (broslavsky.collaboradmins.com [68.183.210.73]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madrid.collaboradmins.com (Postfix) with ESMTPSA id F40CE37820EF; Thu, 14 Mar 2024 12:32:52 +0000 (UTC) Message-ID: <403e7704-5d87-43c5-b48d-3faca2a9727a@collabora.com> Date: Thu, 14 Mar 2024 17:33:13 +0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Muhammad Usama Anjum , kernel@collabora.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Anshuman.Khandual@arm.com Subject: Re: [PATCH] selftests/mm: virtual_address_range: Switch to ksft_exit_fail_msg Content-Language: en-US To: Dev Jain , akpm@linux-foundation.org, shuah@kernel.org References: <07e2e91b-7b0d-4810-a2a1-ed4654ecafb4@collabora.com> <20240314122250.68534-1-dev.jain@arm.com> From: Muhammad Usama Anjum In-Reply-To: <20240314122250.68534-1-dev.jain@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: AE8F9C0020 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 6dduwtn44u54fgdedsduxx7y7mu5sb94 X-HE-Tag: 1710419576-935201 X-HE-Meta: U2FsdGVkX18utzRqBAvpqiNNDHBb8H1VUnAkYZJr35O9fty1q6F16+UNVRbtfz5ZwcieA+sX1NGPeyW9v7K7rfND8s9jMmWX/G1m8gjMWRjAd4a5zhc/kFuSld8nrwSiASj4ygmYja0zZtpxBqVY1AZMIJBGx8hTPxXgXyMCQQYLYgTzFoajx4RimNS0jbWCJuDcZxbnXBZzx3FRQEQTpPaGaY8X+TpItkMeplHZ29YvBvsZKCSDJr8R+eKhQgySn+2YeFy54GgyYIvgNU26vamA67U3nyIe7LhKixafKzSkHSA5fTEZKNqzVvbzw7k7hI5Gao8R+Q5Ueqot4wN91M0kuVI2zAxDKOk8RHaJk9ZANuulJdmv3JH7OhEy9hGnF9ir++aHw+UsUxh78U4gmu+DJJ42bCjghEbG1D1dQWDdHJNTu954ualwqM/YjbFcWZ9mR1GfOmp21WVbcWQkaGe6yyqlOWF/YjVFKrVnMlZyqGCnYnZH7oSMKQ9X4Bua5M5a5DoZ9mPAfrUPgxOcz8Sv29jyBKsG7PZP3CLpqwRVodyr+TPo5ZcTL+ycDvHpDrDHTeVQNCZiyG8i58gD52TEpsLU/SEUCAnoNmpv7AEsBzOLysY8G6FItbYRHGBTTv1oPz2vrdkSqHUAuJbU7vrpXSGEkO9sZQeir5ggDjcD6JTyMKmW5TIUf/6eQsGevg2k4VsVAdQXgTbApBqjhH2h1KmR8Nvw/OLL8yXYLD2jyQpeO8iueXVgX+wPCWEkUz9VRnVqTjDD3GFGWfIY9zS/csZAPIj9wgqvnN5u3LcZL+uT03njhjplBkaXO17awJAVuLOVgaqxnGQM1n5MgXh5TdSEMf/nN3fwkCrOLJ1MuOELbTDkx9avLFXB1zjMlLmvYOoVXF8dQTsS3jpUR1bpTEu4pL+UafpYiSInRm5DN5jHHl3ZG4y9DhgpeTjd9Duo/olv7V1aMnrwXaj 0dR3awRT 1TA1gkvYxtZ/BKZVK6vAIli8vYneuVtXodw2vd9/pQ74nm/ilE6ak5EgT6kCSNl1otKSroU8UdAMz3Kn2D2FpK4E4/haysQX3DO2fG1O2x5YixTO1l7WzNLDzdD6G6qLSl3A1FMAOkeFEU0esEFZ9NrxkP7XnUfXT/eGdOSFHh6qowzryWhh0I5cP9iICvw5BteqT6335VdhTsdBA1DH8kE7rYtVnn5raGKqYLgWXvveHdacPhWJA4BSIdICZqFJIK2Gy9CD2XnK927PgtgnJAE9IHc9XA8tj9PHyPuqqpOmdDT0P38erfpxwNU03riF0p90HNi2+pGht0AEuxWQjlA428IBHoSPJ379a/9hogtId+ohSAmofSH84E7kWZXJ9HIheNZ+PC5f+J93CqZEmLG93Hg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Thanks for the patch. The patch should have been sent to a separate new thread. On 3/14/24 5:22 PM, Dev Jain wrote: > mmap() must not succeed in validate_lower_address_hint(), for if it does, it > is a bug in mmap() itself. Reflect this behaviour with ksft_exit_fail_msg(). > While at it, do some formatting changes. > > Signed-off-by: Dev Jain Reviewed-by: Muhammad Usama Anjum > --- > tools/testing/selftests/mm/virtual_address_range.c | 12 +++++------- > 1 file changed, 5 insertions(+), 7 deletions(-) > > diff --git a/tools/testing/selftests/mm/virtual_address_range.c b/tools/testing/selftests/mm/virtual_address_range.c > index 7bcf8d48256a..426ddfc345fb 100644 > --- a/tools/testing/selftests/mm/virtual_address_range.c > +++ b/tools/testing/selftests/mm/virtual_address_range.c > @@ -85,7 +85,7 @@ static int validate_lower_address_hint(void) > char *ptr; > > ptr = mmap((void *) (1UL << 45), MAP_CHUNK_SIZE, PROT_READ | > - PROT_WRITE, MAP_PRIVATE | MAP_ANONYMOUS, -1, 0); > + PROT_WRITE, MAP_PRIVATE | MAP_ANONYMOUS, -1, 0); > > if (ptr == MAP_FAILED) > return 0; > @@ -105,13 +105,11 @@ int main(int argc, char *argv[]) > > for (i = 0; i < NR_CHUNKS_LOW; i++) { > ptr[i] = mmap(NULL, MAP_CHUNK_SIZE, PROT_READ | PROT_WRITE, > - MAP_PRIVATE | MAP_ANONYMOUS, -1, 0); > + MAP_PRIVATE | MAP_ANONYMOUS, -1, 0); > > if (ptr[i] == MAP_FAILED) { > - if (validate_lower_address_hint()) { > - ksft_test_result_skip("Memory constraint not fulfilled\n"); > - ksft_finished(); > - } > + if (validate_lower_address_hint()) > + ksft_exit_fail_msg("mmap unexpectedly succeeded with hint\n"); > break; > } > > @@ -127,7 +125,7 @@ int main(int argc, char *argv[]) > for (i = 0; i < NR_CHUNKS_HIGH; i++) { > hint = hind_addr(); > hptr[i] = mmap(hint, MAP_CHUNK_SIZE, PROT_READ | PROT_WRITE, > - MAP_PRIVATE | MAP_ANONYMOUS, -1, 0); > + MAP_PRIVATE | MAP_ANONYMOUS, -1, 0); > > if (hptr[i] == MAP_FAILED) > break; -- BR, Muhammad Usama Anjum