From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4269C63697 for ; Thu, 26 Nov 2020 13:52:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 42ED22087C for ; Thu, 26 Nov 2020 13:52:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 42ED22087C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9A8516B0070; Thu, 26 Nov 2020 08:52:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 95B3C6B0075; Thu, 26 Nov 2020 08:52:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8489D6B007E; Thu, 26 Nov 2020 08:52:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0249.hostedemail.com [216.40.44.249]) by kanga.kvack.org (Postfix) with ESMTP id 6E1CA6B0070 for ; Thu, 26 Nov 2020 08:52:35 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 30CB2181AC9B6 for ; Thu, 26 Nov 2020 13:52:35 +0000 (UTC) X-FDA: 77526709470.06.ice41_33144102737f Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin06.hostedemail.com (Postfix) with ESMTP id 07F0B1004C642 for ; Thu, 26 Nov 2020 13:52:35 +0000 (UTC) X-HE-Tag: ice41_33144102737f X-Filterd-Recvd-Size: 2562 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf07.hostedemail.com (Postfix) with ESMTP for ; Thu, 26 Nov 2020 13:52:34 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 5D187AD20; Thu, 26 Nov 2020 13:52:33 +0000 (UTC) Subject: Re: [PATCH 7/7] mm,hwpoison: Remove drain_all_pages from shake_page To: Oscar Salvador , akpm@linux-foundation.org Cc: n-horiguchi@ah.jp.nec.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20201119105716.5962-1-osalvador@suse.de> <20201119105716.5962-8-osalvador@suse.de> From: Vlastimil Babka Message-ID: <4033449e-eb86-e306-81af-d4c6dc823bdf@suse.cz> Date: Thu, 26 Nov 2020 14:52:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20201119105716.5962-8-osalvador@suse.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/19/20 11:57 AM, Oscar Salvador wrote: > get_hwpoison_page already drains pcplists, previously disabling > them when trying to grab a refcount. > We do not need shake_page to take care of it anymore. > > Signed-off-by: Oscar Salvador > --- > mm/memory-failure.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index 512613e9a1bd..ad976e1c3178 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -263,8 +263,8 @@ static int kill_proc(struct to_kill *tk, unsigned long pfn, int flags) > } > > /* > - * When a unknown page type is encountered drain as many buffers as possible > - * in the hope to turn the page into a LRU or free page, which we can handle. > + * Unknown page type encountered. Try to check whether it can turn PageLRU by > + * lru_add_drain_all, or a free page by reclaiming slabs when possible. > */ > void shake_page(struct page *p, int access) > { > @@ -275,9 +275,6 @@ void shake_page(struct page *p, int access) > lru_add_drain_all(); > if (PageLRU(p)) > return; > - drain_all_pages(page_zone(p)); > - if (PageLRU(p) || is_free_buddy_page(p)) > - return; I wonder if page in the lru pagevec can in fact become free after draining the lru - in that case we could keep the is_free_buddy_page() check. > } > > /* >