From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A385EC4332F for ; Thu, 17 Nov 2022 21:41:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1E2466B0071; Thu, 17 Nov 2022 16:41:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 192076B0072; Thu, 17 Nov 2022 16:41:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 05A3A6B0073; Thu, 17 Nov 2022 16:41:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E9AC46B0071 for ; Thu, 17 Nov 2022 16:41:29 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id AD5E1120516 for ; Thu, 17 Nov 2022 21:41:29 +0000 (UTC) X-FDA: 80144255898.01.B0411FC Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 439E2A0009 for ; Thu, 17 Nov 2022 21:41:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668721288; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UuffnjWXo7tMwo00tJbjEU1LHxhg1We6830zDfm1nv8=; b=DIUL0IuDlNddnIFXkE0QyDMQZhbJUYLtHxAbH4DlKcWchvEoC9XlsLcau340162cgqzPdV Akn1/u4Be40L6nhOVr+TNpwb+wnPU66+ulcambjlNYvB9bC8iiT02IBa0+i3oa+qwlWx/J a+LILUWd9oKUE3oIqjimADHeon76Dhg= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-628-2Ct9ZNWvOY2mRvcbD5Qzyg-1; Thu, 17 Nov 2022 16:41:25 -0500 X-MC-Unique: 2Ct9ZNWvOY2mRvcbD5Qzyg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A8B0329ABA33; Thu, 17 Nov 2022 21:41:24 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.24]) by smtp.corp.redhat.com (Postfix) with ESMTP id 123EF40C6EC3; Thu, 17 Nov 2022 21:41:22 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20221116183900.yzpcymelnnwppoh7@riteshh-domain> References: <20221116183900.yzpcymelnnwppoh7@riteshh-domain> <20221113162902.883850-1-hch@lst.de> To: "Ritesh Harjani (IBM)" Cc: dhowells@redhat.com, Christoph Hellwig , Namjae Jeon , Sungjong Seo , Jan Kara , OGAWA Hirofumi , Mikulas Patocka , Dave Kleikamp , Bob Copeland , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-karma-devel@lists.sourceforge.net, linux-mm@kvack.org Subject: Re: start removing writepage instances MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <4031744.1668721280.1@warthog.procyon.org.uk> Date: Thu, 17 Nov 2022 21:41:20 +0000 Message-ID: <4031745.1668721280@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DIUL0IuD; spf=pass (imf25.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668721289; a=rsa-sha256; cv=none; b=bUpidZyYoAQpBe/N2qYSIDDdNEVyOlXh3IVdLYJ7oeVpUaPdE2O4/+d6FFc0iDqVUuNgns /+4+wy7KjWAQk11fgJlC2x/2s/X/FV0Q2LDdY7vGgN6xEoljhUAlG5yuyauXae//ROt88/ SgcI6V7FnSQfH8hRJHKjzWYuDriIYis= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668721289; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UuffnjWXo7tMwo00tJbjEU1LHxhg1We6830zDfm1nv8=; b=vjYPC/yZc5hbWrN8PdzolyDD5EXA4OQ9Lj85hG3VfK+IUCnTc+/lrW41F/TFOaMWrzLcIq VTEYz7dh+9E9dA8afdcmJ0JadkcalxP6832k31yQxWUxcuZUraCAo47hZjOgVSMWuz0UOX 0BEDrXSB/iwxPpnXRIC8K/BRn5t+99I= Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DIUL0IuD; spf=pass (imf25.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam02 X-Rspam-User: X-Stat-Signature: di5wjkrpjkwo8choe9wbi1kj4g3joqrq X-Rspamd-Queue-Id: 439E2A0009 X-HE-Tag: 1668721289-144295 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Also ->writepage() is called with the page already locked, which is a problem if you need to write out a number of surrounding pages with it. David