From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 693FBD44167 for ; Tue, 19 Nov 2024 15:29:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DFCBF6B00A3; Tue, 19 Nov 2024 10:29:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DAC3F6B00A4; Tue, 19 Nov 2024 10:29:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C4D9B6B00A6; Tue, 19 Nov 2024 10:29:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A3DE66B00A3 for ; Tue, 19 Nov 2024 10:29:15 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 51E141C6A6C for ; Tue, 19 Nov 2024 15:29:15 +0000 (UTC) X-FDA: 82803226716.23.7863619 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf23.hostedemail.com (Postfix) with ESMTP id CABC314000B for ; Tue, 19 Nov 2024 15:28:39 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YgYlpBun; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732029969; a=rsa-sha256; cv=none; b=ivlwbP4hTF8MDJt2tq250cROAk9XF8jdc12UDniwR2IxQR+eRlceOIIxUN9u7DFWLoYuce TRPvMeAmwuXW5WKuVRcOjzYs14/OioeKfu4rC6lWTvo3hv/f14OMUrWgq9FE7d1IN61wRP 1KysI1i69ci7LkSAT3PX6MivZHvhfmY= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YgYlpBun; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732029969; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vc5vvzTPcrv6TN+NrDbFJ4TRG1yk/ozBlawitHkFcNE=; b=gnvU2HrCEdjDrvaHFaaqLfxhPG9qwJ/ahMy7iCp1eu2vYBsROjjUorpHomz+RDIiiXCrcb OTAbpuHecF0hsnCGkCVA07y+XNzhT6NdBZYMoqbs0vk7tev7MasA9i4g1eRmwmj3wEZNc3 2y/ilv5JCWVIuF+bfTc8kOGKD7/fPis= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732030152; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=vc5vvzTPcrv6TN+NrDbFJ4TRG1yk/ozBlawitHkFcNE=; b=YgYlpBunIUgTla86+9Bd1zxxMF+nYKstDT+C+P4uDJ7PYb2yoJ1/v4xSH1GiY9grOF7yMy cZkZTYJZINAaGg96wFIUZqhxazHi6loC0mTElvNTCtPceGqi3EDTe7nDIjU93B7mQUsY4t e/gN9DcG9uRvIhSkjXTYU0CzpZDRVc4= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-400-kxRcojhON8aI1y_0o2Bukw-1; Tue, 19 Nov 2024 10:29:10 -0500 X-MC-Unique: kxRcojhON8aI1y_0o2Bukw-1 X-Mimecast-MFC-AGG-ID: kxRcojhON8aI1y_0o2Bukw Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-431673032e6so35393425e9.0 for ; Tue, 19 Nov 2024 07:29:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732030149; x=1732634949; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=vc5vvzTPcrv6TN+NrDbFJ4TRG1yk/ozBlawitHkFcNE=; b=Ih8+olfQ9SqwGlncD7pFs6c0di7eoPetaEasfYZSytFXD/81HU7UaIEAY4a/bIIIeK jX7SdbNDaZeI9XvKoK+V7T4/NAcz7uVf7kl0jz5S/GWxrqCCtIT89Kl6xC4UBTkfEMnM r15m/oAlQW207ZBHyaq8IaLoCDQRcweoZX+gIFXvimIifZCKtZpBFW6vdIlR8NXjh38D 007grkqa6/CEr98QvkUuZ0cD14i7mI13dTY0PIZCwzItqWmuiGgeUkMRAZ2bPUWhO2X9 yQwrJ5R22AJ6LnKEUz5nP5dSVcstgEKf5ofjMKriIuY1FotSVV+hHcPqNX81Z9UNaNKo 8BlQ== X-Forwarded-Encrypted: i=1; AJvYcCUWIzjoglje5Hmh3QvGaiiAq4D6i85yXnS7Mx3XXCFWoALJd96Z+zpsIFyVd13FzpDSIlS9tqUuug==@kvack.org X-Gm-Message-State: AOJu0Yzxd1FxgILVVmJqB6cjRbc7/RfkMsNl7YjK72r776EL+Jz6kJ7T exyK15i6kxbgtpkFszM3M2tBixb1GINjO1C5vkh5VaffhVjRwdMYHTeYYKt7xWCNCtnUvBl2fUr LQ4PR2sBQQh/AqpA+AC4SnNWIB6zZkttfP0BCwPDuclPGIfmu X-Received: by 2002:a05:600c:3b2a:b0:431:6060:8b22 with SMTP id 5b1f17b1804b1-432df72c076mr163241415e9.10.1732030149502; Tue, 19 Nov 2024 07:29:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IGub6vsuebwWJa+pkt/6fqcrb3uCEp4oj5TyUg2/2lFaCYHSUxogpmeMc8ScPB1EVv7ys2TKQ== X-Received: by 2002:a05:600c:3b2a:b0:431:6060:8b22 with SMTP id 5b1f17b1804b1-432df72c076mr163241255e9.10.1732030149201; Tue, 19 Nov 2024 07:29:09 -0800 (PST) Received: from ?IPV6:2003:cb:c74b:d000:3a9:de5c:9ae6:ccb3? (p200300cbc74bd00003a9de5c9ae6ccb3.dip0.t-ipconnect.de. [2003:cb:c74b:d000:3a9:de5c:9ae6:ccb3]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-432da244924sm199390395e9.7.2024.11.19.07.29.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Nov 2024 07:29:08 -0800 (PST) Message-ID: <402ff3e5-4fca-4452-97ba-5b1ec4a6eeb1@redhat.com> Date: Tue, 19 Nov 2024 16:29:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH mm-unstable v2 1/3] mm/contig_alloc: support __GFP_COMP To: Yu Zhao , Andrew Morton , Muchun Song Cc: "Matthew Wilcox (Oracle)" , Zi Yan , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240814035451.773331-1-yuzhao@google.com> <20240814035451.773331-2-yuzhao@google.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240814035451.773331-2-yuzhao@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Wnyxw2dbJ506a-CThZWU9oXHeDVQeCf52CPhOO0tsQk_1732030149 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: idz6ahuzkjm5z3thqqm1qmjehyi4de1h X-Rspamd-Queue-Id: CABC314000B X-Rspamd-Server: rspam08 X-Rspam-User: X-HE-Tag: 1732030119-826991 X-HE-Meta: U2FsdGVkX1+OWQLMnuh92cWZhKiCEUKe0QhIYBWUOQv5BZBQtvgR8QSiFuu1oRhzuR5u1h/E8DD+ea/zUYlIG26cnrlwmvxeqtEahfeCoGQwABh5c1UwIMZbdsATTIz6+ihcL6MHOQtgMPf58uth9XhXHemvcGp22Ni067zS9CDsxy7c2z3YIMem2ImZ7s90Tc5oLj4egwbNZUiBPyJiw8lpdTofVG3PLb9/1opCE5YimiowOrAvQ7lwn5xZHbu8dKyUVJxcOH513hqE9hm73ff1e1mhHB8K+JXoAcY7LkCwD+IqIbZfCHBu1tqdK1SSXmKO48fs1dpDWyCKlDTOWmqy8nM6+rN3Aibbsg4xn+w3ybEB90F8w9MOzVdbvvq3B7BLt2FgM00MwWjIIv72AenKIc12nS6tD4nm8BLL7dbGX/8xqfHeat5YYJ/Ocz2h+kN6pqfv9mVXL1XBOgJLHRkFMGUX+2ifuJf6vGlnvTAbU0ZQsvR8B2B2DcHfbrNDFGrVPno5CkjVhGxDxY2ZLyz8unWD4of1U/JCkG/ob2quFXgTZ++wA/k+5uPazKjbjZlGrhAw99QUKU+jB5scJyH0xTMNb8u57ZUm8oBEsycOSCg36kZVfRgVktwvBWD3LfUZyBbqTngpJbz5wMDGjFan3UxTsyCKzVsckTl63YIwgjhkP9h02ZJuVLZGbOuHPV+KcfG0QH4F+lpWjm8LbrRv3FJTQf4AGSD6dxWO2HuoeSfyZAkQPV3rnSXRNLHenXujFzh89SICn6czrscKZgxlkhVb0KJ2yLu66aIwOCgTTBeXb9gxDG9GK9LxnwtX1MqMf/Y/y2XU+eNDX9qn/Z9HqNLigAjPoJOmwoancNjnNpVd13+Q5EanLIiGJPL+8p7CCZoKnhF/Mi9IWvDhsfBDTQU57adqp9wdLioEl37lrjIAu5A8JqW43VQzJE6fB5oWd/v38zNvFvtJp6N w98UjD2E FUtLeY7tfZq8XnKILFNcyrfAE9mAGwvyfD1kIGs/byhK2ZBc2MssKHqZ7tv7VvK7r9d7c1Zuu5bzep8SKusqrYBAimozey2MyOCDqRyvMBjphZNaiDhChh4dh0Jw3RnEHqshlWringYFZR8JFcXMsBn/ex/df0oE+d5GJuVVsB5RpiCh0M4/73MfxKAx+4Br/xPq86bpIKNrlLJCGb7Q5QBrJ0RqoZw9Y0ecAQtOq9etIr2+hMCfqPrJfKMvh8gXHTYtRsDDriAe//xNReCiADZWS8dR8C/BwPomzy/HUKEY+AiEbFX88pAttMH8Vn0dQGMK861mBBVnTZOUpVLwBrrMIF1rUscfxBSCrTm27MqDGi+uEcWUuRKQRoPznfa09cIm3JOf8U7kArP0ey9kvOLxeQTwlaBFYoXr7C9meItaAb//GPEBa1lFF7CUEMSTI0nYg X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > +/* Split a multi-block free page into its individual pageblocks. */ > +static void split_large_buddy(struct zone *zone, struct page *page, > + unsigned long pfn, int order, fpi_t fpi) > +{ > + unsigned long end = pfn + (1 << order); > + > + VM_WARN_ON_ONCE(!IS_ALIGNED(pfn, 1 << order)); > + /* Caller removed page from freelist, buddy info cleared! */ > + VM_WARN_ON_ONCE(PageBuddy(page)); > + > + if (order > pageblock_order) > + order = pageblock_order; > + > + while (pfn != end) { > + int mt = get_pfnblock_migratetype(page, pfn); > + > + __free_one_page(page, pfn, zone, order, mt, fpi); > + pfn += 1 << order; > + page = pfn_to_page(pfn); > + } > +} Hi, stumbling over this while digging through the code .... > + > static void free_one_page(struct zone *zone, struct page *page, > unsigned long pfn, unsigned int order, > fpi_t fpi_flags) > { > unsigned long flags; > - int migratetype; > > spin_lock_irqsave(&zone->lock, flags); > - migratetype = get_pfnblock_migratetype(page, pfn); > - __free_one_page(page, pfn, zone, order, migratetype, fpi_flags); This change is rather undesired: via __free_pages_core()->__free_pages_ok() we can easily end up here with order=MAX_PAGE_ORDER. What your new code will do is split this perfectly reasonable MAX_PAGE_ORDER chunk via split_large_buddy() into pageblock-sized chunks, and let the buddy merging logic undo our unnecessary splitting. Is there a way to avoid this and just process the whole MAX_PAGE_ORDER chunk like we used to? -- Cheers, David / dhildenb