From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <40226793.3000306@cyberone.com.au> Date: Fri, 06 Feb 2004 02:56:03 +1100 From: Nick Piggin MIME-Version: 1.0 Subject: Re: [PATCH 0/5] mm improvements References: <16416.64425.172529.550105@laputa.namesys.com> <16417.3444.377405.923166@laputa.namesys.com> <4021A6BA.5000808@cyberone.com.au> <16418.19751.234876.491644@laputa.namesys.com> <40225D1F.8090103@cyberone.com.au> <40225E0B.70200@cyberone.com.au> <16418.24401.323448.472921@laputa.namesys.com> <40226267.3080703@cyberone.com.au> <16418.25964.158500.724463@laputa.namesys.com> In-Reply-To: <16418.25964.158500.724463@laputa.namesys.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Nikita Danilov Cc: Hugh Dickins , Andrew Morton , linux-mm@kvack.org List-ID: Nikita Danilov wrote: >Nick Piggin writes: > > > > Yeah... I think it actually could be: > > > > pte_dirty = page_pte_is_dirty(page, pte_paddr); > > if (pte_dirty < 0) { > > ret = pte_dirty; > > goto out; > > } > > ret += pte_dirty; /* if (pte_dirty) ret++; */ > > > >You mean so as to return number of dirty pte's, rather than just +1? >This may be useful. > That wasn't my immediate problem, but rather than an 'if'. The main thing I'm worried about is you seem to be not handling the error case correctly. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: aart@kvack.org