From mboxrd@z Thu Jan  1 00:00:00 1970
Message-ID: <40225E0B.70200@cyberone.com.au>
Date: Fri, 06 Feb 2004 02:15:23 +1100
From: Nick Piggin <piggin@cyberone.com.au>
MIME-Version: 1.0
Subject: Re: [PATCH 0/5] mm improvements
References: <16416.64425.172529.550105@laputa.namesys.com>	<Pine.LNX.4.44.0402041459420.3574-100000@localhost.localdomain>	<16417.3444.377405.923166@laputa.namesys.com>	<4021A6BA.5000808@cyberone.com.au> <16418.19751.234876.491644@laputa.namesys.com> <40225D1F.8090103@cyberone.com.au>
In-Reply-To: <40225D1F.8090103@cyberone.com.au>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: owner-linux-mm@kvack.org
Return-Path: <owner-linux-mm@kvack.org>
To: Nick Piggin <piggin@cyberone.com.au>
Cc: Nikita Danilov <Nikita@Namesys.COM>, Hugh Dickins <hugh@veritas.com>, Andrew Morton <akpm@osdl.org>, linux-mm@kvack.org
List-ID: <linux-mm.kvack.org>


Nick Piggin wrote:

>
> +                pte_dirty = page_pte_is_dirty(page, pte_paddr);
> +                if (pte_dirty != 0)
> +                    ret = pte_dirty;
>
>
> Won't this leave ret in a random state? Should it be ret++?
>

... must be past my bedtime.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>