linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Nick Piggin <piggin@cyberone.com.au>
To: Nikita Danilov <Nikita@Namesys.COM>
Cc: Rik van Riel <riel@redhat.com>, Andrew Morton <akpm@osdl.org>,
	linux-mm@kvack.org
Subject: Re: [PATCH 3/5] mm improvements
Date: Thu, 05 Feb 2004 13:10:53 +1100	[thread overview]
Message-ID: <4021A62D.40002@cyberone.com.au> (raw)
In-Reply-To: <16417.8644.203682.640759@laputa.namesys.com>


Nikita Danilov wrote:

>Rik van Riel writes:
> > On Wed, 4 Feb 2004, Nick Piggin wrote:
> > > Nick Piggin wrote:
> > > 
> > > > 3/5: vm-lru-info.patch
> > > >     Keep more referenced info in the active list. Should also improve
> > > >     system time in some cases. Helps swapping loads significantly.
> > 
> > I suspect this is one of the more important ones in this
> > batch of patches...
>
>I don't understand how this works. This patch just parks mapped pages on
>the "ignored" segment of the active list, where they rest until
>reclaim_mapped mode is entered.
>
>This only makes a difference for the pages that were page_referenced():
>
>1. they are moved to the ignored segment rather than to the head of the
>active list.
>
>2. their referenced bit is not cleared
>
>

It treats all mapped pages in the same manner. Without this
patch, referenced mapped pages are distinctly disadvantaged
vs unreferenced mapped pages.

Even if reclaim_mapped is only flipped once every few
seconds it can make a big impact. On a 64MB heavily
swapping, you probably take 10 seconds to reclaim 64MB. It
is of critical importance that we keep as much hotness
information as possible.

It shows on the benchmarks too. It provides nearly as
much improvement as your patch alone for a make -j16.
ie. over 20%

http://www.kerneltrap.org/~npiggin/vm/2/


Also, when you're heavily swapping, everything slows down
to such an extent that "hot" pages are no longer touched
thousands of times per second, but maybe a few times every
few seconds. If you're continually clearing this information,
as soon as reclaim_mapped is triggered, all your hot pages
get evicted.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>

  parent reply	other threads:[~2004-02-05  2:10 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-04  9:39 [PATCH 0/5] " Nick Piggin
2004-02-04  9:40 ` [PATCH 1/5] " Nick Piggin
2004-02-04 19:45   ` Rik van Riel
2004-02-09  7:00     ` Nick Piggin
2004-02-09 21:56       ` Rik van Riel
2004-02-04  9:40 ` [PATCH 2/5] " Nick Piggin
2004-02-04 10:10   ` Andrew Morton
2004-02-04 10:15     ` Nick Piggin
2004-02-04 15:27     ` Rik van Riel
2004-02-05  2:18       ` Nick Piggin
2004-02-04  9:41 ` [PATCH 3/5] " Nick Piggin
2004-02-04 15:28   ` Rik van Riel
2004-02-04 16:45     ` Nikita Danilov
2004-02-04 18:53       ` Andrew Morton
2004-02-05  2:10       ` Nick Piggin [this message]
2004-02-04  9:42 ` [PATCH 4/5] " Nick Piggin
2004-02-04 10:11   ` Andrew Morton
2004-02-04 10:19     ` Nick Piggin
2004-02-04  9:42 ` [PATCH 5/5] " Nick Piggin
2004-02-04 10:03   ` Nick Piggin
2004-02-04 10:18   ` Andrew Morton
2004-02-04 10:22     ` Nick Piggin
2004-02-04 13:25 ` [PATCH 0/5] " Nikita Danilov
2004-02-04 13:53   ` Hugh Dickins
2004-02-04 14:03     ` Nikita Danilov
2004-02-04 15:03       ` Hugh Dickins
2004-02-04 15:19         ` Nikita Danilov
2004-02-05  2:13           ` Nick Piggin
2004-02-05 14:03             ` Nikita Danilov
2004-02-05 15:11               ` Nick Piggin
2004-02-05 15:15                 ` Nick Piggin
2004-02-05 15:20                   ` Nikita Danilov
2004-02-05 15:33                     ` Nick Piggin
2004-02-05 15:46                       ` Nikita Danilov
2004-02-05 15:56                         ` Nick Piggin
2004-02-05 16:03                           ` Nikita Danilov
2004-02-05 16:09                             ` Nick Piggin
2004-02-04 18:33     ` Andrew Morton
2004-02-04 20:54       ` Hugh Dickins
2004-02-04 21:04         ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4021A62D.40002@cyberone.com.au \
    --to=piggin@cyberone.com.au \
    --cc=Nikita@Namesys.COM \
    --cc=akpm@osdl.org \
    --cc=linux-mm@kvack.org \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox