VM patches (please review)

VM patches (please review)

[Nick Piggin]

(may need to reload)

Here are the patches to go with my earlier post.
kernel is 2.6.2-rc3-mm1.

I'm suire I've upset at least one uncommented^Wdivine
balance so if anyone has time to review and comment
it would be appreciated.

I can email the patches to the lists if anyone would
like?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>

Re: VM patches (please review)

[Bill Davidsen]

Nick Piggin wrote:
> http://www.kerneltrap.org/~npiggin/vm/
> (may need to reload)
> 
> Here are the patches to go with my earlier post.
> kernel is 2.6.2-rc3-mm1.
> 
> I'm suire I've upset at least one uncommented^Wdivine
> balance so if anyone has time to review and comment
> it would be appreciated.
> 
> I can email the patches to the lists if anyone would
> like?

Since this is broken down nicely, a line or two about what each patch 
does or doesn't address would be useful. In particular, having just 
gotten a working RSS I'm suspicious of the patch named vm-no-rss-limit 
being desirable ;-)

Nice work, but it would be nice to see what problem a patch addresses to 
check for blowback under some other load.


-- 
bill davidsen <davidsen@tmr.com>
   CTO TMR Associates, Inc
   Doing interesting things with small computers since 1979
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>

Re: VM patches (please review)

[Rik van Riel]

On Wed, 4 Feb 2004, Bill Davidsen wrote:

> Since this is broken down nicely, a line or two about what each patch 
> does or doesn't address would be useful. In particular, having just 
> gotten a working RSS I'm suspicious of the patch named vm-no-rss-limit 
> being desirable ;-)

The bug with the RSS limit patch is that I forgot to
change the exec() code, so when init is exec()d it
gets an RSS limit of zero, which is inherited by all
its children --> always over the RSS limit, no page
aging, etc.

I need to find the cleanest way to add the inheriting
of RSS limit at exec time and send a patchlet for that
to akpm...

-- 
"Debugging is twice as hard as writing the code in the first place.
Therefore, if you write the code as cleverly as possible, you are,
by definition, not smart enough to debug it." - Brian W. Kernighan

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>

Re: VM patches (please review)

[Bill Davidsen]

Rik van Riel wrote:
> On Wed, 4 Feb 2004, Bill Davidsen wrote:
> 
> 
>>Since this is broken down nicely, a line or two about what each patch 
>>does or doesn't address would be useful. In particular, having just 
>>gotten a working RSS I'm suspicious of the patch named vm-no-rss-limit 
>>being desirable ;-)
> 
> 
> The bug with the RSS limit patch is that I forgot to
> change the exec() code, so when init is exec()d it
> gets an RSS limit of zero, which is inherited by all
> its children --> always over the RSS limit, no page
> aging, etc.
> 
> I need to find the cleanest way to add the inheriting
> of RSS limit at exec time and send a patchlet for that
> to akpm...

Thank you! I had assumed that the info was being carried through exec, 
fork, and pthread_* and similar, and just not enforced.

I still think this will be great for those applications known to 
occasionally get a tough data set and not converge or recurse beyond all 
sense.

-- 
bill davidsen <davidsen@tmr.com>
   CTO TMR Associates, Inc
   Doing interesting things with small computers since 1979
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>