From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0571EC25B0E for ; Fri, 19 Aug 2022 07:54:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4DD2C8D0003; Fri, 19 Aug 2022 03:54:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 48C698D0002; Fri, 19 Aug 2022 03:54:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 37B1F8D0003; Fri, 19 Aug 2022 03:54:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2BDB88D0002 for ; Fri, 19 Aug 2022 03:54:46 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0468A8091C for ; Fri, 19 Aug 2022 07:54:45 +0000 (UTC) X-FDA: 79815580572.26.1CC3094 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf26.hostedemail.com (Postfix) with ESMTP id B6D15140013 for ; Fri, 19 Aug 2022 07:54:44 +0000 (UTC) Received: from fraeml712-chm.china.huawei.com (unknown [172.18.147.207]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4M8DTw5Pw8z68BVL; Fri, 19 Aug 2022 15:51:32 +0800 (CST) Received: from lhrpeml500003.china.huawei.com (7.191.162.67) by fraeml712-chm.china.huawei.com (10.206.15.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 19 Aug 2022 09:54:42 +0200 Received: from [10.195.34.98] (10.195.34.98) by lhrpeml500003.china.huawei.com (7.191.162.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 19 Aug 2022 08:54:42 +0100 Message-ID: <4014a51d-0925-c0dc-70dc-1a465dd278e7@huawei.com> Date: Fri, 19 Aug 2022 08:54:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [ata] 0568e61225: stress-ng.copy-file.ops_per_sec -15.0% regression To: Oliver Sang , Damien Le Moal CC: Christoph Hellwig , "Martin K. Petersen" , LKML , "Linux Memory Management List" , , , , , , , References: <2e9cf5a6-c043-5ccf-e363-097c6c941891@huawei.com> <43eaa104-5b09-072c-56aa-6289569b0015@opensource.wdc.com> <28d6e48b-f52f-9467-8260-262504a1a1ff@huawei.com> <743867a6-b266-58e4-a8a6-542757916f0a@huawei.com> From: John Garry In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.195.34.98] X-ClientProxiedBy: lhrpeml500006.china.huawei.com (7.191.161.198) To lhrpeml500003.china.huawei.com (7.191.162.67) X-CFilter-Loop: Reflected ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660895685; a=rsa-sha256; cv=none; b=vyBqR7zvusg54AuGeynaEHE/mb4FbdFsNPEyhQgQKIUlE/8dDGYEWexcaV6EEm/DKdu/D5 VHTjXE2w49MgWHw6cxHurMT4xNgo11Q+gvfjh8O5CR8+MYS+vIbrsKah1AVRFNhVv2aq6W qU6E3lAIKvE+xZm0wVDm/Ty1GQ9cd/c= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf26.hostedemail.com: domain of john.garry@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=john.garry@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660895685; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DQWJjgzFMzHfopVI5yyP/2I6+tF7HctBDaoL4DaJZdA=; b=yCbiBIXCgijvqYpNJVaf/1YbQc0nO5vkZFjt7xyeJRtaHMpXGcryCybQqPKzh98wWjS36V F3ITvpQcXNEP/kgXL1MKj+st1IgJmsqfYrtvJxFQiVQeWA3NSJ3OXqLs2QDyt46Ig8Ou8Y RpTF4Ax4gbWzeLaB4Q7rCkS7lTAikJY= X-Stat-Signature: 3wgkyyhfeh6nsqh6hu8xgq353j4go6ka X-Rspamd-Queue-Id: B6D15140013 X-Rspam-User: Authentication-Results: imf26.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf26.hostedemail.com: domain of john.garry@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=john.garry@huawei.com X-Rspamd-Server: rspam11 X-HE-Tag: 1660895684-875627 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 19/08/2022 07:24, Oliver Sang wrote: >> As you probably saw, I sent "[RFT PATCH] ata: libata: Set __ATA_BASE_SHT >> max_sectors" for testing on top of v6.0-rc1, and I hope that then we can get Based on result below, I wonder if SAS HBAs (which use libata) should not use default SCSI max_sectors also. Any libsas HBA driver does today, IIRC. >> same performance as v5.19 > yeah, our test confirmed your expectation: > > stress-ng.copy-file.ops_per_sec > v5.19 - 26.85 > v6.0-rc1 - 23.03 > v6.0-rc1 + your patch - 26.94 > great, thanks Thanks, John