From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33D4EC7EE30 for ; Tue, 24 Jun 2025 14:47:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BE23C6B00AE; Tue, 24 Jun 2025 10:47:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BBC586B00AF; Tue, 24 Jun 2025 10:47:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD0376B00B2; Tue, 24 Jun 2025 10:47:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8F42F6B00AE for ; Tue, 24 Jun 2025 10:47:21 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 30CC95C07C for ; Tue, 24 Jun 2025 14:47:21 +0000 (UTC) X-FDA: 83590572282.26.BE47F30 Received: from mail-oa1-f47.google.com (mail-oa1-f47.google.com [209.85.160.47]) by imf06.hostedemail.com (Postfix) with ESMTP id 43A10180007 for ; Tue, 24 Jun 2025 14:47:19 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b="HK/zzt/y"; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf06.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.160.47 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750776439; a=rsa-sha256; cv=none; b=6aj2bfUY7nymnuiUb1fDmExQg5fgM93ur1udsdcGGMjwDlyQBVXLTFP+Q205mrW8vWkYvw u0psXTXbdPj1oUOP5axxza5bRQyRfgskf+MkFZL6jPjlJ1TDLyBIGw8AihPcwwKq8uvGbZ qNKSSzE2VANeur+dQL4mvT84Rm57Dzc= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b="HK/zzt/y"; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf06.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.160.47 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750776439; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:dkim-signature; bh=6uA5wqktVLlF/6ye0p0dHnC0cgi9tO2Q4YJtZShQkDM=; b=qOgnZUa9FUZkdWwvLoW3N0Hb/o6MSMqJNhQPyuLGzsHJlMfPJjt3VZdbdYfe62/bBzUQve 2QgSh9YY+btLeRFRcyBDUeh+hV/qGaBmVjXymBO/PIBM+tt5EJXo/tERGL+8gox1Wt6vGy kMMXeFi7ZROgSZdkFAwGpoiR1DOe350= Received: by mail-oa1-f47.google.com with SMTP id 586e51a60fabf-2edec6c5511so143751fac.2 for ; Tue, 24 Jun 2025 07:47:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1750776438; x=1751381238; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=6uA5wqktVLlF/6ye0p0dHnC0cgi9tO2Q4YJtZShQkDM=; b=HK/zzt/ydWbhAg2Vt87FC2fgGho/hPTjnddM7HYz8z7mA5B0itXAXVJ8jIuvNrTrLF 7DZpOxFl0cs4n2uKzB8/bvYufYFWxnCeVS8asVqrMSbRsI6qnYMqB38Mh/OOCjX1Eh9X 1iAUkb8WwsDA+pcQsBfNGp7LS/sf8lhL29ccHl0qpyBesOcVp6jp3N/bgmAET20LqgNi zFAehfh5m6BW8gb5vVwtAsQYhJRd/3ySi5PLt61cfP1rLw1OO6Z8VxLqmT1Ch24CdXzE OO0kwedHxfCgl1PHhTj9jp7OIsLbG9MI9ATUIKdZeAjbdgfqNPAqSK3xaQkGY3nW9ZBT JV1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750776438; x=1751381238; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6uA5wqktVLlF/6ye0p0dHnC0cgi9tO2Q4YJtZShQkDM=; b=JZfWj0nZ7dVMX8lj6weCWmsSGz4w/a/OLEmx3AbCPtM4wDKoTlMBJ9sMqmx85KbcPV FNfXXyfu8ty754l20HSMjMi9+Fb6Y98O6K+baFgW7CsKCb5a3a4uUmgY6dGzPyhw2zy+ do2W8uQjkMmJdFwzJnscLNVmZWtRZESOT2Xv6u3YSX0uw2Dp6caYGCwY89E5asupdT/a NFiyZZjToPNtNOXaTc0/gCLK4d1fchOXPUzUc74ctsTqdLF+x7D+9gIg9rLES821lGRc sMVpwTbHKz36dF4SVYjK8xPato0TOn3Wlm7Ub6zESxnHX/2cAGRya+9S9RPzHC0LVWGm Q4cA== X-Forwarded-Encrypted: i=1; AJvYcCWuSmJaru7KvWgT+WK3Rc6IeFpIbd3PhwMSA6mx6UkfWc09Gq3KzQg2xJWSVfn2tFvAXctaGdozmQ==@kvack.org X-Gm-Message-State: AOJu0Yyaq3M4/yP3+RSgSoig0iuX+VFd5w2vJuSBR1GLgiDTkhRJzwmD Vg1z/5O+YvNe1heChMY86PD4O1KJ7voMGcHtfgM4y6SStWCzCTwNv1vx65pRdqq2PjU= X-Gm-Gg: ASbGnct5DxFhL8bBHhoQKfIj72z+YufRhlqr+SOYovOo+AhxYTxqpLXvpE3eZpFknI+ nIBZSfGqdnkI5QNaRGh+lbiPbIiZYpGtCcmAF24djKdCqB99OpeIUZ//iOviCjlIa++JZHMdUIn FBvBhDIclkUevAxtYP93y3j69/XBdG9MHAcfF8vRiuctWL1BEa1Ztl3rirgc8kxCyVt4u+8J5eD QEJxbr7rHhQyTkZC74lyUc1E5TuW9Z6EKm2XZA8Yz5QGKsGaKC4I8TpBWmrjwLRAsYwHdr32oBn VyM+Os/x7m9X5Zt1gtWkzcGz7Z9LjwRNRacO6qd4olozhCt2Rf3Gca3pHFdHLEFOTMm32Q== X-Google-Smtp-Source: AGHT+IGt8ie5ZbF0x4WPTsVM6n791kVfLV7Ad3NJEmRPz2hPk2XoNedp9cCuBS6gbjfhNJu6obKMeQ== X-Received: by 2002:a05:6870:2487:b0:2c2:b9cc:afb8 with SMTP id 586e51a60fabf-2eeda4e389cmr9736316fac.7.1750776438135; Tue, 24 Jun 2025 07:47:18 -0700 (PDT) Received: from localhost ([2603:8080:b800:f700:22c9:dcd3:f442:dd1d]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2ee6655a39asm2104434fac.15.2025.06.24.07.47.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Jun 2025 07:47:16 -0700 (PDT) Date: Tue, 24 Jun 2025 17:47:14 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Zhongkun He , akpm@linux-foundation.org, tytso@mit.edu, jack@suse.com, hannes@cmpxchg.org, mhocko@kernel.org Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, muchun.song@linux.dev, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, Zhongkun He , Muchun Song Subject: Re: [PATCH 1/2] mm: memcg: introduce PF_MEMALLOC_ACCOUNTFORCE to postpone reclaim to return-to-userland path Message-ID: <400e2b89-1ad7-4626-9ee0-e45a9e5b5227@suswa.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <71a4bbc284048ceb38eaac53dfa1031f92ac52b7.1750234270.git.hezhongkun.hzk@bytedance.com> X-Rspam-User: X-Stat-Signature: oa58srzh5gpwt53zqukx6znp6qa9i78i X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 43A10180007 X-HE-Tag: 1750776439-307868 X-HE-Meta: U2FsdGVkX1/ryJuv4C5uuJulwuEeIZ5rEBJHXok4AHkTxiHsWfN9Vfqd3Uc1j8jQmWGNGTECsSDrDS7C4ITQ4Qpy5RF02z3kT4MFogoF1rWyyfMeEjE754t4cdGVt9+T5cN4atGRUBBoJV37gVv11JUaw727zDcH9oax7ztP0c8HBtPUekXWB5qztUUMecLs+q4RHQsrAHRPPbp3fkjS3sZhK2U4C+4uRwyn1eh01lJYZcPhwxqV9EvGcmVgay0+vFKFfC40jCFtKa2kAiKwTA+GXpYJQkoTXuHdvrtQSOZ9B+ehf+njuc4gvFpy/OGzLNXEA1tJb9DeP9u8/Ctoarjqkpxb3D6p2Nc0vAqyYacdW+wy4BoPynoVIURIUDuQHQEPQKMz8+ovpR8T1JqN+3rZpiwdqeEgHC0Bjf4L/WzxE3n/Tk80AJw/gMEMWtqw1qxOwjxhRZUPOSEYyeWlE9JKfBI8V00eThPPYYnc0M0dlNmNlninEBSIzL8AewJ7N7S78+Qwg9YDVEJCCMwcyexzP3atXzWekSnpkjrblNko8vyk8EVdmFpTiUI27vp1oikgReOqqe4lvdEDSooglE6/qVRn88Ur8gxH3DA5zrtUpE8rOMFjO7/3VkQkhfXYsM8K4mPi34pJlQ4ibNK8NdkwVwmsVLauKWR1d4Rxl1XNq1K3oRWYcVzJpfVFGMM7yLRqpXxnUpkjILUWrgczOfDH3sytEYO4eJlHrJrj7+BuumQD9CS38le6QJlI2swVBGwnXtVw9Mk/M9+i6WbtK2qVYgRO6xxLa10oyGFcjT4p4hXKqyXJQWS1L+Om2ww+RHONsgZNwYFSPFGOX2hwjYgvCREKG+OKfFVX6/4IZYwxnqZPcGHdcju7lElBFCo+IQWTczOZ8+pxySHJ3+fQAj1c0hfimsmvIbQRtXZKNEzBaolg+dQdHdGo2aw3V9kQDLrPE6DCGce85wxPpmN cxachh94 uP2vra+oP/4OmWQsqCKQ1fQYMzFuMBg+Tg8Rql6fxYhEpaObqGgmqSc8CQfFIQXBO9cc3tAiW7aTWM2jBMD67o/GkVhvg8BkkHiUlfIpAR/Qoe3GHUbC/IO8m/kMu++u0MG9W+4hB04jWYx5HgPBBZD30o1Q2xnyjqELUfOGLpeWye9FEAKxXRVL3FP6Ht/lz3o5rNbei3B4cy+An28WOFviINW57nLuffKBgj+IxPtodlwH6BUyHaTWWWyBenSco3pw8YDAENSRQ1maQcPkniIrsY2+OMf8BrOYTZNyaAgDTNhnd+q3vSngKzIJYcOUwRwh5ieZIzBUTYncID+vJPMy3In6OT8lVu8L864S/SM8fOWjTQXzPyrpaE2XqksDAUo1gyvoR/i5lxAoZReDhG0jRb3tW3legX1iGxnJ6cOI4O8Vcf66ZTHEvS5qmSKBuIvRcD7b8bb9hl3mqvOs0G2OhXHiiWNdSQii9ynbK00Sl/TdX3EEN8zlvVM2sx5NegA9IpHbjTFVm5f9IEUR668ipfwXJsMDby4TWhVppw1/d08ainpeag8JaJ7nPW7DsNz7b9XBuiEIZyyP22drjvO5NjWDosVeRjqpyXwRXunk7KOyWCWqZs+N2ixxv8Hwl+tEWG06I6fYfFWAuicFsGxG6wg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Zhongkun, kernel test robot noticed the following build warnings: https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Zhongkun-He/mm-memcg-introduce-PF_MEMALLOC_ACCOUNTFORCE-to-postpone-reclaim-to-return-to-userland-path/20250618-194101 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/71a4bbc284048ceb38eaac53dfa1031f92ac52b7.1750234270.git.hezhongkun.hzk%40bytedance.com patch subject: [PATCH 1/2] mm: memcg: introduce PF_MEMALLOC_ACCOUNTFORCE to postpone reclaim to return-to-userland path config: i386-randconfig-141-20250619 (https://download.01.org/0day-ci/archive/20250624/202506242032.uShv7ASV-lkp@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202506242032.uShv7ASV-lkp@intel.com/ smatch warnings: mm/memcontrol.c:2341 mem_cgroup_handle_over_max() warn: use 'gfp_mask' here instead of GFP_KERNEL? vim +/gfp_mask +2341 mm/memcontrol.c b5db553cc19549 Zhongkun He 2025-06-18 2320 void mem_cgroup_handle_over_max(gfp_t gfp_mask) ^^^^^^^^ b5db553cc19549 Zhongkun He 2025-06-18 2321 { b5db553cc19549 Zhongkun He 2025-06-18 2322 unsigned long nr_reclaimed = 0; b5db553cc19549 Zhongkun He 2025-06-18 2323 unsigned int nr_pages = current->memcg_nr_pages_over_max; b5db553cc19549 Zhongkun He 2025-06-18 2324 int nr_retries = MAX_RECLAIM_RETRIES; b5db553cc19549 Zhongkun He 2025-06-18 2325 struct mem_cgroup *memcg, *mem_over_limit; b5db553cc19549 Zhongkun He 2025-06-18 2326 b5db553cc19549 Zhongkun He 2025-06-18 2327 if (likely(!nr_pages)) b5db553cc19549 Zhongkun He 2025-06-18 2328 return; b5db553cc19549 Zhongkun He 2025-06-18 2329 b5db553cc19549 Zhongkun He 2025-06-18 2330 memcg = get_mem_cgroup_from_mm(current->mm); b5db553cc19549 Zhongkun He 2025-06-18 2331 current->memcg_nr_pages_over_max = 0; b5db553cc19549 Zhongkun He 2025-06-18 2332 b5db553cc19549 Zhongkun He 2025-06-18 2333 retry: b5db553cc19549 Zhongkun He 2025-06-18 2334 mem_over_limit = get_over_limit_memcg(memcg); b5db553cc19549 Zhongkun He 2025-06-18 2335 if (!mem_over_limit) b5db553cc19549 Zhongkun He 2025-06-18 2336 goto out; b5db553cc19549 Zhongkun He 2025-06-18 2337 b5db553cc19549 Zhongkun He 2025-06-18 2338 while (nr_reclaimed < nr_pages) { b5db553cc19549 Zhongkun He 2025-06-18 2339 unsigned long reclaimed; b5db553cc19549 Zhongkun He 2025-06-18 2340 b5db553cc19549 Zhongkun He 2025-06-18 @2341 reclaimed = try_to_free_mem_cgroup_pages(mem_over_limit, b5db553cc19549 Zhongkun He 2025-06-18 2342 nr_pages, GFP_KERNEL, I guess GFP_KERNEL is fine. The gfp_mask is used below. Don't worry about this one if the GFP_KERNEL is intended. Just ignore the warning message. b5db553cc19549 Zhongkun He 2025-06-18 2343 MEMCG_RECLAIM_MAY_SWAP, b5db553cc19549 Zhongkun He 2025-06-18 2344 NULL); b5db553cc19549 Zhongkun He 2025-06-18 2345 b5db553cc19549 Zhongkun He 2025-06-18 2346 if (!reclaimed && !nr_retries--) b5db553cc19549 Zhongkun He 2025-06-18 2347 break; b5db553cc19549 Zhongkun He 2025-06-18 2348 b5db553cc19549 Zhongkun He 2025-06-18 2349 nr_reclaimed += reclaimed; b5db553cc19549 Zhongkun He 2025-06-18 2350 } b5db553cc19549 Zhongkun He 2025-06-18 2351 b5db553cc19549 Zhongkun He 2025-06-18 2352 if ((nr_reclaimed < nr_pages) && b5db553cc19549 Zhongkun He 2025-06-18 2353 (page_counter_read(&mem_over_limit->memory) > b5db553cc19549 Zhongkun He 2025-06-18 2354 READ_ONCE(mem_over_limit->memory.max)) && b5db553cc19549 Zhongkun He 2025-06-18 2355 mem_cgroup_oom(mem_over_limit, gfp_mask, b5db553cc19549 Zhongkun He 2025-06-18 2356 get_order((nr_pages - nr_reclaimed) * PAGE_SIZE))) { b5db553cc19549 Zhongkun He 2025-06-18 2357 nr_retries = MAX_RECLAIM_RETRIES; b5db553cc19549 Zhongkun He 2025-06-18 2358 goto retry; b5db553cc19549 Zhongkun He 2025-06-18 2359 } b5db553cc19549 Zhongkun He 2025-06-18 2360 b5db553cc19549 Zhongkun He 2025-06-18 2361 out: b5db553cc19549 Zhongkun He 2025-06-18 2362 css_put(&memcg->css); b5db553cc19549 Zhongkun He 2025-06-18 2363 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki