From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6C75C77B61 for ; Fri, 28 Apr 2023 15:23:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4EEF46B0072; Fri, 28 Apr 2023 11:23:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 49F2B6B007B; Fri, 28 Apr 2023 11:23:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3677C6B007D; Fri, 28 Apr 2023 11:23:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 282F56B0072 for ; Fri, 28 Apr 2023 11:23:40 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E77E71201EA for ; Fri, 28 Apr 2023 15:23:39 +0000 (UTC) X-FDA: 80731169358.28.588F8D8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf18.hostedemail.com (Postfix) with ESMTP id BDB431C0003 for ; Fri, 28 Apr 2023 15:23:37 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hhKdEHOd; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682695417; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xNqQu/Hbgh8GgG/TaR2UQBBPYePy9tTL0DFgLY8LdrU=; b=6M7ygUk8JmnXq5S15HemwoK/iA2J8Uh4YfEotr2Ol/1vMRylDExp1lXLiHA6mtZyfw2PbJ tb0kKALYF8rfXhXJ0ye23gsDOk0RGBhyurIEaoIKP00MjVJKaZyfEkc0AC8Wv22FN0fOCU /zgPQJxz9h3K8gmO3js0OndIBcX38O0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682695417; a=rsa-sha256; cv=none; b=ShST7ppBY18/1J+nCuTI9y7Nz1jGXQsyDbIsqG1a7MKJM5eBV3irC3X+nVi43yK4DNS2+T 3RH8Kp54fPY+RHz5NrkG5uiUNV2JC1xHreaCiqt/jAtEY2AudQ0YUoVVrGcjsxx8vfO+uc ucRf4iR7rQY0UMx2ILDvZtfaFgp+cig= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hhKdEHOd; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682695417; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xNqQu/Hbgh8GgG/TaR2UQBBPYePy9tTL0DFgLY8LdrU=; b=hhKdEHOdqCpYNi/0vYEq4cRWcfOnpWz6KVI2/r9RHdfso3eVM+XnsuJWXqZNH1ZQ6LYv01 byuLtP7IA6HwHIjN+0o0GI9dOjJlHY2p1M0YfSPZfU0kgvaKn44ox1R/qwpCrN3cLcRnnP AOkvIc8zm9RxkoXdokrx7o0xIYVOoYI= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-460-CO5d95dsPoGpa-ztFXOvAw-1; Fri, 28 Apr 2023 11:23:33 -0400 X-MC-Unique: CO5d95dsPoGpa-ztFXOvAw-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-3f168827701so38791795e9.0 for ; Fri, 28 Apr 2023 08:23:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682695413; x=1685287413; h=content-transfer-encoding:in-reply-to:subject:organization :references:cc:to:from:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xNqQu/Hbgh8GgG/TaR2UQBBPYePy9tTL0DFgLY8LdrU=; b=DLP6/FKHGugKb16fdyZEmjJQ7k3CaF2Y5KC2doZshK/SoA5NF56JZWL2fN55MYGX+m SiTP7OFnsYa6z3HDF9mTocCdnZ/oMX0RV/hunqi+veLHGyhO8jzWYMlq5JAbjC4npuu4 WlMiJBYArUbjgrBGx7ju8cmbUr++tpzm/c+MLmIccq2KDbjNVVa6pbnBCH4ciFwcnqFz NrYubg1F/zYfLWYHujIPltXwYITd2ScN2usS4/zgsebbbw9CkPbtPzXvacWardbgssBy h+OUN+8LiWBUoSB6hdb0hJj0JnAjaMh6QvajBvwoFyk2Iu0L/MrsEEsaOqGHG/w85LCd +HPA== X-Gm-Message-State: AC+VfDxp67pp9//ipPSF5AZd1+mM8LCcjmHx6O53YfJB0a6jHLrpwtgz ZCNy3ulmR5PiyORkL1PQ0K3UfC6m/zQw6mIH5Isn27goFh+MwwQyAQnyIFuArMwzDAdbWashwE7 GQ1uV75CMUCM= X-Received: by 2002:a05:6000:1148:b0:304:7159:d3e4 with SMTP id d8-20020a056000114800b003047159d3e4mr4054760wrx.44.1682695412807; Fri, 28 Apr 2023 08:23:32 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7m7lYREqwJwCW0J3nLemNcIH2KdfBgyx6gX0Qrhp/YfT+ZQtoJy3PoVU25XYCmL9JQIphxhg== X-Received: by 2002:a05:6000:1148:b0:304:7159:d3e4 with SMTP id d8-20020a056000114800b003047159d3e4mr4054718wrx.44.1682695412463; Fri, 28 Apr 2023 08:23:32 -0700 (PDT) Received: from ?IPV6:2003:cb:c726:9300:1711:356:6550:7502? (p200300cbc72693001711035665507502.dip0.t-ipconnect.de. [2003:cb:c726:9300:1711:356:6550:7502]) by smtp.gmail.com with ESMTPSA id a18-20020a056000101200b002e61e002943sm21368158wrx.116.2023.04.28.08.23.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Apr 2023 08:23:31 -0700 (PDT) Message-ID: <400da248-a14e-46a4-420a-a3e075291085@redhat.com> Date: Fri, 28 Apr 2023 17:23:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 From: David Hildenbrand To: Jason Gunthorpe Cc: Lorenzo Stoakes , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Jens Axboe , Matthew Wilcox , Dennis Dalessandro , Leon Romanovsky , Christian Benvenuti , Nelson Escobar , Bernard Metzler , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Bjorn Topel , Magnus Karlsson , Maciej Fijalkowski , Jonathan Lemon , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Christian Brauner , Richard Cochran , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , linux-fsdevel@vger.kernel.org, linux-perf-users@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, Oleg Nesterov , John Hubbard , Jan Kara , "Kirill A . Shutemov" , Pavel Begunkov , Mika Penttila , David Howells , Christoph Hellwig References: <6b73e692c2929dc4613af711bdf92e2ec1956a66.1682638385.git.lstoakes@gmail.com> <094d2074-5b69-5d61-07f7-9f962014fa68@redhat.com> Organization: Red Hat Subject: Re: [PATCH v5] mm/gup: disallow GUP writing to file-backed mappings by default In-Reply-To: <094d2074-5b69-5d61-07f7-9f962014fa68@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: BDB431C0003 X-Rspamd-Server: rspam09 X-Stat-Signature: mg3yh1zwpf7xw47fy8j6jmishiyr73ju X-HE-Tag: 1682695417-601139 X-HE-Meta: U2FsdGVkX19aKnevWiR9aiYu4cj2apKgZh7m0trGwf5qmXW5yVY9j8Ydf2NNdnwhF7l3kjFgCvQd69uZkGKEBktlO4OGpORLnjy/Ya/YoxdYNl8Q/hkQ8AR8XdVVBKB3H4SoMC2ogpmTVpr3floF3+etgOascN1vrdOnUO0o9ChxlBSv83EUDM+B1o011ss7cVo0nz7Ro+Cd0aSe+ZrAfflJWnR933Gu1BYpp4RprZ7No7WNt9o0silZoY5rWko6HHG2F/4vK0xFzcB+ZGK+YHBnfG95wF5bGUKiZ52dpZenGWqaJuODMjvTsDxPebpU9uW99PrVp3K5Og7VgRj8DiMfEFI2GeUh1pxLARQWu9zHFp566NObE3JA7Ncoxu1L02B1INK07Ubg0ESO5GrGAIt4kkYib6lQWyYbkTY7f+AdTY2sxKm2xwwpHvbY6YgWXoX05usxo31u+9nmP32TB47QUJXgpwze6Wl8I9GWqtM8CvG8T5xqskBIXpaIJf/RcWlANRde0CISucKSPYPsa8U4vNl8sPFDvtjpKljlqQgxxvoDieC2NwyQ4N9DPMxdoNce4wcImU/0ZLl5IlGItkq3z5Uudhkurtbg3Fvmj6/QBqeH4ZWRRcu9xo5aMLev2ULdiZNKcVWLAZ6qlZmnrvLcJuzbM3tc2gfVDtCPxfzvhASMLvOsUZG7rlPOKeHzpAlzCDpjYVrFK8gP+yY0ExWyXGPYAAunHV4yNG0EaL5cpMD7Yzs4nihhEbvMGwojOUnEI3GX/trkWLNaW2RHjBTPWGFmOqOU2/HLvyBBtF/KvF/n/LgY94XtDKkp7oho/lQgLX//nmzH0dEKbPIu9qnCr+ipYkTopNVUdyjoWawGFvkmGw4VE5eUPS5oE7tOi64GoqXSNcrtY+hBY4mLjtxocyXXhUPyIL2JRJlYvBXhkRpiMaAhPimbMt4d2Fe5n7QW6vzVvOeddfpBGZH 2/VfEHWF NymWKBsTKjG8RiK3H/V93kJoeoeEt0Kk6NwSVqeuI2cnZFjx+L1kcoYkaivnU6ZJc0tQOIbpzcMZCY0+CmgYFsjfA1KrUw/EkAyNSjsfbQW6gXPUxOz4yPaSMzLflI04t+gM1u7C7YkD1rk9gfj8Gqlvwsjr6mGr6htaziQggNu4iTxdDlCgrSKxY+Mpcz5pNc6RCkAFo9iQgbuDVRJpySvdnA+XEqEAq9DiGNs1qN5wKOgd1BBToBUPHDEdudIz40hn5+SHDgK2kJ8Kd2O7ofh3rnnzzNCf2oKczQDK5hEeV6wYis9mpWzlZmJ776ieb6kEV+naXkdLb+hHH7PHdxBNNNtg4/PKC41siDnojymiD4sWPO58m3w3sBnb14ry17x+j2bug3ClcF93qVIn7LNBDSEPs0MFEwm6wuySSJsq6+wPZUYsR7Uhdu2xrJCqjVWDPB5mIr4k4fH8NqUQd8usz3vAvVPUNLdT8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: >> >> Security is the primary case where we have historically closed uAPI >> items. > > As this patch > > 1) Does not tackle GUP-fast > 2) Does not take care of !FOLL_LONGTERM > > I am not convinced by the security argument in regard to this patch. > > > If we want to sells this as a security thing, we have to block it > *completely* and then CC stable. Regarding GUP-fast, to fix the issue there as well, I guess we could do something similar as I did in gup_must_unshare(): If we're in GUP-fast (no VMA), and want to pin a !anon page writable, fallback to ordinary GUP. IOW, if we don't know, better be safe. Of course, this would prevent hugetlb/shmem from getting pinned writable during gup-fast. Unless we're able to whitelist them somehow in there. For FOLL_LONGTERM it might fairly uncontroversial. For everything else I'm not sure if there could be undesired side-effects. -- Thanks, David / dhildenb