From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19B6CC388F9 for ; Fri, 6 Nov 2020 22:18:46 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7DE44221F8 for ; Fri, 6 Nov 2020 22:18:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7DE44221F8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 80ECF6B0068; Fri, 6 Nov 2020 17:18:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 798006B006E; Fri, 6 Nov 2020 17:18:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6609D6B0070; Fri, 6 Nov 2020 17:18:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0003.hostedemail.com [216.40.44.3]) by kanga.kvack.org (Postfix) with ESMTP id 343296B0068 for ; Fri, 6 Nov 2020 17:18:44 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id CF622181AEF07 for ; Fri, 6 Nov 2020 22:18:43 +0000 (UTC) X-FDA: 77455408926.16.steel81_3e0a5bb272d6 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin16.hostedemail.com (Postfix) with ESMTP id AF036100E690B for ; Fri, 6 Nov 2020 22:18:43 +0000 (UTC) X-HE-Tag: steel81_3e0a5bb272d6 X-Filterd-Recvd-Size: 2736 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by imf09.hostedemail.com (Postfix) with ESMTP for ; Fri, 6 Nov 2020 22:18:42 +0000 (UTC) IronPort-SDR: ETZazMY3k8ZY0LN5+JjU/yIF6m2y2W2N3SFBZTqiK9WlNB5Zid5jqG0LknjPkpjBzJJt7UKI+y I52cptRDS6Lw== X-IronPort-AV: E=McAfee;i="6000,8403,9797"; a="233774162" X-IronPort-AV: E=Sophos;i="5.77,457,1596524400"; d="scan'208";a="233774162" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Nov 2020 14:18:41 -0800 IronPort-SDR: 2Zx0iM0UujJBR4LqxqwdesHkiuBAEMc6DJ/dodXIRKOPJxvfKp9ugB7rb2bqF8Xylesggd6HMP ubKCJ935Kqjg== X-IronPort-AV: E=Sophos;i="5.77,457,1596524400"; d="scan'208";a="326555163" Received: from schen9-mobl.amr.corp.intel.com ([10.251.2.174]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Nov 2020 14:18:40 -0800 Subject: Re: [PATCH 1/2] pagevec: Allow pagevecs to be different sizes To: Matthew Wilcox Cc: linux-mm@kvack.org, Jan Kara References: <20201105172651.2455-1-willy@infradead.org> <20201105172651.2455-2-willy@infradead.org> <1c857e99-5985-5bc2-ca29-c77d612460fa@linux.intel.com> <20201106191210.GR17076@casper.infradead.org> From: Tim Chen Message-ID: <400d19a9-1113-5903-053e-85100104d229@linux.intel.com> Date: Fri, 6 Nov 2020 14:18:40 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20201106191210.GR17076@casper.infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/6/20 11:12 AM, Matthew Wilcox wrote: > > I have a number of changes already in that area that are currently in-flight. > > https://lore.kernel.org/linux-mm/20201026041408.25230-1-willy@infradead.org/ > > (although I should modify patch 9/12 to not use PAGEVEC_SIZE directly) Okay. I assume that you are using pagevec_size somewhere to replace those hardcoded PAGEVEC_SIZE somewhere. > > I have some patches that I haven't bothered sending yet since I have so > many other outstanding patches to do something similar to find_get_pages() > / find_get_pages_range() / pagevec_lookup() / pagevec_lookup_range(). > > > The trace you sent showed the problem being with the lru_add pagevec, > and that's never used with the pagevec_lookup_* APIs (afaik), so I didn't > see it as urgent to fix those. > Okay. Thanks for allowing the bigger pagevec size tweak in your patches. Tim