Re: [PATCH 1/2] pagevec: Allow pagevecs to be different sizes

[Tim Chen <tim.c.chen@linux.intel.com>]

On 11/6/20 11:12 AM, Matthew Wilcox wrote:
 
> 
> I have a number of changes already in that area that are currently in-flight.
> 
> https://lore.kernel.org/linux-mm/20201026041408.25230-1-willy@infradead.org/
> 
> (although I should modify patch 9/12 to not use PAGEVEC_SIZE directly)

Okay. I assume that you are using pagevec_size somewhere to replace those
hardcoded PAGEVEC_SIZE somewhere.

> 
> I have some patches that I haven't bothered sending yet since I have so
> many other outstanding patches to do something similar to find_get_pages()
> / find_get_pages_range() / pagevec_lookup() / pagevec_lookup_range().
> 
> 
> The trace you sent showed the problem being with the lru_add pagevec,
> and that's never used with the pagevec_lookup_* APIs (afaik), so I didn't
> see it as urgent to fix those.
> 

Okay.

Thanks for allowing the bigger pagevec size tweak in your patches.

Tim