From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C8A1C61D97 for ; Wed, 22 Nov 2023 12:46:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F26C6B054B; Wed, 22 Nov 2023 07:46:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A1FC6B054D; Wed, 22 Nov 2023 07:46:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 742AA6B0551; Wed, 22 Nov 2023 07:46:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 63BC56B054B for ; Wed, 22 Nov 2023 07:46:53 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 3A145A0AE4 for ; Wed, 22 Nov 2023 12:46:53 +0000 (UTC) X-FDA: 81485564706.08.4112C68 Received: from mta22.hihonor.com (mta22.hihonor.com [81.70.192.198]) by imf20.hostedemail.com (Postfix) with ESMTP id 17DF51C001D for ; Wed, 22 Nov 2023 12:46:49 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=hihonor.com; spf=pass (imf20.hostedemail.com: domain of "prvs=06838c7359=gaoxu2@hihonor.com" designates 81.70.192.198 as permitted sender) smtp.mailfrom="prvs=06838c7359=gaoxu2@hihonor.com" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700657211; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references; bh=QzVkvtmFlQzq4+coN9LQ2LiCSDBo4lRm2R77wY73wSA=; b=UuG6uAebLkl/8n5+WMId5DPzgSPXd83xvTDJ8oxnRn8IZe3WfbDGuN9d0K9NpaT44IhVX8 oD5TBqNx0EMUswkUIVnqdhaGGMBby431Wo9kCdnFUTMZS79WvitYYMklGZ+UrvyalZvCni dqUmoppHTMkyVUEAQ66osc7QkFELCJU= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=hihonor.com; spf=pass (imf20.hostedemail.com: domain of "prvs=06838c7359=gaoxu2@hihonor.com" designates 81.70.192.198 as permitted sender) smtp.mailfrom="prvs=06838c7359=gaoxu2@hihonor.com" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700657211; a=rsa-sha256; cv=none; b=LQ2Y3D4UStX/TaTyLhn7yegSNf4jyLUxvONfZ71O9bUeoTUkZfL2iobKIxP8xPoPesG710 b4uSts7nd7zTfAuSxto60bKG1frfCPMm6uGvts7mVirNEYdV6Zj3jf0X6kGWpobO+WtQcE YUqamV/ikNCFJLWe7IuXjHR4sXtvwa4= Received: from w002.hihonor.com (unknown [10.68.28.120]) by mta22.hihonor.com (SkyGuard) with ESMTPS id 4Sb1FT2BH0zYlfl6; Wed, 22 Nov 2023 20:46:05 +0800 (CST) Received: from a004.hihonor.com (10.68.27.131) by w002.hihonor.com (10.68.28.120) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.25; Wed, 22 Nov 2023 20:46:45 +0800 Received: from a007.hihonor.com (10.68.22.31) by a004.hihonor.com (10.68.27.131) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.25; Wed, 22 Nov 2023 20:46:44 +0800 Received: from a007.hihonor.com ([fe80::ccdd:b4b:ae86:edd4]) by a007.hihonor.com ([fe80::ccdd:b4b:ae86:edd4%10]) with mapi id 15.02.1258.025; Wed, 22 Nov 2023 20:46:44 +0800 From: gaoxu To: Andrew Morton CC: "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Suren Baghdasaryan , yipengxiang Subject: [PATCH] mm,oom_reaper: avoid run queue_oom_reaper if task is not oom Thread-Topic: [PATCH] mm,oom_reaper: avoid run queue_oom_reaper if task is not oom Thread-Index: AdodQUgb0N3ZJU2TSUK/4IicgpocdQ== Date: Wed, 22 Nov 2023 12:46:44 +0000 Message-ID: <400d13bddb524ef6af37cb2220808c75@hihonor.com> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.164.11.140] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 17DF51C001D X-Stat-Signature: emfomnj7s8cp5cwnj7awfkwdnnn7kknt X-Rspam-User: X-HE-Tag: 1700657209-785431 X-HE-Meta: U2FsdGVkX1/5kh9Z5JbbI2/S4dUoLjcfNP9zAGoiyIul8J5DLWzeCBAH3xaIjwr9ZwetHDUoOEygE0/sbSQYIq46RrMSBgLPmJ4hC4ONb6O592TL8yqpOuSP8GTB0Th2CuiC2MWnSU+fhKs5f69zl6LJBJhFi8UNPXjLm92X4WAS4BG1x8vr51DP42R1MK5V9uYDyZkn8pF2QsxDDZWUWGOlu3Vs6tncIrX+9pY5zMN1c1HG8q5Q7cAGkPBrNLWzfMVI1aXchrDeBFaDv6DqE9kSz6UGajYINv67XOB/OfOUZpKhG7BAf0dFebaWAvos7WaKXF+BzCLKnu1TgDT3WCOuBvMi4EqqDHp7+14mXTEAM08z5ST4YXTGXRUVz0yiI5owWXrOErVF0qPjR9yZtGZYe0seKD2YiHMGsQsfEDmOK+qB/7tYGSLi0d7JXxm53VrnZuzXNdjWL3m96IKXxg8YNLZ58KSyl7RBStwKmnlOW4cCz1WiTLQrU88V8YzwxkBRcN2iGPxWn1VnfayQvQk42U7wDTsnOaGxRoQGjfbK/84ZmotGJTihHeefnv3DtuQDhB+vJ3hg8vYuGZzTDaQ0yHhY+CYLwnQaSozgTJ6KrTPYab9GH4isnTJEoKymRJpsl6F3U8LinRHwRzdaS/RcuO9HSZjs1WGhXF0BsU1U0W/dJxKCVa7O63DaCJYPICo+i9NaO60L4gWSOZ4kfI23tT+5wk6Kz+WfKsm117/q6MNaaVs2pAykgUq/ydNaqQ56iGbM59CeZqwQoTeF8On+TjQUpVp3VighDbixmG2rkYcYBi8FLDGN1oVJabaNKVkq7j+Z3CmXBGF/FSADkYcaIwSbIIiRbXZwjIFNtl1Ip+iJ7sOEnKQRVV/K2I/DTt0lL61OZ8scQh/EWxrNbkPld9SCe9QMpW0+q+x3g+OSz5wRqVNv/69UPWioddRSNtIToDSPKJlIgapX6Un ftx/Oi3p 1se2IkiLiWoV0k46EdOOrwI6GzgyWfbOJIp2gDm9xWpWRL5Q0dn4YzAIEdQ+vPg0A5VtHz3hlf6LothJmMHWdXnz7OaHNX1m0YKbBcRLKPIXPvee6UQCMF466EKXb8x5nxH9hdL4lwuocqm8YsJC7wDb3PzdCU9nnpNW0NuN7Zf4RpBwksuTYw6fd8qI8sBIEjV0z658Ak+s1BSs2k73acnvt4zANmct5JKxE++o2GifL3kyryXj5xiQe1zyE9J6mAa0wxVlyhOUvMvmfEwIvCWSJjWVAFpHCN9SzC/r4LnMoTyAtjtIZC/bzrQfk3oVkN13/EI1lJo02P/MXVUUHSZWEdd/Wkb6S9bQZVT6Jd0QWMkJj/qeHREhO1m73V14cgOea86/a7u5vQ4CIizSId1VIRA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.002291, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The function queue_oom_reaper tests and sets tsk->signal->oom_mm->flags. However, it is necessary to check if 'tsk' is an OOM victim before executing 'queue_oom_reaper' because the variable may be NULL. We encountered such an issue, and the log is as follows: [3701:11_see]Out of memory: Killed process 3154 (system_server) total-vm:23662044kB, anon-rss:0kB, file-rss:0kB, shmem-rss:0kB, UID:1000 pgtables:4056kB oom_score_adj:-900 [3701:11_see][RB/E]rb_sreason_str_set: sreason_str set null_pointer [3701:11_see][RB/E]rb_sreason_str_set: sreason_str set unknown_addr [3701:11_see]Unable to handle kernel NULL pointer dereference at virtual address 0000000000000328 [3701:11_see]user pgtable: 4k pages, 39-bit VAs, pgdp=3D00000000821de000 [3701:11_see][0000000000000328] pgd=3D0000000000000000, p4d=3D0000000000000000,pud=3D0000000000000000 [3701:11_see]tracing off [3701:11_see]Internal error: Oops: 96000005 [#1] PREEMPT SMP [3701:11_see]Call trace: [3701:11_see] queue_oom_reaper+0x30/0x170 [3701:11_see] __oom_kill_process+0x590/0x860 [3701:11_see] oom_kill_process+0x140/0x274 [3701:11_see] out_of_memory+0x2f4/0x54c [3701:11_see] __alloc_pages_slowpath+0x5d8/0xaac [3701:11_see] __alloc_pages+0x774/0x800 [3701:11_see] wp_page_copy+0xc4/0x116c [3701:11_see] do_wp_page+0x4bc/0x6fc [3701:11_see] handle_pte_fault+0x98/0x2a8 [3701:11_see] __handle_mm_fault+0x368/0x700 [3701:11_see] do_handle_mm_fault+0x160/0x2cc [3701:11_see] do_page_fault+0x3e0/0x818 [3701:11_see] do_mem_abort+0x68/0x17c [3701:11_see] el0_da+0x3c/0xa0 [3701:11_see] el0t_64_sync_handler+0xc4/0xec [3701:11_see] el0t_64_sync+0x1b4/0x1b8 [3701:11_see]tracing off Signed-off-by: Gao Xu --- mm/oom_kill.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/oom_kill.c b/mm/oom_kill.c index 9e6071fde..3754ab4b6 100644 --- a/mm/oom_kill.c +++ b/mm/oom_kill.c @@ -984,7 +984,7 @@ static void __oom_kill_process(struct task_struct *vict= im, const char *message) } rcu_read_unlock(); =20 - if (can_oom_reap) + if (can_oom_reap && tsk_is_oom_victim(victim)) queue_oom_reaper(victim); =20 mmdrop(mm); --=20 2.17.1