From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFCF6C636D3 for ; Mon, 6 Feb 2023 16:36:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 377486B0072; Mon, 6 Feb 2023 11:36:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 326FE6B0073; Mon, 6 Feb 2023 11:36:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1EF3A6B0074; Mon, 6 Feb 2023 11:36:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0BD9C6B0072 for ; Mon, 6 Feb 2023 11:36:10 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A89F880985 for ; Mon, 6 Feb 2023 16:36:09 +0000 (UTC) X-FDA: 80437419258.29.1D91F4E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf30.hostedemail.com (Postfix) with ESMTP id 51E5D8000A for ; Mon, 6 Feb 2023 16:36:07 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HS19IjyC; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675701367; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eeZtsKyA0Y6gRhG9+TJW3Hh5qiBXm4UNVthJbfS8u7U=; b=ZhtGCymkOtpV99bk1Mm7euI5ieVtxlEt/KvrDCJyoPY/8C/RN6jhJTn5zKBC54/MCqvFgj Wj8q4SXBUCdZqDqNphZH1Q1NLNr4wSu0p7O7mt1XQxdtwcpNnr6ubFBuc8S869fahEiTDC rWHeMj7C2lrIHDN3h0dnQ7f1Yf7xwxU= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HS19IjyC; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675701367; a=rsa-sha256; cv=none; b=BsbJYfLiwRvsaKyKuPnPz1sCLgId077KiFFS+NckEJIBwa5Ajfp9uGkzYJ78ypWpk1mt57 uwE9xDWf3KcmvT7SNTeDe9CLNk9ulFnYcGF+4xKZvvfnmjgB+Qkwdpu9MggNHFJ2ONAJ18 tuzr62564IuTcyhbeMCmpySYxRKxS10= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675701366; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eeZtsKyA0Y6gRhG9+TJW3Hh5qiBXm4UNVthJbfS8u7U=; b=HS19IjyCh35YLa2okLZnVLItmRqeEw6Hb2J9M1uKZGfTrca4qo+tf7vEq5/8FisjFilvQk DorZJLKr75yHp+D5pjL8kh/goEuAgYPrVI/kb6L2QCZw+OoKKhTT+SIhaI1br9j3768pBp CrE97DQPd8zKwul9tZMrgMds5zzLxyQ= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-138-Bq-p5TutPnmAWY35yLAKTg-1; Mon, 06 Feb 2023 11:35:57 -0500 X-MC-Unique: Bq-p5TutPnmAWY35yLAKTg-1 Received: by mail-wm1-f71.google.com with SMTP id o42-20020a05600c512a00b003dc5341afbaso6800207wms.7 for ; Mon, 06 Feb 2023 08:35:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=eeZtsKyA0Y6gRhG9+TJW3Hh5qiBXm4UNVthJbfS8u7U=; b=pxNUvTCHYIyC3NB8vTZ3y7lvc/nc4fKG7BIFFKYw1zer0xkFFPXZmc7YoIWeCgoVXP mClfca9go0CSFQlyHbWk0L3D75GKaygV2ads7lFBm63WRcdJtSmPGamP03acxn05AwnZ qb/0OBm8hLjsYLm7mr+nHWCnbOkNAdrtzINW9VHCAoe6bMvyOaIoTSQqLqylmQQbo9IZ vhD1OrVkH0cGRh4E43m1P0RoY/lPfEboW50RdKV71AEZ0kPvqn7gWefZYRMlLLitnFP3 h32JNmZuVn+P9u4unuH+iCzW4qDjZ3mr4od5WFQ+cf9raF3Cg3LaTd5gDHarySawxOHy WJjw== X-Gm-Message-State: AO0yUKVgfZDNshD/+XLWZfgzqdiWaCnbuNskN0fk/Yb9AECaK5sYUgq1 f61jKpJTXBarfGHG5SLwgX/RRGgDq4UfujrOX0zvXvDGCkBDc2qhN5bQCPspg9Izgud9gzVT/B0 7gvqGKYPxc+A= X-Received: by 2002:a05:600c:707:b0:3dc:572f:edb7 with SMTP id i7-20020a05600c070700b003dc572fedb7mr216046wmn.1.1675701356657; Mon, 06 Feb 2023 08:35:56 -0800 (PST) X-Google-Smtp-Source: AK7set/LiwMbF0GnLdEQGcaIZGESX4i4HYjQuqXyux6grSfRLrlaKaHm0vuHOjAf5fDdSlquuIAhqA== X-Received: by 2002:a05:600c:707:b0:3dc:572f:edb7 with SMTP id i7-20020a05600c070700b003dc572fedb7mr216033wmn.1.1675701356329; Mon, 06 Feb 2023 08:35:56 -0800 (PST) Received: from ?IPV6:2003:cb:c704:6200:8129:46d3:fa82:23f8? (p200300cbc7046200812946d3fa8223f8.dip0.t-ipconnect.de. [2003:cb:c704:6200:8129:46d3:fa82:23f8]) by smtp.gmail.com with ESMTPSA id d17-20020a5d4f91000000b002c3ec85285bsm2004260wru.70.2023.02.06.08.35.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Feb 2023 08:35:55 -0800 (PST) Message-ID: <400c5fb6-11ae-7771-07e0-538ebe652b2a@redhat.com> Date: Mon, 6 Feb 2023 17:35:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [RFC PATCH v4 3/4] mm: add do_set_pte_range() To: Matthew Wilcox Cc: "Yin, Fengwei" , linux-mm@kvack.org, dave.hansen@intel.com, tim.c.chen@intel.com, ying.huang@intel.com References: <20230206140639.538867-1-fengwei.yin@intel.com> <20230206140639.538867-4-fengwei.yin@intel.com> <7c8d3d2c-35e3-5be4-684b-4b991a0adb8e@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 51E5D8000A X-Stat-Signature: d6dhirrahuobw35g8r1ys7ytxj7dwf5s X-HE-Tag: 1675701367-579569 X-HE-Meta: U2FsdGVkX1/quzg4W63QUbmiKKRpt5q2C8h58xJmvJVOKELiMcKQ7OoD0Cdm2yYjg8JOrTlkafXHcinkStrVlGhtebnkulB6OyUyAd/jxuCZMwFRYRPWCs+624nlEVcITbXKq1SfFZ0ksKrOdt60UQqOpZcnQeRDENQgl0EF5IOPk1k3hvaCJ3AcjZq1JOxOYPHTOEL9I7//Qz1RiWu6iCNzHCHh//7oKraaL9rqS01B7k/0olqo7u+jjY/twWTlBzIGp1ZGwNkSlWl8dH+cWYVd6ooESX05oLYwHinWTfJLXrB4+BqAfCbNuvYoy/WCJA7TKnr41epJVluBBoKi9+7wloy8w0kgEJLX5xe+++wCjO3rJuwQRXyVdGkKqHdaOU7Qj2NmnbbifFE1VtB7JxSkm5Om4gDmdfcksaXvH0BxWGHC0fCM3EtAGys3g/J98Sjtlg35ezpADQEGBNdgBpFToKX5tkDZX+T+DwYSpgfcBB+vU+XuBphJugg+WFFbowawv82mwE4myr7+qm3wb467mUCdLQsqfWbUsM4f4oBdfOCIBeRqslZ+drShowi8tgo1eQXWlWydX46ETMdUPCB5vehMNYr4yyd3pSxaYyeParFXlvPg7mVbdE6PwKil6OOAOMsvhYkdk8jU3+1VfXukXPDJRZRkTZ6+4O9pVmwdNgnOTm7bO0kc+4SVaIbKsYyFFkSSEzzYLH/W9BTS9z86/ZdH1V2CfrlaU5iknDm+S6xiMesU08GSJD8f4kb9yG+Je0njqEKOeStCk1ls+WknzmO5Et/6BKy8BFRCzjKElSgFWEbTVkMuO5STDNn02UPzasCPvuHI0nOksi7j5iPuJdvZnIj9D+Mbu3mzkUC5+853gyJHKPP1/+xgXeJpFYHzubPqNzC7DxFgaBYhOLnLmBTofX1ws2it14HXqNXlhKBkLyOkYuNAS0UEq6vY2q/uD+2cuEiQ/OjDgON M5Kdjc8E GvL1+jFMooAQEN0IxrgRGpqYz0MULVTqLieD4cpCY/h9QDLTtAhUBmg+xsMLmbzHisXVg6PXfe1JddjKmX6Xt+41+leBdM0AqC/Urd1jwFxERRikzvhej5Zj4u59ZjdEyNkmPYgURBD5kWu1Eux5XfTTwQ/vVQmJG42jhHPHO9fun+7MsgFWh2BaIXQafcpUpXeAntUdNOK2fjqa+YxWaVfKuPPgj6YUzQXaXMFUc1ev74SzfyyeL9EYTsATcc+hly17ulwbpaL3U6GrmvF3yYtvW7js+IpBrirGMEmrN6OAqI9/vKib3No0VPQLciphwyK1BDhptp6AI1F26tr2mmX9Kb+Q3PCS94C0hvnM5LPa+OgUPYPLpygenZkO2QyXppbt8DO5ilMsNQXIDn27bti2QNO8KVr9vwv9x/N+ng0E69Df9zT6mEq9RMoYjLtZE3ESM X-Bogosity: Ham, tests=bogofilter, spamicity=0.000541, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 06.02.23 17:33, Matthew Wilcox wrote: > On Mon, Feb 06, 2023 at 04:13:44PM +0100, David Hildenbrand wrote: >>>> The handling of cow pages is still very clunky. >>>> folio_add_new_anon_rmap() handles anonymous large folios just fine. I >>>> think David was looking at current code, not the code in mm-next. >>> OK. Let's wait for further comment from David. >> >> As I raised, page_add_new_anon_rmap() -> folio_add_new_anon_rmap() can be >> used to add a fresh (a) PMD-mapped THP or (b) order-0 folio. >> >> folio_add_new_anon_rmap() is not suitable for PTE-mapping a large folio. >> Which is what we are intending to do here unless I am completely off. > > I think you are. While the infrastructure here handles large folios > which are not PMDs, there's nobody who will allocate such a thing, so > there is no problem. Right> And that's precisely what I want to have fenced off here. I want that function to complain instead of silently doing the wrong thing. -- Thanks, David / dhildenb