From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D362C4332F for ; Mon, 11 Dec 2023 20:02:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 950256B01FA; Mon, 11 Dec 2023 15:02:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 900666B01FB; Mon, 11 Dec 2023 15:02:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C8476B01FC; Mon, 11 Dec 2023 15:02:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6C7696B01FA for ; Mon, 11 Dec 2023 15:02:12 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 3C88BA1C55 for ; Mon, 11 Dec 2023 20:02:12 +0000 (UTC) X-FDA: 81555608904.20.D562172 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf02.hostedemail.com (Postfix) with ESMTP id 63B6980031 for ; Mon, 11 Dec 2023 20:02:10 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=U5evn4Dx; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf02.hostedemail.com: domain of broonie@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=broonie@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702324930; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=B1VaaVmBr41R3A/7hC3cq83geUXWrIaCFbBccORESyE=; b=YQvGBpq3C9m7Wsd0xVqvmiQQ2uNuWW56dCJ5xtcXl7mUBbsJRhRjKIzbgyx9hHjbHfYQIJ +0TX6NLY/+jH/Ox2rhRUb9LyCS5d8cYCtmrBNXUpjTegRdtZrXW8sNJGma1gXNn6P1Z+BF CZWven7gqwJa/zi+vfK6/XnQcAyNRh0= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=U5evn4Dx; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf02.hostedemail.com: domain of broonie@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=broonie@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702324930; a=rsa-sha256; cv=none; b=DLsyUjaOsORpPCzhaWmGXnCme6iQ/PvgBlZhgxmCRMfxJWHAOILz22oEkS3DRne4nLQYGh OdI4W1gCyIadh1jahZYt20SON9zwIK4509CkMU/9SUoIzq1MWKLVZar5gQ0u3unDO7cZac HGbnWW//c1BKX2isqwHIj9sBF6bn9k8= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 69804B8107B; Mon, 11 Dec 2023 20:02:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2CA26C433C7; Mon, 11 Dec 2023 20:02:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702324927; bh=0muo1Uoi32hut1hx3yMwoWK9bfatBaZv4kIG4F1glqg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=U5evn4DxU2NcpgJ9s72YHzYM8pWzYiZDS4VpHFRrQVGissAfR7uMl4oZFRg0BIAX7 CN0OS0Kbnft0dHbdlNHlWimW62G0Tsu8P8djSjW15jd4oqZuhepaiT+ixOexOjGttt cPnuhd5MsxToFTb5zKx0syWfzGQDkNMKfkfSjNEjTG2RaCDiPe/JljeWqSOpmZfkRu wvlHrsRmoI8VUCkicMgLEmhbgcjQ9xUEe4aWcIw3m/GU6VIXwfV5jlXYUR/XWPv38a A/UiHNDjqqR7mkW44WT1jP6GGqfzmdm8EgK1+eQZ2erD5oczAltOvjJ5se7zQYESl3 34OdoPsk1CUdg== Date: Mon, 11 Dec 2023 20:01:59 +0000 From: Mark Brown To: David Hildenbrand Cc: Suren Baghdasaryan , akpm@linux-foundation.org, viro@zeniv.linux.org.uk, brauner@kernel.org, shuah@kernel.org, aarcange@redhat.com, lokeshgidra@google.com, peterx@redhat.com, ryan.roberts@arm.com, hughd@google.com, mhocko@suse.com, axelrasmussen@google.com, rppt@kernel.org, willy@infradead.org, Liam.Howlett@oracle.com, jannh@google.com, zhangpeng362@huawei.com, bgeffon@google.com, kaleshsingh@google.com, ngeoffray@google.com, jdduke@google.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com, John Hubbard , Peter Zijlstra Subject: Re: [PATCH v6 5/5] selftests/mm: add UFFDIO_MOVE ioctl test Message-ID: <400c0342-bb28-4dd2-b132-9927c7babec4@sirena.org.uk> References: <50385948-5eb4-47ea-87f8-add4265933d6@redhat.com> <6a34b0c9-e084-4928-b239-7af01c8d4479@sirena.org.uk> <3240f4b5-081b-4075-851a-7d1cd86f4333@redhat.com> <1368c558-c58c-4574-907e-36b07dee31bb@sirena.org.uk> <6ee5d68a-fa54-4ed6-bc41-2bff0d9eb12f@redhat.com> <052dc756-cc05-4aa8-9724-14d42853089c@sirena.org.uk> <8a2ce635-58f4-44e1-a646-6527936c5836@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="v6cD9Anxo0FHLDGJ" Content-Disposition: inline In-Reply-To: <8a2ce635-58f4-44e1-a646-6527936c5836@redhat.com> X-Cookie: Better dead than mellow. X-Rspam-User: X-Stat-Signature: kj1hpjujzi1fcquuhtc89syg5mnih4za X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 63B6980031 X-HE-Tag: 1702324930-929429 X-HE-Meta: U2FsdGVkX1/7keM4g0Tjmq51z460vknsmBgCrqtGBFcs469aEZdDOHJmszoMA2KI7/vSF8MQ80IxZ067TrHwlC1njFz/wjzNo+9ajRnik5F0J/h42p+qGa3suCrMSRKwVY5Ipew7JE+qawlQYszEk7mcMwxbUwUPh+4XNH5k5+Vi/vmLyT9Gkp3qkKcI4/nWVZT1yXYgqnodyTMwETAY1pG+FNFBKQlVWBAS1wjcpfrnj5/Tw16Dy02YAfCle3GckBg2vp58x2rVn5xDvp7UdJJj2LikEvqIuY58TYO6u6COXEYPMkwbBsRBaEZjJ2yAKS1uSPdTd5acIFoQOAyleNzubDVFpsQHqimtCjzvr/aO8S64uQFf7FfUuflEjGX3D53lb7Yts0AkcAFAZmVVfQOmvRcEHdZpvDv5dOHjhhaVdZPmx6Y/UIOCBolB2xlsCrO7nw9xd4BugEWFJaj5qIlHyigHHyAo5f/7PUYzRlp6+dGSW2bsz4umnHoTubQPY6SvBgS08EClvp28UNa0m64Kh3EWySqphRGENh+08fF2AfkMFL2kHZIoD/uiae/KNNLloNJD+xa8K6SNyCZ126K+MjdT8bk2BotHR/tpG4RcvdPn6hxuD5Utc7ZMNbzLwlcH+0zROTJ9X5qZ/3fjxDJOQQbOVqJn7EbKIUBZqOQqmG3YmIIMd/6JUbFaJddSOfK6y4CiPrCxaY/6PWyDH5FJvoTiWSS59Wih/1h4oMlWJolEWoG6HZBKUzryxi40ppEmYANZ9OspSt3Hu+Ezr2itdWhefljaibX6j32c6U02YbfeXJtxM+lUlLaKxujqnhFWb+ABdwrUmT2k0X9TfZkW9HEEb0ebq1R0ra+SV2KaQEED41DGadZe10Qn/rGx8aASZl6jdXdCkqNutNfNYGT5Si1wJR4bfbK3n3ImoE1Q4GKv797Tz2eRMClIdyzDw/2jo6QLxnGXI1eD/l0 XjrhV+dL Qe5AgH6VNkZa6gRIVYecdhrXLshKwk6MgY0zQr36306/GqMTUP21+eSGrbTbdOrWcL51FZhZTnXjA+85S33gEX7r3AmeA2OqoHQ6x2WW7vudEXD37cqxkl0fNP/L1HqloOK5PtB7pcuH9ofhATgZhqChVGh//Ce7coNPxTe62tfkIQJq8pgVfCllu5wbd5jQRbvdFyEt2cZnI+gz7CIRh4X1MxT5aUHIJzkTOQCNcJadUVhuTIyGD6dbw9h+eJvbQ0/AlmpKZQEcUBnvFJDA1SPWF32tEY7+GxsLYywN55SXj3imaovwfDkzInGu6CVmjQMhTV+ChgwTyNkaSkSq/56pojkdCYqF/4itPvtPJ936g1PhxovvgOL0c9rU+8O7uY0MX X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --v6cD9Anxo0FHLDGJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Dec 11, 2023 at 07:00:32PM +0100, David Hildenbrand wrote: > On 11.12.23 18:32, Mark Brown wrote: > > On Mon, Dec 11, 2023 at 05:53:59PM +0100, David Hildenbrand wrote: > > > https://lkml.kernel.org/r/20231209020144.244759-1-jhubbard@nvidia.com > > I mean, I guess people who don't want to install the headers are just > > not going to be able to build a bunch of tests? There definitely are a > > bunch of tests where it's not needed so I can see why people would not > > like being forced to do the headers step if they're only interested in > > those tests. > Yes. And before that, people mostly had no clue that headers had to be > installed in order to compile successfully. > So maybe a warning to give at least some hint might be reasonable. That sounds sensible, especially if we could arrange to flag when the specific tests being built need it. --v6cD9Anxo0FHLDGJ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmV3arYACgkQJNaLcl1U h9B1kwf9FSJkPhxe7Bh+LVMm9M/JwDNNcn4+8J9LLt5yC5m4APhXIPtgAzsQf7HZ pA1lZh6HCE3f7G0WAFms4UkYnL4Sg+/5/1KIJmZZ8PiSelGBMEqQxhqJzWcI6za0 gZODJQZdI4yuMG7RLnVum7TzOenAd+7RpT8TOmcn/UM6BF8BWLg26DmB+Yf/Hf/f gL0W3epHdBysAKO+esLc+6ifEBeokyHtETY9wNLHcKnA09K0YY0Jp55tfwbKvPgi D8MyS+1kNPy2to2TMPGxhVilrB0zS0ifR8ELa+Dlnf3A0PfsBa2fdIeW2ARZ7+7C UjMVDE+wbqAH29BU8bvGTEEha1jV1w== =JgyN -----END PGP SIGNATURE----- --v6cD9Anxo0FHLDGJ--