From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A005AC636D4 for ; Fri, 17 Feb 2023 08:08:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CB56B6B0072; Fri, 17 Feb 2023 03:08:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C654E6B0073; Fri, 17 Feb 2023 03:08:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B2CFB6B0074; Fri, 17 Feb 2023 03:08:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A2FC56B0072 for ; Fri, 17 Feb 2023 03:08:53 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 5EA22A1643 for ; Fri, 17 Feb 2023 08:08:53 +0000 (UTC) X-FDA: 80476057746.18.4CA9220 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 1AACA1C000A for ; Fri, 17 Feb 2023 08:08:49 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JiRxoOmn; spf=pass (imf18.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676621330; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oj3qHyJXPrt95ESZEYz+HIUZYia6cHmkbLgbrVa/onk=; b=qqIZDohDmYqgrfGRjRUQAiHmG/RU4mnDjyKeqLoKF31fVBiccY60wUhftLB8t53D7dcTuD p8K5YXxFy4LbkA+/KRr0qYUqiqbU2GQWGUkEzMyP8k06PRzA1BcMNfXxrUVbBr9d9H+192 CxwG4IcA1jRb8vMco2jZWVRzLP+zQa8= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JiRxoOmn; spf=pass (imf18.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676621330; a=rsa-sha256; cv=none; b=WvnSpdSSHa53L1Yy96jNSPKvnNgIx7EahZ/1J7QpOatHtBzZzG/4tdQkBbirBxnGqUysMH Sdma4AxDiuPzr+/7QKp/0clD6wsvnz7d50nICCDnBX66bYornCryAK55SQKJHGq/WoYEhJ nj48jwCoD95pdZ2soCQf9WExZH2YPD0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676621329; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oj3qHyJXPrt95ESZEYz+HIUZYia6cHmkbLgbrVa/onk=; b=JiRxoOmnnw0QSa53kYso6bxItggrGBuWVv/6dpTKTYi9yYnUzypmMHEUhvH8FyyWOu+0Rm N0z9AUbaQyvpwXvnJq2TBd8uM0LvLTrx0whXPEZKbp8XvoHqoViQJ1YbD8a6s0zHz9J+XC FoXIHNF+qLahMyvy0Xkw0MZTLgXoZ60= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-17-QBH5zj9SMgCu1xXomTCUeQ-1; Fri, 17 Feb 2023 03:08:45 -0500 X-MC-Unique: QBH5zj9SMgCu1xXomTCUeQ-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C0B0E800B24; Fri, 17 Feb 2023 08:08:44 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.24]) by smtp.corp.redhat.com (Postfix) with ESMTP id 889A4492C14; Fri, 17 Feb 2023 08:08:42 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20230216214745.3985496-1-dhowells@redhat.com> <20230216214745.3985496-15-dhowells@redhat.com> To: Steve French Cc: dhowells@redhat.com, Jens Axboe , Al Viro , Shyam Prasad N , Rohith Surabattula , Tom Talpey , Stefan Metzmacher , Christoph Hellwig , Matthew Wilcox , Jeff Layton , linux-cifs@vger.kernel.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Steve French , Paulo Alcantara Subject: Re: [PATCH 14/17] cifs: Change the I/O paths to use an iterator rather than a page list MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <4008034.1676621321.1@warthog.procyon.org.uk> Date: Fri, 17 Feb 2023 08:08:41 +0000 Message-ID: <4008035.1676621321@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Stat-Signature: 864ohtujoga4a7dsh35zxazt6fohrteu X-Rspam-User: X-Rspamd-Queue-Id: 1AACA1C000A X-Rspamd-Server: rspam06 X-HE-Tag: 1676621329-317441 X-HE-Meta: U2FsdGVkX1+2Th/Nysn38hme4/InG25k0hIWcgWcIfo6pdeFcItgxwSvV+Z9swzGM0hi480IE61ubp1EF4jA69K97Xn10He6VPvC2TUlN4ZPurdyNY51poTyJ5BsN5ENhP9TLw3XDPba9rL5z7Kx66aWlqaFxpEKQkbMaG3+UctCMN4uLeI30zo4yQm3cX+6ynrLYDOTEcQHA7XhBbrG5sU2BirGYf6FdpYdi7qfidHkVPuo43U+yCMB3ac2bJsd/NuGvtuS06F7LGw9NvtFsnZjIdeJe+y7X17ArYKU4GWrumgnPzMPy2wxfPjBXi+/hY5m77DHzpSOJEfhxxhfIl8uQyMo/sHDqpHQpd9oup9eesNJ87bNkyKtm0bt9nRiDFvGPNz1VKygDy8MDN8StuFWfsINsJBBAcU503Y3WOup5w2H4giVPQbE4tOov4Is19hEitvPbFdiVcnfTU02ZCLAM0jme5rLVUfP5TfpzIJ1RhuFwyloFbsb+lRVD92d/mXt2SMtj/71v0dwaHVTamuyWLBWxyDqtqgP020OMUsmNE7PVWhL/7SQOSYb7UtPpPYDmuv+N24zyLEUU/Sm12li5kXhV0R+iBUiBxu1O+MVIKNXQW7+iRJKKsTOzxq5DLhOnPypgasyOtuToA3cpubRVY5I2ROKkS1xq5fBlgkZVIJIkHgKjF0dVeT1ExDEtcnOO1qRaa/o73J8nP1aSZ1Ag+GYauTzYZop2LOMSfgaIzon6mwvqo9feXieFImKw6KOSmqwx9hpGFq9CvzUkXRNa1ZtaltvLL+iThsWmmU1HL6Wu5VdIOf/mFotzPG7mddcQnKODJhOBLlLEK1YYbEfuPOTiHnmCdOuyJDNuU1yGa1Ah033fx9DvI9Af9ubfU1Hh2HazrW+dd7vjpaiS10kCqTfztFghyieAtDWlR98uXLcJq4bD+Mpv8Zi8LH91mTs0OYwaIektcLxMKL g+ydtZUH AQdhXXnIjA0J9JIfbzl470UrT7jV28Mg/Lf3tX0O4hpjmhnwoV8SxoqigxUMNFvSV4DXC7rkYBDH2Fjlpe9DBfHTQ60p0Hs1u3NSEcGD2lZ+NJRhS/moSGsfwX62+DuzHQWzPz9H94YApkL/okt8tUktcNt2+oz/yER+6ckR9Q//5CliWwhzpPOAqR18jHbRnUMLXh+Yf+l8KgxTFktVkAgtEg/Mh5gESP6LFnb5HC31lj2yUsngiohJy4YoJpvKZcwLhfAzmsgzb0dWXBgfPft3mQWOHDoRUfMc3i+Y65p6i75o6F7q9QLSXrWIJOM+vHg1sYOYha4kePXM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Steve French wrote: > WARNING: Consider removing the code enclosed by this #if 0 and its #endif > #627: FILE: fs/cifs/file.c:2609: > +#if 0 // TODO: Remove for iov_iter support > ... > WARNING: Consider removing the code enclosed by this #if 0 and its #endif > #1040: FILE: fs/cifs/file.c:3512: > +#if 0 // TODO: Remove for iov_iter support > > WARNING: Consider removing the code enclosed by this #if 0 and its #endif > #1067: FILE: fs/cifs/file.c:3587: > +#if 0 // TODO: Remove for iov_iter support > > WARNING: Consider removing the code enclosed by this #if 0 and its #endif > #1530: FILE: fs/cifs/file.c:4217: > +#if 0 // TODO: Remove for iov_iter support > > WARNING: Consider removing the code enclosed by this #if 0 and its #endif > #1837: FILE: fs/cifs/file.c:4903: > +#if 0 // TODO: Remove for iov_iter support These chunks of code are removed in patch 16. I did it this way to reduce the size of patch 14. I can merge 16 into 14 if you like. David