From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76EB2C54E58 for ; Mon, 25 Mar 2024 05:44:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E27FE6B0082; Mon, 25 Mar 2024 01:44:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DD8306B0083; Mon, 25 Mar 2024 01:44:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C9F476B0085; Mon, 25 Mar 2024 01:44:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B838B6B0082 for ; Mon, 25 Mar 2024 01:44:13 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 5C370C091C for ; Mon, 25 Mar 2024 05:44:13 +0000 (UTC) X-FDA: 81934470786.20.622438C Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) by imf06.hostedemail.com (Postfix) with ESMTP id 8703D180007 for ; Mon, 25 Mar 2024 05:44:11 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=gzHaDSPG; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf06.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.208.44 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711345451; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:dkim-signature; bh=YSiD+9+Vo/MN7nexjWvC9Mo/4lJyNqYqVIVWFz6u1GY=; b=vnX6eRnOjE17mUHIVHzVatnZJO9JME1uQQL2AefyLwXP9cWENUKjuEulcSOT3izM9G91j1 84WPAKuK3AEqlap21/2mmjoUVOZdPAJH0705bi+4pgVD1nxVB36SUFXT/QH/iy1ZMSyuO5 ty8oqx0ufA9tQ4eM5gFtuevC6fSFwkk= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=gzHaDSPG; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf06.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.208.44 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711345451; a=rsa-sha256; cv=none; b=BP55l2a3MlWxqZD0ODFn+SZPmjBFv309KFP+B4IjrsyZEBXX1efpzHZau03+9fnjbY+SG8 5It0Ksy2mbH9l4ZblU9evAi47GXjJtdOzXaWphuJGmIEEDq5fTB1xPSZqs74oX+Bf41UQB jFdhkHHzy7b3H/oo0DBuo3MraeHxxS4= Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-56c0613307cso1070662a12.0 for ; Sun, 24 Mar 2024 22:44:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1711345450; x=1711950250; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=YSiD+9+Vo/MN7nexjWvC9Mo/4lJyNqYqVIVWFz6u1GY=; b=gzHaDSPGi3P07QzesNxfeh8kpSiMXR1VcCouuNI6oSXdkt7wbwkt4ntXcZrdwf4Oaw Js2w7cPh+lcXd+rnBvo8GB+dJc4B8aDtxcLX+aC2AMj43u93nvXwTJtSprLJm66ReNCD OBaZrb/hiV38cOLwzrKYYfULkY5PjAMPKhgaE33uW18uMhLxeT6W86g3Kf180SnuwwRh MsMVVEup1aF+D5BD/9DJZBsB1eg5tg1BXp6VzkCQyPIGixCQvNjP7sIK+vrzlpsYBGcS Dhdj2uOcu56p+z2ACm+LDjGiz2sOZF8WXcZo7CdEOCQmGwF6AzZxEc5M+C3ejmwpg7Iy mM6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711345450; x=1711950250; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YSiD+9+Vo/MN7nexjWvC9Mo/4lJyNqYqVIVWFz6u1GY=; b=o437BVHvsTqEn1Uh/w+JDnOAdbybyK8IE25stgE9oXGjCpRgdspfKz6ELhbC/XvR5w tWRsREpf7Wq/lAjOT2dc8RQZJvwy/lJTM8/TW3Dzig4AIkwUW8HGwgkoMlkl4SgxscVx eW7pjOjdFuy34KJWh31OJpa6pG/Dz9l7LVO2+LvUhr2enCzRSqgMYrnu/F90H0naluNn EX7GpbUefeKWIlYy/EhfUtTCOeiFhZG2dfJJJr8M02/uunjmdQmctOowC5b8niBAaR7Q qpJud8/GZYRt+0pdvcu41goTAGicAAiWRgzvA2ZE99nNqddBNg7jODP6US5fPY10by9l XmTw== X-Forwarded-Encrypted: i=1; AJvYcCX5Jztt+Dsg/2OuRrIXl6uTXIbYft++ZbW/cp8jpRgJF8+IPZOZgsMCgfHZQS8Wt/8cs10oUD1k5jTRR9JncxLXLgE= X-Gm-Message-State: AOJu0YzWlgrIgjkoEPt8k9Gv3wkfNk/Bi5ZvEdLpY/ey4bzvqpiu9d8g zBIv9oCHB2ylpwMVuSUvWi+61RlP318lc8/iZtK6QfnZkArosH1+IzJ7ZvFXRv8= X-Google-Smtp-Source: AGHT+IGwv0s6BaURbKfJtjYu2GpcpPn5goZ2nF4pAupUt62oAYFBPgf35YKkH3776wuuNPBOF6xOrQ== X-Received: by 2002:a17:906:947:b0:a46:edb6:df44 with SMTP id j7-20020a170906094700b00a46edb6df44mr3208186ejd.67.1711345449597; Sun, 24 Mar 2024 22:44:09 -0700 (PDT) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id i27-20020a170906265b00b00a471481ef3csm2630995ejc.124.2024.03.24.22.44.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Mar 2024 22:44:09 -0700 (PDT) Date: Mon, 25 Mar 2024 08:44:04 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Jinjiang Tu , akpm@linux-foundation.org, david@redhat.com, shr@devkernel.io, hannes@cmpxchg.org, riel@surriel.com, wangkefeng.wang@huawei.com, sunnanyong@huawei.com, linux-mm@kvack.org Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, tujinjiang@huawei.com Subject: Re: [PATCH v2 1/2] mm/ksm: fix ksm exec support for prctl Message-ID: <4005efd4-06a5-4c91-845a-f0ad2cc792e2@moroto.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240322060947.3254967-2-tujinjiang@huawei.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 8703D180007 X-Stat-Signature: jhikdjmqig4eoa3fd846s8ys8uwo8zue X-Rspam-User: X-HE-Tag: 1711345451-681475 X-HE-Meta: U2FsdGVkX1/GBkRDc2A34xhh5Z8XFKN3hfD8J3w8GdJbJt2bCwBukPw6eflk+o0/HA/Cw6AWCBEnCEZCVTHEwsL0s0WIf+JfyaPnaLazpX2rr88duoOF3hAdXxULwjooQDHp9xpdvUuUNTQd3yrsc2YHxildUuWYd9/3rUlLzO+yLB3WRjtwFierQjleH7ZVreuchF7DdoxhbtG3AvUWCGz/x1ujvWSj4VI/O+rCpQMi9Nve763G4kvZWQjPozHTIAei2cuLdlxEqvIYwHznMuJWbfAs/uHIP67kaJAzQYReXpmtNTOpijN48UWJMUsDwaG/uOw+pX2SaTD70UnCyy49oa0nxhyxmJuYykvRfr5yLXk8WMr8LN5IFiW9OVKik0sNrmVWY0G1Yub6ha+VYT8qdUpWVaMKVBYgUVvJLP3JGoOr2YXuAo9FOX7gay1Pf+QxL/cLOTnw7GmsGxR0G6J/EwhIrYhEtrC3P32fx0dufnSvgluLr49hrShLHrHJjTEl7skcKph7v1LkKDt30Ev6YWbyR04ZGb9fEUApm2XFYMnCfU4L2r4gFnymG96cnyto5btS9nJfh/0fxHgWjIcrrqFglmPHOwcrVm9h57meQu1KJveSuOezeSntXOcFM4TGlR1mbyWo1UmsxjbVoJjxznooerR0p2C/x+BwDhzfEaBt4HHOSIqgH8ANgO7ofsQtTh5Fd7SjmCZA92/sn/xeJu2eqT5UKw9v9s8gwr30wiyv3T3SUh6ejQdk6qbMlT2oauzb9fRIdG8ZoURfC7dqgwizgtBguYE+/1jQ71MYkZe1RdWTxh9eYYhiMK7fmHIU00tlfsZPSYFAxDuH9nD5qOXwDopX1rL1aM0GflnJXyhhQ14gUQS2KJ1hudvtjjN21LizaqT6UoOXjYTATbW2YmQjBK4v X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Jinjiang, kernel test robot noticed the following build warnings: url: https://github.com/intel-lab-lkp/linux/commits/Jinjiang-Tu/mm-ksm-fix-ksm-exec-support-for-prctl/20240322-141317 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/20240322060947.3254967-2-tujinjiang%40huawei.com patch subject: [PATCH v2 1/2] mm/ksm: fix ksm exec support for prctl config: openrisc-randconfig-r081-20240322 (https://download.01.org/0day-ci/archive/20240324/202403240146.Pv4gVc5N-lkp@intel.com/config) compiler: or1k-linux-gcc (GCC) 13.2.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202403240146.Pv4gVc5N-lkp@intel.com/ smatch warnings: fs/exec.c:305 __bprm_mm_init() error: uninitialized symbol 'err'. vim +/err +305 fs/exec.c b6a2fea39318e43 Ollie Wild 2007-07-19 255 static int __bprm_mm_init(struct linux_binprm *bprm) b6a2fea39318e43 Ollie Wild 2007-07-19 256 { eaccbfa564e48c8 Luiz Fernando N. Capitulino 2009-01-06 257 int err; b6a2fea39318e43 Ollie Wild 2007-07-19 258 struct vm_area_struct *vma = NULL; b6a2fea39318e43 Ollie Wild 2007-07-19 259 struct mm_struct *mm = bprm->mm; b6a2fea39318e43 Ollie Wild 2007-07-19 260 490fc053865c9cc Linus Torvalds 2018-07-21 261 bprm->vma = vma = vm_area_alloc(mm); b6a2fea39318e43 Ollie Wild 2007-07-19 262 if (!vma) eaccbfa564e48c8 Luiz Fernando N. Capitulino 2009-01-06 263 return -ENOMEM; bfd40eaff5abb9f Kirill A. Shutemov 2018-07-26 264 vma_set_anonymous(vma); b6a2fea39318e43 Ollie Wild 2007-07-19 265 d8ed45c5dcd455f Michel Lespinasse 2020-06-08 266 if (mmap_write_lock_killable(mm)) { f268dfe905d4682 Michal Hocko 2016-05-23 267 err = -EINTR; f268dfe905d4682 Michal Hocko 2016-05-23 268 goto err_free; f268dfe905d4682 Michal Hocko 2016-05-23 269 } b6a2fea39318e43 Ollie Wild 2007-07-19 270 d282f6b19afd1a9 Jinjiang Tu 2024-03-22 271 /* d282f6b19afd1a9 Jinjiang Tu 2024-03-22 272 * Need to be called with mmap write lock d282f6b19afd1a9 Jinjiang Tu 2024-03-22 273 * held, to avoid race with ksmd. d282f6b19afd1a9 Jinjiang Tu 2024-03-22 274 */ d282f6b19afd1a9 Jinjiang Tu 2024-03-22 275 if (ksm_execve(mm)) d282f6b19afd1a9 Jinjiang Tu 2024-03-22 276 goto err_ksm; "err" not set before the goto. d282f6b19afd1a9 Jinjiang Tu 2024-03-22 277 b6a2fea39318e43 Ollie Wild 2007-07-19 278 /* b6a2fea39318e43 Ollie Wild 2007-07-19 279 * Place the stack at the largest stack address the architecture b6a2fea39318e43 Ollie Wild 2007-07-19 280 * supports. Later, we'll move this to an appropriate place. We don't b6a2fea39318e43 Ollie Wild 2007-07-19 281 * use STACK_TOP because that can depend on attributes which aren't b6a2fea39318e43 Ollie Wild 2007-07-19 282 * configured yet. b6a2fea39318e43 Ollie Wild 2007-07-19 283 */ aacb3d17a73f644 Michal Hocko 2011-07-26 284 BUILD_BUG_ON(VM_STACK_FLAGS & VM_STACK_INCOMPLETE_SETUP); b6a2fea39318e43 Ollie Wild 2007-07-19 285 vma->vm_end = STACK_TOP_MAX; b6a2fea39318e43 Ollie Wild 2007-07-19 286 vma->vm_start = vma->vm_end - PAGE_SIZE; 1c71222e5f2393b Suren Baghdasaryan 2023-01-26 287 vm_flags_init(vma, VM_SOFTDIRTY | VM_STACK_FLAGS | VM_STACK_INCOMPLETE_SETUP); 3ed75eb8f1cd895 Coly Li 2007-10-18 288 vma->vm_page_prot = vm_get_page_prot(vma->vm_flags); 462e635e5b73ba9 Tavis Ormandy 2010-12-09 289 b6a2fea39318e43 Ollie Wild 2007-07-19 290 err = insert_vm_struct(mm, vma); eaccbfa564e48c8 Luiz Fernando N. Capitulino 2009-01-06 291 if (err) b6a2fea39318e43 Ollie Wild 2007-07-19 292 goto err; b6a2fea39318e43 Ollie Wild 2007-07-19 293 b6a2fea39318e43 Ollie Wild 2007-07-19 294 mm->stack_vm = mm->total_vm = 1; d8ed45c5dcd455f Michel Lespinasse 2020-06-08 295 mmap_write_unlock(mm); b6a2fea39318e43 Ollie Wild 2007-07-19 296 bprm->p = vma->vm_end - sizeof(void *); b6a2fea39318e43 Ollie Wild 2007-07-19 297 return 0; b6a2fea39318e43 Ollie Wild 2007-07-19 298 err: d282f6b19afd1a9 Jinjiang Tu 2024-03-22 299 ksm_exit(mm); d282f6b19afd1a9 Jinjiang Tu 2024-03-22 300 err_ksm: d8ed45c5dcd455f Michel Lespinasse 2020-06-08 301 mmap_write_unlock(mm); f268dfe905d4682 Michal Hocko 2016-05-23 302 err_free: b6a2fea39318e43 Ollie Wild 2007-07-19 303 bprm->vma = NULL; 3928d4f5ee37cdc Linus Torvalds 2018-07-21 304 vm_area_free(vma); b6a2fea39318e43 Ollie Wild 2007-07-19 @305 return err; b6a2fea39318e43 Ollie Wild 2007-07-19 306 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki