From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C165C02188 for ; Mon, 27 Jan 2025 17:55:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2F52C28018E; Mon, 27 Jan 2025 12:55:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2A56728018C; Mon, 27 Jan 2025 12:55:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0F9E128018E; Mon, 27 Jan 2025 12:55:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id DFE2B28018C for ; Mon, 27 Jan 2025 12:55:01 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 8B3DD1604F5 for ; Mon, 27 Jan 2025 17:55:01 +0000 (UTC) X-FDA: 83053982802.05.626E8FD Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf27.hostedemail.com (Postfix) with ESMTP id 165F040011 for ; Mon, 27 Jan 2025 17:54:57 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=A9xaxKt4; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=gdWsltSj; spf=pass (imf27.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738000498; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Fq13oMkLNwjGIm5ZVvD9vTByMNhMcQENm/1YSnUjJM0=; b=uUFD2VMZimEve3N58Ma+aYQai3rJ/i1DVg6m6u3mJIEENGV5uN6m4pt7mSaSrSrpx968gu p8ZJJ0etqWi5PFkIdncWcP+ZnUJ/uxm4P8XsoX9Aqi0fsqVOellOxB+vvUynLh0DubHp/m FIQHbUijVuX+84BkRNNrofHP9ARdpng= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1738000498; a=rsa-sha256; cv=pass; b=lAkpY2DpEgHIN/t+2mDC+eXMqMu7oCBpzWNAdB82wa+JSo9g578KvyFwhwM+nJYXrGrS1a Fcbm9qd5KhFwd5qmQwYf/TXKl/A1z73gpxkKg4LD75roPE60KuDBfTo7JGG+bN0nEqVDKd 44z2iNdWZ+Gj6JSUkIcb0Vx2hCIwORU= ARC-Authentication-Results: i=2; imf27.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=A9xaxKt4; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=gdWsltSj; spf=pass (imf27.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=oracle.com Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 50RHm9Gg031585; Mon, 27 Jan 2025 17:54:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=Fq13oMkLNwjGIm5ZVv D9vTByMNhMcQENm/1YSnUjJM0=; b=A9xaxKt4fYjYL0Y1nKRpQ8KrGg6Gwqq4w/ vd3bAPG/d2P3g5lKxZauI7PmsAK9+72+z2poY4KRo7fQXBUDO3uvTw1kcP67c5kD X2kzzdSolmwTt/V189EBJbvYE2m89H+/q7otmzKlzCsNtRlUVM/UQG2BqNSdSfDG h0hQghR+W8xSwKW91f/2+Ejs429LGtPNkwJKREGw3yLK6KirjFuVIKQC4Um4Jf5J gr+v+cAhmt0QT9z2IwA5M/qa/doOtp3Puz52Hp1Z9aDpaxnrFBDkdAGq0IJtcBiv gXQg+4jSFdl/EhKOFa/M8XeDY2l6h5XKlLak0fYLdAW8MAvs10zA== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 44eefqr2p6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 27 Jan 2025 17:54:38 +0000 (GMT) Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 50RGYIjw005356; Mon, 27 Jan 2025 17:54:36 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2174.outbound.protection.outlook.com [104.47.59.174]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 44cpd7b44t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 27 Jan 2025 17:54:36 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VBK5S3Mfd+r4grU8TvsqncHzbD5jUsZ4/6siEFlOXJCZ5LtJ9y8dLWScmPLisF4jEt+VY0OwXtl7/NOOfTqThJ05y/UBdAOydYuHkhbKfEBxh5tB18qqufVbPoK9JsGUg0WMzmCVvhQ6nx8xu/58QVrNIBBjZ3S4o4ZntNYTW5WixdQ6dggdI5/ewnT/j88ZrfaWwpMqq2G2M+uLW+whpqSru1n6vJAxUPpyLxZ0YSZj37uiJ8roGVIkeVYbWCVyY0qZnjZUv6k6gCdkYUViAyvsYNU3zL8f+R76FbhXddoP+Dzd7QSCnIdch3Zxk5rVa+PJdOXxaF26LfUI8XY7iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Fq13oMkLNwjGIm5ZVvD9vTByMNhMcQENm/1YSnUjJM0=; b=q7CYtz/QBuQ33pd/M883byqfjWiJwZka6JZX0icIgt6odTU0tae4DtubbQIbiMCxSy7Z65Qcda/enkQVkyRJW+f/MYTCc3vcMY3g0QoAEw5LHBfjU0CPAA4XUglxgn5QQ0+tRgZyf9bXZwv4caFJhHjacnoN2LGmFuvyiRyUkX/l6Hm3IWwYPoQX4d4zvVq48+bNcdVhDj9PV2/QfuwdKExD7DtDiVdmGddhWlCSOeWhugXYsk0jSNwz7uE3yRQIHEyYg2VfLLOlkRmQNdROZfcmk9g5drXnLmLlUwg08UA4r2oLAKlFh9jyKIGoYz27r1wPAdAILikgK8FXZGOE3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Fq13oMkLNwjGIm5ZVvD9vTByMNhMcQENm/1YSnUjJM0=; b=gdWsltSjGxdLUmjTZaGDkwAg2MDAIM7UTkbRjVnbpKFj09idh3RRO7+Fgo7hAndJZMZwSn+cHuBEbAq4brcmbXvbilaFbIQESygSMMKe6Bfjeti48BvPQN5PoDvQb0PQYMSCOTpWMZUndUsgTyed030GISNFLQT6xtRGuXOu04s= Received: from PH0PR10MB5777.namprd10.prod.outlook.com (2603:10b6:510:128::16) by SN4PR10MB5655.namprd10.prod.outlook.com (2603:10b6:806:20e::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8377.22; Mon, 27 Jan 2025 17:54:33 +0000 Received: from PH0PR10MB5777.namprd10.prod.outlook.com ([fe80::75a8:21cc:f343:f68c]) by PH0PR10MB5777.namprd10.prod.outlook.com ([fe80::75a8:21cc:f343:f68c%4]) with mapi id 15.20.8377.021; Mon, 27 Jan 2025 17:54:33 +0000 Date: Mon, 27 Jan 2025 12:54:18 -0500 From: "Liam R. Howlett" To: Matthew Wilcox Cc: Andrew Morton , maple-tree@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Oleg Nesterov , Masami Hiramatsu , Jann Horn , Lorenzo Stoakes , Peter Zijlstra , Michal Hocko , Peng Zhang Subject: Re: [PATCH v2] kernel: Be more careful about dup_mmap() failures and uprobe registering Message-ID: <3zg7e6dyu2mbugguwtzlobwavhtgjw2zk7jo7eqzbqhpqxjxnz@nxokogoh7dtm> Mail-Followup-To: "Liam R. Howlett" , Matthew Wilcox , Andrew Morton , maple-tree@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Oleg Nesterov , Masami Hiramatsu , Jann Horn , Lorenzo Stoakes , Peter Zijlstra , Michal Hocko , Peng Zhang References: <20250127170221.1761366-1-Liam.Howlett@oracle.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20240425 X-ClientProxiedBy: YT1P288CA0022.CANP288.PROD.OUTLOOK.COM (2603:10b6:b01::35) To PH0PR10MB5777.namprd10.prod.outlook.com (2603:10b6:510:128::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR10MB5777:EE_|SN4PR10MB5655:EE_ X-MS-Office365-Filtering-Correlation-Id: 2e8073f6-7150-493e-f9f8-08dd3efba7fb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|366016|376014|1800799024|13003099007|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?mAnrLwomKaMtPCx1pr5+sdCL6vxpxatL3SB9KxjmZL/ax4KmAMSKVu77XaSB?= =?us-ascii?Q?MMgvYvb9mlnDwJzHe2bEvyquhf8TlljIpNVm4QqWFfawIf43m1VrCm44Z+uO?= =?us-ascii?Q?Y7l/eM4wOgABUxUuldFYl0HB2cGHVC7LcHap0D+0SsjJZN0wOKzF0ikhZ9Kh?= =?us-ascii?Q?DzIs30JCmfZ8RzJRV0uB5igfNAiwUDLhenOVgVO7889ee5x+lhoRY7ZpwHBd?= =?us-ascii?Q?goWlO7qR3/ZMGxTRp9cuPXLLypaH3Wp5aEe+bJOXRjgKhPo4/ZytbW6puH8W?= =?us-ascii?Q?Ak1QPpxiZOgsdzRPCTFqnwdt7N3pwCwo4HdJylvg2kHkzcDKrjvKd3yK0fRh?= =?us-ascii?Q?DPI/H3tH6Y67fOw9Fn7q3yL6PbEEfi1nNqZnkVV4XSgCDdFHBLgtHG0dxhJ4?= =?us-ascii?Q?K+0p4tOLsaA+FoahHfRRqv6cXANwpgwMPY7Omp9k9/IJeJ21YmOcyPhZRoMi?= =?us-ascii?Q?S51UvxQCoqsBn3t0y14w8BWFHVQ02Tw6JNPlLeelJx8+CPQEkDN7jFcmg8We?= =?us-ascii?Q?gQRnaHiC8AeAWVI/aOaYNjtXCiIWYDXF+7Eu2WcktDU2z3JJCiYwL3OEVqyt?= =?us-ascii?Q?f+zjtA4cD/zQZ51yPAUQMWRnGcDRAuRUW5sUy820yk1b6Q9bEPdwG63MLFzY?= =?us-ascii?Q?nIQBh7YuzC//0UMuL4wrT3LKLF6s2jHh0UHj2/EE83ZmoU9c2bZzNrOKDq6p?= =?us-ascii?Q?oJz4aTZhGegg6NzmaMVdyfWfD2pCWgvW0SQTg8ti5sEJW1f6uYsYCAk1Qsbb?= =?us-ascii?Q?JYJQ3a5jvBKlmNE8C1Yvcvn65zCtfhzhcNOmvGMwI3/ITfcdz0hxenWIgFXv?= =?us-ascii?Q?X8/t3afWPclfUJhFl2WycoCGir0SzwvvoZwoS/VblTwni79HuVcapLOCVeBt?= =?us-ascii?Q?uJIqGO9MLmOul6GwCSJdZqg9MimVhM5dz679V0LavJQlwcllKJNJYKOUGUJD?= =?us-ascii?Q?sA9QpAv5vjfW54mCr3Id/o46bDm+6Haf/dX1545jL/S1LksK8zLh+OV4ur04?= =?us-ascii?Q?FChtENBMtKMoI7/H5hx/Z0om18rdktUeuEFn7rJSd1KOBvat3PmJ6JBJAA49?= =?us-ascii?Q?Qu0nyQ7WJge7ik4m3iyZDZ0/6niy7wb3GPHijuIPSsbEPpHmVCb2NvwBx2eK?= =?us-ascii?Q?XspPria6PwsBQlMGNApXlIAWCxVjeHSNmCrvPrL+pwBxYqezyFQ2hKwNpqnm?= =?us-ascii?Q?kspPG8z3A01P74JKPM4sG3XxwjI59fPFfcL2vL1BVUI02QYZH/rG5ZyaQmPn?= =?us-ascii?Q?Q3IIyVzLAK6Fl7pcW4AzzkvIQFdJbT5bA+bxfeuuo595GrMzE1FAXskSdmqb?= =?us-ascii?Q?8x/NNsyqNTtB1GrIIp9fiwS79/G9Wj84zTgzssWMPiekSw=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR10MB5777.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(366016)(376014)(1800799024)(13003099007)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?L+siUlVMgj9xGwTJ5O49U2D5W43JtHvOsm9S9nnzqPuomuTO086pR3HM5bBW?= =?us-ascii?Q?xbS37NCQncuDrCuYqv25VW/4hTe03vSjkJ4NquvR0RfK/DPMgjv77b6rTK4/?= =?us-ascii?Q?iv+mWp2JiqM25VlOZc5z6kHbpY5oXplgadLs+vSDiNJbwLZTjsVhfdt07SyE?= =?us-ascii?Q?iyePrhPiQaYbF3yE+NzsFogtgS8pu670g8QyoLBBfG0xKnS9hZk4C1A/2F67?= =?us-ascii?Q?wgFc72Bs0jyTGWBqcSoCe8BJBXWLC1Y6aI6GC4yMLIiKSbJMSoYuRKFnfs4y?= =?us-ascii?Q?5uQW1TFsYS3t5ksNO830UHKcmpm7lbvzJYJsvIyMJx01GIUautRBiXCEV13b?= =?us-ascii?Q?sBt6SyrRuIrXYWrfEwr5yzYozidyUeqV6AEB6pptZLioj1YQtUAcXry7q7BY?= =?us-ascii?Q?6rsoPKPlLNq57Lq+LUfIAVvxIIgSEVFRfZENO23iSaHuAhY8vuTaNSJcRITM?= =?us-ascii?Q?TvcmPJYrH+MlmuErf5q+5z5ShwRQQ/a7zMW4+Q7fBUFirFoZYIXo8d6jeI4L?= =?us-ascii?Q?6s3bXiz0svdbCawZ2Di+cJ3z1OR0E4UuabeQWrKYhTItQNdOgodiIjYSa9PN?= =?us-ascii?Q?+qft2QADw83WUrlrK9h7asdYNY7njUU34HhoVaVNL6zAIYGSNi5eMr6rW+A3?= =?us-ascii?Q?VDXynvcfQL+Xs1GymxPFEEjotgby+2O/F/C1f5qaWL3hknC1fYckYDBrYZAS?= =?us-ascii?Q?ub9LBpwqBnf4FxpCq7m44/fQkPCZdrHRV+uC1h0BsOBYSbmmVEPTkmeoRI9Q?= =?us-ascii?Q?wTrcQoWjfLRUrcYBgZlaR/RM8ebmLP+6HY9VIY+Zx9TQBAkC1FK4/TX9bZSd?= =?us-ascii?Q?KaUK34AAQmL58XQsvLR/Xv+yNZcBDtm3CGeI0t+YUJp3cs8YVZ7ile87wA9l?= =?us-ascii?Q?hmyb0o0m98ZyIwA2LwPhrA/PCmLQefo4NPLVVV+xJQtTAUI1UfUkO4P4xx12?= =?us-ascii?Q?DY+cVQdD0pHuHToP/tph1Je7Q+hYSAwGYyXDntXeUKJUxtYlwnaqPdF9xydb?= =?us-ascii?Q?5BI4B3KTEZ4AervnA0h7cueFb+Y68tBz/2jb3UimmZISJz/nqbA2uZ35lMtM?= =?us-ascii?Q?G8IOTtvhq/Vp8a4Vvsezll+/NnPaV/xW94Z/N7obBxleJlnh06AxuOQfYmPp?= =?us-ascii?Q?KpIHsY9U2gSyYNosqwzgwnY1oIemVmG/7mPaxc13DaZbhCXwh9KfCdInrZjB?= =?us-ascii?Q?O9kliaqHirhaInm0gW2+GvLX+QwEEAuLg5AEpLrwL+8KK5o7cLPoglEEQnI6?= =?us-ascii?Q?8D3yIjZaFZ3vkwfrI455lTd1/XeO53TgrVJQiWSxHpWQJCEvYTmbB4LdiJLQ?= =?us-ascii?Q?Rh/LOQs1PfMXjx3B0e/Lj5FJGJYAMHHLQaQb7Mo43bBtDJkKHRMZrDufQr/H?= =?us-ascii?Q?RZxGa4B6e8OIF/3oe6dRlTiEKT1FeYPicbWz9xvzn36vKnWepyiiVdgyXefW?= =?us-ascii?Q?hFMvK1wWs5TkTfavtEskljWg6LvZQ1ommrhZ/M/x0T3sh2b96syU1sLbVjKT?= =?us-ascii?Q?LvgxKKqzKEOBS6fVOX3prwSty3lAeWyWUM9QcanIw6n7KsTdGjJ6EzmEYM3K?= =?us-ascii?Q?twH/IQm9mTzE4ESEOUDZMokHkf1HWhq9oBZ9YfSM?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: QSDZ14GVDxVf7Fpm1iYKs8a1LHV+NSofclyU7aPMNFng5Z3ba0PzhA1C+9sf8SOWDP07hRxnYw12NBYOBaoAU6ZY5D3AMLx1BT7+1oHLAEOg/ERY4BN+Rurg/OBXdsxxN87XXGdLniBAffQ6j+BsvLAucMoVVDMHOjRblMnj7K+dtIjtVlV394F3GxogmA9yOcR9fLYlf4uYA7qMVapgUYytNvcWopq7Kdrbl3mD+iTofZFqZjL713FQe52xdT5ZwYOICFc6hw7uq75hp5jaSzy5B2VUkmSqr7QXpk1Dk/XMmz0+8ttUNfVARz0s4piH6iVXCFPnyVoKmXFCiN3L8UDJEi7VGhEV2x1um+qRCPuN7UyvTxGReqQ3wxWGDo4o0evndH0uEdaVhFjUQi6CvjV+YDg0Z3bslA6yGl79udyUmA4ACltLuk75r2n7bh278kvEUjwOL3S1XaxbEfvSz3u9aSes5vaycw35BSAkTmS8BgdcdD+RZS3HNYmNnON1bzjGCwmYlQiDgN7k0ebGrswZQIW7CSGJdGojWrab7AOWXTUZ5BqFXNXheOYVbb+NIOtAZ6LPTlYqf2siqWaah6VpVDND/JgYWHezaWF2qOQ= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2e8073f6-7150-493e-f9f8-08dd3efba7fb X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB5777.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2025 17:54:33.4019 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: H666PhPvp6hcJVl05710TeGTzBNB20yXNVQYclT8bmwgEPv9RbtTkqg6hS+1fMrMtXqt93ULIA2b4O7zHUD4ZA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR10MB5655 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-01-27_08,2025-01-27_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxscore=0 adultscore=0 malwarescore=0 spamscore=0 bulkscore=0 mlxlogscore=999 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2411120000 definitions=main-2501270141 X-Proofpoint-GUID: lYi79qUqEJs9lQyuucr_rf2bvdXlAs2n X-Proofpoint-ORIG-GUID: lYi79qUqEJs9lQyuucr_rf2bvdXlAs2n X-Stat-Signature: mokc33f8eqwrqo6yafc9fi7mikywhoob X-Rspam-User: X-Rspamd-Queue-Id: 165F040011 X-Rspamd-Server: rspam03 X-HE-Tag: 1738000497-159470 X-HE-Meta: U2FsdGVkX1+1Hf30I1xpYJ4BUt5S7SMENBHgiiYfMIOGXpt2BfvfNOTnsWzRNGY+iwg/Sxirmoj6MhuKvZqqEdBTNPx4UaQ02aIuRWkoanbs6sOPZdg9/aagXq7Lh+/w933E8IkbmmuoOzh/pga9Zrnd18ZBXkkvu2+zsN1bSWuIGRU9+fEJ2vU02SwngEYKSUFSUJFaq/MVTH3cWCUY5ZP7y5IDq1cpYNkSxmdeDY5A0ODxIZJ5uo6kjY8Z+1FIIvMxPO1azxpmNgAeNH0RVI3f00ocHijgIBg5Q8bMN1vWHHs9FRZV8e8jnMzJR/tzRqU+zh8FIYXXGTR0hVv3b0mPWlLa0IS198InZKopy463Ir51kFhQ4pSzvC3j9rFnijXEjLH6LBW7qxeEyRy2oA93m+r3tDQRZvBeYQ9bypX6WR+QhoeeuVvKG40Q0Vs5qxd/R4FIXWDtbTZQDOZWWDf3jHOP8oxZI/nebucdB8+b0l34HO01WwAuwpp5TlTlW07bKWL/liyJk4FsZBQBLg1uAoui9lEXFIJFYpS9SZPaA/EvzlZyScsWl+trsOBnVtqS2EI0P40pO+DuM/p5O4f7B9eKh62QYcrBwlxIf8hW1k30t1P8wBNKmHPXCDEqpHtfR/4vPfjY6agqQU2zQNQS/ryOsgLZgxTnp1+2fHG27297Nt6YjpCqwBASiZfbr1iCrN426gbVZe9qhNBV5wSy4qwkDS1RvEjRHpZojxE95szdpiqP+lDdkE7BYx6x7Ic4Ti5/VPMesmgEXTbmtvUT0fM1Om/bI8keGgMx0xtDb8lX5CG+w6E8cbvAmvE9IhaKqkyQW+0T4d3dI3+bXjHVUJm5aOdYShyY+FDW7fBdNs56suAxzNR04Qil9iI2E0HtQ6Q6ONcQ/NsRuGb4BU2AJjaY9f2oa5Ej+qqbZWWl+rfzr0s772CsuzJPMnpitTuQDsfLD4m5Xd0JYAZ i45O5OCq be+A/F7Bb7OVxOc/vo6MugHfRzosTop6j9MEWdR88CoVQp4ZZE/VTOQLpdyYuzsFa6ab1Rx3PO4ZWitvJQG1UwTUrubHfJitWLWnptIvE7kCjl5H/VmGDE/oJ90IQ26ZV8QiGmROqIdtZqdHCGH2MPEz1QiK4Nife5jKomVtrz8+plL9qegS1EtiHITujE06QcrR4WFws2U9C5fZatsjDw2HCeEBO0zHw0VcHTy/kJUVOrZV5ydxX9v81lUUFBy0zrV2S9//nNVcyTAK/8nzOaXle0DHWVq8nJ5jOIqCV7hOXKQAtW6burD4zidPe80H5rtGtk2P7nvzHXYRjinb3Oi6Rrzd5FpOnDRZGcyrVLKbsX5daheIzpmbICw3TAAyYerx59aosO098Gcv1XlE2ARexn1AH1MFWHrAlbx79xsOSl+rIGmuwUZC1c2ZvcqMzOcJkiuaf/86phF2r9k/nc0N9svA9v1GcgypIKdkGzGSLoxax3lIp8jtexobUqt9GtKZJishh3Z/rQ9bY+4tP/lLwoN3WIzrM2jnUBNoYMUswJVP0iK12oZ35CvL/fAW6KFdsT8KYZ4ikY7+iAEPCyy2BfEzGBeREHOoMY6+u/wXrEAiS9Pl7OF4NRRpS6+xHvmlMNO55Q3H4YZnpMyBs31f9Rx3iicIMmORyYr5KMKjdZXrVkYma/iMdZ8PHG3Pyg8ekpi9ZoQlpkKtgEE+/SFLRYHf1reMjOX1yaiLb6xQLmzm4WoMqLBA3sta/lmCSJZHmTN7hPwQAmFN36LgZF7s4INOXMvKLjVeaEM4YJIaR5YXq4/rCOFk65lcH5JXzpQPn9d5M29YkhgS0Cpdlsb2fYQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: * Matthew Wilcox [250127 12:08]: > On Mon, Jan 27, 2025 at 12:02:21PM -0500, Liam R. Howlett wrote: > > From: "Liam R. Howlett" > > > > In the even that there is a failure during dup_mmap(), the maple tree > > "event". Although the writing is a little clumsy here. You could just > say "If there is a failure". Thanks. > But that begs the question of what kind of > failure, and I think it's only a memory allocation failure? So you > could say > > "If a memory allocation fails during dup_mmap()," The problem that syzbot found is an allocation failure, but I didn't want to say that's the only possible failure that could cause the duplication to fail. Looking at the code, we could also hit this issue with a fatal signal. If the return isn't zero, the mm will be marked as unstable. If we fail in the loop across the vmas, then we also set the OOM skip bit as the oom iterator may not be safe. > > > can be left in an unsafe state for other iterators besides the exit > > path. All the locks are dropped before the exit_mmap() call (in > > mm/mmap.c), but the incomplete mm_struct can be reached through (at > > least) the rmap finding the vmas which have a pointer back to the > > mm_struct. > > > > Up to this point, there have been no issues with being able to find an > > mm_struct that was only partially initialised. Syzbot was able to make > > the incomplete mm_struct fail with recent forking changes, so it has > > been proven unsafe to use the mm_struct that hasn't been initialised, as > > referenced in the link below. > > > > Although 8ac662f5da19f ("fork: avoid inappropriate uprobe access to > > invalid mm") fixed the uprobe access, it does not completely remove the > > race. > > > > This patch sets the MMF_OOM_SKIP to avoid the iteration of the vmas on > > the oom side (even though this is extremely unlikely to be selected as > > an oom victim in the race window), and sets MMF_UNSTABLE to avoid other > > potential users from using a partially initialised mm_struct. > > > > When registering vmas for uprobe, skip the vmas in an mm that is marked > > unstable. Modifying a vma in an unstable mm may cause issues if the mm > > isn't fully initialised. > > > > Link: https://lore.kernel.org/all/6756d273.050a0220.2477f.003d.GAE@google.com/ > > Fixes: d240629148377 ("fork: use __mt_dup() to duplicate maple tree in dup_mmap()") > > Cc: Oleg Nesterov > > Cc: Masami Hiramatsu > > Cc: Jann Horn > > Cc: Lorenzo Stoakes > > Cc: Peter Zijlstra > > Cc: Michal Hocko > > Cc: Peng Zhang > > Signed-off-by: Liam R. Howlett > > --- > > > > v1: https://lore.kernel.org/all/20250123205849.793810-1-Liam.Howlett@oracle.com/ > > > > Changes since: > > v1 > > - Added check_stable_address_space() to uprobe code - Thanks Lorenzo > > - Added Oleg & Masami to Cc list. > > > > kernel/events/uprobes.c | 4 ++++ > > kernel/fork.c | 17 ++++++++++++++--- > > 2 files changed, 18 insertions(+), 3 deletions(-) > > > > diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c > > index fa04b14a7d723..90ebcdbad05ca 100644 > > --- a/kernel/events/uprobes.c > > +++ b/kernel/events/uprobes.c > > @@ -28,6 +28,7 @@ > > #include > > #include > > #include > > +#include /* check_stable_address_space */ > > > > #include > > > > @@ -1260,6 +1261,9 @@ register_for_each_vma(struct uprobe *uprobe, struct uprobe_consumer *new) > > * returns NULL in find_active_uprobe_rcu(). > > */ > > mmap_write_lock(mm); > > + if (check_stable_address_space(mm)) > > + goto unlock; > > + > > vma = find_vma(mm, info->vaddr); > > if (!vma || !valid_vma(vma, is_register) || > > file_inode(vma->vm_file) != uprobe->inode) > > diff --git a/kernel/fork.c b/kernel/fork.c > > index ded49f18cd95c..20b2120f019ca 100644 > > --- a/kernel/fork.c > > +++ b/kernel/fork.c > > @@ -760,7 +760,8 @@ static __latent_entropy int dup_mmap(struct mm_struct *mm, > > mt_set_in_rcu(vmi.mas.tree); > > ksm_fork(mm, oldmm); > > khugepaged_fork(mm, oldmm); > > - } else if (mpnt) { > > + } else { > > + > > /* > > * The entire maple tree has already been duplicated. If the > > * mmap duplication fails, mark the failure point with > > @@ -768,8 +769,18 @@ static __latent_entropy int dup_mmap(struct mm_struct *mm, > > * stop releasing VMAs that have not been duplicated after this > > * point. > > */ > > - mas_set_range(&vmi.mas, mpnt->vm_start, mpnt->vm_end - 1); > > - mas_store(&vmi.mas, XA_ZERO_ENTRY); > > + if (mpnt) { > > + mas_set_range(&vmi.mas, mpnt->vm_start, mpnt->vm_end - 1); > > + mas_store(&vmi.mas, XA_ZERO_ENTRY); > > + /* Avoid OOM iterating a broken tree */ > > + set_bit(MMF_OOM_SKIP, &mm->flags); > > + } > > + /* > > + * The mm_struct is going to exit, but the locks will be dropped > > + * first. Set the mm_struct as unstable is advisable as it is > > + * not fully initialised. > > + */ > > + set_bit(MMF_UNSTABLE, &mm->flags); > > } > > out: > > mmap_write_unlock(mm); > > -- > > 2.43.0 > > > > > > -- > > maple-tree mailing list > > maple-tree@lists.infradead.org > > https://lists.infradead.org/mailman/listinfo/maple-tree > > -- > maple-tree mailing list > maple-tree@lists.infradead.org > https://lists.infradead.org/mailman/listinfo/maple-tree