From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2566C4829D for ; Tue, 13 Feb 2024 02:09:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 553086B007D; Mon, 12 Feb 2024 21:09:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4DC536B007E; Mon, 12 Feb 2024 21:09:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 37D0D6B0080; Mon, 12 Feb 2024 21:09:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2239A6B007D for ; Mon, 12 Feb 2024 21:09:03 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C2B1914067C for ; Tue, 13 Feb 2024 02:09:02 +0000 (UTC) X-FDA: 81785147724.09.99F5083 Received: from out-172.mta1.migadu.com (out-172.mta1.migadu.com [95.215.58.172]) by imf13.hostedemail.com (Postfix) with ESMTP id C596B20005 for ; Tue, 13 Feb 2024 02:09:00 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=jB3cf+to; spf=pass (imf13.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.172 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707790141; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lKnD7PD7vHFoDrdYFBy0aSAjzzsTiox2zmAp9jUaeUo=; b=QLo0ZYeLmzJpsHhSvS3mxAs6jTzTR86/8m6ORk89wNj0daPERV0SezprpDWmge/xYgBJsK OD3Cy9pmnEf1fBHGEgSmz1Z1IrbcjPG/lURwRhvNMPgpnqm6SNSprEUP32AwT+4SMKBEN4 wTpN7vuHGF0vJCvDqTNAWwijMD6kcnE= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=jB3cf+to; spf=pass (imf13.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.172 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707790141; a=rsa-sha256; cv=none; b=d2VKSjGxmdtMsJsDLaiqWKOILt2h1bwYEPynHA6LN/0oPUAwgkUYAGyybsjK444ps+1k3/ 7f1wJsI8lYvZR0L1Nm6W1YkUmhhnNqocFkuMkwmoy2EBAeF7lk5ouJRtIYjytIif5VDTob Yhe+73HlK9xhCKsoM+IjbG7sNP2WMxg= Date: Mon, 12 Feb 2024 21:08:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1707790138; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lKnD7PD7vHFoDrdYFBy0aSAjzzsTiox2zmAp9jUaeUo=; b=jB3cf+toUIgh4WRnofpxNLsUtSjV8FWhNPjGE3TxFN2aHuUKMaKW/k/FKCrg95huIAE8vg 1DptOGDgE4p5+0wKKAn7cUzEeup1I6Bd7OUmai5FE8zZTqtIOX58n58fV16NjN6wT+pgxg zhmNnkLjJoV7XN2H1w2Kx2/R/EABNYg= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Kees Cook Cc: Suren Baghdasaryan , akpm@linux-foundation.org, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Subject: Re: [PATCH v3 23/35] mm/slub: Mark slab_free_freelist_hook() __always_inline Message-ID: <3xhfgmrlktq55aggiy2beupy6hby33voxl65hqqxz55tivdbbi@j66oaehpauhz> References: <20240212213922.783301-1-surenb@google.com> <20240212213922.783301-24-surenb@google.com> <202402121631.5954CFB@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202402121631.5954CFB@keescook> X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: C596B20005 X-Rspam-User: X-Stat-Signature: xtbft7ceg9ieginxpgja6sxz6zbedtfc X-Rspamd-Server: rspam01 X-HE-Tag: 1707790140-781779 X-HE-Meta: U2FsdGVkX1/v1W3PFrlr1HhdpTyIHFJmiuWrfM/EyGjuyZdRJahXBkLqwt3yBwd6TtXk21Jz6npqA/H67Gc4HV0ACeohgR/5o+gBmDI8itmEDZXY9KfMA927tK6kg/wiX0byk+gyI35hd1rbFE0cof/dyOVaTXkKHHnCo6Rklofa0PkmdlfjNbnMDsHl7grIxjY8XIIwlMa+5IMvnvrMxfnOWNhk2MxzowST7H+itA9R0ZOYyHTGxrAqdVO/1XfqRA+x+I8Q1qpHbmwje6db9bQEBcmvt/5C2lGMbNfN6IIQDe6vqUMqSP26J9qf/trQgsw/kpiH9LumqagqsZsGP7FSxW0YgK1CFPa7Fvmb3F3pgb55QRTu/D8aA6dqG6LEiWuxaUGReuPZx9EDKowoQe/qtFBXTcc4F+HcURGdwdcfcnpNJu4OBzdpn5knpEzbINMf6ikhNxcVUtOeWVagzkM7n2wnd9Ss8OiTTX4ZKT/wwoEntESdPLidOScYhQQoq0suNDzISQmv83+gr1mnN9KgS0uojFd/kWrELHIbugaF1A80p2ffyJvQhqn4KA5PiYk+kDTfwsA1DIXGN9yHdXNSvBCHDlvvsxU6Fftf8NneYHelssRVz2anh3ip8o7qanRl96CWOdk/M7uGxhIaVHGFOoxKVyRCaOtDZCFNK2HmoLs1RHmDjvUV69HtX6FZ31wMx+C08UDQ2EHuuXS8ZBY0SqQ3cdQy8om8H5/i9d6G+3i9vHCgI8dsfRHXTlD9AvqoTkolBWa2QhQC6C9c2dVXMzyDwdPGpz36Gym0GExBOZAGYk5w2KxR8iR9KhdHeT/Z1gN6FH6FcqckFGOUddmSUfJ+/rXbLb3NXh3uftHLdaq1TBmzRI4nibFlTzu0hytb68gZQ8kmjLVFleaSS0jjoaopnkBaFYknqNZgszCF5kM8UX3zEw9mGz0+PzdNVKoul6sPTXlXO47xuqs D5ubal9Y bhSZNmLyOQAxWHt5sPUuGzPW1h9LtVviZ3etBX+BWudz90d+WP17qf406fK6wI+dg5gP8fGhWWh2kcOKUNmworpCo218al/5gM+ezEIgccL2sMzTDzLJrdcVCeKiR7TpNrLCqlo/xj5MN2ODMUX+tJonDpvP2Cctqlz3tfI0g50RdA/PLLdWL4OcuD/khjlWdtNbd7h4+rFoW0sY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 12, 2024 at 04:31:14PM -0800, Kees Cook wrote: > On Mon, Feb 12, 2024 at 01:39:09PM -0800, Suren Baghdasaryan wrote: > > From: Kent Overstreet > > > > It seems we need to be more forceful with the compiler on this one. > > Sure, but why? Wasn't getting inlined without it, and that's one we do want inlined - it's only called in one place.