From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D86E1C48291 for ; Mon, 5 Feb 2024 11:51:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4404F6B0072; Mon, 5 Feb 2024 06:51:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3EFC26B0074; Mon, 5 Feb 2024 06:51:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2DF2A6B007B; Mon, 5 Feb 2024 06:51:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 1B78C6B0072 for ; Mon, 5 Feb 2024 06:51:10 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 85F8B80A2F for ; Mon, 5 Feb 2024 11:51:09 +0000 (UTC) X-FDA: 81757584258.24.1DB8B6A Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf02.hostedemail.com (Postfix) with ESMTP id C349F8001A for ; Mon, 5 Feb 2024 11:51:07 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=iR5MGOuB; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf02.hostedemail.com: domain of cem@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cem@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707133867; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KirdE+OR9rAOUDaYZBLJZC8GCkto4l1vvaQr50l2vFk=; b=eEO5Y8I/XCyoJhglmv0gqcYY27BlA0O7hF8EL2LhUVa9QLSSfiGoG8Z248TJtrHri2fklE zMRvorD1Es5tndDxKENcsKJxYmd5uKuYQSn8C6QhSHNMnaaoo44qqNZA70R/VNtXxr6WxU 4aD1b/EmCeihLjYhB1/frK5xdPbcDVQ= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=iR5MGOuB; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf02.hostedemail.com: domain of cem@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cem@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707133867; a=rsa-sha256; cv=none; b=Y0AFZPTnplch6bc+vR1Ju19jSxnk62u/Erkd3uOuSDVqnq2X0BrQnGCiUE/xK0SiehqPc0 EmGj3bcYwXxrV9O8eN7b5/HRHQFZ7Jek0cv0c+FaXK2esKssHRbbDT70AEbcbArufkIjdy G2mSrcZBMu+rlOxlpo8t0joXhYA3MGE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id CAE2A60FE8; Mon, 5 Feb 2024 11:51:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 804E1C433C7; Mon, 5 Feb 2024 11:51:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707133866; bh=RsKiX6stsBUz6etEeQ7nCiTonNqjthkxqp3onyO3J+Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iR5MGOuBtwjZgq63vcx2hhWX4w3r+FGePH6bHc/JbvXPdV82I6val1bWU+v3JLAQI KnHHAUdEb4HvgQ2n02lrLAsXIMKdi1TV5wRiRYzqHyMo0bI2vbhZ4sBKY0ud4leziV rBloIKg4aGmf4qvrOMDPuMd+3y2DpDRfT26dinmzOVFWozwXk/9qbOWnx5fsz/nds6 fONQUMQ5fG4/tze+QgIBA1ATB1fDzQWELEH5IutNvKaOJBnd7jVz9YPT02AyHsba6z ibN1KSGHbZTY2X8IPZL+kY6Q0+60DwmUEUKGmazxEXhC7YYlDaRTD35V+fA7BUGM7Q qMbK8oV5WX8EQ== Date: Mon, 5 Feb 2024 12:51:02 +0100 From: Carlos Maiolino To: Jan Kara Cc: Hugh Dickins , linux-mm@kvack.org Subject: Re: [PATCH] shmem: Properly report quota mount options Message-ID: <3uyerhrmrt2hqaq6j44aiefatlf6iitnh3eqgmonaahy22twa4@rqf6wj3yvfle> References: <20240129120131.21145-1-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240129120131.21145-1-jack@suse.cz> X-Rspamd-Queue-Id: C349F8001A X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 8s159j1fy1izs17k5mfsgytof1ih8y6u X-HE-Tag: 1707133867-15468 X-HE-Meta: U2FsdGVkX1+9aTpIXsvO1OtLtR6/8qT/Xq8Wl7OpWuPI1gtBhhJ6ElauJvMQm71YY3i/5wGtnlO4pQ7Ids7ikBFndhyhnykw9SbigLkikCU0rEt9j8L9AQm8FZ/DVgJp3ppNkUdWpWqLexxE9cEvSXHGadD616+5K8qjt/NhhpN+MCvhE1uLwSUqne92TByeHK71igeeNFqN3ivVCtoN6Com6UzC0WKO60wbR33pi/w2WcpC4yz2coqHgNq1cdSDbtInawLW3bRIpmlyHIApmo/uzxgL0oop6PASUvbq+P7jO1Jl2h+CnVFJDP7RQvlFWnOgCMu0Uzsm5m4FkBb1bqZcRtlWXKyL9oWoet5f4qvAmEXq/aQWQNq3kIgrN7bBNDGzUGvz4I/EzLOITsYPmaWZ5afMNoEuWcgyFQI8liqBG9POAfvgPWrig+f/VQYmi1lZd4j5w/GYrYKZtRCZWBRawwOshVFnCYq1/zI3RjadLFM3LGeJGTOhOTQ+wKWhChdqzOpKBJDFelx2Aok5KKOudPaEMJvUG8vkuwYFYyWdyeGayk2nvSRQYhkotkOfMMRp+a3hItIL2J3GuHivT9KZCPZ6ZeC5hOfNZRru42gN4truM971K8TpdiautrKcvjiCzL5LuyxTaYIPxgb97H8ZH2sdTxa2jfGuueFAtqACE3owEg+RmMnMsPhLd6k8RYOEpyt//DsKibtYZ9o92watO+Utt14zIhNqe1sP3cFrzxQseBfGzIOpgCYPR7aqfmGRxNODe2C7vb2NW2rDLhJ/LJHTcDWcUi+vGxlGUV+0SL9a1dm7gIv/VTrmlvpvzOWmNoKDnljzejWMpWaK4uzP9kACusXE14uRLH0zopkn3+ehxuIyRbCby+HY96vVlET1f7FElaFSmMo/Sy+gV7fwUU1Cv5DK2tTMgCo+jM54AM7TfyEzuMmLQ5sebRw5Xt/a+7BGZHlf0jQIKmK Lp3z5KDJ PhbYsmK0cvTTvz14Q07pVCHAaIcLsum2dDoxxy2CSd1La0ReFYFLAM3+a29fmTcEL1A3tQKVzFmcCskkgY2af6/7yO6pxi1QjUjy5+yZOBh3C/mGWtJVLW3qHD0vFf8358ZQ84mDqRLD06vJwwCQc9WWRxYJHTY80AK5j+uKEUz13dWnb6qP+/Tn3F3Ux3G98CxXm0l4BEVEF0u+l0a7BOkIvEg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 29, 2024 at 01:01:31PM +0100, Jan Kara wrote: > Report quota options among the set of mount options. This allows proper > user visibility into whether quotas are enabled or not. > > Fixes: e09764cff44b ("shmem: quota support") > Signed-off-by: Jan Kara > --- > mm/shmem.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > I've noticed this omission when testing quota-tools support for tmpfs... > > diff --git a/mm/shmem.c b/mm/shmem.c > index d7c84ff62186..30c9dc862505 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -4265,6 +4265,24 @@ static int shmem_show_options(struct seq_file *seq, struct dentry *root) > mpol_put(mpol); > if (sbinfo->noswap) > seq_printf(seq, ",noswap"); > +#ifdef CONFIG_TMPFS_QUOTA > + if (sb_has_quota_active(root->d_sb, USRQUOTA)) > + seq_printf(seq, ",usrquota"); > + if (sb_has_quota_active(root->d_sb, GRPQUOTA)) > + seq_printf(seq, ",grpquota"); > + if (sbinfo->qlimits.usrquota_bhardlimit) > + seq_printf(seq, ",usrquota_block_hardlimit=%lld", > + sbinfo->qlimits.usrquota_bhardlimit); > + if (sbinfo->qlimits.grpquota_bhardlimit) > + seq_printf(seq, ",grpquota_block_hardlimit=%lld", > + sbinfo->qlimits.grpquota_bhardlimit); > + if (sbinfo->qlimits.usrquota_ihardlimit) > + seq_printf(seq, ",usrquota_inode_hardlimit=%lld", > + sbinfo->qlimits.usrquota_ihardlimit); > + if (sbinfo->qlimits.grpquota_ihardlimit) > + seq_printf(seq, ",grpquota_inode_hardlimit=%lld", > + sbinfo->qlimits.grpquota_ihardlimit); > +#endif > return 0; >a } Looks good, thanks Honza. Reviewed-by: Carlos Maiolino > > -- > 2.35.3 >