linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Liam R. Howlett" <Liam.Howlett@oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, Vlastimil Babka <vbabka@suse.cz>,
	Matthew Wilcox <willy@infradead.org>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
	Eric Biederman <ebiederm@xmission.com>,
	Kees Cook <kees@kernel.org>,
	Suren Baghdasaryan <surenb@google.com>,
	SeongJae Park <sj@kernel.org>, Shuah Khan <shuah@kernel.org>,
	Brendan Higgins <brendanhiggins@google.com>,
	David Gow <davidgow@google.com>, Rae Moar <rmoar@google.com>
Subject: Re: [PATCH v2 0/7] Make core VMA operations internal and testable
Date: Thu, 11 Jul 2024 14:00:15 -0400	[thread overview]
Message-ID: <3sdist4b5ojz2iyatqgtngilrkudb63i7b6kp3aeeufl3vrnt6@p4icz5igbsix> (raw)
In-Reply-To: <20240710195408.c14d80b73e58af6b73be6376@linux-foundation.org>

* Andrew Morton <akpm@linux-foundation.org> [240710 22:54]:
> On Wed, 10 Jul 2024 20:32:05 +0100 Lorenzo Stoakes <lorenzo.stoakes@oracle.com> wrote:
> 
> > On Thu, Jul 04, 2024 at 08:27:55PM GMT, Lorenzo Stoakes wrote:
> > > There are a number of "core" VMA manipulation functions implemented in
> > > mm/mmap.c, notably those concerning VMA merging, splitting, modifying,
> > > expanding and shrinking, which logically don't belong there.
> > [snip]
> > 
> > Hi Andrew,
> > 
> > Wondering if we're good to look at this going to mm-unstable? As this has
> > had time to settle, and received R-b tags from Liam and Vlasta.
> > 
> > It'd be good to get it in, as it's kind of inviting merge conflicts
> > otherwise and be good to get some certainty as to ordering for instance
> > vs. Liam's upcoming MAP_FIXED series.
> > 
> > Also I have some further work I'd like to build on this :>)
> 
> It's really big and it's quite new and it's really late.  I think it best to await the
> next -rc cycle, see how much grief it all causes.

Yes, this patch set is huge.

It is, however, extremely necessary to get to the point where we can
test things better than full system tests (and then wait for a distro to
rebuild all their rpms and find a missed issue).  I know a lot of people
would rather see everything in a kunit test, but the reality is that, at
this level in the kernel, we cannot test as well as we can with the
userspace approach.

With the scope of the change, it will be a lot of work to develop in
parallel and rebase on top of the moving of this code.  I'm wondering if
you can provide some more information on your plan?  Will this be the
first series in your mm-unstable branch after the release? iow, should I
be developing on top of the code moving around for my future work?  I am
happy enough to rebase my in-flight MAP_FIXED patches on top of this set
if that helps things along.

Thanks,
Liam


  reply	other threads:[~2024-07-11 18:00 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-04 19:27 Lorenzo Stoakes
2024-07-04 19:27 ` [PATCH v2 1/7] userfaultfd: move core VMA manipulation logic to mm/userfaultfd.c Lorenzo Stoakes
2024-07-09 10:40   ` Vlastimil Babka
2024-07-09 14:14     ` Lorenzo Stoakes
2024-07-09 13:07   ` Liam R. Howlett
2024-07-04 19:27 ` [PATCH v2 2/7] mm: move vma_modify() and helpers to internal header Lorenzo Stoakes
2024-07-09 10:45   ` Vlastimil Babka
2024-07-09 13:09   ` Liam R. Howlett
2024-07-04 19:27 ` [PATCH v2 3/7] mm: move vma_shrink(), vma_expand() " Lorenzo Stoakes
2024-07-09 10:49   ` Vlastimil Babka
2024-07-04 19:27 ` [PATCH v2 4/7] mm: move internal core VMA manipulation functions to own file Lorenzo Stoakes
2024-07-09 11:09   ` Vlastimil Babka
2024-07-09 13:12   ` Liam R. Howlett
2024-07-04 19:28 ` [PATCH v2 5/7] MAINTAINERS: Add entry for new VMA files Lorenzo Stoakes
2024-07-09 11:11   ` Vlastimil Babka
2024-07-09 13:13   ` Liam R. Howlett
2024-07-04 19:28 ` [PATCH v2 6/7] tools: separate out shared radix-tree components Lorenzo Stoakes
2024-07-09 11:14   ` Vlastimil Babka
2024-07-09 13:13   ` Liam R. Howlett
2024-07-04 19:28 ` [PATCH v2 7/7] tools: add skeleton code for userland testing of VMA logic Lorenzo Stoakes
2024-07-05 18:28   ` SeongJae Park
2024-07-08 13:14     ` Lorenzo Stoakes
2024-07-09 11:29   ` Vlastimil Babka
2024-07-09 13:16   ` Liam R. Howlett
2024-07-10 19:32 ` [PATCH v2 0/7] Make core VMA operations internal and testable Lorenzo Stoakes
2024-07-11  2:54   ` Andrew Morton
2024-07-11 18:00     ` Liam R. Howlett [this message]
2024-07-19 10:52       ` Lorenzo Stoakes
2024-07-19 20:49         ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3sdist4b5ojz2iyatqgtngilrkudb63i7b6kp3aeeufl3vrnt6@p4icz5igbsix \
    --to=liam.howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=brauner@kernel.org \
    --cc=brendanhiggins@google.com \
    --cc=davidgow@google.com \
    --cc=ebiederm@xmission.com \
    --cc=jack@suse.cz \
    --cc=kees@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=rmoar@google.com \
    --cc=shuah@kernel.org \
    --cc=sj@kernel.org \
    --cc=surenb@google.com \
    --cc=vbabka@suse.cz \
    --cc=viro@zeniv.linux.org.uk \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox