From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33437C369BD for ; Tue, 15 Apr 2025 17:15:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D6F3B6B0005; Tue, 15 Apr 2025 13:15:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D1FCC6B0006; Tue, 15 Apr 2025 13:15:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AFB8B6B0007; Tue, 15 Apr 2025 13:15:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 815AC6B0005 for ; Tue, 15 Apr 2025 13:15:53 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 093A4AF851 for ; Tue, 15 Apr 2025 17:15:54 +0000 (UTC) X-FDA: 83336930628.22.1536B74 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) by imf28.hostedemail.com (Postfix) with ESMTP id 237B4C0003 for ; Tue, 15 Apr 2025 17:15:51 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=PeBguF2a; spf=pass (imf28.hostedemail.com: domain of mkoutny@suse.com designates 209.85.221.51 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744737352; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aCTIg/HVs2mq0xM+WgoXECviqWLvTa4bEgyDlcUjb5s=; b=SAV20a9ymuUGeiafQXwOO0lAsBImDlgwDkIu60mKvcSQFIsZ+J6rc5tyZW5wUkoKZ9CL0T xO90IZOSO55fw3/cyowv6xT8vUYH8K0BhSLxDsZbJgf2YNgVmeL1oRQPGq//BH5pTrGR8o EqhRysymih/O6HmvKKgNJQhOI6weKXg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744737352; a=rsa-sha256; cv=none; b=sFnVubbD5jkUvdLRAqw/TyaHziBS2AsIqpxrzYFkXewf++AGjSP/NMq1HpgmUxdxw5bBP3 cIQwpH6Njg4psRleMCEOcdHN59y0W6wl2F6JXsraWpD5DECLwU475R9L5cDPReaq/4W1dR tJRG8jUtDl/e+ICrrU+e+lwOUXC6ZcA= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=PeBguF2a; spf=pass (imf28.hostedemail.com: domain of mkoutny@suse.com designates 209.85.221.51 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-39c266c1389so4161228f8f.1 for ; Tue, 15 Apr 2025 10:15:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1744737350; x=1745342150; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=aCTIg/HVs2mq0xM+WgoXECviqWLvTa4bEgyDlcUjb5s=; b=PeBguF2aGyDtOeHSb9zHxs5hWkTqvdUwEoPtdTKOCwLROrwjiSSr+CNrBcREIJjTbA 0r5JHG4yXmwXwmlL47S9Sx2v3jD/itwa6VLjohSmPRutFrHobPZ7F1CKuCsxurH253KI oGo9GKgYmZM1eg1HG3y8xmwX6TNb2oSgiVMGxt9yqTbjPa0rn4tYpJe4CANLCaQa2aLC srIbTTJQq1Dnh5B64KjQyq+TDm4TObIVopERPgb6XPgSsPvooTWpcUdhwIDY6myCC1U/ uVDURQBK+M7nXhQqcwBf7pF4XDAWyfmI/AYMepZxgMSsQ9AmNORIxqOurGMxm+Jod1vE aEzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744737351; x=1745342151; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aCTIg/HVs2mq0xM+WgoXECviqWLvTa4bEgyDlcUjb5s=; b=sOnmfwrbwYHfAuBvy66MYrE3MgyGVq+Mjxa12uamJzENk8bp0r1n30rq2Gah2bnBMq J3Ul60pRrf1KnMa8bTe2pvZOdcd9On5PRJ+PsupFxzDqyu9wlJGTZLDHclK0eMi/iqDo Ulw8RDwaN2+N51JYvHnZ0QmlMTA0P65A56U7vephz1ScdkAxoCy+FuVGFpYjOJC3AlIi BwxoKbtSjtrLfVQXgvjAxjP+DjHwNwfdJCQ5XQoTciQNqiMBiO1MPrWzPuRFJmHpmL0/ jgmuNFez7JBfB8Gcj3OmeI+9IY30Ms3eadGtrajdMtrexYmK+wriwbaLZqeU/K/s23LI zGsA== X-Forwarded-Encrypted: i=1; AJvYcCUp2jBun/yci1iQko5XM+sYuy1cQTmLfxDbwTWVbC/2UpFyjBsxk3inVTLE7mk3hsHVrqPm7CEiwA==@kvack.org X-Gm-Message-State: AOJu0YzI498wkEyKZkN3RvMgMfEur0Wxw7hZXSihV00OOQhCzKwiLT42 /vyMAFYOnn2GkI2cRb4WYcFK71ot4Sz7wA+TXxoqH2bEFS4zwoaCqxLtBko4HzM= X-Gm-Gg: ASbGncuSiR0yhnFd0Aq7zfE92k6Hoa9eM06PDpRXuSf3ljh9CNjDR8ysRkdvEI/Bp9/ XaLPK47c+e71g9xN+xollPCXOaKaaKzXCvGWp36pfBRBpyLtPuiAB9/P2ItrmRsWB9+N6lmYvIp kQCg0y6PsQbwbaUBpPQznjPdMsFD1iYggzs3qj6uevFvAGSKJeXYuXYoh70DVcdhEmLQNXYueDx dZWIHL/uNOOkwCWetnUW12udRQNoO7DPvDG9lbaZ1kzaaL5lXrKRcjO8ShYybRxgrSF7auv4vVr qEzcnv9gfGVlpyQwO/h6uEQ+VcwkpIiV7y2SgBdz+i4= X-Google-Smtp-Source: AGHT+IE0dnBTb1x5DxcK37beXnHw3gjuy3gQskSVRipp/bi0wuY0O//pL/fZp7F8bWH3D2xrTe5Hpw== X-Received: by 2002:a05:6000:2282:b0:391:4999:778b with SMTP id ffacd0b85a97d-39ee27519c1mr301518f8f.28.1744737350567; Tue, 15 Apr 2025 10:15:50 -0700 (PDT) Received: from blackdock.suse.cz ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39eaf44572csm15412050f8f.90.2025.04.15.10.15.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Apr 2025 10:15:50 -0700 (PDT) Date: Tue, 15 Apr 2025 19:15:48 +0200 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: JP Kobryn Cc: tj@kernel.org, shakeel.butt@linux.dev, yosryahmed@google.com, hannes@cmpxchg.org, akpm@linux-foundation.org, linux-mm@kvack.org, cgroups@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH v4 5/5] cgroup: use subsystem-specific rstat locks to avoid contention Message-ID: <3ngzq64vgka2ukk2mscgclu6pcr6blwt3cwwmdptpdb7l7stgv@vhpyjbzbh63h> References: <20250404011050.121777-1-inwardvessel@gmail.com> <20250404011050.121777-6-inwardvessel@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="cor5zs4qbgttlckm" Content-Disposition: inline In-Reply-To: <20250404011050.121777-6-inwardvessel@gmail.com> X-Stat-Signature: 7i4z74g4b18b3pbhzkttryo9dg7sbp5b X-Rspam-User: X-Rspamd-Queue-Id: 237B4C0003 X-Rspamd-Server: rspam08 X-HE-Tag: 1744737351-327155 X-HE-Meta: U2FsdGVkX19IOmLhqLAYZcbZbLZ6YNXa08APBs8iMd0ti/MUFk0NyomzFqzXSsw8QN1ZuQKZ2thYfl8J4uqgeGDwC6xq8NDC/Q6EBDvDv2trkVNsHBQjIpfKegI5BKReKiW7mQYR0d8dIATyISOOEF6ediTx18FWC5w67C0CJXhWbH5rbvNU7c0iwLqHgpFHSGl14TGq39VDyjNU9GSCnoM4bamdM3CLM5Y0JpNthRxHma4v0R1b104zMZJ1X+tytP4Qadzo7N6Vj9x1o6Ta5rydcQycCoC22H61+XCKo4suI1sFttQELeLVOmG4vROgvgum45hIasnY+0kXMrM8dFqR+7FVFoW12s5fIUYerGBzyoVbowWz66gL7FgTxlEx2JXoe+ZLI72unUizChEKmVLOjhEOp7+s0PymgK/DKqwbR0TowzrP2PTOSjTFMpzpXyU6SMszXn178ZMwbilTmgnyA44CLvBIzNd7iRAXeaNrtw3OMdvJeul9/0XsMQ0s5pDZuMlpi0ot554pzltf8DJdQeNrqWaK2vHH2DnjrXbc9nQwb/xIJDJdOt31JJB74rYjlRImeX5qPubkW/yzxoCn1orf/LPr3ZjX47H2eAYgAyPTX7eUIb3/IfCde0I2d5pkOwu86R15lo9pdgMBOFmWOU8OLMdlvQhOoC452rJQdTwRIbaG5ItJcEP5jj4k6Sfz+jDV4rxMwuawzaPE8w81r1pBfjOdhPKU2iWe+AbkQ02ekIpObvb32gkFCnU5nVlD4dW3c5YyJf771pZG8RLelL+7DRmA8qh1yl1+hR3SD0c1WcjdbX148XeIglIPkHh+TgzaYLusQBV6qktxCR/nVFqlvt4hhEQzMNz7drntMTjkK/HPRZ0wl3LQqpRv+Bl/BYN9PuWoqEjifVNI2gpkBdF85onbaPOF9RFut2L0wjaQALWkL48/etYbwwZeMUbAt7hOMhWcaWFeRLm tRpfiLM7 51bQ8RjNAG40ajCyr/jnyHdBEnfYZX7m8vAUV8joHafGpsWiXs9MwyuYU9z819D4MYpCWggPaLk1TEnWvApx1pG+79sqQ9s0wOhsBaC9sirzflHbdGayIMunNDStvmaytwxjpse2ewtoeKia/FGLozSqP/H7Rzm8cTP25BJWBGWg4hmNOgxZp3ckzBJqfl6fuoOWQOBC22S6lwYAo5UjXcZioQBmNbafD83vE+LHNaKlVyAuSst1pE9oIeXLwr9TRM00PtIrRfypiIxM/iEBIXEVuD1aIpiUnNWeHAPXR7yrW3MZAIADN8FK7cdS2+Zztoe5RJ1Nd7LZ0vZTYrhTp2dAC2xrABYUa+KMvQWsrI5dE+XuLhbQrDwExgUdL6bKmrt9PWuKlbXapk2VtP2VHJokt1rrofq9U7DgaWJleXZUNBh0NsLH2pQq55jkxX5fxBr5lmGkx7l+oiyBu9JDv2mWEX+RB341Uk+rBD98wFcmnDe7Mpi9RFq7YzQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --cor5zs4qbgttlckm Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Subject: Re: [PATCH v4 5/5] cgroup: use subsystem-specific rstat locks to avoid contention MIME-Version: 1.0 On Thu, Apr 03, 2025 at 06:10:50PM -0700, JP Kobryn wrote: > --- a/kernel/cgroup/rstat.c > +++ b/kernel/cgroup/rstat.c ... > static inline void __css_rstat_lock(struct cgroup_subsys_state *css, > int cpu_in_loop) > - __acquires(&cgroup_rstat_lock) > + __acquires(lock) Maybe __acquires(ss_rstat_lock(css->ss)) It shouldn't matter anyway but that may be more specific than a generic 'lock' expression [1]. Besides that this patch LGTM. Michal [1] https://sparse.docs.kernel.org/en/latest/annotations.html#context-ctxt-entry-exit --cor5zs4qbgttlckm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTd6mfF2PbEZnpdoAkt3Wney77BSQUCZ/6UQgAKCRAt3Wney77B SbddAPsHqv+2FAa1isXCc+qO4DC3AZhsBckqZaPuxJkhNwHxBgEA0isqJaUtAfBn ojjC2QJDbRXHxkFbbp6vOk0TVjjt6w4= =Y7HY -----END PGP SIGNATURE----- --cor5zs4qbgttlckm--