From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D54DC76196 for ; Tue, 11 Apr 2023 12:23:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A3AF46B0074; Tue, 11 Apr 2023 08:23:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9EADC900002; Tue, 11 Apr 2023 08:23:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B6276B0078; Tue, 11 Apr 2023 08:23:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7DD0A6B0074 for ; Tue, 11 Apr 2023 08:23:38 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 4706F120BAA for ; Tue, 11 Apr 2023 12:23:38 +0000 (UTC) X-FDA: 80669026116.04.4AE4C63 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf08.hostedemail.com (Postfix) with ESMTP id 797E9160014 for ; Tue, 11 Apr 2023 12:23:35 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=o5SNl5sy; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf08.hostedemail.com: domain of mkoutny@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mkoutny@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681215815; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Zrc6f9m1IkUZIG9FYgI96c26lt3qznrpmnR3S4+Pvz4=; b=lIIWKEN1FdUUCTomPPOVL61+8WurOgLg3hSKTvQ9Kk9SC+cafAdTvjkMnP2WdLV6gnXNR8 QY6JAaflDL0R+hRVBjv+vNsC8RDz7JDmyjTB1O/qolYD2vroR1WQx5W+CBZXwSUxDCXhTl GlRk9+ztt1h7kRtrHXfruDiMvmJplGE= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=o5SNl5sy; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf08.hostedemail.com: domain of mkoutny@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mkoutny@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681215815; a=rsa-sha256; cv=none; b=jpVivQ4a/JMqJpDLdbsLOzElJI3nmNjiWyfagNiCd76lOwjCh1YZpwQ8ppfuv3rQD6voEq 2wFdR1wb5UtrRu6e66WCPTAf+WY7OandS3nbo9K9tKFJRzuTOsVB8zxZqOdqnrlIewWX1i nNGQbfM5O+I+TazXhdMY/iIKC+mPSy8= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E87821FD6A; Tue, 11 Apr 2023 12:23:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1681215813; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Zrc6f9m1IkUZIG9FYgI96c26lt3qznrpmnR3S4+Pvz4=; b=o5SNl5syy5B3mqUwrBXxNR3RlyJ3lv8VJ8lbtzjQNV89dP9dYeYcXXmgAu1mxnhXVTwLIt rvIkhS+3q5Ug7+SqqD6O1Egypv7DaxkYs0k9n7e8qv8nfHzgvqXz9Q1Jh+XtkMXBYoLTwY YFcJ92qLpealU/gNva2WG24Psf7WfDg= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id BD9EA13638; Tue, 11 Apr 2023 12:23:33 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id l21LLUVRNWSoDwAAMHmgww (envelope-from ); Tue, 11 Apr 2023 12:23:33 +0000 Date: Tue, 11 Apr 2023 14:23:32 +0200 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: Gang Li Cc: Waiman Long , Michal Hocko , cgroups@vger.kernel.org, linux-mm@kvack.org, rientjes@google.com, Zefan Li , linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] mm: oom: introduce cpuset oom Message-ID: <3myr57cw3qepul7igpifypxx4xd2buo2y453xlqhdw4xgjokc4@vi3odjfo3ahc> References: <20230411065816.9798-1-ligang.bdlg@bytedance.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="qy2a2rv2poa26h7t" Content-Disposition: inline In-Reply-To: <20230411065816.9798-1-ligang.bdlg@bytedance.com> X-Rspamd-Queue-Id: 797E9160014 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: mjhrt3coiexa1yy1rm1ajxzdds73mjh3 X-HE-Tag: 1681215815-693660 X-HE-Meta: U2FsdGVkX19CmBZDQF4rl/vOpEyqjifYxAzIXrf2IB+obNOxASp/YBwcgPm5PLK/FDjWGafBQOzBD8VdKfBMiH6Arg9qU6ttFJ7pAYDoMFOOoiegGHJnVrYkxE4XvfXph2n6J/+Hmf3FgvWxF+VPSif8fVV9FLUZOF9wfY8w9PNMAtnV/8BIDFKCL8RqdbZ1XGwKVd0i9lUTfcD7I8zPT4ZSfMfzLpNGnkoETeQSPK7buebhZ/XYoxi9pJ4PQAYHKnPOFSm4lTCa+rmKQPmP3oLO8Yoa2xsErPwolhTPw2I2M9sgimmZdIOZAFUxuBWNM0OCx/3tFwFI/hLuFvOeK8H0rLaCFc1gicKej7Y75b2txBhf5eY4RFcnYIcmY1P4qOkK+3Ny1K8NY6Y0z0shi2os64pDYZVrxjvq5r1YdYkVay0PuFEOaR/8vGt6zyrbCYnib3j6vVeF7bPUz49hxSFfVxhrKfnncu/TjTSlZrqYfIxxneP6yOzQM5MktmB0eF8HgpGC7U2Y792i+q43rTaF8WmXlKJSn5muOgtRFFh32Qiqvy5TQ/B11y56KLtCOT55tTH9lId12ajN8gfY46YEse/JhwC4J0FFor3tBB6nCCYTtyr9cBM5nKfbthQOvkar966QPGufz/kL868yztJbfQkEiegDxyxT0M4lm1tjcpc6SC6klkBvIx58BzucwHnk0eAtPoFk0zczrLMH93dNlBn8jvFvQp7twxgcdN0uBqfoo+BOgWkW6n/6Q7AFpG6xapBQ1DdcrIPhY8U9Y4aui4g185TQ1S7InLYa5C/v9TA4ZKFjQGa3sYbHQblt7MJl9YoObB7/z12YCzHrt3DNrdXF0kjd9Ou1CMDG/4REXNdzmwiSsEFFSE9rbSEbR9Qtv0Yd6p61cOtBRKTtfOXegID3zUS6VmzBqBGq5P6xkZjGRXpZOVahEQznjmgMmjrXPNIz+glnyAAKCUv DPHae7Cm De96HdSHetwVC4FJ0pU7of7AeF3mTH0W+HPcxawR/6yYi5tsJuFMti9XKS8qdu0RJOJeQ8ddM6e0Qg3xSu9euJTGXNsEOgP7hX65/5G/lbmUmQqhKqkd7hMrs+MaiRI3xQ0i8UsmhPf0BO/KdzscJs8DgE4XWNl/6iNPMlJqCNnBGlNTL3vVR81orwF6AdAec7jPmBXO1GVHcrUQqBjPQ89L4I7QWWoMFzKXDlTLqYlA8bEbyFHVSCFTs0H+7vemOctY/iRinlXfLEZkaZnGuTZdZX5tlWL9B3gHtJJIbf3rdDnBDqrfK7EqZ0iNXDFrlvqKk6dZ0Olm+LciuKSghXW3s5iEN0gmlva5l10gcqfY7gzb8qqukjLADfmNiwFGBjLJe X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --qy2a2rv2poa26h7t Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hello. On Tue, Apr 11, 2023 at 02:58:15PM +0800, Gang Li wrote: > +int cpuset_scan_tasks(int (*fn)(struct task_struct *, void *), void *arg) > +{ > + int ret = 0; > + struct css_task_iter it; > + struct task_struct *task; > + struct cpuset *cs; > + struct cgroup_subsys_state *pos_css; > + > + /* > + * Situation gets complex with overlapping nodemasks in different cpusets. > + * TODO: Maybe we should calculate the "distance" between different mems_allowed. > + * > + * But for now, let's make it simple. Just iterate through all cpusets > + * with the same mems_allowed as the current cpuset. > + */ > + cpuset_read_lock(); > + rcu_read_lock(); > + cpuset_for_each_descendant_pre(cs, pos_css, &top_cpuset) { > + if (nodes_equal(cs->mems_allowed, task_cs(current)->mems_allowed)) { > + css_task_iter_start(&(cs->css), CSS_TASK_ITER_PROCS, &it); > + while (!ret && (task = css_task_iter_next(&it))) > + ret = fn(task, arg); > + css_task_iter_end(&it); > + } > + } > + rcu_read_unlock(); > + cpuset_read_unlock(); > + return ret; > +} I see this traverses all cpusets without the hierarchy actually mattering that much. Wouldn't the CONSTRAINT_CPUSET better achieved by globally (or per-memcg) scanning all processes and filtering with: nodes_intersect(current->mems_allowed, p->mems_allowed) (`current` triggers the OOM, `p` is the iterated task) ? Thanks, Michal --qy2a2rv2poa26h7t Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTrXXag4J0QvXXBmkMkDQmsBEOquQUCZDVRPwAKCRAkDQmsBEOq uVVFAP965wOBxTUUG+YbMpda2aYpjr/QsqcnSO6eT4AgpmO90gD+OHV1fcIafZ+J +SF+dtNZgMgKmvwZY6aKbUZOmnn7ewk= =h0ch -----END PGP SIGNATURE----- --qy2a2rv2poa26h7t--