From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C29B4C3ABC3 for ; Tue, 13 May 2025 07:37:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EBE2B6B000A; Tue, 13 May 2025 03:37:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E6D346B0083; Tue, 13 May 2025 03:37:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D0C776B0085; Tue, 13 May 2025 03:37:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id ABEA26B000A for ; Tue, 13 May 2025 03:37:05 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6EBFDC1B20 for ; Tue, 13 May 2025 07:37:07 +0000 (UTC) X-FDA: 83437078494.07.6E73849 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf14.hostedemail.com (Postfix) with ESMTP id BFF9D10000C for ; Tue, 13 May 2025 07:37:05 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=scm7ESZP; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf14.hostedemail.com: domain of joel.granados@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=joel.granados@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747121825; a=rsa-sha256; cv=none; b=vlQWLN+qKlSl1eL1TvtSVD3ALkPWOOHbpcevUFdm256JK0AHqe2QF+hOIfL/9umZ7f5fqg PLabLK10aVint46QvU5XUI6VTFKV4Qnk9owO8JF0+1rjh8HZq6wPEWGI8n50Ed3fF0JDBO ioNihi06RXepbMYDSR6YZMpdT89/D9Y= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=scm7ESZP; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf14.hostedemail.com: domain of joel.granados@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=joel.granados@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747121825; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uI4FPh+YH1b4aqysgJA3dwdXMIoanncYT1gitbZ7Cq8=; b=T4XLHbYytjUkXGvBhnX6T2ClBTPLNayXn+rlgi7rSOey0W/jxit0arPgbOIJ2INETVPh4M qu4BP2PihUl3EGHJ0HIhsqL1DsPp9dR3gl/c8wEuTegA54XRvAdZ+9akrHdT4gW7gGSsbk B4KL0M9nXFiF4j3Dd2kDupWpEvwT2rE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id AB44B5C02E2; Tue, 13 May 2025 07:34:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2C9F4C4CEE4; Tue, 13 May 2025 07:37:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747121824; bh=3eJWzTh8RQPPZqSzUIOgAER3ng2OBNfm7iT2iwjU8Cc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=scm7ESZPqGKRICUMPr0ebRK/9FLzyDjTKcWLva5L6oU2ggz0+sB3iI801PyQcK0mK /meQaHzbsmhKsoIVhHX0/F589L34t+QE+xYW1QE+p/3pRDzJlwBK2K6pgZBj0zw1WI BTAB7Bd2vGF90fKutKOszz3KrrlkuBZHxZvDL4ZIxCCMTi6t/rGi+xyj8xoYqfOWv2 JPFj88qlpmVDUpYAfGItnUsoBm3zhWlI4m+rGq7IzeoTqOwA1v/w/COBIuv7bA+/Ov 1IDRsWZyjHwVUl1c3hVguVXcxHW15fdcdUIQYHp5qFwFtEoTbP2X2Qugmer+edJHt+ 2heXJWzcGhAMw== Date: Tue, 13 May 2025 09:37:00 +0200 From: Joel Granados To: Luis Chamberlain Cc: Petr Pavlu , Sami Tolvanen , Daniel Gomez , Kees Cook , Peter Zijlstra , Ingo Molnar , Will Deacon , Boqun Feng , Waiman Long , "Paul E. McKenney" , Frederic Weisbecker , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Uladzislau Rezki , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Andrew Morton , "James E.J. Bottomley" , Helge Deller , Greg Kroah-Hartman , Jiri Slaby , linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, rcu@vger.kernel.org, linux-mm@kvack.org, linux-parisc@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH 01/12] module: Move modprobe_path and modules_disabled ctl_tables into the module subsys Message-ID: <3mco5hjj2lefeyyoy2wcm63fl3wh2qvac57puktpqpwx7vpunf@63vk55fgiikt> References: <20250509-jag-mv_ctltables_iter2-v1-0-d0ad83f5f4c3@kernel.org> <20250509-jag-mv_ctltables_iter2-v1-1-d0ad83f5f4c3@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ormwqfkrprpiilub" Content-Disposition: inline In-Reply-To: X-Stat-Signature: j6igz1p15adyt1zj9yikmum87d1gy6co X-Rspam-User: X-Rspamd-Queue-Id: BFF9D10000C X-Rspamd-Server: rspam06 X-HE-Tag: 1747121825-777084 X-HE-Meta: U2FsdGVkX19VzO3Rd/q6jnCB+ayZqPc3ohgDBnhKPRlJ6gerYjl6OhphuikaxbdpDtlQfZigY4BZlS5VxdQffVev5U2ctJuJkaJealrwTzlKd1UWAd7ATiAYThz7JZe8mbhkVeCBC4x8K4ydsUCNf/sClDb0XVrerG039EaUJFVUD1hQxKmqLX+j/n07wzt9qMkNTdWyWNqozMVgc0Wqh5pI0FiwNTdV40+ZL0U+iblzZfSgy48JgMas6VUeLfdgKSPkEWlFxPgAqcHel9bZBi+nifmiGGS6ogZmL6kgL6LJhVIKTZAoqETCg498tpdPqH4ZtwjVJ4dcmacK1F3zbal/8euV5tNHu511msnGXWE/nJoRXXnhJisn1q577EYoqTdqMtDjLqUXE52TJjkUr0kdmUtOD+PPkuWlEfz4A251Ey8HVOElJJcAoA5Nc4RtAlSMdPWH4Qy/lIGXd8yKtD11O8sXMyzatqwHGNWYWgvZHENieWBh+CMGkpag7Y22BCcRIvUSx4RT6P4xRLvWso6Z3Bz+BkF1enJznN7lxLgm1dl8DH4EqQUOU9yPKb5LWQe9L1orE8qF3uLYWNS3nFAUZ45yp56fUcU9apmqACduDASSA05chUjkMVnHPETXD58WyqSUx1U1BhjBehlqJ7RaqeW6LkWtTkonQ7kkUyhaBssCJ+zpkhDaYcqoOm7T8X2NtsXOsAG0AzOAkCX75V9k5Okl3C8laeP9ewHrnm+E1V+JsSoaQvQFinA1aVyn5SesSQ+8zTsqd8BoZFtdtB/SsQDHWvwhS2DECDaQ2GL62+WJ/gYYsM6ZAiyvIuMYwsZZPhTsMLEkH8DUm8b1H3wB8p1XeXzD59kDLVRFnrjDnHQkBXtqLcR3a281t9tetnDcfjKHVEUTuR9kIvNPzx+s7heg0a3bWkRJr3AiN9Svd8euqTMOTUO1UI1Q/htAP39XvXli/YtvNJqs+CB sgIcRIn3 8QE2OFZUttoVfh1g2T5z3m34n86UPTuOrAoMvTxi+IYxvb1Ar+nIuWlrAXQcG8bYYeuDQZZdaOniiOFpf+TGIUkUM9g1ttHcVSZMPEm/9VB5NTutVHDl+Z8KZDXgv+QyNBFpqYsHIvNInb3JsbhcJwu38W4rqQrUBIbaZhAjRL3fo/E5DIh1DLWqooYW4p98U7c5llh/9RrBPx2wVgcdAOpx1w2zbawdyzAPoucVNKOFOIlKt3KrAXjIGFgIGTbZd89RH6iRb421UBIOzF9IRhLnMCCsMO8QkfU4XWjXganf/rYbb6wYD4BwYckso4ZmWHxBAaziu4SuP5zlMMwO8kv25eAUc82bwTmIleRLExA+3Qy2dZkHp2IA4MZmirdLYMhhWK9X4oxVHcMcPZ/kE83p7yo8BNrxaRskr0xOc0EV4tq3xv3mMw5C/lSFN3ubT2lK982BaKnRZb6+65RAzeesEaDZPjyb8cR0qqQscJakbKacBN2ZpWaVMWg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --ormwqfkrprpiilub Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, May 09, 2025 at 09:09:44AM -0700, Luis Chamberlain wrote: > On Fri, May 09, 2025 at 02:54:05PM +0200, Joel Granados wrote: > > diff --git a/kernel/module/kmod.c b/kernel/module/kmod.c > > index 25f25381251281a390b273cd8a734c92b960113a..5701629adc27b4bb5080db7= 5f0e69f9f55e9d2ad 100644 > > --- a/kernel/module/kmod.c > > +++ b/kernel/module/kmod.c > > @@ -60,7 +60,7 @@ static DEFINE_SEMAPHORE(kmod_concurrent_max, MAX_KMOD= _CONCURRENT); > > /* > > modprobe_path is set via /proc/sys. > > */ > > -char modprobe_path[KMOD_PATH_LEN] =3D CONFIG_MODPROBE_PATH; > > +static char modprobe_path[KMOD_PATH_LEN] =3D CONFIG_MODPROBE_PATH; > > =20 > > static void free_modprobe_argv(struct subprocess_info *info) > > { > > @@ -177,3 +177,33 @@ int __request_module(bool wait, const char *fmt, .= =2E.) > > return ret; > > } > > EXPORT_SYMBOL(__request_module); > > + > > +#ifdef CONFIG_MODULES >=20 > kernel/Makefile: >=20 > obj-$(CONFIG_MODULES) +=3D module/ >=20 > And so you can drop this ifdef. Done. Modified in my version, but will not bother to send a V2 for this. >=20 > Other than that: >=20 > Reviewed-by: Luis Chamberlain >=20 > Luis >=20 --=20 Joel Granados --ormwqfkrprpiilub Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEErkcJVyXmMSXOyyeQupfNUreWQU8FAmgi9psACgkQupfNUreW QU8bzwv9GHn9q80K4WLodwErjZKnXswr6KwUEI0c9eHsdmFPBt2RjTo06HJtguMb 0kvfMFNn2PAooIe37ym5MHSod9+xcOVLlQY/8A2ClIf9NBaPsWMIkkyM+KhWcO8i 0E8Nfni6EKPbAAurHklbRft1cnpRSz2FM5yc8USBLQSDjY8lHDGUBYRiKLeiuZdu BD2oTfxU1HKKvv+k4IAonAsRc5fX9WKeVCcJqRBRx3iI7zsqyArktttxXuDgSf9e Sny9c88uZGwsqdFolhgmv0HZF+/94DZobqzW0FS3Vs3N2CPPi0NsqRDnC62U8cDx ez/K2w4byBXR85L7MG6DWLFy5nyCFrNPzIuKQdVrqDvBVfAfJUIZWdT18OskOJsC AocFglwyj5U28DU6J6oRfGwouGeKsn5f9GhQOjRoVQGsXZ7LUVJ/vAmXtNOBr8w6 fcJDSP+sr2iphL7RnV35xdEz+sAAhulDj8ka3odtUmKoJC6P0UWf4qIAQpT7HAud ZENwtTtF =LNIR -----END PGP SIGNATURE----- --ormwqfkrprpiilub--