From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06AECECE589 for ; Mon, 9 Sep 2024 22:00:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 458356B020E; Mon, 9 Sep 2024 18:00:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 408566B020F; Mon, 9 Sep 2024 18:00:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2CF906B0213; Mon, 9 Sep 2024 18:00:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0D2C16B020E for ; Mon, 9 Sep 2024 18:00:48 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id AC422AA1C8 for ; Mon, 9 Sep 2024 22:00:47 +0000 (UTC) X-FDA: 82546570134.28.424F4D9 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) by imf16.hostedemail.com (Postfix) with ESMTP id ACBB3180004 for ; Mon, 9 Sep 2024 22:00:44 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ZlVXmI52; spf=none (imf16.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 198.175.65.13) smtp.mailfrom=kirill.shutemov@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725919143; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yDg7OEnUI2zgTpf4lhTDBy0yv8vF6QKfYp+xUoI8v9U=; b=DDNg23KNu2vULfp4sulpT6kA+B0xRWBMuFSXrSTAz0Eoiws9sPJO65cNC/CPq7HrXqH5Nf NmQanduQ6p0CRVykUEFJT8Ja9bj/Wa9ZHFUVk+z2yew2WSU0CG9rAQoUXba8YrVUAJMf0u 3FPgLN39VeHiJU+QaOA/jwEtNi5eJqs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725919143; a=rsa-sha256; cv=none; b=h+l2rQ+guRkQfr2jkzCLzqsomUJMywiT9aFwezWm0POfvV4YvrciJ3p0GEgaMHQNlhD20O hVjRhbCeWjGX8Io1VShjmg9/5nx86g3ojcIi/5SBPLrJ41/5Y/vg4oA3zw4ehXLWI/aYpc vO69LLHJMrY9K0uun8x1zGgLrbYHbDY= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ZlVXmI52; spf=none (imf16.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 198.175.65.13) smtp.mailfrom=kirill.shutemov@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1725919244; x=1757455244; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=jFmE10NY4nDymrGpFrGQLkUzdd+T1rpk9Y87FgAuX+s=; b=ZlVXmI52hFuUo3t/CQVc5z4jpcvnskBpcVwMRRcWUUPD2JDRPesqQ3Sx O5smqmxWl1u93c5uxMP0F4enVmop07hKkoshJhnlyxxkXzxe8pga+AhCH IHG/ksVeMzMqbX6rO2buRq5h30294TTUidBvz0ljmWSWHPW7UxOqzjv8Q 4wfhlAuW7sCUt984QMhMDZEyUWAHKc8ZPBByBz5/k6oPaULxMWChx8JOr 0oKsIABDKJmViAZ5acw7fbhXicey4fXosoQovRwcUZq95XGlpJ5G8cM6W QMehMGBbIqwDPVTF5EamyQARkqENMjc6h29DSy5bvVpD9YgnY2HLZmF07 w==; X-CSE-ConnectionGUID: RWt69dv+SrCJD0h1LdbW5g== X-CSE-MsgGUID: WUw3vQcmRO2xaGSHviv7vg== X-IronPort-AV: E=McAfee;i="6700,10204,11190"; a="35782916" X-IronPort-AV: E=Sophos;i="6.10,215,1719903600"; d="scan'208";a="35782916" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Sep 2024 15:00:43 -0700 X-CSE-ConnectionGUID: KLMWswB7TcqzyMgx7C4r1A== X-CSE-MsgGUID: 8fgWyY/8SfqIz3JMXboCbw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,215,1719903600"; d="scan'208";a="71603008" Received: from black.fi.intel.com ([10.237.72.28]) by orviesa003.jf.intel.com with ESMTP; 09 Sep 2024 15:00:41 -0700 Received: by black.fi.intel.com (Postfix, from userid 1000) id F3E831AC; Tue, 10 Sep 2024 01:00:39 +0300 (EEST) Date: Tue, 10 Sep 2024 01:00:39 +0300 From: "Kirill A. Shutemov" To: Andrew Morton Cc: Vlastimil Babka , Mike Rapoport , "Matthew Wilcox (Oracle)" , David Hildenbrand , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel test robot Subject: Re: [PATCH] mm/page: Drop has_unaccepted_memory() helper Message-ID: <3inyypayz63x3zktypqdgzrcsrwoetub4y66r4dleoz2lscmws@ocfmmnc2q5f5> References: <20240909081930.748708-1-kirill.shutemov@linux.intel.com> <20240909122558.aa726d312d8b166a515dd751@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240909122558.aa726d312d8b166a515dd751@linux-foundation.org> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: ACBB3180004 X-Stat-Signature: jxi8ffjshwa8qdzu19aedmy68as3beax X-HE-Tag: 1725919244-967159 X-HE-Meta: U2FsdGVkX1/CnhBcba0k+oZKKmKbFhHsXER5vISAibsoNJNPo2psS8Ltc+tzlaG0QtSSWhYn0lyxImgDUctTgxoMyVYrdVUUavGBX4NZenayRKQzCAa5s/rpzfo7OlmmltAfXxBxCeiD5FIZl6Up6NI/YMj76VG3Ezt99xykiE9G0DrHtEgfVz4dVj5G5t7MEt9FLCc9jm3g/qe643eMZmLX61LCnnboQRV1RSi1hYFkk3Ge1omAX4ZS627O+fJok5u007fYtmYpyydBv9gCq02OrQS8jA7eaK0LoFoIE6diOGoLfKlEIwpRtHZRLlb2UyaszAK5DVSYdakENboBJ/x+NvXPJoy2gTfi7deBVUMuoVq7EvFLhrDiYnmjdseK1w+AYb/FUELrRUhUw569xx5miI+j0CwguhjXTb+fMI/9p464QZYz5OQ/OxxWcDZMftE+55NGxQ3DfxzN33hEoVZ3Ck7BVcNRhCaADl2Lvqv/L6QE4Y6fThoBa93LSCxPgf+m/1ooHKWOVEYvsv1cSVON/FW8cUqN7nNt7OI77ZU9IyLxKdlioKjJQjQnJVeDjH5arhmHRAlJ8DIAZYZKKnTzQx+UrIJoBh7VbKHbwP1gvMl4x1udDrLb8DGU1ONLAlXKLc3LIpDAb+KKNncHWYprEesd2pZnW5fvdjqzsOzRpKXIaDV8XezpCBO+Vl5PjqD74tK5LEvqFhfLxcj6XuBED9kZYUufcnK7caOyHo5oVl7VgJrrEJh0PRfUxkDM5cPMv2mkfi4vG5Wbg5aR1pKwPX60bCEP5pL+Vk7qXfV3g9iu5J/hkfUawx4p1pg6BPefQnagVnO2FWLJ6Hto71gVx4seREZZ9dW/oUZqtgOaHcAr3jcQp2x9ZbfFj7tJuVMVeLhG/TihE1voGMvkdjF85OaihtESNoVaKECugEbNsQw8V05GudP0ujWEnRuirRPjpytf6hadyt6eMHB dsYsoWKn HgvYcfHa6Ytkkr97ujK3jI4vDDkr+Q7snX0Nm2jL0djXrweTBHhNSSbgqttuTjxcAqc+pSEHyPhPC9yXo9of2tkt9GJvd4/weBfaggflVeV1KyW3sEf6T7WNSToMZKj8pCxOecP2owAIRb+Cu8TKioREE/+SdUakpQC4NxCaQipwb5uvFM+g1taPTQByzsxjOGljFuWBlHPJ668InZYERxdOxzgTdyagIcSfrWmgis9O/OU360lC71OXINJINKQnzY58/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Sep 09, 2024 at 12:25:58PM -0700, Andrew Morton wrote: > On Mon, 9 Sep 2024 11:19:30 +0300 "Kirill A. Shutemov" wrote: > > > has_unaccepted_memory() has the only caller -- cond_accept_memory(). > > > > Remove the helper and check zones_with_unaccepted_pages directly in > > cond_accept_memory(). > > > > It also fixes warning with clang 18 when kernel is compiled without > > unaccepted memory support: > > > > mm/page_alloc.c:7043:20: error: unused function 'has_unaccepted_memory' [-Werror,-Wunused-function] > > > > Thanks, mm-unstable has a similar fix: Works for me. -- Kiryl Shutsemau / Kirill A. Shutemov