From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE816C021B5 for ; Sat, 22 Feb 2025 13:19:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6DDBF6B0083; Sat, 22 Feb 2025 08:19:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 68CD36B0085; Sat, 22 Feb 2025 08:19:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 52D58280001; Sat, 22 Feb 2025 08:19:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 346FF6B0083 for ; Sat, 22 Feb 2025 08:19:27 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id AFD441A1540 for ; Sat, 22 Feb 2025 13:19:26 +0000 (UTC) X-FDA: 83147637132.02.14E7920 Received: from dediextern.your-server.de (dediextern.your-server.de [85.10.215.232]) by imf16.hostedemail.com (Postfix) with ESMTP id 61A12180010 for ; Sat, 22 Feb 2025 13:19:24 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf16.hostedemail.com: domain of marcus.wichelmann@hetzner-cloud.de designates 85.10.215.232 as permitted sender) smtp.mailfrom=marcus.wichelmann@hetzner-cloud.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740230364; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EOwh0VPtc54CEp/+zxX50GcxXUmg3tzBz9e0Tv0vVSc=; b=prvOyGvqi8MaMLEYLqrttRnSJ5KMjiBw9kfmUb7C87jQJ9cpVWEm0ARhuB7EVr9G7klBje vEYNN/8HoAz4xdgJ+XLa75eS4G1UhiQ3F6sENYcqzH30rwjJ1jwfPurHEnrfc2WTY/r03k kWgDtcBpJX5u7T7ODi+4mHltS8tjams= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740230364; a=rsa-sha256; cv=none; b=PEVlYvrbOi4BrMJDovNo/aa1wS8k3cQr+EWyD6U40cWYEEqNey7zBpGgKqjX16X7uFo1ah fzyDCx0+q9Ck6TZ6jTdONShZBe++nXvUsjALlzVSjm0aeP7IoKxL1bsCdvfWYH7N1xEDNW KnKTb22GLgzEAteOkIo1qOfvXQAgp7E= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf16.hostedemail.com: domain of marcus.wichelmann@hetzner-cloud.de designates 85.10.215.232 as permitted sender) smtp.mailfrom=marcus.wichelmann@hetzner-cloud.de Received: from sslproxy08.your-server.de ([78.47.166.52]) by dediextern.your-server.de with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tlpPU-00035g-9T; Sat, 22 Feb 2025 14:19:12 +0100 Received: from [2a0d:3344:1523:1f10:f118:b2d4:edbb:54af] by sslproxy08.your-server.de with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tlpPT-0008yK-1N; Sat, 22 Feb 2025 14:19:12 +0100 Message-ID: <3fffc23d-45fa-497b-82a1-e09bb81c0011@hetzner-cloud.de> Date: Sat, 22 Feb 2025 14:19:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Andrii Nakryiko Cc: Jordan Rome , bpf@vger.kernel.org, linux-mm@kvack.org, Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Kernel Team , Andrew Morton , Shakeel Butt , Alexander Potapenko References: <20250213152125.1837400-1-linux@jordanrome.com> <20250213152125.1837400-3-linux@jordanrome.com> <386d3514-1822-45a2-a2c5-1567a0d599a5@hetzner-cloud.de> Content-Language: en-US From: Marcus Wichelmann Autocrypt: addr=marcus.wichelmann@hetzner-cloud.de; keydata= xsFNBGJGrHIBEADXeHfBzzMvCfipCSW1oRhksIillcss321wYAvXrQ03a9VN2XJAzwDB/7Sa N2Oqs6JJv4u5uOhaNp1Sx8JlhN6Oippc6MecXuQu5uOmN+DHmSLObKVQNC9I8PqEF2fq87zO DCDViJ7VbYod/X9zUHQrGd35SB0PcDkXE5QaPX3dpz77mXFFWs/TvP6IvM6XVKZce3gitJ98 JO4pQ1gZniqaX4OSmgpHzHmaLCWZ2iU+Kn2M0KD1+/ozr/2bFhRkOwXSMYIdhmOXx96zjqFV vIHa1vBguEt/Ax8+Pi7D83gdMCpyRCQ5AsKVyxVjVml0e/FcocrSb9j8hfrMFplv+Y43DIKu kPVbE6pjHS+rqHf4vnxKBi8yQrfIpQqhgB/fgomBpIJAflu0Phj1nin/QIqKfQatoz5sRJb0 khSnRz8bxVM6Dr/T9i+7Y3suQGNXZQlxmRJmw4CYI/4zPVcjWkZyydq+wKqm39SOo4T512Nw fuHmT6SV9DBD6WWevt2VYKMYSmAXLMcCp7I2EM7aYBEBvn5WbdqkamgZ36tISHBDhJl/k7pz OlXOT+AOh12GCBiuPomnPkyyIGOf6wP/DW+vX6v5416MWiJaUmyH9h8UlhlehkWpEYqw1iCA Wn6TcTXSILx+Nh5smWIel6scvxho84qSZplpCSzZGaidHZRytwARAQABzTZNYXJjdXMgV2lj aGVsbWFubiA8bWFyY3VzLndpY2hlbG1hbm5AaGV0em5lci1jbG91ZC5kZT7CwZgEEwEIAEIW IQQVqNeGYUnoSODnU2dJ0we/n6xHDgUCYkascgIbAwUJEswDAAULCQgHAgMiAgEGFQoJCAsC BBYCAwECHgcCF4AACgkQSdMHv5+sRw4BNxAAlfufPZnHm+WKbvxcPVn6CJyexfuE7E2UkJQl s/JXI+OGRhyqtguFGbQS6j7I06dJs/whj9fOhOBAHxFfMG2UkraqgAOlRUk/YjA98Wm9FvcQ RGZe5DhAekI5Q9I9fBuhxdoAmhhKc/g7E5y/TcS1s2Cs6gnBR5lEKKVcIb0nFzB9bc+oMzfV caStg+PejetxR/lMmcuBYi3s51laUQVCXV52bhnv0ROk0fdSwGwmoi2BDXljGBZl5i5n9wuQ eHMp9hc5FoDF0PHNgr+1y9RsLRJ7sKGabDY6VRGp0MxQP0EDPNWlM5RwuErJThu+i9kU6D0e HAPyJ6i4K7PsjGVE2ZcvOpzEr5e46bhIMKyfWzyMXwRVFuwE7erxvvNrSoM3SzbCUmgwC3P3 Wy30X7NS5xGOCa36p2AtqcY64ZwwoGKlNZX8wM0khaVjPttsynMlwpLcmOulqABwaUpdluUg soqKCqyijBOXCeRSCZ/KAbA1FOvs3NnC9nVqeyCHtkKfuNDzqGY3uiAoD67EM/R9N4QM5w0X HpxgyDk7EC1sCqdnd0N07BBQrnGZACOmz8pAQC2D2coje/nlnZm1xVK1tk18n6fkpYfR5Dnj QvZYxO8MxP6wXamq2H5TRIzfLN1C2ddRsPv4wr9AqmbC9nIvfIQSvPMBx661kznCacANAP/O wU0EYkascgEQAK15Hd7arsIkP7knH885NNcqmeNnhckmu0MoVd11KIO+SSCBXGFfGJ2/a/8M y86SM4iL2774YYMWePscqtGNMPqa8Uk0NU76ojMbWG58gow2dLIyajXj20sQYd9RbNDiQqWp RNmnp0o8K8lof3XgrqjwlSAJbo6JjgdZkun9ZQBQFDkeJtffIv6LFGap9UV7Y3OhU+4ZTWDM XH76ne9u2ipTDu1pm9WeejgJIl6A7Z/7rRVpp6Qlq4Nm39C/ReNvXQIMT2l302wm0xaFQMfK jAhXV/2/8VAAgDzlqxuRGdA8eGfWujAq68hWTP4FzRvk97L4cTu5Tq8WIBMpkjznRahyTzk8 7oev+W5xBhGe03hfvog+pA9rsQIWF5R1meNZgtxR+GBj9bhHV+CUD6Fp+M0ffaevmI5Untyl AqXYdwfuOORcD9wHxw+XX7T/Slxq/Z0CKhfYJ4YlHV2UnjIvEI7EhV2fPhE4WZf0uiFOWw8X XcvPA8u0P1al3EbgeHMBhWLBjh8+Y3/pm0hSOZksKRdNR6PpCksa52ioD+8Z/giTIDuFDCHo p4QMLrv05kA490cNAkwkI/yRjrKL3eGg26FCBh2tQKoUw2H5pJ0TW67/Mn2mXNXjen9hDhAG 7gU40lS90ehhnpJxZC/73j2HjIxSiUkRpkCVKru2pPXx+zDzABEBAAHCwXwEGAEIACYWIQQV qNeGYUnoSODnU2dJ0we/n6xHDgUCYkascgIbDAUJEswDAAAKCRBJ0we/n6xHDsmpD/9/4+pV IsnYMClwfnDXNIU+x6VXTT/8HKiRiotIRFDIeI2skfWAaNgGBWU7iK7FkF/58ys8jKM3EykO D5lvLbGfI/jrTcJVIm9bXX0F1pTiu3SyzOy7EdJur8Cp6CpCrkD+GwkWppNHP51u7da2zah9 CQx6E1NDGM0gSLlCJTciDi6doAkJ14aIX58O7dVeMqmabRAv6Ut45eWqOLvgjzBvdn1SArZm 7AQtxT7KZCz1yYLUgA6TG39bhwkXjtcfT0J4967LuXTgyoKCc969TzmwAT+pX3luMmbXOBl3 mAkwjD782F9sP8D/9h8tQmTAKzi/ON+DXBHjjqGrb8+rCocx2mdWLenDK9sNNsvyLb9oKJoE DdXuCrEQpa3U79RGc7wjXT9h/8VsXmA48LSxhRKn2uOmkf0nCr9W4YmrP+g0RGeCKo3yvFxS +2r2hEb/H7ZTP5PWyJM8We/4ttx32S5ues5+qjlqGhWSzmCcPrwKviErSiBCr4PtcioTBZcW VUssNEOhjUERfkdnHNeuNBWfiABIb1Yn7QC2BUmwOvN2DsqsChyfyuknCbiyQGjAmj8mvfi/ 18FxnhXRoPx3wr7PqGVWgTJD1pscTrbKnoI1jI1/pBCMun+q9v6E7JCgWY181WjxgKSnen0n wySmewx3h/yfMh0aFxHhvLPxrO2IEQ== Subject: Re: [bpf-next v8 3/3] selftests/bpf: Add tests for bpf_copy_from_user_task_str In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authenticated-Sender: marcus.wichelmann@hetzner-cloud.de X-Virus-Scanned: Clear (ClamAV 1.0.7/27557/Sat Feb 22 10:28:44 2025) X-Rspam-User: X-Rspamd-Queue-Id: 61A12180010 X-Rspamd-Server: rspam07 X-Stat-Signature: epq6bk67pm5uz4anugkj5moa5sqzn8hd X-HE-Tag: 1740230364-553819 X-HE-Meta: U2FsdGVkX185hsFNIISpzX1kPhUKqhr1ytJ1GwCa31b2p2utZhD/mvxfi9sJ2WPv9XNrkJqMbkXhcZ9BAO4QmmQPRfj15FTqjEOvLS8TypMB/DJ7mcNIueqRHxd+q3eTu5wsmoHrLbXvZJJ++lQKYtIdR+ZJVyqOSzC8N+C3j+ZD8BscIPyEsktJzk6yIk214oXS9ZVHncfe1UxDnof9FZp9VgzizQpwnwizHOc8R4K+XIsQOonah4mZ5l0cWBK8/lNqfbjaygEBGZeHZIIQwmjrnLBLiXTrB3GDR8oQkQXS7lh6L1/5qkdsHXQNhoV+n7g17k24z3OpzhS6JQgW9P7XDkRq/wwTT3o1xzaVcZqA6VAw9jDKN3SVa/9TOhWQob1pqFcnRIyz/RcKGoVkcgWzX5ljgebqkZbX+SFK3KKGfBPpric9OYqiCjwKqLg0rwiX9zrIG6BH67D33VAjZSKva8gcyZ1guFGUXJ3ZtAexiKyfzIcJB7BTFs27zfr5bB0hu63Xb19SakSpBcweLNAOH8gbJevEIagpn7LlXmChV/4m8CZ5DKPQaqUK+aKueSHIwYohjAQf0fZ/uBfEqXYPdjEOWZi2Nq+bFCGEm6rADJgNAav5qYkZD/ASB3416TeMLte0aRpVk6yhiIc8RzAXs04wzI3/yiFivEEjZajokMffgf4F+BX95JZUwAJcXDjFLuA+C5sSqcO+mABeXuRbN0EP6U32F6oBKHaFn6sNYZQ5c+ZSawVV8nW7l3W4gdjHi3lLXZ0V38lGfjcbipFw9bbIgShrfJ55oxLteWdKggCKxWCqpR7sF5/qUGTP9EqAQ+t3x3D5wvNCOyPExx0fvZTcr5EYb/3PLXngUVWJiMaQGWfjYSnv2YdqQrXGUlwSu6kcE8HBmJSfIvKdX2n3pn+uVwJCgcUktbUUp6/UOWoLz7sTAa0+vlq72dxGRygGzWfkqKk2enlBKRp obXqVwu7 J4n7G1kCDGFceuyNUl4+a7LtYFBoeRN0TSUSqBxPOIHjkKjApF36Z9nzn2rWqMvAqNlJwuwXkPrr/DpWaSI/ubfLHj3apIjDNW/jAz+VzDfc9MdcRCISwWCc2n6YVMMf80kPCr4ZRwuQ6lM1u4fRVr4WvdaIlBwFFb5PWyRMv44Rou8y/qXRVTSBEPkPt2b1FDsvLsZenbe55bHPzmuGxf2TyIN7h/mgHn7yF5sARVfEY8SKqyHiTQTVQHhSgcTX4450CtAhat5YLS5xKj2dllz1WS72Kddt6KOjnoBhiZiPTMLGfEfQ4s2nC3uwLamPXlNCizrEgAMO0khBflkJOfReX5k86nM86tRxQUG43HYXUXgaqkYJWrlqCjizlalTCcWcsQEggxCfYgXLKilftnAGAvQnznCh+W0KNd0QF0NdBeNc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Am 21.02.25 um 19:26 schrieb Andrii Nakryiko: > On Fri, Feb 21, 2025 at 7:01 AM Marcus Wichelmann > wrote: >> >> Hi, >> >> I'm not sure what I'm doing wrong, but after rebasing on latest bpf-next >> which includes this patch, I'm no longer able to build the bpf selftests: >> >> # pushd tools/testing/selftests/bpf/ >> # make -j80 >> [...] >> GEN-SKEL [test_progs] bpf_iter_task_vmas.skel.h >> CLNG-BPF [test_progs] bpf_iter_tasks.bpf.o >> progs/bpf_iter_tasks.c:98:8: error: call to undeclared function 'bpf_copy_from_user_task_str'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] >> 98 | ret = bpf_copy_from_user_task_str((char *)task_str1, sizeof(task_str1), ptr, task, 0); >> | ^ >> 1 error generated. >> make: *** [Makefile:733: /root/linux/tools/testing/selftests/bpf/bpf_iter_tasks.bpf.o] Error 1 >> >> I suppose the function definition should be in the vmlinux.h? >> > > Yes, it should be in vmlinux.h, and if you don't have it, then you > must have a bit too old pahole. > > $ git tag --contains ce4d0bc0200e3 > v1.27 > v1.28 Ah, my pahole version was 1.25. Compiling a newer version from source did the trick. This was really the last thing I would have thought of. Thank you very much for your help! Marcus