From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75B52C369DC for ; Mon, 28 Apr 2025 16:19:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BF06C6B00A3; Mon, 28 Apr 2025 12:19:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B9E216B00A6; Mon, 28 Apr 2025 12:19:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9C9346B00A8; Mon, 28 Apr 2025 12:19:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7CF446B00A3 for ; Mon, 28 Apr 2025 12:19:47 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 28E0380C04 for ; Mon, 28 Apr 2025 16:19:49 +0000 (UTC) X-FDA: 83383963698.20.3444CBA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 9207614000E for ; Mon, 28 Apr 2025 16:19:46 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=O8Bb79xS; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745857186; a=rsa-sha256; cv=none; b=MYnwv35fqByB21oU9D2u6GrxizcCRxtBZWgAZrC5rVNVihTndAnAHaukQXiuocbYiJA5lt E1w4z5mGbtoL8E9RMUYGZqJOM6JSGWgqIaa8kLvbn4QwwBy9WfjXgYlsolRS73+zwEqSKv FyZC2FpTmDM8lOHKYMGOwaIr+DXSLV4= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=O8Bb79xS; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745857186; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VmOzNNa2lSW/GlQQhEhQ9IBRbBC+qenaKrXSKelhh2w=; b=gwJEk1yihaElHYSnLCByyR4JnWungJGJMadYBThdZK1x/ZuSdF5TrQz+4b7uS32IE+83F3 mmADf8wdxagODyfxUHuBhXHN4fyTFhZOWbwJBg3YHip6hedvWMznV+7Kujj/G2JkfjdrCy JjefX+Kkahjdmu/MSzxxZAPDVMEM2OM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745857186; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=VmOzNNa2lSW/GlQQhEhQ9IBRbBC+qenaKrXSKelhh2w=; b=O8Bb79xSWE6Zo0WRMlqdnPjHwH/GYjgSPDsEKxJVkW0+t523r9ipQdywuqeid/VFXdoFPZ 6V8tf/ZlJaOAmcIp9ycWG35SyNdz5iSKwa38z6qTf/0IoFm7yQkYOUunBg0nV8j2F9E9Vh vmT4G2/9nmK2HOR95tmKR627FeUVo+w= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-477-blPPbH9bMLSx1ROzUMY5TQ-1; Mon, 28 Apr 2025 12:19:44 -0400 X-MC-Unique: blPPbH9bMLSx1ROzUMY5TQ-1 X-Mimecast-MFC-AGG-ID: blPPbH9bMLSx1ROzUMY5TQ_1745857183 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-39d9243b1c2so1585316f8f.2 for ; Mon, 28 Apr 2025 09:19:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745857183; x=1746461983; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=VmOzNNa2lSW/GlQQhEhQ9IBRbBC+qenaKrXSKelhh2w=; b=jSPWhMahayijJNZ1zSSEdwKnO6tR+cCc/T9MuE73tSe/AKp8kyNKi//ot3fTQLLsg6 9dT6TIRnpP4l82ufBfXjn8odbwoDd5ss65RHYRt7bbZlij3Gr+L28aLPhb0FgvY2Dyjv rHonlXFdWTSiA0bpNRTiVXLPRmkcNJN+BPDtGlA1xpdo/jb8x+GbA9etLkpu1KDjiik3 kbJOBhfTVbHb0IIEd/iMQqpSc1ocURVyym8ssTlwwRCCUuZTSeXCbFh7JECp6h5Gvc6m AIztblP3Cig2H2CRuGaH9LdeM5MJnEFsJLKyhnG6sCuGQ/Y3bFEiFDXF7Kl9zRkqC9P5 zTKA== X-Forwarded-Encrypted: i=1; AJvYcCXbSqUp0k+EcyVxRscr+c/o6F36NIAdF56gHm99NjA3FJ8C857+REU7uYEEbkH4IRO8HPo4EhcnsQ==@kvack.org X-Gm-Message-State: AOJu0YxjagqPYXQFFFF9p7Irwo5yQZXvXvpcRiNiQ8pUnKbS0z2PZwfM 3osXQShxqVNXfXyIWgxGuITwUbxGBV2RtIYmYsswe0CzIwlwN85Fv7wdfXAWPxWsJY7jMb/rsTr ib9mca6eXuKmyGRIdFDO+aXAoRsPy8UngmApi7OhsKxNQPFCe X-Gm-Gg: ASbGncvk7+O+haCd6mWI6DkZvVDU8izCD+Oc56SHz9JIK9Fm5C+IXfpPRVTa1zT6Ih3 1Q0ZD5/y2WlqZZvzw0OONe/zkBa1M4BgOlEx4gDQ7MBp2e6iQQ2vG7WUG43wR/RozCZ67nCsW/u +TERn69286pKwleGMg/hIx51f9gpcqOe7kT+Bg0jOGxEZf8AEPOK8kOfggEN2bzDBkCYdzw9+Vb NekfXTd67xTAAxc5dparF1CGlfFI9vSABJxZkAsv39FxvMGCgXuvNiLfsytEXJ/zf/vJrYN6XgF V4Vinhm0JZsEwZtIR+Pj2329eqkpGOjz66H2Xcj/yeaeelhy522xsp+28lebEvZy1ZCItJlKCUV BjAimX+Hx+kgSVEFnAETxYyC0AzBSyOikltN9BQ== X-Received: by 2002:a05:6000:40cb:b0:390:e5c6:920 with SMTP id ffacd0b85a97d-3a07aa5aae6mr6979553f8f.3.1745857182972; Mon, 28 Apr 2025 09:19:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGfmXkFACO0g+j1lWpGRrjxvjpCuhLDHs85OpH7KxVI0nfzMRleb7eHjmZesdIvv0+FDZpOXQ== X-Received: by 2002:a05:6000:40cb:b0:390:e5c6:920 with SMTP id ffacd0b85a97d-3a07aa5aae6mr6979515f8f.3.1745857182529; Mon, 28 Apr 2025 09:19:42 -0700 (PDT) Received: from ?IPV6:2003:d8:2f32:c200:9add:4a7a:46aa:f740? (p200300d82f32c2009add4a7a46aaf740.dip0.t-ipconnect.de. [2003:d8:2f32:c200:9add:4a7a:46aa:f740]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4409d29b990sm166199255e9.4.2025.04.28.09.19.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Apr 2025 09:19:41 -0700 (PDT) Message-ID: <3feed348-a646-4a41-b9d4-9df788b3ef85@redhat.com> Date: Mon, 28 Apr 2025 18:19:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 01/11] x86/mm/pat: factor out setting cachemode into pgprot_set_cachemode() To: Lorenzo Stoakes Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-trace-kernel@vger.kernel.org, Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Andrew Morton , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , "Liam R. Howlett" , Vlastimil Babka , Jann Horn , Pedro Falcato , Peter Xu References: <20250425081715.1341199-1-david@redhat.com> <20250425081715.1341199-2-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 6f48jrlU1UIMFXXmFIo1FbiXYzUK1U9zS3MOMIJNBGM_1745857183 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 9207614000E X-Stat-Signature: bgbwh7ybuxj5yct4gdfpce59o6t5cgs5 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1745857186-848766 X-HE-Meta: U2FsdGVkX1/PFAoI/swBaod8pPYOQi2P1fRKaDDbTuHy8kqEHh0MRoQNjZQnPmwLyAjUU38ocEFZXg9VXRkEqahwzAxewwqbqZamX1ZNOLlnQ9uTNJRxMIKCNKU/3iUC5xvrh1lukd7zJI1MtC4lUo36XYSeKUS4Eygk5c1MKJ/eTJ/FhBy7iBn+iHcW9NsJBs2ZKdD92Wa5jOCW1cA7OW5QieH2j+AXrrV0Ceb11RKeeLdBUnu3b+cdWdkTJhUpCiIGMV3tsVIGfP+Kb+PhIbIFhUPnzl2YMSv6DlTSVazegjS55kJrt+4RPkyacyody4LFqaDoSw6vyDdmChvWkJ4lSyNCaQFOkl06pA5TfTz44zoMYDlBbuQS5Z58wNSag+Z/pXRbVKTsZGePMMD4lgoZ8FGQKkYXmjcNjEWHPji1Z70W6JcpwuVk8ja/Qk854A/2XtkdUx/BTpkWfVmp9ziZ28XlnWr/SgQQnnS6rktdL/4+6GTpLtcrwU2vLquerao5X05sjtx66aghg+zxO5zgerNPJxx4swAUNuYpt2DrahDgYoNw8nBaTfV6E6cG8TQ2R09DnjLS8QSXWf5Ej6RUIBpN2TX82Dy/71GVzK7LvvaV5jIq6PeU7jpQh2V75y/YUqeNi9RVBsOqt4awwL6SEhbPrfvr+Us+C5tVHbsf22gFa6agKh0uLgkiOtWsFJCnW70T9SA7jmFa35NS8vKMlSjYQY0DS60Vau66Bf19gtwzQ+PNVnGzf6eo01u3pptYfuvGfMC3CbsMGwDqMC8DqxdC/1izvBeMe+JSu69g6nBtjzyq/kVqXyj3Jf3DX+T6e5K4ILzNJk0jtUOsqhoNRqWWrSVpy6YRPsbsdM9SkUDYj8WIh6zl3Q+CmGoJzgJs2sb3vH1GxuzyAISQrc4GytYdJC8798GxYtOEJxUrCz7KbmEWgYqZslMErh00YGd+e4N+PrWtL2iC1Lw MLYUBD3h Xo9xKP99SaZmpRGEZNUdsTMCGZuCxEa2vQCG8D+3+Nn/gYusA8dXm0U6YFLh6JsGHJLqgA3XFsfmqBPkRdMjwrEQChfoEA3etSzDGGZWSEfAmgXH2vLi8+Vfua0hAYoqbVlKPI5pI63/CC+eOs3k4+o8w0LpYVhTaEpEl3Y0p1d/JqzZuwuvxj5rSTmXJEOQ33oXZbcCSaN8xK5ESIWAgJDljcp5N/y1t1Se9NIyifWsk5LbvffZk1E6wjlSWzC/qhr/h7uIjOdb7Nxr4tSbPZXYAW+OQWQ9B/oYr6U0+AdKD5eZN/PETXz0cPThsxV4dnI2XidKHdpDfCRYX+9ZGRGkPeS6ylzxqMN+cYvvv8h3orqLyZjjzR7w3O9zp7UVowdvjMYQBr/DVV7DsdhQdWvzRhwAMIZf/yhGY6jbKNQRpJQYLNxcSgrhBbt3hqLmdbxoNJeBIWOYjDJXZIhcJCLmwr6w7PhTOsril X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: n 0; >> } >> >> @@ -1073,10 +1072,8 @@ void track_pfn_insert(struct vm_area_struct *vma, pgprot_t *prot, pfn_t pfn) >> if (!pat_enabled()) >> return; >> >> - /* Set prot based on lookup */ > > We're losing a comment here but who cares, it's obvious what's happening. > Yeah, it's now self-documented :) lookup ... set cachemode Thanks! -- Cheers, David / dhildenb