From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
To: SeongJae Park <sj@kernel.org>
Cc: linux-mm@kvack.org, rppt@kernel.org,
linux-kernel@vger.kernel.org, kernel-dev@igalia.com,
kernel@gpiccoli.net, Andrew Morton <akpm@linux-foundation.org>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH V2 1/2] mm/memblock: Print out errors on reserve_mem parser
Date: Fri, 13 Mar 2026 17:59:09 -0300 [thread overview]
Message-ID: <3fe8232d-f563-7e02-ee83-3535e88e2f7a@igalia.com> (raw)
In-Reply-To: <20260305011429.79193-1-sj@kernel.org>
On 04/03/2026 22:14, SeongJae Park wrote:
> On Wed, 4 Mar 2026 17:14:10 -0300 "Guilherme G. Piccoli" <gpiccoli@igalia.com> wrote:
>
>> The parsing of kernel parameter "reserve_mem=" is subject to
>> multiple failures, like duplicate naming, malformed expression
>> or even lack of available memory. Right now, all of these fail
>> silently. Let's add some messages so the kernel log can provide
>> useful information in case of failures.
>
> Makes sense to me.
>
>>
>> Cc: Andrew Morton <akpm@linux-foundation.org>
>> Cc: Mike Rapoport <rppt@kernel.org>
>> Cc: Steven Rostedt <rostedt@goodmis.org>
>> Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
>
> Reviewed-by: SeongJae Park <sj@kernel.org>
>
Hi SJ! thanks a lot for the review, I'll resubmit with your tag and
fixing the unnecessary blank line.
Cheers,
Guilherme
next prev parent reply other threads:[~2026-03-13 20:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-04 20:14 [PATCH V2 0/2] Small improvements to reserve_mem, take 2 Guilherme G. Piccoli
2026-03-04 20:14 ` [PATCH V2 1/2] mm/memblock: Print out errors on reserve_mem parser Guilherme G. Piccoli
2026-03-05 1:14 ` SeongJae Park
2026-03-13 20:59 ` Guilherme G. Piccoli [this message]
2026-03-04 20:14 ` [PATCH V2 2/2] mm/memblock: Add reserve_mem debugfs info Guilherme G. Piccoli
2026-03-05 1:44 ` SeongJae Park
2026-03-13 21:09 ` Guilherme G. Piccoli
2026-03-14 0:42 ` SeongJae Park
2026-03-07 8:35 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3fe8232d-f563-7e02-ee83-3535e88e2f7a@igalia.com \
--to=gpiccoli@igalia.com \
--cc=akpm@linux-foundation.org \
--cc=kernel-dev@igalia.com \
--cc=kernel@gpiccoli.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rostedt@goodmis.org \
--cc=rppt@kernel.org \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox