From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8D0EC05027 for ; Tue, 14 Mar 2023 17:20:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E36F6B0072; Tue, 14 Mar 2023 13:20:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 393D78E0002; Tue, 14 Mar 2023 13:20:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2335C8E0001; Tue, 14 Mar 2023 13:20:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 112F66B0072 for ; Tue, 14 Mar 2023 13:20:01 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D23DB8013E for ; Tue, 14 Mar 2023 17:20:00 +0000 (UTC) X-FDA: 80568166560.14.D18D98D Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by imf21.hostedemail.com (Postfix) with ESMTP id 6E7701C0014 for ; Tue, 14 Mar 2023 17:19:58 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm1 header.b=gfCgeBXF; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=pHIQuao2; spf=pass (imf21.hostedemail.com: domain of arnd@arndb.de designates 64.147.123.21 as permitted sender) smtp.mailfrom=arnd@arndb.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678814398; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=f2kuFxnIY96/eRVz9DcVTAjN6Y4RzO1AJtCfHPZg11c=; b=NFFn4XCa2U7yWRWC8u4pWRRk7Cmb3ln7OhjdxeSxPVylZSoOW4SYM7ngrtmZ87rPZFvu/P 4v1swR0Fgle9rd0IdBPDHSfKp20oZgCsmgH0xjeGcqJWN61lgTVYzfiuKGKjkqqIg3Fe8g syjy1FFX5WJP6EG8AhuPhkmQd8Je9UI= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm1 header.b=gfCgeBXF; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=pHIQuao2; spf=pass (imf21.hostedemail.com: domain of arnd@arndb.de designates 64.147.123.21 as permitted sender) smtp.mailfrom=arnd@arndb.de; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678814398; a=rsa-sha256; cv=none; b=WsMad84waCW5yw9B1ImttVAAQo2PlhikATuCopLtCUTncuIS+C1Cta+5EG41iiBCpPlz0l XXbZgyjuPWwyhtdXRTjr4MsU8zGIbEmJQVY5h46NEFqANeCtKUR4/jafIxM8IRRS+l1grS nlWCz3lWVwWhNVHUNXydPBO5UMS4Yb4= Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 5818332007F1; Tue, 14 Mar 2023 13:19:55 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Tue, 14 Mar 2023 13:19:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1678814394; x=1678900794; bh=f2 kuFxnIY96/eRVz9DcVTAjN6Y4RzO1AJtCfHPZg11c=; b=gfCgeBXFK+Co8QX3Au 2ahZs7OKsfn08pGOjk7kWyZ6KPNjFmwWw8TZvrHipzxt3WS12t32la5MG/MTIYkF ITD8vrZVDCjIgxKSaMF6qgpgVxrJ31xELNL9nElBfI9sjJ9gPusi0gf0PN+zE5LN GH+NHFXq0J3v9maToOzX+LJdcas6KklwkRLaYNvu1k4SiIFQ2Ik3Qiw9iXul7yDz xnWb3Qw81+qNXKRbT0ww2guSXZ56CxEdh7Ylc8V+QaAuw6IOE+X7ocyOHCBZfHU5 9Nj4tPueHd/0dGzTQ6ny+qOrOZrLF1Fn+e73buoK2X7UW91GCHzHqU3wtFx3VWOV VVkw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1678814394; x=1678900794; bh=f2kuFxnIY96/e RVz9DcVTAjN6Y4RzO1AJtCfHPZg11c=; b=pHIQuao2zCwmjVU642T5/GPfuSdOU 93ExunLOjQKwwpaeaPgQWkMUauLcxxiimsICl2plbSV3DZP0dVaeuDL0+HmFnWV/ D0kkvTg1rTVubz5DtEuEj3pgUpmrQsC0M/NP+f5bE6N7z44n6rW7+zc2u5osUzaB 6Hqbop36P62Plgi1nDJaRS1SbjQWJjueQn5T0eAReSdq9VmEuOZWiROHwI4zpxz8 Sfcexkx0zyYIfY+8CAS24bKv/Tm6RMbXot97oQjQlRO7f/hZbSjX4cRbhA+uwD4b CTxZmHi6tXz7Dxi8FKqVhbL5BnVytTv/Cu7ztNpx1pAgSE6aWZNvGsrpA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvddviedguddtvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdet rhhnugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrg htthgvrhhnpeffheeugeetiefhgeethfejgfdtuefggeejleehjeeutefhfeeggefhkedt keetffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe grrhhnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 7B08FB60089; Tue, 14 Mar 2023 13:19:54 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-221-gec32977366-fm-20230306.001-gec329773 Mime-Version: 1.0 Message-Id: <3fd94bd7-ab10-4d50-bcb6-7c13a3346d6a@app.fastmail.com> In-Reply-To: <7f39daad-05b0-46f8-bc89-185b336d8fd4@gmail.com> References: <20230308130710.368085-1-bhe@redhat.com> <20230308130710.368085-3-bhe@redhat.com> <20230313175521.GA14404@alpha.franken.de> <20230314153421.GA13322@alpha.franken.de> <7f39daad-05b0-46f8-bc89-185b336d8fd4@gmail.com> Date: Tue, 14 Mar 2023 18:19:34 +0100 From: "Arnd Bergmann" To: "Florian Fainelli" , "Thomas Bogendoerfer" , "Baoquan He" Cc: linux-kernel@vger.kernel.org, Linux-Arch , linux-mm@kvack.org, "Michael Ellerman" , "Geert Uytterhoeven" , "Luis Chamberlain" , "Christoph Hellwig" , "Helge Deller" , "Serge Semin" , "Huacai Chen" , "Jiaxun Yang" , linux-mips@vger.kernel.org Subject: Re: [PATCH v4 2/4] mips: add including Content-Type: text/plain X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 6E7701C0014 X-Stat-Signature: 7qi8kkkf15rinm8dtzyocpezukxcgrar X-Rspam-User: X-HE-Tag: 1678814398-600495 X-HE-Meta: U2FsdGVkX19GPtogq5Y9WAqayVeZiUyyavKY0WyAzu7fgimXsllyQRnAQK/dPmPsw7Tx/TfLo4/APZRL0sJdXOB/OSVsvOXXtCAIXv+n4ZwM2YJJno6tx+X7Bnv07ma2Ur06xGE8W4U7I3CDP4w5hMVJ8vGfMA8uN9HQ9mf+bDJE3QdmgyJQyht3pK1RGC8ZKNrq9MH+XuI5LH6NTXwHNdozCaKd/gwnpTGE1jeRK7IjZXCkZe+bxob9oVfMHm5xwL670KqhFpsq5/L420ZxoeC8VebTNGc0vhN8i0aG9/kqOzmXf4qaJQ07Sjz1JESMa3JycwV2L9uOBBcCGdYxxBgpcOH+xHo9hVIdqtVTWjiM56c5T/tqlRFUok1Vhv4GFJGv2lZLqzBtAc6nwXnnD6/Tzoq3O6M9uvD6uZEqXEDP/2/JkQL1ph1lW+i4cFBkKgy6QSUScwsYWTJ+DTskMrIIMPn8w20SUYq9xJeoF4fHvV39GRijKlBrAUTFfLa8MpdlRRlwmYqXUMGgGzxt28AUNbXkii6KQb88YQZbwee7FuJxPZ7WxhdZSTjJIXmCWmPNe1TV6Qs/IRXm/CwSs+oj17Z7VdtOsktbw36WQGfiBboA5WPG5dWzP8hjud2TL3hKOcR2JOPrkl2lYs0EndVJQ11nH+ocgOcWK7eIerdp6j5b9PAKEUCfUdaBIWmlmGcSvqVijgIaNMCeax/Obytxc6Q+nT06Y5kT42rxC6VEi2z3ye6XEM+R/jEPAKWCvewzJN0HIM1VbypgbwtH1FcKFFnmBphFfxr7afuk4yYSI6ByYqQ/UfNhFOASk/ClBM1A//efYJFy8BmpG/0/TcrCBk/KpbrO/iH0SbnkjtT7NVsqRsR9aDJujob/wDHdBiZh9ZQ/M07HLUXQM2JuDIzujD6f14CCXTNEQNDeVlOcwwA6i0KhXnvVRFK7jnkW96Sxn8GrQ54KbYqU5zN 305jkkwe AIYgvr/AeZuaNygHEHDxNcAoOXel1XIDvjIz5RkNBNLvJhEUBjPAUv9D6P3agyC52avY1Eun6exPu27jTkKqt7ZAQoqtlh/S4kOk2qc2ySTbd+w6Bs/oEB5Sh8p0v4qE2qWQzmjD/Lfh4tgPvQQLzMyySzazAV3CEdeKSKZgKhHhEjJAthTFMg2bOU2iqjrV6w/90Uk+zXnA/P3CN8S8ShKEvrWh5SZFWV7YX X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 14, 2023, at 17:31, Florian Fainelli wrote: > On 3/14/23 08:34, Thomas Bogendoerfer wrote: >> On Tue, Mar 14, 2023 at 10:56:36AM +0800, Baoquan He wrote: >>>> In file included from /local/tbogendoerfer/korg/linux/include/linux/spinlock.h:311:0, >>>> from /local/tbogendoerfer/korg/linux/include/linux/vmalloc.h:5, >>>> from /local/tbogendoerfer/korg/linux/include/asm-generic/io.h:994, >>>> from /local/tbogendoerfer/korg/linux/arch/mips/include/asm/io.h:618, >>>> from /local/tbogendoerfer/korg/linux/include/linux/io.h:13, >>>> from /local/tbogendoerfer/korg/linux/arch/mips/include/asm/mips-cps.h:11, >>>> from /local/tbogendoerfer/korg/linux/arch/mips/include/asm/smp-ops.h:16, >>>> from /local/tbogendoerfer/korg/linux/arch/mips/include/asm/smp.h:21, >>>> from /local/tbogendoerfer/korg/linux/include/linux/smp.h:113, >>>> from /local/tbogendoerfer/korg/linux/include/linux/lockdep.h:14, >>>> from /local/tbogendoerfer/korg/linux/include/linux/rcupdate.h:29, >>>> from /local/tbogendoerfer/korg/linux/include/linux/rculist.h:11, >>>> from /local/tbogendoerfer/korg/linux/include/linux/pid.h:5, >>>> from /local/tbogendoerfer/korg/linux/include/linux/sched.h:14, >>>> from /local/tbogendoerfer/korg/linux/include/linux/utsname.h:6, >>>> from /local/tbogendoerfer/korg/linux/init/version.c:17: >> >> already tried it, but it doesn't fix the issue. I've attached the >> config. > > I had attempted a similar approach before as Baoquan did, but met the > same build issue as Thomas that was not immediately clear to me why it > popped up. I would be curious to see how this can be resolved. I think this is the result of recursive header inclusion: spinlock.h includes lockdep.h, but its header guard is already there from the include chain. There is probably something in one of the mips asm/*.h headers that causes this recursion that is not present elsewhere. I think this should fix it, but is likely to cause another problem elsewhere: --- a/arch/mips/include/asm/smp-ops.h +++ b/arch/mips/include/asm/smp-ops.h @@ -13,8 +13,6 @@ #include -#include - #ifdef CONFIG_SMP #include Arnd