From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31234C48260 for ; Thu, 8 Feb 2024 22:12:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B6D046B009C; Thu, 8 Feb 2024 17:12:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AF7656B009D; Thu, 8 Feb 2024 17:12:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 970F48D0001; Thu, 8 Feb 2024 17:12:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 844C06B009C for ; Thu, 8 Feb 2024 17:12:40 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 662D216100B for ; Thu, 8 Feb 2024 22:12:40 +0000 (UTC) X-FDA: 81770036880.20.D27166C Received: from smtpout.efficios.com (smtpout.efficios.com [167.114.26.122]) by imf28.hostedemail.com (Postfix) with ESMTP id CA3E6C0010 for ; Thu, 8 Feb 2024 22:12:38 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=efficios.com header.s=smtpout1 header.b=iWWcaxmc; dmarc=pass (policy=none) header.from=efficios.com; spf=pass (imf28.hostedemail.com: domain of mathieu.desnoyers@efficios.com designates 167.114.26.122 as permitted sender) smtp.mailfrom=mathieu.desnoyers@efficios.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707430358; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tETCz+MewdGQ5zn9iWOBlJ25UYOqFQalFNPXRZ0WhNQ=; b=bduG4HOtJJnEtPC3drop8SphRRFFK5kfhwFAGPOclDoafHH2OyTDpRdwQFeo+MaRDpPy3z /giU5/t/wqWEb0S3FPDMf5qtENGjn9Q1rVdNZ6DgtlIYbeF45xTN9EZPhGF/xR4bb61zw/ pFQJfPPEh7fXUPCkk8LgQ2fGNqwjx58= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=efficios.com header.s=smtpout1 header.b=iWWcaxmc; dmarc=pass (policy=none) header.from=efficios.com; spf=pass (imf28.hostedemail.com: domain of mathieu.desnoyers@efficios.com designates 167.114.26.122 as permitted sender) smtp.mailfrom=mathieu.desnoyers@efficios.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707430358; a=rsa-sha256; cv=none; b=6iteAZy7vhAO5DdlJfwSO/1GeIq1pmNaYbzTmleEormXRKE0MdkMOTFudjN+xORPoHREUG TZXuwEVFnAajslTacrbKXHHJIL4ngXxxOkNno6N0EC114wFdqyyGIwro5+GbdwodfphGV6 oQupAKsxOXnENWJpHAotBY1YH9xXEfo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=efficios.com; s=smtpout1; t=1707430358; bh=SaWM1q3KRwkuItGeKAM3LJGUjBgBF2JdvDnT+CbIZAY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=iWWcaxmcWqoFAauOWqJqBCtLndtPt2l1BF+/ArVLyJihI6jbAHHUucumYgk+xw26N P3551E3iLtytFyzNQ69/j79OQKihodE5Fy/KSJIyqxv9qWGTnoF3a2LECcmwNBAKsb vcuhi79H9kIfGII2z8Ch9d9dMrCGPMpALLzCh98wCC8UUrH+mYLPkfIrKgMgbmV3zj e9NjeD9+6oFTo+WC/aQYnTqK6LrY8dMHC22nBsHC2Ca7Caib+wQPYkyZsQDs3EMdOn D4/1Ir30vdpd7VyniS+hEcxrCgA7LJR68oCAt+hx0zvvwO/dVzklnH0e+sH9habPdl PmEhO2iFFQnqA== Received: from [172.16.0.134] (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) by smtpout.efficios.com (Postfix) with ESMTPSA id 4TWB795fqgzYGM; Thu, 8 Feb 2024 17:12:37 -0500 (EST) Message-ID: <3fd6615a-a17e-4c68-9e92-fd1a6939fdfe@efficios.com> Date: Thu, 8 Feb 2024 17:12:43 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 09/12] nvdimm/pmem: Cleanup alloc_dax() error handling Content-Language: en-US To: Dan Williams , Arnd Bergmann , Dave Chinner Cc: linux-kernel@vger.kernel.org, Andrew Morton , Linus Torvalds , Vishal Verma , Dave Jiang , Matthew Wilcox , Russell King , linux-arch@vger.kernel.org, linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org, dm-devel@lists.linux.dev, nvdimm@lists.linux.dev, linux-s390@vger.kernel.org, Alasdair Kergon , Mike Snitzer , Mikulas Patocka References: <20240208184913.484340-1-mathieu.desnoyers@efficios.com> <20240208184913.484340-10-mathieu.desnoyers@efficios.com> <65c54dc181e01_afa429468@dwillia2-xfh.jf.intel.com.notmuch> From: Mathieu Desnoyers In-Reply-To: <65c54dc181e01_afa429468@dwillia2-xfh.jf.intel.com.notmuch> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: CA3E6C0010 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: u7o3fxuaygtygpxwpmuqt1bfdbsowpqt X-HE-Tag: 1707430358-187919 X-HE-Meta: U2FsdGVkX1/4S/UievvPppI8nvRJXgIj2h6HgrlBHH/VRoVOjrU/Oqi4DV5WILV11NV+hL7BW94+3Cfpl8XmqHAVdXcZjLmoVzhCkhPr/xnxe1GF3WKP1wrG3iliPGBYnvHo4xfqMqEU12Wrp7JIldo75vRz/uRsQJBFONPbKJCAJ2V262+OE77XNhAr0iU/7x47SEeWl214aPWlLlFoXjIJZKd0SlZQtIRZoFNHVeLiiebrrRM4vRozPzCIlKojMRfYHAyUYNmYCpXW7dGTFzF7oHosbsWg98uO/VTBbnsPAwJvwY9crVqy20hKjRChAwZ1dlpHcfoo6eKGdokYseIwM/r2f7ockFWE6EzGjZU4JhahB9P+RsgzAwI/itlDO1q3ZzROUd0nnhgVrKChRO6rlM0Ki32ZEro3VzL9Gq4T+OKAAXOLwFKcTAskVN6MMgSDZYXg2AteI3k4tf9K5JLAPAFhMhF4joHpS1ydDqSdMC8GhQVAdRBOxPnyqhXuP5V9h++eHp+LBj6MoMYNzbzW9WNMRMBdUKegwf4hut4sVOC2NRR3IyKF2eFTNeu5NEWDrT7YzPu3inLatzBG1eF2v+uyWk8L4AABnvO7z9wzxfpTG39tyTVO9cIrKSpKm/p6g39VPYZvBZIX4ByCMNEiY0AVCQzcH5/ZZn1AhZEXRZKKpEAakCwotAw8oM7lSWdTVJJfu/MOQjParcV0KJnrPcBWywokPyU/i6nXHFgrZ7yog9fsqBuvfdjYIW+f+dnShZ8LP1qZncBcOnZGB+Yv27d2Uv9J2TOc8Shf5hT6LMCEz/uromkIGeQ1moBhCVVQh6FCD695Ziiw+azdfR8+6iabYJwt1DY2rYEvOEuqtx+OtN0mU9WoT57M10JI1ycwSr5d6TlF9vEY6ATYFYZuqyaWUrtJC0AzPYkTKmnbwizllyUTkZXKjH/ixyfCVlzXA7oQ2iEj7hmZKo+ N8/gzHbw rK2GtplL0e+p8Wo7sYbnWXBCxkFIgf4bwZqABaOPiiL1jubFUUHe8Dholykt9Aedv+ZPPSZnB0T+xDPoqrh+3OFsi0O+VXn2Up7oDPE8isn8X6UtL/6BCMfWQULsTPdxwh6eDcN+FvqIl026tC0C1xSWWgpZoqLAjvcezdkCaavDzSV+elZgdcR7OuNm9dBkjmrqQP9ZaRKtK66/X5cVGxzoIs2nUt2RDWSeJchyKiesHu9izxDvjcQxW6Q3KMV2PREUQSrDpMDhRaUvVM+9psUbGT6gMQFQWAElXUTK+qSJwAPNscdDy1/6uADbHIk0XR31s/HM/38BQva3Jm8LcDmqKHw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024-02-08 16:55, Dan Williams wrote: [...] > > Oh... I see you cleanup what I was talking about later in the series. > > For my taste I don't like to see tech-debt added and then removed later > in the series. The whole series would appear to get smaller by removing > the alloc_dax() returning NULL case from the beginning, and then doing > the EOPNOTSUPP fixups. > > ...repeat this comment for patch 10, 11, 12. Done. Mathieu -- Mathieu Desnoyers EfficiOS Inc. https://www.efficios.com