From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82EDDC36010 for ; Fri, 4 Apr 2025 16:07:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7BF866B000A; Fri, 4 Apr 2025 12:06:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 76D4F6B000C; Fri, 4 Apr 2025 12:06:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 60ECF6B000E; Fri, 4 Apr 2025 12:06:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4215C6B000A for ; Fri, 4 Apr 2025 12:06:59 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 8B129B79AA for ; Fri, 4 Apr 2025 16:07:00 +0000 (UTC) X-FDA: 83296840200.07.F8E2165 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) by imf23.hostedemail.com (Postfix) with ESMTP id 2BB1814000D for ; Fri, 4 Apr 2025 16:06:57 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=aaju+rqW; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf23.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.14 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743782818; a=rsa-sha256; cv=none; b=xymjI0pN6J0DjuNAFbbPohXclL2hAf9eMA/+84k64h/Tu+P7ecZR7bOk/e0pULZav8/vxo Un+UuEBm8rT/iYcWO297Zo8BSVBtLddov+rACFhU42rFwS7Y/Npl+jD81YHpJ0/2jQrUl/ YZdiqcqGPDwzsXMOmQoBoIaprPOEPmM= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=aaju+rqW; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf23.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.14 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743782818; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gZZdXY01HwinpOfDX0scOXOqRXZ1fOWsPF1WPbAPzUc=; b=lBCW7JofC3FgoRaTG2FxFD72zad10ReD6s8uLerTm0rbXK+kZSYNMYojuLsQF/kxC++MtO hYUyw7YQRO9Ei5oSIy6aHTVr4idbfwSMrKsqrym5FHECyQNUXUs2iSo5ziIdyzJeQsXMTx dfRibU1RhP1wWiL3ucHvwOC3npCcioo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1743782819; x=1775318819; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=iXVoP3wKEH70qKx98Hhc6Wogu3HSHe/ZVCwkUx8UtjI=; b=aaju+rqW0wyKTbvyG+nP/mRZMb7O1A3Dr5wumKMlaFh0/KqutkgI3reN qXvOCEFTGtfzmEIBFU4B3kew/7u6wgmBOZSCbEubn1Wl5E9xX+onMT2+P IgxWAMax/nAhABnwrZf+Ju5doI9so7VaeOOkWPqFYJM/aWFojCJ/48RJU 5iECP+W5J1CTQjSsvXomlYkpvDDhBUEbsyCJuOKder662qQBvE8UnBfLi f34PZFJftiphfOAFdQIrN6HGMmilkRYatXftF1ZYBnVlQENJra0kwTo0D jO0E2zJKgKmnTpce8oX0/o+b5kVZrT1ZUdMAZm+LY1syC5/3hLACJu+77 g==; X-CSE-ConnectionGUID: 6jKc8PviTLOKMywlACjfTw== X-CSE-MsgGUID: EItsNRInQUCFRJMcsJjdIg== X-IronPort-AV: E=McAfee;i="6700,10204,11394"; a="49022892" X-IronPort-AV: E=Sophos;i="6.15,188,1739865600"; d="scan'208";a="49022892" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Apr 2025 09:06:57 -0700 X-CSE-ConnectionGUID: cO+Z9NzfR/u/1zgGGwdspw== X-CSE-MsgGUID: 96Ikxg4US7+bKvi55n+CVw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,188,1739865600"; d="scan'208";a="164554384" Received: from daliomra-mobl3.amr.corp.intel.com (HELO [10.124.223.29]) ([10.124.223.29]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Apr 2025 09:06:54 -0700 Message-ID: <3fd46452-fc96-4d50-9c40-a8a453d58f40@intel.com> Date: Fri, 4 Apr 2025 09:06:51 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 03/14] x86: Add arch specific kasan functions To: Maciej Wieczor-Retman , hpa@zytor.com, hch@infradead.org, nick.desaulniers+lkml@gmail.com, kuan-ying.lee@canonical.com, masahiroy@kernel.org, samuel.holland@sifive.com, mingo@redhat.com, corbet@lwn.net, ryabinin.a.a@gmail.com, guoweikang.kernel@gmail.com, jpoimboe@kernel.org, ardb@kernel.org, vincenzo.frascino@arm.com, glider@google.com, kirill.shutemov@linux.intel.com, apopple@nvidia.com, samitolvanen@google.com, kaleshsingh@google.com, jgross@suse.com, andreyknvl@gmail.com, scott@os.amperecomputing.com, tony.luck@intel.com, dvyukov@google.com, pasha.tatashin@soleen.com, ziy@nvidia.com, broonie@kernel.org, gatlin.newhouse@gmail.com, jackmanb@google.com, wangkefeng.wang@huawei.com, thiago.bauermann@linaro.org, tglx@linutronix.de, kees@kernel.org, akpm@linux-foundation.org, jason.andryuk@amd.com, snovitoll@gmail.com, xin@zytor.com, jan.kiszka@siemens.com, bp@alien8.de, rppt@kernel.org, peterz@infradead.org, pankaj.gupta@amd.com, thuth@redhat.com, andriy.shevchenko@linux.intel.com, joel.granados@kernel.org, kbingham@kernel.org, nicolas@fjasle.eu, mark.rutland@arm.com, surenb@google.com, catalin.marinas@arm.com, morbo@google.com, justinstitt@google.com, ubizjak@gmail.com, jhubbard@nvidia.com, urezki@gmail.com, dave.hansen@linux.intel.com, bhe@redhat.com, luto@kernel.org, baohua@kernel.org, nathan@kernel.org, will@kernel.org, brgerst@gmail.com Cc: llvm@lists.linux.dev, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, x86@kernel.org References: From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 2BB1814000D X-Stat-Signature: dsmzooknmkzp1jo53dp8feahsguhhic6 X-Rspam-User: X-HE-Tag: 1743782817-74143 X-HE-Meta: U2FsdGVkX18C0K6r/iODvTx6BvRtxLGQ1wQHc0V4Yn0XJFZ/Gcgi6T1xv29npvNOH/vRNS/IQK+dFlzcXGul64KbCjdslwYoQDByY+y/ER7Ngy35T1hRNlCmMoWBRFndR7Pxb/e41HTHe+e9oFzfIYCnKnNpPmMtkAV59aheFAcXvCQzk1Vve4L9TEoG9JXNtuWHDwIy5wXxWLrYsmK0T7JGCBqGRvjoNOMHB7ihADrmxKFoDS94B/3rmZx8NgH8OD/xPEV+N6voeWbejNJuDGgbP/TiR+RYAJP8TCIlGmmnyuL4nehhjGoQdcGb20HkDoylPphmIDIoChjAYll70F+FOXqMVq8GVSSA6YMSTXhhQmB35bgfAUUMJCmNcgi86TkQfQMAXpZMM9yxCpkZ8jNb+cS0utfhwbQla3QKGDfMqGRCsz8gG6sqeaCt1o7V6QfYembxYVrHXVvrsfQly/CncQxU3twDbBQRQv4cmKUz2ZWeiAZuB+QWa9hPgtGEHlJSXhwgeFzXYoLyJrtBXAtQrINu4XzmzhLZtFNAkNN2oAg3gx9ge8rU1xEOoHMgopm5oKo5YXtedtlV2EpYoGSwdUn+n+XRRZ9z9HpC6soWuh4QiX5HBk+gPXskRQB/WcE8STxdohdQyOpsHsAEnQMdWvF4XPsnTdZzbgqtZPHeMZiRmAZWRllb613uJXIPa8n3mH7NKzGc28vW8RuImXiZFCFsfXpTxc9i1p/T1srNSq8CzsU68FDyKAhRnB1v7UVJtpBvRptxdYiH5yU/mDDGysnBe8lew/lYiQ0ImzkLB8bTWfsOFhKEu2G9TEa25LI7yHkBBMjgoMBRhXUXTlTy77fLYg3Hb0goo8LScPtrXDyOgljxEACtfIod/viMpMYg1P94F66wDLSAHTLAXXcdA4SOfzRGbrME/ktGsIC9D1be7ttMIcRMJrtPNo2B9w33jZ8JQR4jVdW2cuJ DbGW3U92 A4OBaaPOwGWS2lNlGvoKwOq8xFxdV6Gb3UB/nD+U5VHcT8o5wImaKXlZwIIA4yL6gsMlWzP42eRjVuBevCakH1vt8cfIAYuVnpjcAM+OvtHGa6syBKgjlGqpkTSJaREZwyyiLryqdOiJ73KKDEo/W2ST4rCaQ++Dd1KnCaVhz9GAS74uze9mFc86Hkpz9Jxx7f3V5Ve1cuLVWgXUYK6agOQ9sa8Hu8woEwLrEsnuAsJWyXyao1/zk32wGqpSCdGBaNYlCIus6CHyQmJEGqwd+QIl4lw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/4/25 06:14, Maciej Wieczor-Retman wrote: > +static inline const void *__tag_set(const void *addr, u8 tag) > +{ > + u64 __addr = (u64)addr & ~__tag_shifted(KASAN_TAG_KERNEL); > + return (const void *)(__addr | __tag_shifted(tag)); > +} This becomes a lot clearer to read if you separate out the casting from the logical bit manipulation. For instance: static inline const void *__tag_set(const void *__addr, u8 tag) { u64 addr = (u64)__addr; addr &= ~__tag_shifted(KASAN_TAG_KERNEL); addr |= __tag_shifted(tag); return (const void *)addr; } Also, unless there's a good reason for it, you might as well limit the places you need to use "__". Now that we can read this, I think it's potentially buggy. If someone went and changed: #define KASAN_TAG_KERNEL 0xFF to, say: #define KASAN_TAG_KERNEL 0xAB the '&' would miss clearing bits. It works fine in the arm64 implementation: u64 __addr = (u64)addr & ~__tag_shifted(0xff); because they've hard-coded 0xff. I _think_ that's what you actually want here. You don't want to mask out KASAN_TAG_KERNEL, you actually want to mask out *ANYTHING* in those bits. So the best thing is probably to define a KASAN_TAG_MASK that makes it clear which are the tag bits.