From: David Hildenbrand <david@redhat.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Gaosheng Cui <cuigaosheng1@huawei.com>,
akpm@linux-foundation.org, wangweiyang2@huawei.com,
linux-mm@kvack.org
Subject: Re: [PATCH -next] mm/ksm: Add missing IS_ERR_OR_NULL check for stable_tree_search()
Date: Fri, 15 Nov 2024 16:52:48 +0100 [thread overview]
Message-ID: <3fca7ab0-b6b5-4110-8bc8-55f951b0ba1e@redhat.com> (raw)
In-Reply-To: <Zzdrnod2zcTeI-Nt@casper.infradead.org>
On 15.11.24 16:41, Matthew Wilcox wrote:
> On Fri, Nov 15, 2024 at 11:44:10AM +0100, David Hildenbrand wrote:
>> On 24.10.24 05:23, Gaosheng Cui wrote:
>>> The stable_tree_search() maybe return -EBUSY if the stable node's page
>>> is being migrated or nullptr, we need to check kfolio with
>>> IS_ERR_OR_NULL() before dereference it.
>
> Argh. I doidn't notice this when it came through. Andrew already
> folded it in, but it's utter garbage. We don't dereference folio.
> NAK.
Ah, &kfolio->page indeed doesn't de-reference. I was blindly assuming
someone actually ran into an issue here.
Thanks for double-checking ...
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2024-11-15 15:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-24 3:23 Gaosheng Cui
2024-11-15 10:44 ` David Hildenbrand
2024-11-15 15:41 ` Matthew Wilcox
2024-11-15 15:52 ` David Hildenbrand [this message]
2025-09-25 8:02 ` [PATCH] ksm: Fix potential NULL pointer dereference Fushuai Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3fca7ab0-b6b5-4110-8bc8-55f951b0ba1e@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cuigaosheng1@huawei.com \
--cc=linux-mm@kvack.org \
--cc=wangweiyang2@huawei.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox