From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87E90C7EE29 for ; Fri, 9 Jun 2023 08:48:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0FC968E0002; Fri, 9 Jun 2023 04:48:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0AE758E0001; Fri, 9 Jun 2023 04:48:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EB8B68E0002; Fri, 9 Jun 2023 04:48:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D8EF88E0001 for ; Fri, 9 Jun 2023 04:48:49 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A8CE2140185 for ; Fri, 9 Jun 2023 08:48:49 +0000 (UTC) X-FDA: 80882583978.13.FE1AA5A Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by imf29.hostedemail.com (Postfix) with ESMTP id BE527120014 for ; Fri, 9 Jun 2023 08:48:47 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b="rJc//ty1"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf29.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.167.48 as permitted sender) smtp.mailfrom=lstoakes@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686300527; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zSGqb02gzoaEjtKR6JU66NNivYp/3SwH4FmhCExXxIE=; b=BkOKDwx7GaiTm+0xV8X9SiiHR7c6G8B4WkublS6RAempd+OlVWKqF7i+uZxrTcuyg2M+G/ WyAhlpia38i4fMhx94pE3yn6pm2Oq/ZmTwKh6cgfCCxeq3DFQXvfcDjU3tYKBKF2mLVQYQ NXBgGXHYo4/O12Detr6sYtgjF5wbo1Q= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b="rJc//ty1"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf29.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.167.48 as permitted sender) smtp.mailfrom=lstoakes@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686300527; a=rsa-sha256; cv=none; b=bfC7lJckQ74EHjpUHuJqXonqohCzjFGZykAudBYS/5LsT3PwCnAebjP+2CTbKXuX5HFfgn kq2C+0SLMJB1n6RTFouPkqfmcoRtvoTaO8qPBCk1hlo17ZCPaoDInyMpMyddTKcuJpTQi3 QyCOuNzxPaWwYKJamFtWY1uSygXpaGM= Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-4f642a24568so1849161e87.2 for ; Fri, 09 Jun 2023 01:48:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686300526; x=1688892526; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=zSGqb02gzoaEjtKR6JU66NNivYp/3SwH4FmhCExXxIE=; b=rJc//ty17aedU5JQdky1ceN1yEvT+ypVHFV8MnwcfbRyjg4Hi5lmq4mt93HSVJwwYA 6OULR2YfWn1tkeiRjxX4t7FwXmfOdGi2vlqvfEqBcIj4OmI1v1Niwial/LIsLOAj8NFp 5blY6UoGvEPP5QzLaKqb8Y7/lULPmDIjI2eaKMB/T6AGRq6/Tjic5qHp4ateXgEZq22Z GzwrxV7DIPYML7f4B50SXd1SNswEg4GOcdRJ4Vp+ieaEHcKxCm/7zwBNX9V8KsgWcLxo eyfizkHCl99g5U81fg4IGjyUCQpSiNIxchJb6eXRoGXZgfqmWkH+9bMqNjz9xjRWCoYH UoIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686300526; x=1688892526; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zSGqb02gzoaEjtKR6JU66NNivYp/3SwH4FmhCExXxIE=; b=Gq9RPYBsT7OIURtzqonSCZu9tiEeoA0Fch2Y3cLOoakN8G3FP/pU7z8PCuLJybnUsC 1irythhvytKRf0N5Aux//fhGtBCxh1uovyRZb4BndA30FoyPRrifrfIS9yN8Y+lj4SPV +Tf3rMmCCuvvY+ziMmVyi9O8QZ2/zFfsCqMgKeDhFRa8FWGJ08MEIkppHPFHzdqr1Z6A uc1BszA2DCeRCyAKDidX/tIZef+A8QU9fVdm9OUNCI+iuk4m/+bQTlUwyJf4q4wdIw3p ML+6ul1UoZGvnzUMnVwpKKx8R9/49AxrNKr5ySAUYNSR4nBNzkyQKfLun4RXHbwu/wy+ VaGw== X-Gm-Message-State: AC+VfDw5WaTNS4FJ+RgbHz3kHZag0j/5gpbNDNR0F0T9zLBHOq3JvgYd N7VEUsAv4RanRRcxDeRN2So= X-Google-Smtp-Source: ACHHUZ45QRL6crB+3utek4atjv3kIidZdpGzBDG6SbAMc8bVK42uK/blVBB64NKZxVvw26ozHHbuDA== X-Received: by 2002:a05:6512:205:b0:4f2:74d3:8996 with SMTP id a5-20020a056512020500b004f274d38996mr390574lfo.8.1686300525546; Fri, 09 Jun 2023 01:48:45 -0700 (PDT) Received: from localhost ([2a00:23c5:dc8c:8701:1663:9a35:5a7b:1d76]) by smtp.gmail.com with ESMTPSA id f16-20020a1c6a10000000b003f60fb2addbsm1922377wmc.44.2023.06.09.01.48.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Jun 2023 01:48:44 -0700 (PDT) Date: Fri, 9 Jun 2023 09:48:44 +0100 From: Lorenzo Stoakes To: Lu Hongfei Cc: Andrew Morton , Uladzislau Rezki , Christoph Hellwig , "open list:VMALLOC" , open list , opensource.kernel@vivo.com Subject: Re: [PATCH] mm/vmalloc: Replace the ternary conditional operator with min() Message-ID: <3fc87d60-4e81-4f49-95f0-0503ad5cdf35@lucifer.local> References: <20230609061309.42453-1-luhongfei@vivo.com> <832d7c69-ffd5-4764-8ffe-3a02bef0efb0@lucifer.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <832d7c69-ffd5-4764-8ffe-3a02bef0efb0@lucifer.local> X-Rspamd-Queue-Id: BE527120014 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 4k1egtn9n7mkyadycobt93ucdghphu7d X-HE-Tag: 1686300527-767512 X-HE-Meta: U2FsdGVkX1/vO44B7AeOSiGRvicuOQvgyMYaMFIGpaTISSpcKLqsN2PBVHocBYh7CnqFjCrq7ldre/T6tyEZoSQtzNirgbj8gF6aQbXkCaOCr7/pIo05N+PLQDHPGUZa4YJqXolfbJV251hFFXsbvKEU/68nFv0qcGshpwJ2Y/wnFofpAlza8hdrk4dX6eK3UsvVp05yfI164ZlJt15pvVV1YqEV2l+7WdGLgAG8OiRm9ajC5pdRU5wxwq48iV1ylduUj8HyPN0NThXLzU31U9vE/hP5byKVqwTXCUUfQfXlE4r+YFZBYjflT+cH9b9R5IrrQSPiz5WAtNsai5lnachr51tdCIOs8t+3918ljFHnMY+U5UCUctlR+KGuFdvcYeV2SUclsJ4UvbUnX1OEKq1Or0SWC6msbKyVze5nBh3Fl6XlzQl6ddXGUOrs83ugliLc5R3AgOmDBiik1bkg7/JEoCwEQKCKtehHVh3VxcORKUzv723CS4I6RMn0S1sZLkcOa1IkF5AsY+9CejzN7/UR9O3HBhmoKfSZX8QbGZfBxD0s+mhdcXkyFiJtnCrPYrWEpcbhV5RfF1T9beCY6eQusVXjXsX0zw+zUazDdcMHylE4NEUAS330iEetA+GnZIxW7EZBmf1Sa5NphqSt/8MU57EJ/2IPhHNkMsKyQPTvtOUfLOuNeWAIM7QdeuNIWKf6JkfXfMsRJajE8RJsHElliKINTmkLKPT5DguHnc4qi+mleeFHKz2DxdpU4O/6LSR2Z3V5OhFjm84aNWZY8vGAEouitUSo77g2kqjZxxfgIfptb+p9usKHfGO5OM9rc2UonPFps0OE0jBQjIOU6CIgf41buyHo4I4dT35/szct0Y2rMhTeZla9RnPFLob6bRGcBVUS+nqfnVsNkqfhYFsl2OBvR3Ls/085llDHnHJC7TlvMli5zEwyA2iRdbZlQW2kWNvrbZO6IRYCDye XKiDJ8x3 3OrrIVZevH8QNOtrGiiTJkA+xkE4dI4yuieV8CCf8Th3Y5vEaw06OsL8nonQDdfpAsw8f2mgpL5PRx2BepxlMDA3xcp49UW766HAstJXTgXuO84Xljpj7H9bgAIlMEOj/8WwZBVHXbBpgkoKYp3KeA7etIURYLhWX8Le5PWVycqf+J4Q6bfMWSTATr3tudRSWshciYmiOK9zTp7GBmmEF5k/gzsNmosSv2DGBzjGpyLd08NiUX//X2YCyf/asswHd7GLBmnWK/ITz1ynZWFDZImFJ8cLwKi5ifsn8pg4ZZdTJBAG2JHxxDSA48l+Y5AbeYtcNbb+1fBe84HNfCqH5zjsbFnEmjei58hRkHUQRV8FpZanxuPFfwrMSlVUgUtz5z9R84VA0a9blYMi6D3FCVRITRwFVjeTV+1xpYH+bFRYhSFpAuTQujF7P2IjMB9KnDOS+XOfTn4C/uD3Vmy8EXb3HaBnVimsXwbDn X-Bogosity: Ham, tests=bogofilter, spamicity=0.000011, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 09, 2023 at 08:09:45AM +0100, Lorenzo Stoakes wrote: > On Fri, Jun 09, 2023 at 02:13:09PM +0800, Lu Hongfei wrote: > > It would be better to replace the traditional ternary conditional > > operator with min() in zero_iter > > > > Signed-off-by: Lu Hongfei > > --- > > mm/vmalloc.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > > index 29077d61ff81..42df032e6c27 > > --- a/mm/vmalloc.c > > +++ b/mm/vmalloc.c > > @@ -3571,7 +3571,7 @@ static size_t zero_iter(struct iov_iter *iter, size_t count) > > while (remains > 0) { > > size_t num, copied; > > > > - num = remains < PAGE_SIZE ? remains : PAGE_SIZE; > > + num = min(remains, PAGE_SIZE); OK, as per the pedantic test bot, you'll need to change this to:- num = min_t(size_t, remains, PAGE_SIZE); > > copied = copy_page_to_iter_nofault(ZERO_PAGE(0), 0, num, iter); > > remains -= copied; > > > > -- > > 2.39.0 > > > > Looks good to me, thanks, > > Reviewed-by: Lorenzo Stoakes Please spin up a v2 with this change and then you can take my Reviewed-by tag :) Cheers, Lorenzo