From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50A95C46CD2 for ; Tue, 30 Jan 2024 04:26:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A26F16B00AE; Mon, 29 Jan 2024 23:26:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D6676B00AF; Mon, 29 Jan 2024 23:26:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8A77A6B00B1; Mon, 29 Jan 2024 23:26:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 773896B00AE for ; Mon, 29 Jan 2024 23:26:31 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 3786D80246 for ; Tue, 30 Jan 2024 04:26:31 +0000 (UTC) X-FDA: 81734690982.18.5BB0CD7 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf08.hostedemail.com (Postfix) with ESMTP id 456C616000D for ; Tue, 30 Jan 2024 04:26:28 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf08.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706588788; a=rsa-sha256; cv=none; b=TeuRYEZ52vRn17cbajyIlki7eEp79PAW4i39Ad3/hyWSyMN4tLhmB78/uO327tN2AY9RL1 wXw18ujNXGmrJzZK3fSYLs5wK7eSERPrtsJfhGujfU86U7pHU+ZJda/D0JV+9rsTGrmLiV EmcBAZagcaRm/iPeCtyHudm6bDmNDe4= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf08.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706588788; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E8YWZSuX+7i5B016etblhfbrPqzIgaYEXbp7mvjkmxw=; b=mR2iCNw/jYeMDhcNhVyOFbiUxaNnCa/L70wYvkEw/BNdCi8/Ej7j+ylkIEGEemmtmSlLYe gsmKAhtuEAh+SQ1MKvFMLqK23GSRcQbxd3MMDlN2kzbo/tdsIp8rzOc09VqR5UsPVyYqZz K/ft1DjHeMD9cpbmm1wQVz9TbHFxvzI= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C3D28DA7; Mon, 29 Jan 2024 20:27:10 -0800 (PST) Received: from [10.163.41.110] (unknown [10.163.41.110]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 31CBB3F762; Mon, 29 Jan 2024 20:26:13 -0800 (PST) Message-ID: <3fbfb5fc-83a4-49da-ba75-9b671ffe0569@arm.com> Date: Tue, 30 Jan 2024 09:56:10 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC v3 01/35] mm: page_alloc: Add gfp_flags parameter to arch_alloc_page() Content-Language: en-US To: Alexandru Elisei Cc: catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, maz@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, arnd@arndb.de, akpm@linux-foundation.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, mhiramat@kernel.org, rppt@kernel.org, hughd@google.com, pcc@google.com, steven.price@arm.com, vincenzo.frascino@arm.com, david@redhat.com, eugenis@google.com, kcc@google.com, hyesoo.yu@samsung.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org References: <20240125164256.4147-1-alexandru.elisei@arm.com> <20240125164256.4147-2-alexandru.elisei@arm.com> From: Anshuman Khandual In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 456C616000D X-Stat-Signature: fu99bheduzs3sxan9jqybb9ta5y4998g X-Rspam-User: X-HE-Tag: 1706588788-399698 X-HE-Meta: U2FsdGVkX19vFhNQUMpu1xGhTF6SG3kOd3zsrTnP03S1LGkzRFZfuwFLbcAyZDGsz82cE9YJkB7fVar5c3di0Z6hn6MVtzVrrIBUCDqVaro4rd7Jor1cgBLHky+wat3RyF81s1zfB1H6mQbzZLQ9pcYtbyAmffYrxLopwqsyBzgm3F5l0O8iH00sUqy2+67CAIJqlZVlse97C5d84omC2hGYXEvQrkUAa3zMPfCexV4hLh6vDBVfhmPz2iht2kXODk90oOZnWn7/TQk+Hq1lv6LzGIVOHc3Y8CHvE0GocFRm7YjJQb7s4wm7QF7IJP7PNfy2DyRetv9DgRcCYR6x81ahFx5nTwEzdloizIyIO+Lr1fjqZSYdKCRZLEh2Q9dw+Rv3fnM3qq93m50C6UfMuanxhwB5qk4EiTHU41w4t0uPM5L1LlZuSIWG6AFqXim/NZa9NJ5RCa249v9wYv34ys16ums1yCgmSEAMZ+Go2TfAIyDz8DIG16MPnl8fFrLWXRslSb/vXmxT40wG7z0YbcjknuYHqm+Qgl+1nLBAF8Jty9+qGsfkIchZGCk3rSwjAdB9kKZF830bO45uslTpSz2kbe86rZOT4bkcga0ZL/faRYw53LLtPvS/ua6xcxTFWW94S6rPOkQrl3o9M815nqwJ0XCfbrJDDvs8SKkBhxXRhfru/IAVnKTPBDgUk62HYeKj5sd6z3FO9vV5gSUj25M+F+NHlDx4b25n29xEi7FxZFdk+SJo72qWiQt5C+2t8159bWbky+ZteBMRQFZry2x4pyNKHHMS4xs8rqAPendW1FBL9GB3h0pwNNAnoSAi63v1btmW+r3TdN6tT7qwvZjrVR+GV3lUUEQl/VSbs0JUpSf8JujcE6ZJ6i29fmn4lwnHLpuCu1mGC8+eOM1+TFdamQSyBGHp81NDBllTXkj0DumwUbscQAD8bCm/T9pnjXPod45gFZ84hab5nae LR8mteQz JDP9es63ds40lca8EvnIRn8RpDX3RHIczOFZ3vF4+0klrDxt07fqC8kdKrdBwOYDLQwqQAC58NC/zryGwuk5fab/3nWSgAW6HQ9k3OLsJKJfSaqXvkZnLaMmrv95+Efcts4lixEm6/EEQeBUUgaFWBtUiYHSDQUNoHjOGtp6/Fs8pffaPXEh9OmpN6MIIfVff37BkTVgb1/J67a9tZW8cEtQxu7Lqu35AFm2zLUqbM0BjTmzr0l6eug5cb8A4biXa2Se5UdgibBh2WfZujBrFhhVdfFN3vx+cQt0JKjgT1dGBf+CFgpp/Lhd51g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/29/24 17:11, Alexandru Elisei wrote: > Hi, > > On Mon, Jan 29, 2024 at 11:18:59AM +0530, Anshuman Khandual wrote: >> On 1/25/24 22:12, Alexandru Elisei wrote: >>> Extend the usefulness of arch_alloc_page() by adding the gfp_flags >>> parameter. >> Although the change here is harmless in itself, it will definitely benefit >> from some additional context explaining the rationale, taking into account >> why-how arch_alloc_page() got added particularly for s390 platform and how >> it's going to be used in the present proposal. > arm64 will use it to reserve tag storage if the caller requested a tagged > page. Right now that means that __GFP_ZEROTAGS is set in the gfp mask, but > I'll rename it to __GFP_TAGGED in patch #18 ("arm64: mte: Rename > __GFP_ZEROTAGS to __GFP_TAGGED") [1]. > > [1] https://lore.kernel.org/lkml/20240125164256.4147-19-alexandru.elisei@arm.com/ Makes sense, but please do update the commit message explaining how new gfp mask argument will be used to detect tagged page allocation requests, further requiring tag storage allocation.