From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48515C433EF for ; Thu, 2 Jun 2022 07:45:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D51A26B0075; Thu, 2 Jun 2022 03:45:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D00EF6B0078; Thu, 2 Jun 2022 03:45:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BEE936B007B; Thu, 2 Jun 2022 03:45:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id AC8286B0075 for ; Thu, 2 Jun 2022 03:45:21 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 71D1033D21 for ; Thu, 2 Jun 2022 07:45:21 +0000 (UTC) X-FDA: 79532510442.15.2E2C9A0 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf27.hostedemail.com (Postfix) with ESMTP id BC2D44004D for ; Thu, 2 Jun 2022 07:45:16 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.56]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4LDJ0n39kgz1K9Lv; Thu, 2 Jun 2022 15:43:37 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 2 Jun 2022 15:45:18 +0800 Subject: Re: [PATCH 2/6] mm/page_alloc: Rename free_the_page() to free_frozen_pages() To: Matthew Wilcox CC: References: <20220531150611.1303156-1-willy@infradead.org> <20220531150611.1303156-3-willy@infradead.org> <6777286e-747d-93e7-f361-c31f8e481bb5@huawei.com> From: Miaohe Lin Message-ID: <3fbbab63-a690-56fe-ee32-5ef5c8d43419@huawei.com> Date: Thu, 2 Jun 2022 15:45:17 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected X-Stat-Signature: uno9d1cxfkj451y3kjzetdfygkuc8ety X-Rspam-User: Authentication-Results: imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: BC2D44004D X-HE-Tag: 1654155916-283515 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/6/1 20:23, Matthew Wilcox wrote: > On Wed, Jun 01, 2022 at 02:58:23PM +0800, Miaohe Lin wrote: >> On 2022/5/31 23:06, Matthew Wilcox (Oracle) wrote: >>> In preparation for making this function available outside page_alloc, >>> rename it to free_frozen_pages(), which fits better with the other >>> memory allocation/free functions. >>> >>> Signed-off-by: Matthew Wilcox (Oracle) >> >> Reviewed-by: Miaohe Lin >> >> Thanks! >> >> BTW: I thought it means we can free the temporarily frozen page (via page_ref_freeze) now >> when I saw the name "free_frozen_pages". ;) > > Well, you can. Before you'd have to do it by calling free_unref_page(), > but now you can do it by calling free_frozen_pages(). Sorry, it's my mistake. We can do this indeed, e.g. shrink_page_list is doing this via __remove_mapping + free_unref_page_list. Thanks! :) > > . >