From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D9DECD1288 for ; Thu, 28 Mar 2024 23:41:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 077BC6B0095; Thu, 28 Mar 2024 19:41:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 027E76B0096; Thu, 28 Mar 2024 19:41:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DE4606B0098; Thu, 28 Mar 2024 19:41:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C12F96B0095 for ; Thu, 28 Mar 2024 19:41:10 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 814DEC0FD8 for ; Thu, 28 Mar 2024 23:41:10 +0000 (UTC) X-FDA: 81948071100.22.DBFBECE Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2099.outbound.protection.outlook.com [40.107.244.99]) by imf25.hostedemail.com (Postfix) with ESMTP id 7B3B9A0003 for ; Thu, 28 Mar 2024 23:41:07 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=os.amperecomputing.com header.s=selector2 header.b=M7SzFza5; spf=pass (imf25.hostedemail.com: domain of danielf@os.amperecomputing.com designates 40.107.244.99 as permitted sender) smtp.mailfrom=danielf@os.amperecomputing.com; dmarc=pass (policy=quarantine) header.from=amperecomputing.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711669267; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ifdDr9Pm/vCS2faiLvXwMKlUrOVmpwk2L+9S97LuZOM=; b=dYUmdH4fvVMsSFWU7SyynJIaq+kg52/htuRZxriUQRUF2XFoglk0ARLjF7PGDhN3JMfV9R gaG2RpmlSCPw/s9EvEvF3uncuIYxQ5fOGZSd6oZNPBhlFKbaeqyLx+/1bsx40K6Ql4CRJR S5bnV+E9SpYuMS/Aj4URUcbza6UB49k= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1711669267; a=rsa-sha256; cv=pass; b=E2nRq4tQZdL6Chc+0x+Y6F2SmAHa6TLfeyIxEN3SiA31EucqtaIcgNnmmLDH9VSaCfmMqe +hbIYNTV73P16TlQCvF7f86djbXcLPtNNiQLdsV6giVdwHt2gqdbOCVqEo6gFAniIZ7Kw2 63p90uTpyNY2UQN6/wwTpRD3S+fJNbU= ARC-Authentication-Results: i=2; imf25.hostedemail.com; dkim=pass header.d=os.amperecomputing.com header.s=selector2 header.b=M7SzFza5; spf=pass (imf25.hostedemail.com: domain of danielf@os.amperecomputing.com designates 40.107.244.99 as permitted sender) smtp.mailfrom=danielf@os.amperecomputing.com; dmarc=pass (policy=quarantine) header.from=amperecomputing.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PKcXWm9PFUczcLxegPJlv/4ny4H64FxAAvLdSs6hMo7f+Bcc1zKUIk/9Zdqgut6sQtSobqq8quqpYx6NDDpOmsqMcARWAPZEU2GIdHQ213NTjwpdg+6aTTZ+V6IaulSqoWsoKAYYPJV92MvbkeKYHX3+L749Hoa7s2g5N4Rq0u9drJyDruy6SKdhhUfLjAVGDsXR69tEnPecqAyfNWAWGq3jOfyENeMe2Yq/yOY0oHMCoTzMq8OWxJhKykJtsD3Yzvq+I8lcGleHMWJ2Dcvrqd02w3tiY7e+1ZVSLWzA9uT7IhCED0/naJq38A5sEW6rkGQMMaftNDzZ2TPvTcvKxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ifdDr9Pm/vCS2faiLvXwMKlUrOVmpwk2L+9S97LuZOM=; b=NWdJpqnJeH82XsnIXR4gGIpo9uESKFF8+o4SDzXL4plppw/Ofe8grYND+I+s3ptKd0QglGAwDrvKLU5R9/WIyMKOKzOKcI9UxEwIFV7g9MZbjlf390UrdrGZ4byEnWsRIdIs6qZYnJQC2mTCYX3uts7+5OHee/HO/b2zMIeeldGNdVb6f4OuOXwp3SI8qRo9BfLxxS/veJgM3nKiTEzfEgliCNYGvGzIR4Oy60bujnyDfQntkws/txNrBo0XEX4AdJ0tNS5mbI1vdt8CF8SkSB8mvvTDgM+0WdJGnxAOl+fCu7KZm3yX7VRwLNRIfyoEa64ne0KqEpD21ROUxGu2bQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=os.amperecomputing.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ifdDr9Pm/vCS2faiLvXwMKlUrOVmpwk2L+9S97LuZOM=; b=M7SzFza50WnPNBBysi9LJAgYUVwUNygpELCwoWjMnEB04JzoF85Q1bsVJFPw4GTrPn7TU21DcXF2OzpKYFYfgIeT377W+sSBLXEQ87q0ldJQ8QUUMUvif0eIe4ivUrrFKiKUpaxkqSYtKrkU/ifaclaAAQvC+sygfU9JH5T2jHU= Received: from CO1PR01MB7370.prod.exchangelabs.com (2603:10b6:303:159::16) by SA1PR01MB8180.prod.exchangelabs.com (2603:10b6:806:339::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.33; Thu, 28 Mar 2024 23:41:03 +0000 Received: from CO1PR01MB7370.prod.exchangelabs.com ([fe80::994c:4200:8a4b:6882]) by CO1PR01MB7370.prod.exchangelabs.com ([fe80::994c:4200:8a4b:6882%6]) with mapi id 15.20.7409.031; Thu, 28 Mar 2024 23:41:03 +0000 Message-ID: <3fa20038-347f-48c3-814c-0dc1ed109244@os.amperecomputing.com> Date: Thu, 28 Mar 2024 16:40:58 -0700 User-Agent: Mozilla Thunderbird From: Daniel Ferguson Subject: Re: [RFC PATCH v7 10/12] ACPI:RAS2: Add common library for RAS2 PCC interfaces To: shiju.jose@huawei.com, linux-cxl@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, dan.j.williams@intel.com, dave@stgolabs.net, jonathan.cameron@huawei.com, dave.jiang@intel.com, alison.schofield@intel.com, vishal.l.verma@intel.com, ira.weiny@intel.com Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, david@redhat.com, Vilas.Sridharan@amd.com, leo.duran@amd.com, Yazen.Ghannam@amd.com, rientjes@google.com, jiaqiyan@google.com, tony.luck@intel.com, Jon.Grimm@amd.com, dave.hansen@linux.intel.com, rafael@kernel.org, lenb@kernel.org, naoya.horiguchi@nec.com, james.morse@arm.com, jthoughton@google.com, somasundaram.a@hpe.com, erdemaktas@google.com, pgonda@google.com, duenwen@google.com, mike.malvestuto@intel.com, gthelen@google.com, wschwartz@amperecomputing.com, dferguson@amperecomputing.com, tanxiaofei@huawei.com, prime.zeng@hisilicon.com, kangkang.shen@futurewei.com, wanghuiqiang@huawei.com, linuxarm@huawei.com, wbs@os.amperecomputing.com References: <20240223143723.1574-1-shiju.jose@huawei.com> <20240223143723.1574-11-shiju.jose@huawei.com> Content-Language: en-US In-Reply-To: <20240223143723.1574-11-shiju.jose@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: CH0PR03CA0181.namprd03.prod.outlook.com (2603:10b6:610:e4::6) To CO1PR01MB7370.prod.exchangelabs.com (2603:10b6:303:159::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PR01MB7370:EE_|SA1PR01MB8180:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: x9U8wRyPi+zxslJVSyV/8r7cszUcc9hmYG8s2UXPgYz9wK+G8KIosxFpHeZATJCPEWDQderhmH4/RBvi+Np2BKebfpDFe8xrnfJDoOzVj/cWJQcnoraIOBnGvQ2TE3eWnbfp0kN04ArsliTD0/S7YEbSSeZiqfa0f1CI+YUPqlUE1E+Oa+lBCu5xPwWTDq/1H6SpCiFouGe/ATzK7rLSQw3uT6N/Mv7loi0bm6BqzKnhfhH6pKJ9wuwSDSPvdndlvp37+qPjErkcOXnxlC+SqVkXB5o5Ate1VsYdKA/xpyDijrsa2bj591KyrufIXsF7VhzEAbEmaFQ6i6l6H+FqU/XNEAF7iNMkI4A0NisOqTFQawzZjaZ8KsHm50uA5qwqUh8mWtTCjbRrFzm1S+LFps4Tgg06x4xmQGKAFopr4rFFUqfcMYNIDe0lf1i+gipJQ4/xmEUQNnotx/pZMaF0OUJf+eFW6fdUrD0gRzPLT+VyB0USj59IaEmX+t1iB6SMmvBwphfpBzALFL2FXNn3d2t3xVzHJbB6d+9K2xv6ozroryHz7IXEPbdnhcI+lmGDLhCMfPD6sG3LIfzSJxxaJQ+3deXipPEj+AkSw7+NbeEWxGWUrKdxmnPmgel/OH4xW9Q8tzjyYySQTYr4JKEeFrGJd3LYl8O/ra4+5g+CMYopVeyc7FfcjdNnQ2fqQ2DB1LnI2emzzDIYJGeTkAN84YoMLA1aONLGtUm9sLoOD4Y= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR01MB7370.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230031)(1800799015)(7416005)(366007)(376005)(52116005)(921011)(38350700005);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N1ZPQmF3ZU9LVkdiZ3U2bmcraFZNeDZoWHhwVjFpZWp1WldyZWlTTktibUVy?= =?utf-8?B?VERqVGsvMEJ6V1JwVzNpSG04c0JmL0oxUXE2RDhxOHFSWFdvUjlnbXQ5SCto?= =?utf-8?B?bHBjOUtxMzBBTlI0ZlRqZUIzOTdVem5rcTNETU5zaFJQVEtvL2FySHJNeUMr?= =?utf-8?B?QTVhUlFlZnA0TVVjTGhiejFuUFNwS2NoYkRKb1V3MHpFUlZ2K1NqZzE5WllS?= =?utf-8?B?aXI3ZG94b28rTTF5MHdrZEVDT0lSQ2JJd0RLL2RoNTJBOG1jUXNKV1NLYWla?= =?utf-8?B?M01OUUxiRFY5L2VxWHdJbkpSdzZNU3kyaTZRNU1OWHd2dU43MXREZy83bGoz?= =?utf-8?B?U0g5OVM5NC9DSnZzT00vNzVZTFBiTVVMNzZreHZIUVB4OXVhZVNHU0dsZW9J?= =?utf-8?B?WFNvM3VmWW5ZMmQrYmhLVm0ycTh1c0tmN1YxRHYwL1BtM3hSRW1ESmZTZHdC?= =?utf-8?B?d1ZWb3c4L1A5Y3JMUE10ZGJiZm5sa2R2QVZHYm04NUdMVnUrckNIUjVNTk1i?= =?utf-8?B?Y0RLSHcxV0xKemhoN3FyN0taeFZ4VFp6eUxpTnhTNTVNT0IwN3lvVE5GTDk4?= =?utf-8?B?T2hOUnBkTVdtUVpUVG5Dend4OFRBdTFiK3dhTmNkU3VydWs0SnpUZDFZRzFD?= =?utf-8?B?WjhXbE9hUnRLelF3Ry9TWkxlTFJaSHZhdWNQT3VldGJEL21jN2VKOEI5RGs0?= =?utf-8?B?Ry85eUc5U01DUjI5SjV2VlVKMWt0SFErLzNNYy9sWC9rRXJZREVPdFRsWjZj?= =?utf-8?B?NGhkRHBNeW8ybmxMQ29qcEMwK1RzQTZvT1Z6T1E0QnIrbVlNQTBvWkpxZVJR?= =?utf-8?B?aVVseW4wUkdma082VzNtNkh1YzdvUWIxMldjb3ExSGRpUmQ0RDBqeGxmdTZU?= =?utf-8?B?OG5zSndJSmpwT1dEV0N0ZitNaUtQaEtEckQ4aTdodnY4S2x0d3J2Zis3V2lr?= =?utf-8?B?VWxqUWwwQTZTZWFUamQ4N25iUVNPL3l3TEZDREo4NVhwZ3pnRnlzTmpya1gy?= =?utf-8?B?TmIrYjJQSWQrTE1lNHRxamNGZzFKSk85K1NUL0hFVDBtNVl2V2xpUjUwQlB3?= =?utf-8?B?cTdwQzBCOUd2aGk1ZENzNmRiWWFEVTVwd1o4RmJLaGRDRDZrdmVXV1BYK3d4?= =?utf-8?B?MzVBZGtTSHdUM2h1NkNqVjhJRkJYdTJRK1FxcGpkcDNOSnU5ZDd1UHJWeWRo?= =?utf-8?B?dENURkQzV1B5R2tyTVZyNm5RRE5zb2dUek1TR29BZ2tFSm0wdEQxMkEvd21l?= =?utf-8?B?Qm5RZjBTOS93aTlIbHRwb2MrY2VPb1liWWdxMVdQcFlvOStEQkVOYzE5UTJ4?= =?utf-8?B?dFZoVEc0NjZkNmRWTGROWUNPMU05WHg1QXFOcm5WL0VGMElNQUdZbnlHZ0ll?= =?utf-8?B?SjlyNzRZN3VVYXcyMGxTVm9LRk52bktSUmcrZWs1dGdDVGRXZzFUNkZTdHFG?= =?utf-8?B?RHAyT0FKcmpXaEtQL3dma3ZsNXc1UEF6RjZqR0FxdkZqbWVTd0FTYUZSRWJB?= =?utf-8?B?REFrLzFUWWJMOERnOThhR0lsTmNGWWd1NE9WL0ZpNkJRVDlhYllLM1VXbEJj?= =?utf-8?B?cXdMWlFPZHpkRWhNUVBadmNabVU0eDJxckx5cHJwWWZKRUtBZEl1TUhpVmlL?= =?utf-8?B?aWpicStBcmo4TE5UQTQrRFh5dEtDNWo5bURQa2ZOR21zZFhwYkNuQllneDVQ?= =?utf-8?B?N1RmVU9pS3ZCQTBjaUMwZU9pemJ4aUtic1JTazFWN1JoY2JlRzBhK2NDQjNN?= =?utf-8?B?b2N1d2kzU2l2dlZacHZ2eVpRVFpSdnlMS0Uza1Z2WkNpbEdXOU1aL3JsL2Jy?= =?utf-8?B?SnZUYWF1UDgvczlEVUMvSGZ0bTR2OXpEdEN2a1BCMmVTNlNNZmZRd3RQY2xU?= =?utf-8?B?S0hUYm5CM1lpbGRFY3UyTmtQbGU0MUVnSWEyRWJQUFFIeFdic01zZzdvNHln?= =?utf-8?B?eFBwZGJBSUljci9wSkRPUTZQRDVvaGorVGh0MmlGdjV4U21XKy9PaVZUQXVS?= =?utf-8?B?ZnJDWVhMaWhtcWNMYmVFYktFaVBaOWsyQnQwVTZyWWFhZjM1aW16azFSaHEz?= =?utf-8?B?R0U5YnBMazRueUxiL0pyWXoyS3I5L2ZKc09TZUJnZUp5czFJRHJYZjlVNXVY?= =?utf-8?B?RmVrT2JiK0wwQWMramZYbDh2VVd4Szh0VGhtaldKdEVpcmNKRmJ2WGFyZFVr?= =?utf-8?Q?ScWHCD6mRsCMYLf8MKO9LAw=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 31f6dbdc-47d1-423a-3a02-08dc4f8087cd X-MS-Exchange-CrossTenant-AuthSource: CO1PR01MB7370.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Mar 2024 23:41:03.4497 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UD5iQSivVZDHIqDm83n1MzCQAm1PXSlT/4mSH989GCOSZ9P43Udlt7KUfR+6Ed+Da9mduu6dVnGL9JOb6uK1DEIgTv0Z9UByPXxHEjBa7vtuxcAfhfizAsvHBOxqKI8s X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR01MB8180 X-Rspamd-Queue-Id: 7B3B9A0003 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: uf7o57ceyisrxixs4w73xo4su89ktck8 X-HE-Tag: 1711669267-655348 X-HE-Meta: U2FsdGVkX18RVbw+gKVuSw5S8NXIcluM1Y520HVm5OZ5lkU9Zd4Tc1fDQvSu/QY/GcOL7ano6egJbrGG+8KVf9oB72zeFZCvCo0VaCJSRkaCD3KH3XYG3HsM+KcaqlVweHaChRgvg+I7ZobRBlsDlduuSSNTpWFLRxDFhqdCPY76LFChpbkplJmk8L6JucLlZmCjxS78npL6owIWYaMWUd1AWg6wl8qCAkZnnRaK1D3KdO4gSs/FHAbDGqjDC86ygw6bzJMQ1okoo2a/GwS0XWgpw7evIz4NyYXkv6OrRAdYNdaPga2LnQXc7FMS2OsSMeD+VxAntiYz46DJRncLk3wLB9Vw2L6xfWLmZzCZkubRf4D1Km3GUfcq3apLmuLRk1dLOgUW+mF+57G889ZT/g16lds+FGkk1I7OxgMPZ02Vr3fQzGCYsywI6vXzObJmXFth22nViYTXlUel0YG7Y+VqDUSumrAApa/3FYsZHxB+zVGOqtMRheT7JFszbqaN7pE41qLJYnUNBNB2kxvm6NiuxKwSFnEIPJ3WOv7a56kEpVYt351M1Y2inHr//dxdEFUwIK/bwlPSY+JSKQGCZtBT0P+7fJeYVH8i6TDZAdKzQ565xkCXhjtTfoXSNFMim3TD/WuMUVbzU9pLLoIZ/I6X3dTI0vN5aiPfYcppWvTAPZJW0sRmOUm7ANUQUWAvKPCimdxt5miUGwrFq3jvfT+yHiHLn5tKisnc+58vQAMORK8DwRMwS5yzr/1F5dtq1S3EqGqYkRq6R83hZTS78PkHDbc3cmHnnt2sDrKFCybANixDK93UQxIKtrEDpIc6z9FxgZLdEfiI4CA7yRmFE0akLHTNGw0exsAo9MJCiEfHsall0/wOPwqLW6Bku6Zz0YHSlyjULAMxp9bjKL1+r5Id7S9/OA8dTP3TNgewFKg+jqHAK87oF7feh5UdqKpjq6JUPVtYZW0gFFIqKS/ AKCezsWf V93Fzt5jzybarWiC2t2+RSi63UMUiGs0a+S1u9jh8QDT5v+p6quKocjhjTTmE9xGvMCFX/rHbiVBxDVzfF7U4cxy3XVa7eWcV9/71MTnHkeT34AErvkUqofYsiW7lIT8cT07wHIQZUurzij8yhLxxKnFlxeCqIDvWNIKV7chPzsoNqBN3GyZNAnagRNx7bf/TFv8dCAZC3FPTaoHZ7NB6jatHTL5JiC6Wday9afzeIMa5zXLLei4uLuvfqvCYzPxWeku4GkkXqd13Cj9i8HkDWYh1vX2/f5C10aFzYVxVT4466adW2piuqzAmcjdN9x9F1d4OJSZv+BYmH84ZsOvA7Cokxj9mLT1dXPcsSeTOt5bRDIs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > +static int ras2_check_pcc_chan(struct ras2_context *ras2_ctx) > +{ > + struct acpi_ras2_shared_memory __iomem *generic_comm_base = ras2_ctx->pcc_comm_addr; > + ktime_t next_deadline = ktime_add(ktime_get(), ras2_ctx->deadline); > + > + while (!ktime_after(ktime_get(), next_deadline)) { > + /* > + * As per ACPI spec, the PCC space wil be initialized by > + * platform and should have set the command completion bit when > + * PCC can be used by OSPM > + */ > + if (readw_relaxed(&generic_comm_base->status) & RAS2_PCC_CMD_COMPLETE) > + return 0; We should consider adding error checking here. In a modification of this driver in our enabling efforts, we are checking bit 2 in the status register for errors. For example, in our FW, we will set bit 2 if you try to disable an already disabled scrub. > + /* > + * Reducing the bus traffic in case this loop takes longer than > + * a few retries. > + */ > + udelay(10); > + } > + > + return -EIO; > +}