From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2438C433B4 for ; Fri, 9 Apr 2021 20:31:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6F21F61106 for ; Fri, 9 Apr 2021 20:31:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6F21F61106 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 04FE46B006C; Fri, 9 Apr 2021 16:31:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F41406B006E; Fri, 9 Apr 2021 16:31:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D94106B0070; Fri, 9 Apr 2021 16:31:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0166.hostedemail.com [216.40.44.166]) by kanga.kvack.org (Postfix) with ESMTP id B43BB6B006C for ; Fri, 9 Apr 2021 16:31:01 -0400 (EDT) Received: from smtpin36.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 6FA821848A04B for ; Fri, 9 Apr 2021 20:31:01 +0000 (UTC) X-FDA: 78013972722.36.F6AFDE5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf15.hostedemail.com (Postfix) with ESMTP id C542AA00016E for ; Fri, 9 Apr 2021 20:30:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618000260; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=r3purBUK4sGsBPd0UwK4Y9VUKJGOCt/srJ24LUJR7hY=; b=JXaNNECMbubwUk9IH5gtyyPsaRmp7Fi4YXhKjumkXs/WhrpTfKRFZs9iJm7M4RPeUBAk5w ykvg7RsU8/2/eTpO8SEYxfJP7yFw3hiWXJj/r4YIweSAipxhTLp5Eww3A4Or1gCFzygSwu 3fZTWfNWQyuUlpXcN2sOCKWkCjaqXYI= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-509-DgGAp_wOPB-zBk6_UumefA-1; Fri, 09 Apr 2021 16:30:58 -0400 X-MC-Unique: DgGAp_wOPB-zBk6_UumefA-1 Received: by mail-qv1-f72.google.com with SMTP id x20so3913252qvd.21 for ; Fri, 09 Apr 2021 13:30:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:reply-to:to:cc:date :in-reply-to:references:organization:user-agent:mime-version :content-transfer-encoding; bh=r3purBUK4sGsBPd0UwK4Y9VUKJGOCt/srJ24LUJR7hY=; b=Ga1ewVxfkhKUQkFRVjVInuOL1iNF+K/wsHc9lt/tXznCwYg/sAzuTMXiNQyxeofeBM YiatPWgsUd5hU7k3SWN0s14uJUY2Ypmz2n5Z37AeJrLAvTanYnc23LZAuKK5Sv2GBuGz F5npkx4ywY+BiZTg4/vgVVsg9jG9oL1BSCrn5t/sxyF/qex/KkMXLoerD80L/eXO17pJ ynwdCTu7QDwTdDGWUIVsaT/w4H3Nh7Ikfw+XnhFD7p9K6zRKJPw5W13Wdr4i4VYfvSKs VtG70vaaMngrx3DK6y5lXxAypONJEHt24xd+U12WT9yqUhJELHpobY6ixKv7VJxgRtk1 5Wdw== X-Gm-Message-State: AOAM533iDEJoOWPKHUU16L+yZYR7R+jU4OuI8ULy3Rv5rW16majwris5 grB+EP1Hh+wYI2ti/dOF6lvsLVBBHLeP9iw9B0WMLzSeyZXsHDkoobNZuwzWfltYJSZga/mit7M dvwgQxVT8cdo= X-Received: by 2002:ad4:4c83:: with SMTP id bs3mr16029272qvb.41.1618000257391; Fri, 09 Apr 2021 13:30:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyr1ooCRS/pDUGdY2B2/REevrrf/r2+l/gxxPgseE7hy3UeUufspzsWv3esB5jWHjz6Nz+I2g== X-Received: by 2002:ad4:4c83:: with SMTP id bs3mr16029257qvb.41.1618000257143; Fri, 09 Apr 2021 13:30:57 -0700 (PDT) Received: from Whitewolf.lyude.net (pool-108-49-102-102.bstnma.fios.verizon.net. [108.49.102.102]) by smtp.gmail.com with ESMTPSA id h5sm2556486qtq.1.2021.04.09.13.30.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Apr 2021 13:30:56 -0700 (PDT) Message-ID: <3f97d13aab87ca8023f6607b419e3c0f3249871a.camel@redhat.com> Subject: Re: [drm/i915/dp] 4a8d79901d: WARNING:at_drivers/gpu/drm/i915/display/intel_display_power.c:#assert_can_disable_lcpll[i915] From: Lyude Paul Reply-To: lyude@redhat.com To: Oliver Sang Cc: "Sarvela, Tomi P" , Jani Nikula , Vasily Khoruzhick , LKML , Linux Memory Management List , lkp@lists.01.org, lkp@intel.com, rui.zhang@intel.com, yu.c.chen@intel.com Date: Fri, 09 Apr 2021 16:30:55 -0400 In-Reply-To: <20210325135342.GA17080@xsang-OptiPlex-9020> References: <20210204090229.GH17757@xsang-OptiPlex-9020> <20210318021320.GA10304@xsang-OptiPlex-9020> <90e58cf788299c76b80ec72735ebfd33eef7fffd.camel@redhat.com> <20210325135342.GA17080@xsang-OptiPlex-9020> Organization: Red Hat User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lyude@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: 39hbbjj8easn6odurbttxrz9bmdj7s6s X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: C542AA00016E Received-SPF: none (redhat.com>: No applicable sender policy available) receiver=imf15; identity=mailfrom; envelope-from=""; helo=us-smtp-delivery-124.mimecast.com; client-ip=216.205.24.124 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1618000259-11120 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Could you retest this against the latest drm-tip? I pushed something that= I think might fix this On Thu, 2021-03-25 at 21:53 +0800, Oliver Sang wrote: > Hi, Lyude, >=20 > On Tue, Mar 23, 2021 at 01:27:29PM -0400, Lyude Paul wrote: > > BTW Oliver - I'm still happy to look at this issue, I just need the e= xtra > > logs I > > mentioned below in order to figure out what's going on here >=20 > I enabled "drm.debug=3D0x16 log_buf_len=3D5M" and got attached kmsg.xz = for > 4a8d79901d. > hope it's useful. >=20 > >=20 > > On Thu, 2021-03-18 at 13:16 -0400, Lyude Paul wrote: > > > Well this is surprising, because I had been pretty sure we had aske= d > > > someone > > > at > > > Intel to test that this patch worked on samus and they had said tha= t it > > > did.=20 > > >=20 > > > Is there any way you can get me the kernel messages from this failu= re with > > > drm.debug=3D0x16 log_buf_len=3D5M added to the kernel commandline? = It's hard > > > to > > > see > > > what's actually going on here that's causing this issue to still re= occur. > > >=20 > > > Also adding Tomi P Sarvela onto this thread, since they were the on= es who > > > originally tested this > > >=20 > > > On Thu, 2021-03-18 at 10:13 +0800, Oliver Sang wrote: > > > > Hi Lyude, sorry for later. > > > >=20 > > > > before we send out the report, we also tested fe7d52bccab6, the i= ssue > > > > still > > > > exists on it. > > > > attached one kmsg-fe7d52bccab6.xz FYI. > > > >=20 > > > > we also tested on latest v5.12-rc3, also exists. > > > > attached kmsg-v5.12-rc3.xz FYI. > > > >=20 > > > >=20 > > > >=20 > > > > On Fri, Feb 05, 2021 at 02:53:11PM -0500, Lyude Paul wrote: > > > > > Am I right in assuming this is likely a very delayed test resul= t from > > > > > before: > > > > >=20 > > > > > fe7d52bccab6 ("drm/i915/dp: Don't use DPCD backlights that need= PWM > > > > > enable/disable") > > > > >=20 > > > > > Made it into the kernel? I see that there's a PWM being left on= , which > > > > > was > > > > > the > > > > > same issue we were seeing on fi-bdw-samus > > > > >=20 > > > > > On Thu, 2021-02-04 at 17:02 +0800, kernel test robot wrote: > > > > > >=20 > > > > > > Greeting, > > > > > >=20 > > > > > > FYI, we noticed the following commit (built with gcc-9): > > > > > >=20 > > > > > > commit: 4a8d79901d5bed0812d272c372aa40282937b50f ("drm/i915/d= p: > > > > > > Enable > > > > > > Intel's > > > > > > HDR backlight interface (only SDR for now)") > > > > > > https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.= git=C2=A0mas > > > > > > ter > > > > > >=20 > > > > > >=20 > > > > > > in testcase: suspend-stress > > > > > > version:=20 > > > > > > with following parameters: > > > > > >=20 > > > > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0mode: freeze > > > > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0iterations: 1= 0 > > > > > >=20 > > > > > >=20 > > > > > >=20 > > > > > > on test machine: 4 threads Broadwell-Y with 8G memory > > > > > >=20 > > > > > > caused below changes (please refer to attached dmesg/kmsg for= entire > > > > > > log/backtrace): > > > > > >=20 > > > > > >=20 > > > > > >=20 > > > > > > If you fix the issue, kindly add following tag > > > > > > Reported-by: kernel test robot > > > > > >=20 > > > > > >=20 > > > > > > kern=C2=A0 :warn=C2=A0 : [=C2=A0=C2=A0 21.137894] -----------= -[ cut here ]------------ > > > > > > kern=C2=A0 :warn=C2=A0 : [=C2=A0=C2=A0 21.137897] CPU PWM1 en= abled > > > > > > kern=C2=A0 :warn=C2=A0 : [=C2=A0=C2=A0 21.137930] WARNING: CP= U: 3 PID: 575 at > > > > > > drivers/gpu/drm/i915/display/intel_display_power.c:4902 > > > > > > assert_can_disable_lcpll+0x335/0x3c0 [i915] > > > > > > kern=C2=A0 :warn=C2=A0 : [=C2=A0=C2=A0 21.138084] Modules lin= ked in: sd_mod t10_pi sg > > > > > > x86_pkg_temp_thermal intel_powerclamp i915 hid_rmi rmi_core > > > > > > hid_multitouch > > > > > > coretemp intel_ra > > > > > > pl_msr crct10dif_pclmul wmi_bmof crc32_pclmul intel_gtt crc32= c_intel > > > > > > ghash_clmulni_intel rapl drm_kms_helper intel_cstate ahci lib= ahci > > > > > > serio_raw > > > > > > mei_me proces > > > > > > sor_thermal_device intel_uncore processor_thermal_rfim syscop= yarea > > > > > > sysfillrect > > > > > > intel_soc_dts_iosf sysimgblt intel_pch_thermal hid_sensor_cus= tom > > > > > > fb_sys_fops > > > > > > li > > > > > > bata bcma processor_thermal_mbox joydev mei drm > > > > > > processor_thermal_rapl > > > > > > intel_rapl_common int340x_thermal_zone i2c_hid ideapad_laptop > > > > > > sparse_keymap > > > > > > wmi rfkill > > > > > > video int3400_thermal acpi_thermal_rel i2c_designware_platfor= m > > > > > > dw_dmac > > > > > > i2c_designware_core acpi_pad ip_tables > > > > > > kern=C2=A0 :warn=C2=A0 : [=C2=A0=C2=A0 21.138148] CPU: 3 PID:= 575 Comm: kworker/u8:6 > > > > > > Tainted: > > > > > > G=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 W I=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 5.11.0-rc2-00745-g4a8d79901d5b #1 > > > > > > kern=C2=A0 :warn=C2=A0 : [=C2=A0=C2=A0 21.138153] Hardware na= me: LENOVO 80HE/VIUU4, BIOS > > > > > > A6CN38WW > > > > > > 09/30/2014 > > > > > > kern=C2=A0 :warn=C2=A0 : [=C2=A0=C2=A0 21.138155] Workqueue: = events_unbound > > > > > > async_run_entry_fn > > > > > > kern=C2=A0 :warn=C2=A0 : [=C2=A0=C2=A0 21.138161] RIP: > > > > > > 0010:assert_can_disable_lcpll+0x335/0x3c0 > > > > > > [i915] > > > > > > kern=C2=A0 :info=C2=A0 : [=C2=A0=C2=A0 21.138263] ahci 0000:0= 0:1f.2: > > > > > > pci_pm_suspend_late+0x0/0x40 > > > > > > returned 0 after 0 usecs > > > > > > kern=C2=A0 :warn=C2=A0 : [=C2=A0=C2=A0 21.138296] Code: c0 75= 22 e8 8d 61 cb ff e9 f3 fd > > > > > > ff > > > > > > ff > > > > > > e8 > > > > > > fd bc 6a c1 0f 0b e9 0c fd ff ff e8 f1 bc 6a c1 0f 0b e9 05 f= e ff ff > > > > > > e8 > > > > > > e5 > > > > > > bc > > > > > > 6a c1 <0f> 0b e9 cf fd ff ff e8 d9 bc 6a c1 0f 0b e9 a2 fd ff= ff e8 > > > > > > cd > > > > > > bc > > > > > > kern=C2=A0 :warn=C2=A0 : [=C2=A0=C2=A0 21.138300] RSP: 0018:f= fffc900006f3d58 EFLAGS: > > > > > > 00010282 > > > > > > kern=C2=A0 :warn=C2=A0 : [=C2=A0=C2=A0 21.138304] RAX: 000000= 0000000000 RBX: > > > > > > ffff8881451002e8 > > > > > > RCX: > > > > > > 0000000000000027 > > > > > > kern=C2=A0 :warn=C2=A0 : [=C2=A0=C2=A0 21.138307] RDX: 000000= 0000000027 RSI: > > > > > > 0000000000000002 > > > > > > RDI: > > > > > > ffff888249397cf8 > > > > > > kern=C2=A0 :warn=C2=A0 : [=C2=A0=C2=A0 21.138310] RBP: ffff88= 8145100000 R08: > > > > > > ffff888249397cf0 > > > > > > R09: > > > > > > ffffc900006f3cf0 > > > > > > kern=C2=A0 :warn=C2=A0 : [=C2=A0=C2=A0 21.138313] R10: 000000= 0000000001 R11: > > > > > > 3030302035313969 > > > > > > R12: > > > > > > ffff8881451007f0 > > > > > > kern=C2=A0 :warn=C2=A0 : [=C2=A0=C2=A0 21.138316] R13: ffff88= 8145106c60 R14: > > > > > > 0000000000000002 > > > > > > R15: > > > > > > 0000000000000000 > > > > > > kern=C2=A0 :warn=C2=A0 : [=C2=A0=C2=A0 21.138319] FS:=C2=A0 0= 000000000000000(0000) > > > > > > GS:ffff888249380000(0000) knlGS:0000000000000000 > > > > > > kern=C2=A0 :warn=C2=A0 : [=C2=A0=C2=A0 21.138322] CS:=C2=A0 0= 010 DS: 0000 ES: 0000 CR0: > > > > > > 0000000080050033 > > > > > > kern=C2=A0 :warn=C2=A0 : [=C2=A0=C2=A0 21.138325] CR2: 000055= 7c22ec68a0 CR3: > > > > > > 0000000004c0a003 > > > > > > CR4: > > > > > > 00000000003706e0 > > > > > > kern=C2=A0 :warn=C2=A0 : [=C2=A0=C2=A0 21.138329] Call Trace: > > > > > > kern=C2=A0 :warn=C2=A0 : [=C2=A0=C2=A0 21.138334]=C2=A0 hsw_d= isable_lcpll+0x22/0x280 [i915] > > > > > > kern=C2=A0 :warn=C2=A0 : [=C2=A0=C2=A0 21.138479]=C2=A0 i915_= drm_suspend_late+0x5e/0x100 > > > > > > [i915] > > > > > > kern=C2=A0 :warn=C2=A0 : [=C2=A0=C2=A0 21.138578]=C2=A0 ? pci= _pm_poweroff_late+0x40/0x40 > > > > > > kern=C2=A0 :warn=C2=A0 : [=C2=A0=C2=A0 21.138582]=C2=A0 dpm_r= un_callback+0x4c/0x140 > > > > > > kern=C2=A0 :warn=C2=A0 : [=C2=A0=C2=A0 21.138590]=C2=A0 __dev= ice_suspend_late+0x98/0x1a0 > > > > > > kern=C2=A0 :warn=C2=A0 : [=C2=A0=C2=A0 21.138596]=C2=A0 async= _suspend_late+0x1b/0xa0 > > > > > > kern=C2=A0 :warn=C2=A0 : [=C2=A0=C2=A0 21.138602]=C2=A0 async= _run_entry_fn+0x39/0x160 > > > > > > kern=C2=A0 :warn=C2=A0 : [=C2=A0=C2=A0 21.138608]=C2=A0 proce= ss_one_work+0x1ed/0x3c0 > > > > > > kern=C2=A0 :warn=C2=A0 : [=C2=A0=C2=A0 21.138612]=C2=A0 worke= r_thread+0x50/0x3c0 > > > > > > kern=C2=A0 :warn=C2=A0 : [=C2=A0=C2=A0 21.138617]=C2=A0 ? pro= cess_one_work+0x3c0/0x3c0 > > > > > > kern=C2=A0 :warn=C2=A0 : [=C2=A0=C2=A0 21.138620]=C2=A0 kthre= ad+0x116/0x160 > > > > > > kern=C2=A0 :warn=C2=A0 : [=C2=A0=C2=A0 21.138626]=C2=A0 ? kth= read_park+0xa0/0xa0 > > > > > > kern=C2=A0 :warn=C2=A0 : [=C2=A0=C2=A0 21.138631]=C2=A0 ret_f= rom_fork+0x22/0x30 > > > > > > kern=C2=A0 :warn=C2=A0 : [=C2=A0=C2=A0 21.138640] ---[ end tr= ace a93fe4d40a5a37bb ]--- > > > > > >=20 > > > > > >=20 > > > > > >=20 > > > > > > To reproduce: > > > > > >=20 > > > > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 git clone https://= github.com/intel/lkp-tests.git > > > > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 cd lkp-tests > > > > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 bin/lkp install jo= b.yaml=C2=A0 # job file is attached in this > > > > > > email > > > > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 bin/lkp run=C2=A0=C2= =A0=C2=A0=C2=A0 job.yaml > > > > > >=20 > > > > > >=20 > > > > > >=20 > > > > > > Thanks, > > > > > > Oliver Sang > > > > > >=20 > > > > >=20 > > > > > --=20 > > > > > Sincerely, > > > > > =C2=A0=C2=A0 Lyude Paul (she/her) > > > > > =C2=A0=C2=A0 Software Engineer at Red Hat > > > > > =C2=A0=C2=A0=20 > > > > > Note: I deal with a lot of emails and have a lot of bugs on my = plate. > > > > > If > > > > > you've > > > > > asked me a question, are waiting for a review/merge on a patch,= etc. > > > > > and I > > > > > haven't responded in a while, please feel free to send me anoth= er > > > > > email to > > > > > check > > > > > on my status. I don't bite! > > > > >=20 > > >=20 > >=20 > > --=20 > > Sincerely, > > =C2=A0=C2=A0 Lyude Paul (she/her) > > =C2=A0=C2=A0 Software Engineer at Red Hat > > =C2=A0=C2=A0=20 > > Note: I deal with a lot of emails and have a lot of bugs on my plate.= If > > you've > > asked me a question, are waiting for a review/merge on a patch, etc. = and I > > haven't responded in a while, please feel free to send me another ema= il to > > check > > on my status. I don't bite! > >=20 --=20 Sincerely, Lyude Paul (she/her) Software Engineer at Red Hat =20 Note: I deal with a lot of emails and have a lot of bugs on my plate. If = you've asked me a question, are waiting for a review/merge on a patch, etc. and = I haven't responded in a while, please feel free to send me another email t= o check on my status. I don't bite!